Conditions | 2 |
Paths | 1 |
Total Lines | 283 |
Code Lines | 275 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
34 | public function values(): array |
||
35 | { |
||
36 | $values = [ |
||
37 | '' => '', |
||
38 | 1 => 'Amt', |
||
39 | 2 => 'Amtsbezirk', |
||
40 | 3 => 'Magistrates’ Court', |
||
41 | 4 => 'Bauerschaft', |
||
42 | 5 => 'district', |
||
43 | 6 => 'diocese', |
||
44 | 7 => 'federal state', |
||
45 | 8 => 'castle', |
||
46 | 9 => 'deanery', |
||
47 | 10 => 'Departement', |
||
48 | 11 => 'diocese', |
||
49 | 12 => 'Dompfarrei', |
||
50 | 13 => 'filial church', |
||
51 | 14 => 'Flecken', |
||
52 | 15 => 'field name', |
||
53 | 16 => 'free state', |
||
54 | 17 => 'building', |
||
55 | 18 => 'municipality', |
||
56 | 19 => 'Gerichtsbezirk', |
||
57 | 20 => 'countship', |
||
58 | 21 => 'manor (building)', |
||
59 | 22 => 'dominion', |
||
60 | 23 => 'duchy', |
||
61 | 24 => 'Farm', |
||
62 | 25 => 'canton', |
||
63 | 26 => 'church', |
||
64 | 27 => 'Kirchenkreis', |
||
65 | 28 => 'Kirchenprovinz', |
||
66 | 29 => 'parish', |
||
67 | 30 => 'monastery (building)', |
||
68 | 31 => 'kingdom', |
||
69 | 32 => 'county (generic)', |
||
70 | 33 => 'electorate', |
||
71 | 34 => 'state', |
||
72 | 35 => 'national church', |
||
73 | 36 => 'rural county (rural)', |
||
74 | 37 => 'Oberamt', |
||
75 | 38 => 'oblast', |
||
76 | 39 => 'place', |
||
77 | 40 => 'part of place', |
||
78 | 41 => 'Pfarr-Rektorat', |
||
79 | 42 => 'parish', |
||
80 | 43 => 'Pfarrkuratie', |
||
81 | 44 => 'Pfarrverband', |
||
82 | 45 => 'province', |
||
83 | 46 => 'administrative district', |
||
84 | 47 => 'historical region', |
||
85 | 48 => 'Samtgemeinde', |
||
86 | 49 => 'sprengel', |
||
87 | 50 => 'country', |
||
88 | 51 => 'town', |
||
89 | 52 => 'borough', |
||
90 | 53 => 'urban county (city)', |
||
91 | 54 => 'part of town', |
||
92 | 55 => 'village', |
||
93 | 56 => 'republic', |
||
94 | 57 => 'Amt', |
||
95 | 58 => 'union republic', |
||
96 | 59 => 'voivodship', |
||
97 | 60 => 'principality', |
||
98 | 61 => 'grand duchy', |
||
99 | 62 => 'margravate', |
||
100 | 63 => 'rayon', |
||
101 | 64 => 'Vorwerk', |
||
102 | 65 => 'Pfarrdorf', |
||
103 | 66 => 'village', |
||
104 | 67 => 'solitude', |
||
105 | 68 => 'Hauptort', |
||
106 | 69 => 'hamlet', |
||
107 | 70 => 'bailiwick', |
||
108 | 71 => 'confederation', |
||
109 | 72 => 'people’s republic', |
||
110 | 73 => 'Landdrostei', |
||
111 | 74 => 'deprecated', |
||
112 | 75 => 'Güterdistrikt', |
||
113 | 76 => 'Adeliges Gut', |
||
114 | 77 => 'Reichskreis', |
||
115 | 78 => 'Amt(administrative division)', |
||
116 | 79 => 'hundred', |
||
117 | 80 => 'Landschaft', |
||
118 | 81 => 'monastery', |
||
119 | 82 => 'Domkapitel', |
||
120 | 83 => 'Hanseatic city', |
||
121 | 84 => 'Kirchspielvogtei', |
||
122 | 85 => 'rural municipality', |
||
123 | 86 => 'part province', |
||
124 | 87 => 'mill', |
||
125 | 88 => 'Judet', |
||
126 | 89 => 'cemetery', |
||
127 | 90 => 'abandoned place', |
||
128 | 91 => 'Bistumsregion', |
||
129 | 92 => 'Kirchengemeinde', |
||
130 | 93 => 'Reichsstadt', |
||
131 | 94 => 'Verwaltungsgemeinschaft', |
||
132 | 95 => 'county - level city', |
||
133 | 96 => 'archbishopric', |
||
134 | 97 => 'Bürgermeisterei', |
||
135 | 98 => 'veraltet', |
||
136 | 99 => 'captaincy', |
||
137 | 100 => 'Kreishauptmannschaft', |
||
138 | 101 => 'Kreisdirektion', |
||
139 | 102 => 'forester’s house', |
||
140 | 103 => 'civil registry', |
||
141 | 104 => 'veraltet', |
||
142 | 105 => 'Landgericht', |
||
143 | 107 => 'island', |
||
144 | 108 => 'Gutsbezirk', |
||
145 | 109 => 'Forstgutsbezirk', |
||
146 | 110 => 'district office', |
||
147 | 111 => 'Schloss', |
||
148 | 112 => 'Gespanschaft', |
||
149 | 113 => 'comitatus', |
||
150 | 114 => 'Vest', |
||
151 | 115 => 'forestry', |
||
152 | 116 => 'Oberförsterei', |
||
153 | 117 => 'Unterförsterei', |
||
154 | 118 => 'train station', |
||
155 | 119 => 'stop station', |
||
156 | 120 => 'settlement', |
||
157 | 121 => 'colony', |
||
158 | 122 => 'Verbandsgemeinde', |
||
159 | 124 => 'Abbey', |
||
160 | 125 => 'imperial abbey', |
||
161 | 126 => 'Syssel', |
||
162 | 127 => 'Verwaltungsverband', |
||
163 | 128 => 'Landgrafschaft', |
||
164 | 129 => 'settlement', |
||
165 | 130 => 'state', |
||
166 | 131 => 'Weichbild', |
||
167 | 133 => 'region', |
||
168 | 134 => 'arrondissement', |
||
169 | 135 => 'canton', |
||
170 | 136 => 'commune', |
||
171 | 137 => 'region', |
||
172 | 138 => 'Oberlandratsbezirk', |
||
173 | 139 => 'Einschicht', |
||
174 | 140 => 'Einheitsgemeinde', |
||
175 | 142 => 'Reichsgau', |
||
176 | 143 => 'kommune', |
||
177 | 144 => 'Ortschaft', |
||
178 | 145 => 'Markt', |
||
179 | 146 => 'Bezirkshauptmannschaft', |
||
180 | 147 => 'veraltet', |
||
181 | 148 => 'Erfüllende Gemeinde', |
||
182 | 149 => 'Landratsamt', |
||
183 | 150 => 'Stadt', |
||
184 | 151 => 'Oberlandesgericht', |
||
185 | 152 => 'Landbürgermeisterei', |
||
186 | 153 => 'Kommissariat', |
||
187 | 154 => 'Honschaft', |
||
188 | 155 => 'region', |
||
189 | 156 => 'Gemeindebezirk', |
||
190 | 157 => 'Guberniya', |
||
191 | 158 => 'Gemeindeteil', |
||
192 | 159 => 'Khutor', |
||
193 | 160 => 'soviet republic', |
||
194 | 161 => 'Verwaltungsbezirk', |
||
195 | 162 => 'Stadt - und Landgemeinde', |
||
196 | 163 => 'Ortsgemeinde', |
||
197 | 164 => 'Ortsbezirk', |
||
198 | 165 => 'Gnotschaft', |
||
199 | 166 => 'ruins', |
||
200 | 167 => 'mandate territory', |
||
201 | 168 => 'Provinz', |
||
202 | 169 => 'Gemeinde', |
||
203 | 170 => 'district', |
||
204 | 171 => 'Stadthauptmannschaft', |
||
205 | 172 => 'Katastralgemeinde', |
||
206 | 173 => 'Reichskommissariat', |
||
207 | 174 => 'general district', |
||
208 | 175 => 'Kreisgebiet', |
||
209 | 176 => 'protectorate', |
||
210 | 177 => 'Reichsritterschaft', |
||
211 | 178 => 'Ritterkanton', |
||
212 | 179 => 'Ritterkreis', |
||
213 | 180 => 'Marktgemeinde', |
||
214 | 181 => 'Rotte', |
||
215 | 182 => 'Erzstift', |
||
216 | 183 => 'Hochstift', |
||
217 | 184 => 'Kammerschreiberei', |
||
218 | 185 => 'Klosteramt', |
||
219 | 186 => 'Rentkammer', |
||
220 | 187 => 'zu überprüfen', |
||
221 | 188 => 'Ritterorden', |
||
222 | 189 => 'Großpriorat', |
||
223 | 190 => 'Ballei', |
||
224 | 191 => 'Kommende', |
||
225 | 192 => 'zone of occupation', |
||
226 | 193 => 'Alm', |
||
227 | 194 => 'Distrikts - Amt', |
||
228 | 195 => 'veraltet', |
||
229 | 196 => 'veraltet', |
||
230 | 197 => '', |
||
231 | 198 => 'veraltet(früher: Bundesverwaltungsgericht)', |
||
232 | 199 => 'veraltet(früher: Landesverwaltungsgericht)', |
||
233 | 200 => 'veraltet(früher: Verwaltungsgericht)', |
||
234 | 201 => 'Landeskommissarbezirk', |
||
235 | 202 => 'Amtsgerichtsbezirk', |
||
236 | 203 => 'Domanialamt', |
||
237 | 204 => 'Ritterschaftliches Amt', |
||
238 | 205 => 'selsoviet', |
||
239 | 206 => 'Regionalkirchenamt', |
||
240 | 207 => 'Oberamtsbezirk', |
||
241 | 210 => 'Kirchenbund', |
||
242 | 211 => 'Landgebiet', |
||
243 | 212 => 'Landherrenschaft', |
||
244 | 213 => 'gorsoviet', |
||
245 | 214 => 'realm', |
||
246 | 215 => 'Reichshälfte', |
||
247 | 216 => 'Landesteil', |
||
248 | 217 => 'Direktionsbezirk', |
||
249 | 218 => 'Stadt', |
||
250 | 219 => 'Expositur', |
||
251 | 221 => 'Fylke', |
||
252 | 222 => 'Kreis', |
||
253 | 223 => 'Landgericht', |
||
254 | 224 => 'Pfleggericht', |
||
255 | 225 => 'Rentamt', |
||
256 | 226 => 'Obmannschaft', |
||
257 | 227 => 'Kirchspielslandgemeinde', |
||
258 | 228 => 'Gerichtsamt', |
||
259 | 229 => 'group of houses', |
||
260 | 230 => 'scattered settlement', |
||
261 | 231 => 'Höfe', |
||
262 | 232 => 'Randort', |
||
263 | 233 => 'Flecken', |
||
264 | 234 => 'borough', |
||
265 | 235 => 'unitary authority', |
||
266 | 236 => 'houses', |
||
267 | 237 => 'Siedlungsrat', |
||
268 | 238 => 'urban - type settlement', |
||
269 | 239 => 'Verwaltungsamt', |
||
270 | 240 => 'uyezd', |
||
271 | 241 => 'Volost', |
||
272 | 242 => 'Katasteramt', |
||
273 | 243 => 'Propstei', |
||
274 | 244 => 'Nebenkirche', |
||
275 | 245 => 'chapel', |
||
276 | 246 => 'Gromada', |
||
277 | 247 => 'Ortsteil', |
||
278 | 248 => 'Schulzenamt', |
||
279 | 249 => 'Erzbischöfliches Amt', |
||
280 | 250 => 'Apostolische Administratur', |
||
281 | 251 => 'autonome Gemeinschaft', |
||
282 | 252 => 'local government', |
||
283 | 253 => 'religious organization', |
||
284 | 254 => 'Okrug', |
||
285 | 255 => 'Stadtgut', |
||
286 | 256 => 'Landesbezirk', |
||
287 | 257 => 'Landgemeinde PL', |
||
288 | 258 => 'Stadtgemeinde', |
||
289 | 259 => 'Landvogteibezirk', |
||
290 | 260 => 'Delegaturbezirk', |
||
291 | 261 => 'Hofschaft', |
||
292 | 262 => 'Stadtteil', |
||
293 | 263 => 'Sprengel', |
||
294 | 264 => 'Mairie', |
||
295 | 265 => 'sultanate', |
||
296 | 266 => 'Landratsbezirk', |
||
297 | 267 => 'sognekommune', |
||
298 | 268 => 'Großgemeinde', |
||
299 | 269 => 'Kleingemeinde', |
||
300 | 270 => 'Bezirk', |
||
301 | 271 => 'Stadt mit Munizipium', |
||
302 | 272 => 'Königliche Freistadt', |
||
303 | 273 => 'Stadt mit geordnetem Magistrate', |
||
304 | 274 => 'unincorporated area', |
||
305 | 275 => 'Stadtgemeinde', |
||
306 | 276 => 'Hardesvogtei', |
||
307 | ]; |
||
308 | |||
309 | array_walk($values, static function (string &$value, $key): void { |
||
310 | if (is_int($key)) { |
||
311 | $value .= ' — ' . I18N::number($key); |
||
312 | } |
||
313 | }); |
||
314 | |||
315 | |||
316 | return $values; |
||
317 | } |
||
319 |