Inspection of "Do not try to format date if not in valid range" - fisharebest/webtrees - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1242)

by Jonathan

created 2017-05-07 14:03 UTC

Status

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -98,7 +98,8 @@  discard block
 block discarded – undo
 				<td class="col-xs-1">
 					<?php if ($module instanceof ModuleConfigInterface): ?>
 					<a href="<?= $module->getConfigLink() ?>"><?= $module->getTitle() ?> <i class="fa fa-cogs"></i></a>
-					<?php else: ?>
+					<?php else {
+	: ?>
 					<?= $module->getTitle() ?>
 					<?php endif ?>
 				</td>
@@ -113,7 +114,9 @@  discard block
 block discarded – undo
 										<?= $tree->getTitleHtml() ?>
 									</td>
 									<td>
-										<?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'menu')); ?>
+										<?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'menu'));
+}
+?>
 									</td>
 								</tr>
 							<?php endforeach ?>

Please login to merge, or discard this patch.

admin_module_charts.php 1 patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -73,7 +73,8 @@  discard block
 block discarded – undo
 				<td class="col-xs-2">
 					<?php if ($module instanceof ModuleConfigInterface): ?>
 						<a href="<?= $module->getConfigLink() ?>"><?= $module->getTitle() ?> <i class="fa fa-cogs"></i></a>
-					<?php else: ?>
+					<?php else {
+	: ?>
 						<?= $module->getTitle() ?>
 					<?php endif ?>
 				</td>
@@ -87,7 +88,9 @@  discard block
 block discarded – undo
 										<?= $tree->getTitleHtml() ?>
 									</td>
 									<td>
-										<?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'chart')); ?>
+										<?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'chart'));
+}
+?>
 									</td>
 								</tr>
 							<?php endforeach ?>

Please login to merge, or discard this patch.

admin_module_tabs.php 1 patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -98,7 +98,8 @@  discard block
 block discarded – undo
 				<td class="col-xs-1">
 					<?php if ($module instanceof ModuleConfigInterface): ?>
 					<a href="<?= $module->getConfigLink() ?>"><?= $module->getTitle() ?> <i class="fa fa-cogs"></i></a>
-					<?php else: ?>
+					<?php else {
+	: ?>
 					<?= $module->getTitle() ?>
 					<?php endif ?>
 				</td>
@@ -113,7 +114,9 @@  discard block
 block discarded – undo
 										<?= $tree->getTitleHtml() ?>
 									</td>
 									<td>
-										<?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'tab')); ?>
+										<?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'tab'));
+}
+?>
 									</td>
 								</tr>
 							<?php endforeach ?>

Please login to merge, or discard this patch.

admin_module_reports.php 1 patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -73,7 +73,8 @@  discard block
 block discarded – undo
 				<td class="col-xs-2">
 					<?php if ($module instanceof ModuleConfigInterface): ?>
 						<a href="<?= $module->getConfigLink() ?>"><?= $module->getTitle() ?> <i class="fa fa-cogs"></i></a>
-					<?php else: ?>
+					<?php else {
+	: ?>
 						<?= $module->getTitle() ?>
 					<?php endif ?>
 				</td>
@@ -87,7 +88,9 @@  discard block
 block discarded – undo
 										<?= $tree->getTitleHtml() ?>
 									</td>
 									<td>
-										<?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'report')); ?>
+										<?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'report'));
+}
+?>
 									</td>
 								</tr>
 							<?php endforeach ?>

Please login to merge, or discard this patch.

admin_module_sidebar.php 1 patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -98,7 +98,8 @@  discard block
 block discarded – undo
 				<td class="col-xs-1">
 					<?php if ($module instanceof ModuleConfigInterface): ?>
 					<a href="<?= $module->getConfigLink() ?>"><?= $module->getTitle() ?> <i class="fa fa-cogs"></i></a>
-					<?php else: ?>
+					<?php else {
+	: ?>
 					<?= $module->getTitle() ?>
 					<?php endif ?>
 				</td>
@@ -113,7 +114,9 @@  discard block
 block discarded – undo
 										<?= $tree->getTitleHtml() ?>
 									</td>
 									<td>
-										<?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'sidebar')); ?>
+										<?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'sidebar'));
+}
+?>
 									</td>
 								</tr>
 							<?php endforeach ?>

Please login to merge, or discard this patch.

admin_module_blocks.php 1 patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -80,7 +80,8 @@  discard block
 block discarded – undo
 				<td class="col-xs-2">
 					<?php if ($module instanceof ModuleConfigInterface): ?>
 						<a href="<?= $module->getConfigLink() ?>"><?= $module->getTitle() ?> <i class="fa fa-cogs"></i></a>
-					<?php else: ?>
+					<?php else {
+	: ?>
 						<?= $module->getTitle() ?>
 					<?php endif ?>
 				</td>
@@ -94,7 +95,9 @@  discard block
 block discarded – undo
 										<?= $tree->getTitleHtml() ?>
 									</td>
 									<td>
-										<?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'block')); ?>
+										<?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'block'));
+}
+?>
 									</td>
 								</tr>
 							<?php endforeach ?>

Please login to merge, or discard this patch.

		@@ -98,7 +98,8 @@ discard block
		block discarded – undo
98	98	<td class="col-xs-1">
99	99	<?php if ($module instanceof ModuleConfigInterface): ?>
100	100	<a href="<?= $module->getConfigLink() ?>"><?= $module->getTitle() ?> <i class="fa fa-cogs"></i></a>
101		- <?php else: ?>
	101	+ <?php else {
	102	+ : ?>
102	103	<?= $module->getTitle() ?>
103	104	<?php endif ?>
104	105	</td>
		@@ -113,7 +114,9 @@ discard block
		block discarded – undo
113	114	<?= $tree->getTitleHtml() ?>
114	115	</td>
115	116	<td>
116		- <?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'menu')); ?>
	117	+ <?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'menu'));
	118	+}
	119	+?>
117	120	</td>
118	121	</tr>
119	122	<?php endforeach ?>

		@@ -73,7 +73,8 @@ discard block
		block discarded – undo
73	73	<td class="col-xs-2">
74	74	<?php if ($module instanceof ModuleConfigInterface): ?>
75	75	<a href="<?= $module->getConfigLink() ?>"><?= $module->getTitle() ?> <i class="fa fa-cogs"></i></a>
76		- <?php else: ?>
	76	+ <?php else {
	77	+ : ?>
77	78	<?= $module->getTitle() ?>
78	79	<?php endif ?>
79	80	</td>
		@@ -87,7 +88,9 @@ discard block
		block discarded – undo
87	88	<?= $tree->getTitleHtml() ?>
88	89	</td>
89	90	<td>
90		- <?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'chart')); ?>
	91	+ <?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'chart'));
	92	+}
	93	+?>
91	94	</td>
92	95	</tr>
93	96	<?php endforeach ?>

		@@ -80,7 +80,8 @@ discard block
		block discarded – undo
80	80	<td class="col-xs-2">
81	81	<?php if ($module instanceof ModuleConfigInterface): ?>
82	82	<a href="<?= $module->getConfigLink() ?>"><?= $module->getTitle() ?> <i class="fa fa-cogs"></i></a>
83		- <?php else: ?>
	83	+ <?php else {
	84	+ : ?>
84	85	<?= $module->getTitle() ?>
85	86	<?php endif ?>
86	87	</td>
		@@ -94,7 +95,9 @@ discard block
		block discarded – undo
94	95	<?= $tree->getTitleHtml() ?>
95	96	</td>
96	97	<td>
97		- <?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'block')); ?>
	98	+ <?php echo FunctionsEdit::editFieldAccessLevel('access-' . $module->getName() . '-' . $tree->getTreeId(), $module->getAccessLevel($tree, 'block'));
	99	+}
	100	+?>
98	101	</td>
99	102	</tr>
100	103	<?php endforeach ?>

fisharebest / webtrees

Pull Request — master (#1242)

Status

Category

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch