Completed
Pull Request — master (#1242)
by Jonathan
09:02
created
app/Module/StoriesModule.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -389,8 +389,11 @@
 block discarded – undo
389 389
 						<a href="<?php echo $individual->getHtmlUrl(); ?>#stories">
390 390
 							<?php echo $individual->getFullName(); ?>
391 391
 						</a>
392
-						<?php else: ?>
393
-							<?php echo $story->xref; ?>
392
+						<?php else {
393
+	: ?>
394
+							<?php echo $story->xref;
395
+}
396
+?>
394 397
 						<?php endif; ?>
395 398
 						</td>
396 399
 						<td>
Please login to merge, or discard this patch.
calendar.php 1 patch
Upper-Lower-Casing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -67,14 +67,14 @@
 block discarded – undo
67 67
 	if (strlen($match[1]) > strlen($match[2])) {
68 68
 		$match[2] = substr($match[1], 0, strlen($match[1]) - strlen($match[2])) . $match[2];
69 69
 	}
70
-	$ged_date = new Date("FROM {$cal} {$match[1]} TO {$cal} {$match[2]}");
70
+	$ged_date = new Date("from {$cal} {$match[1]} TO {$cal} {$match[2]}");
71 71
 	$view     = 'year';
72 72
 } else {
73 73
 	// advanced-year "decade/century wildcard"
74 74
 	if (preg_match('/^(\d+)(\?+)$/', $year, $match)) {
75 75
 		$y1       = $match[1] . str_replace('?', '0', $match[2]);
76 76
 		$y2       = $match[1] . str_replace('?', '9', $match[2]);
77
-		$ged_date = new Date("FROM {$cal} {$y1} TO {$cal} {$y2}");
77
+		$ged_date = new Date("from {$cal} {$y1} TO {$cal} {$y2}");
78 78
 		$view     = 'year';
79 79
 	} else {
80 80
 		if ($year < 0) {
Please login to merge, or discard this patch.
medialist.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -110,10 +110,13 @@
 block discarded – undo
110 110
 						</option>
111 111
 					</select>
112 112
 				</td>
113
-				<?php else: ?>
113
+				<?php else {
114
+	: ?>
114 115
 					<td class="descriptionbox wrap"></td>
115 116
 					<td class="optionbox wrap"></td>
116
-				<?php endif; ?>
117
+				<?php endif;
118
+}
119
+?>
117 120
 			</tr>
118 121
 			<tr>
119 122
 				<td class="descriptionbox wrap">
Please login to merge, or discard this patch.
app/Functions/FunctionsDb.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -647,7 +647,7 @@  discard block
 block discarded – undo
647 647
 	 * @param int $min The number of times a surname must occur before it is added to the array
648 648
 	 * @param Tree $tree
649 649
 	 *
650
-	 * @return int[]
650
+	 * @return string[]
651 651
 	 */
652 652
 	public static function getCommonSurnames($min, Tree $tree) {
653 653
 		return self::getTopSurnames($tree->getTreeId(), $min, 0);
@@ -660,7 +660,7 @@  discard block
 block discarded – undo
660 660
 	 * @param int $min only fetch surnames occuring this many times
661 661
 	 * @param int $max only fetch this number of surnames (0=all)
662 662
 	 *
663
-	 * @return int[]
663
+	 * @return string[]
664 664
 	 */
665 665
 	public static function getTopSurnames($ged_id, $min, $max) {
666 666
 		// Use n_surn, rather than n_surname, as it is used to generate URLs for
Please login to merge, or discard this patch.
app/Family.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 	/**
102 102
 	 * Get the male (or first female) partner of the family
103 103
 	 *
104
-	 * @param $access_level int|null
104
+	 * @param integer $access_level int|null
105 105
 	 *
106 106
 	 * @return Individual|null
107 107
 	 */
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 	/**
119 119
 	 * Get the female (or second male) partner of the family
120 120
 	 *
121
-	 * @param $access_level int|null
121
+	 * @param integer $access_level int|null
122 122
 	 *
123 123
 	 * @return Individual|null
124 124
 	 */
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
 			// Check the script used by each name, so we can match cyrillic with cyrillic, greek with greek, etc.
344 344
 			$husb_names = [];
345 345
 			if ($this->husb) {
346
-				$husb_names = array_filter($this->husb->getAllNames(), function(array $x) { return $x['type'] !== '_MARNM'; } );
346
+				$husb_names = array_filter($this->husb->getAllNames(), function (array $x) { return $x['type'] !== '_MARNM'; } );
347 347
 			}
348 348
 			// If the individual only has married names, create a dummy birth name.
349 349
 			if (empty($husb_names)) {
@@ -359,7 +359,7 @@  discard block
 block discarded – undo
359 359
 
360 360
 			$wife_names = [];
361 361
 			if ($this->wife) {
362
-				$wife_names = array_filter($this->wife->getAllNames(), function(array $x) { return $x['type'] !== '_MARNM'; } );
362
+				$wife_names = array_filter($this->wife->getAllNames(), function (array $x) { return $x['type'] !== '_MARNM'; } );
363 363
 			}
364 364
 			// If the individual only has married names, create a dummy birth name.
365 365
 			if (empty($wife_names)) {
Please login to merge, or discard this patch.
app/Individual.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -388,7 +388,7 @@
 block discarded – undo
388 388
 	 *    (b) Level 1 object with the Highlight option missing or set to other than "Y" or "N"
389 389
 	 *    (c) Level 2 or higher object with the Highlight option set to "Y"
390 390
 	 *
391
-	 * @return null|Media
391
+	 * @return GedcomRecord|null
392 392
 	 */
393 393
 	public function findHighlightedMedia() {
394 394
 		$objectA = null;
Please login to merge, or discard this patch.
app/Statement.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@
 block discarded – undo
142 142
 	 *
143 143
 	 * @param int $fetch_style
144 144
 	 *
145
-	 * @return \stdClass|array|null
145
+	 * @return \stdClass
146 146
 	 */
147 147
 	public function fetchOneRow($fetch_style = PDO::FETCH_OBJ) {
148 148
 		if (!$this->executed) {
Please login to merge, or discard this patch.
app/Functions/FunctionsPrintLists.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1717,7 +1717,7 @@
 block discarded – undo
1717 1717
 					if ($endjd === $startjd) {
1718 1718
 						$html .= I18N::translate('No events exist for tomorrow.');
1719 1719
 					} else {
1720
-						$html .=  /* I18N: translation for %s==1 is unused; it is translated separately as “tomorrow” */ I18N::plural('No events exist for the next %s day.', 'No events exist for the next %s days.', $endjd - $startjd + 1, I18N::number($endjd - $startjd + 1));
1720
+						$html .= /* I18N: translation for %s==1 is unused; it is translated separately as “tomorrow” */ I18N::plural('No events exist for the next %s day.', 'No events exist for the next %s days.', $endjd - $startjd + 1, I18N::number($endjd - $startjd + 1));
1721 1721
 					}
1722 1722
 				} else {
1723 1723
 					if ($endjd === $startjd) {
Please login to merge, or discard this patch.
search_advanced.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -154,7 +154,8 @@  discard block
 block discarded – undo
154 154
 				<input type="text" id="value<?= $i ?>" name="values[<?= $i ?>]" value="<?= Filter::escapeHtml($controller->getValue($i)) ?>"<?= substr($controller->getField($i), -4) == 'PLAC' ? 'data-autocomplete-type="PLAC"' : '' ?>>
155 155
 			<?php if (preg_match('/^NAME:/', $currentFieldSearch) > 0) { ?>
156 156
 				<select name="fields[<?= $i ?>]">
157
-					<option value="<?= $currentField ?>:EXACT" <?php if (preg_match('/:EXACT$/', $currentFieldSearch) > 0) echo 'selected' ?>><?= I18N::translate('Exact') ?></option>
157
+					<option value="<?= $currentField ?>:EXACT" <?php if (preg_match('/:EXACT$/', $currentFieldSearch) > 0) {
158
+	echo 'selected' ?>><?= I18N::translate('Exact') ?></option>
158 159
 					<option value="<?= $currentField ?>:BEGINS" <?php if (preg_match('/:BEGINS$/', $currentFieldSearch) > 0) echo 'selected' ?>><?= I18N::translate('Begins with') ?></option>
159 160
 					<option value="<?= $currentField ?>:CONTAINS" <?php if (preg_match('/:CONTAINS$/', $currentFieldSearch) > 0) echo 'selected' ?>><?= I18N::translate('Contains') ?></option>
160 161
 					<option value="<?= $currentField ?>:SDX" <?php if (preg_match('/:SDX$/', $currentFieldSearch) > 0) echo 'selected' ?>><?= I18N::translate('Sounds like') ?></option>
@@ -176,6 +177,7 @@  discard block
 block discarded – undo
176 177
 		//-- relative fields
177 178
 		if ($i == 0 && $fct > 4) {
178 179
 			$j = $fct;
180
+}
179 181
 			// Get the current options for Father’s and Mother’s name searches
180 182
 			$fatherGivnOption = 'SDX';
181 183
 			$fatherSurnOption = 'SDX';
Please login to merge, or discard this patch.