print_navigator_family() - Code Metrics - Inspection of "Unused global" - fisharebest/webtrees - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (60084b)

by Greg

created 2018-01-15 22:04 UTC

print_navigator_family() D

↳ Parent: Project

Complexity

Conditions	9
Paths	9

Size

Total Lines	39
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	9
eloc	34
nc	9
nop	2
dl	0
loc	39
rs	4.909
c	0
b	0
f	0

<?php

/**
 * webtrees: online genealogy
 * Copyright (C) 2018 webtrees development team
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */
namespace Fisharebest\Webtrees;

/**
 * Defined in edit_interface.php
 *
 * @global Individual $person
 */
global $person;
function myFunction($a, $b) {
    // Do something
}
/**
 * Defined in edit_interface.php
 *
 * @global Controller\PageController $controller
 */
global $controller;
function myFunction($a, $b) {
    // Do something
}

?>
<style>
	/* Outer border around nav elements */
	.outer_nav {
		border: 3px #808080 outset;
	}

	/* top Search box */
	input[type='text'] {
		background: #fff;
		color: #000;
		border: 1px solid #000;
		width: 120px;
	}

	/* "Head" button images */
	.headimg {
		margin-top: -4px;
		border: 0;
	}

	/* Prevents clickable td for Search <td> */
	td #srch a {
		display: inline;
	}
</style>
<div id="media-links">
	<table class="center">
		<tr>
			<td class="topbottombar">
				<b><?= $controller->getPageTitle() ?></b>
			</td>
		</tr>
		<tr>
			<td>
				<table class="outer_nav">
					<tr>
						<th class="descriptionbox"><?= I18N::translate('Find an individual') ?></th>
					</tr>
					<tr>
						<td id="srch" class="optionbox center">
							<script>
								function findindi() {
									var findInput = document.getElementById('personid');
									var txt = findInput.value;
									if (txt === "") {
										alert("<?= I18N::translate('You must enter a name') ?>");
									} else {
										window.open("module.php?mod=GEDFact_assistant&mod_action=media_find&callback=paste_id&action=filter&type=indi&multiple=&filter=" + txt, "win02", "resizable=1, menubar=0, scrollbars=1, top=180, left=600, height=600, width=450 ").focus();
									}
								}
							</script>
							<input id="personid" type="text" value="">
							<a type="submit" onclick="findindi();">
								<?= I18N::translate('Search') ?>
							</a>
						</td>
					</tr>
					<tr>
						<td>
							<table width="100%" class="fact_table" cellspacing="0" border="0">
								<tr>
									<td colspan=3 class="descriptionbox wrap">
										<i class="headimg vmiddle icon-button_head"></i>
										<?= I18N::translate('View this family') ?>
									</td>
								</tr>
								<?php
								foreach ($person->getChildFamilies() as $family) {
									echo '<tr><th colspan="2">', $family->getFullName(), '</td></tr>';
									print_navigator_family($family, $person);
								}

								foreach ($person->getChildStepFamilies() as $family) {
									echo '<tr><th colspan="2">', $family->getFullName(), '</td></tr>';
									print_navigator_family($family, $person);
								}

								foreach ($person->getSpouseFamilies() as $family) {
									echo '<tr><th colspan="2">', $family->getFullName(), '</td></tr>';
									print_navigator_family($family, $person);
								}
								?>
							</table>
						</td>
					</tr>
				</table>
			</td>
		</tr>
	</table>
</div>
<?php

/**
 * Display family members with clickable links
 *
 * @param Family     $family
 * @param Individual $individual
 */
function print_navigator_family(Family $family, Individual $individual) {
	foreach ($family->getSpouses() as $spouse) {
		?>
		<tr>
			<td>
				<a href="#" onclick="opener.insertRowToTable('<?= $spouse->getXref() ?>', '<?= e($spouse->getFullName()) ?>', '', '', '', '', '', '', '', ''); return false;">
					<?= $spouse === $individual ? '<b>' : '' ?>
					<?= $spouse->getFullName() ?> <?= $spouse->getLifeSpan() ?>
					<?= $spouse === $individual ? '</b>' : '' ?>
				</a>
			</td>
			<td>
				<?php if ($individual !== $spouse): ?>
					<a href="edit_interface.php?action=addmedia_links&amp;noteid=newnote&amp;pid=<?= $spouse->getXref() ?>&amp;gedcom=<?= $spouse->getTree()->getNameUrl() ?>">
						<i class="headimg vmiddle icon-button_head"></i>
					</a>
				<?php endif ?>
			</td>
		<tr>
	<?php
	}

	foreach ($family->getChildren() as $child) {
		?>
		<tr>
			<td>
				<a href="#" onclick="opener.insertRowToTable('<?= $child->getXref() ?>', '<?= e($child->getFullName()) ?>', '', '', '', '', '', '', '', ''); return false;">
					<?= $child === $individual ? '<b>' : '' ?>
					<?= $child->getFullName() ?> <?= $child->getLifeSpan() ?>
				<?= $child === $individual ? '</b>' : '' ?>
				</a>
			</td>
			<td>
			<?php if ($individual !== $child): ?>
					<a href="edit_interface.php?action=addmedia_links&amp;noteid=newnote&amp;pid=<?= $child->getXref() ?>&amp;gedcom=<?= $child->getTree()->getNameUrl() ?>">
						<i class="headimg vmiddle icon-button_head"></i>
					</a>
				<?php endif ?>
			</td>
		</tr>
	<?php
	}
}


Branch — master (60084b)

print_navigator_family() D

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-02-04 22:19 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 130 and the first side effect is on line 23. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* webtrees: online genealogy
4			* Copyright (C) 2018 webtrees development team
5			* This program is free software: you can redistribute it and/or modify
6			* it under the terms of the GNU General Public License as published by
7			* the Free Software Foundation, either version 3 of the License, or
8			* (at your option) any later version.
9			* This program is distributed in the hope that it will be useful,
10			* but WITHOUT ANY WARRANTY; without even the implied warranty of
11			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12			* GNU General Public License for more details.
13			* You should have received a copy of the GNU General Public License
14			* along with this program. If not, see <http://www.gnu.org/licenses/>.
15			*/
16			namespace Fisharebest\Webtrees;
17
18			/**
19			* Defined in edit_interface.php
20			*
21			* @global Individual $person
22			*/
23			global $person;
			0 ignored issues – show Compatibility Best Practice introduced 2017-10-19 12:46 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
24			/**
25			* Defined in edit_interface.php
26			*
27			* @global Controller\PageController $controller
28			*/
29			global $controller;
			0 ignored issues – show Compatibility Best Practice introduced 2017-10-19 12:46 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
30
31			?>
32			<style>
33			/* Outer border around nav elements */
34			.outer_nav {
35			border: 3px #808080 outset;
36			}
37
38			/* top Search box */
39			input[type='text'] {
40			background: #fff;
41			color: #000;
42			border: 1px solid #000;
43			width: 120px;
44			}
45
46			/* "Head" button images */
47			.headimg {
48			margin-top: -4px;
49			border: 0;
50			}
51
52			/* Prevents clickable td for Search <td> */
53			td #srch a {
54			display: inline;
55			}
56			</style>
57			<div id="media-links">
58			<table class="center">
59			<tr>
60			<td class="topbottombar">
61			<b><?= $controller->getPageTitle() ?></b>
62			</td>
63			</tr>
64			<tr>
65			<td>
66			<table class="outer_nav">
67			<tr>
68			<th class="descriptionbox"><?= I18N::translate('Find an individual') ?></th>
69			</tr>
70			<tr>
71			<td id="srch" class="optionbox center">
72			<script>
73			function findindi() {
74			var findInput = document.getElementById('personid');
75			var txt = findInput.value;
76			if (txt === "") {
77			alert("<?= I18N::translate('You must enter a name') ?>");
78			} else {
79			window.open("module.php?mod=GEDFact_assistant&mod_action=media_find&callback=paste_id&action=filter&type=indi&multiple=&filter=" + txt, "win02", "resizable=1, menubar=0, scrollbars=1, top=180, left=600, height=600, width=450 ").focus();
80			}
81			}
82			</script>
83			<input id="personid" type="text" value="">
84			<a type="submit" onclick="findindi();">
85			<?= I18N::translate('Search') ?>
86			</a>
87			</td>
88			</tr>
89			<tr>
90			<td>
91			<table width="100%" class="fact_table" cellspacing="0" border="0">
92			<tr>
93			<td colspan=3 class="descriptionbox wrap">
94			<i class="headimg vmiddle icon-button_head"></i>
95			<?= I18N::translate('View this family') ?>
96			</td>
97			</tr>
98			<?php
99			foreach ($person->getChildFamilies() as $family) {
100			echo '<tr><th colspan="2">', $family->getFullName(), '</td></tr>';
101			print_navigator_family($family, $person);
102			}
103
104			foreach ($person->getChildStepFamilies() as $family) {
105			echo '<tr><th colspan="2">', $family->getFullName(), '</td></tr>';
106			print_navigator_family($family, $person);
107			}
108
109			foreach ($person->getSpouseFamilies() as $family) {
110			echo '<tr><th colspan="2">', $family->getFullName(), '</td></tr>';
111			print_navigator_family($family, $person);
112			}
113			?>
114			</table>
115			</td>
116			</tr>
117			</table>
118			</td>
119			</tr>
120			</table>
121			</div>
122			<?php
123
124			/**
125			* Display family members with clickable links
126			*
127			* @param Family $family
128			* @param Individual $individual
129			*/
130			function print_navigator_family(Family $family, Individual $individual) {
131			foreach ($family->getSpouses() as $spouse) {
132			?>
133			<tr>
134			<td>
135			<a href="#" onclick="opener.insertRowToTable('<?= $spouse->getXref() ?>', '<?= e($spouse->getFullName()) ?>', '', '', '', '', '', '', '', ''); return false;">
136			<?= $spouse === $individual ? '<b>' : '' ?>
137			<?= $spouse->getFullName() ?> <?= $spouse->getLifeSpan() ?>
138			<?= $spouse === $individual ? '</b>' : '' ?>
139			</a>
140			</td>
141			<td>
142			<?php if ($individual !== $spouse): ?>
143			<a href="edit_interface.php?action=addmedia_links&noteid=newnote&pid=<?= $spouse->getXref() ?>&gedcom=<?= $spouse->getTree()->getNameUrl() ?>">
144			<i class="headimg vmiddle icon-button_head"></i>
145			</a>
146			<?php endif ?>
147			</td>
148			<tr>
149			<?php
150			}
151
152			foreach ($family->getChildren() as $child) {
153			?>
154			<tr>
155			<td>
156			<a href="#" onclick="opener.insertRowToTable('<?= $child->getXref() ?>', '<?= e($child->getFullName()) ?>', '', '', '', '', '', '', '', ''); return false;">
157			<?= $child === $individual ? '<b>' : '' ?>
158			<?= $child->getFullName() ?> <?= $child->getLifeSpan() ?>
159			<?= $child === $individual ? '</b>' : '' ?>
160			</a>
161			</td>
162			<td>
163			<?php if ($individual !== $child): ?>
164			<a href="edit_interface.php?action=addmedia_links&noteid=newnote&pid=<?= $child->getXref() ?>&gedcom=<?= $child->getTree()->getNameUrl() ?>">
165			<i class="headimg vmiddle icon-button_head"></i>
166			</a>
167			<?php endif ?>
168			</td>
169			</tr>
170			<?php
171			}
172			}
173

fisharebest / webtrees

Branch — master (60084b)

print_navigator_family() D

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like