Completed
Pull Request — master (#1461)
by Rico
07:40
created
app/Date/CalendarDate.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -842,7 +842,7 @@
 block discarded – undo
842 842
 	/**
843 843
 	 * Which months follows this one? Calendars with leap-months should provide their own implementation.
844 844
 	 *
845
-	 * @return int[]
845
+	 * @return integer[]
846 846
 	 */
847 847
 	protected function nextMonth() {
848 848
 		return [$this->m === $this->calendar->monthsInYear() ? $this->nextYear($this->y) : $this->y, ($this->m % $this->calendar->monthsInYear()) + 1];
Please login to merge, or discard this patch.
app/Database.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -85,8 +85,7 @@
 block discarded – undo
85 85
 		// Create the underlying PDO object
86 86
 		self::$pdo = new PDO(
87 87
 			(substr($DBHOST, 0, 1) === '/' ?
88
-				"mysql:unix_socket={$DBHOST};dbname={$DBNAME}" :
89
-				"mysql:host={$DBHOST};dbname={$DBNAME};port={$DBPORT}"
88
+				"mysql:unix_socket={$DBHOST};dbname={$DBNAME}" : "mysql:host={$DBHOST};dbname={$DBNAME};port={$DBPORT}"
90 89
 			),
91 90
 			$DBUSER, $DBPASS,
92 91
 			[
Please login to merge, or discard this patch.
app/Module/StoriesModule.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -381,7 +381,8 @@  discard block
 block discarded – undo
381 381
 						<a href="<?= $individual->getHtmlUrl() ?>#tab-stories">
382 382
 							<?= $individual->getFullName() ?>
383 383
 						</a>
384
-						<?php else: ?>
384
+						<?php else {
385
+	: ?>
385 386
 							<?= $story->xref ?>
386 387
 						<?php endif ?>
387 388
 						</td>
@@ -410,6 +411,7 @@  discard block
 block discarded – undo
410 411
 	 */
411 412
 	private function showList() {
412 413
 		global $controller, $WT_TREE;
414
+}
413 415
 
414 416
 		$controller = new PageController;
415 417
 		$controller
Please login to merge, or discard this patch.
app/Mail.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@
 block discarded – undo
16 16
 namespace Fisharebest\Webtrees;
17 17
 
18 18
 use Exception;
19
-use Swift_Mailer;
20 19
 use Swift_MailTransport;
20
+use Swift_Mailer;
21 21
 use Swift_Message;
22 22
 use Swift_NullTransport;
23 23
 use Swift_Preferences;
Please login to merge, or discard this patch.
app/Theme/CloudsTheme.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
 			if (!empty($menu->getSubmenus())) {
107 107
 				// Insert a dummy menu / label into the submenu
108 108
 				$submenus = $menu->getSubmenus();
109
-				array_unshift($submenus, new Menu($menu->getLabel(), null, null, [ 'onclick' => 'return false;']));
109
+				array_unshift($submenus, new Menu($menu->getLabel(), null, null, ['onclick' => 'return false;']));
110 110
 				$menu->setSubmenus($submenus);
111 111
 			}
112 112
 
Please login to merge, or discard this patch.
app/Module/GoogleMapsModule.php 2 patches
Switch Indentation   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -1120,24 +1120,24 @@
 block discarded – undo
1120 1120
 										if ($latlongval[$i] == $latlongval[$k]) {
1121 1121
 											$dups++;
1122 1122
 											switch ($dups) {
1123
-												case 1:
1124
-													$marker_number = $curgen . 'L';
1125
-													break;
1126
-												case 2:
1127
-													$marker_number = $curgen . 'R';
1128
-													break;
1129
-												case 3:
1130
-													$marker_number = $curgen . 'Ls';
1131
-													break;
1132
-												case 4:
1133
-													$marker_number = $curgen . 'Rs';
1134
-													break;
1135
-												case 5: //adjust position where markers have same coodinates
1136
-												default:
1137
-													$marker_number = $curgen;
1138
-													$lon[$i] += 0.0025;
1139
-													$lat[$i] += 0.0025;
1140
-													break;
1123
+											case 1:
1124
+												$marker_number = $curgen . 'L';
1125
+												break;
1126
+											case 2:
1127
+												$marker_number = $curgen . 'R';
1128
+												break;
1129
+											case 3:
1130
+												$marker_number = $curgen . 'Ls';
1131
+												break;
1132
+											case 4:
1133
+												$marker_number = $curgen . 'Rs';
1134
+												break;
1135
+											case 5: //adjust position where markers have same coodinates
1136
+											default:
1137
+												$marker_number = $curgen;
1138
+												$lon[$i] += 0.0025;
1139
+												$lat[$i] += 0.0025;
1140
+												break;
1141 1141
 											}
1142 1142
 										}
1143 1143
 									}
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -2247,7 +2247,7 @@  discard block
 block discarded – undo
2247 2247
 				'place_id' => $place_id,
2248 2248
 			]);
2249 2249
 		} catch (\Exception $ex) {
2250
-			FlashMessages::addMessage(I18N::translate('Location not removed: this location contains sub-locations'),'danger');
2250
+			FlashMessages::addMessage(I18N::translate('Location not removed: this location contains sub-locations'), 'danger');
2251 2251
 		}
2252 2252
 
2253 2253
 		header('Location: module.php?mod=googlemap&mod_action=admin_places&parent_id=' . $parent_id . '&inactive=' . $inactive);
@@ -3295,7 +3295,7 @@  discard block
 block discarded – undo
3295 3295
 								<?php endif ?>
3296 3296
 						</td>
3297 3297
 						<td>
3298
-							<?= FontAwesome::linkIcon('edit',  I18N::translate('Edit'), ['href' => 'module.php?mod=googlemap&mod_action=admin_place_edit&action=update&place_id=' . $place['place_id'] . '&parent_id=' . $place['parent_id'], 'class' => 'btn btn-primary']) ?>
3298
+							<?= FontAwesome::linkIcon('edit', I18N::translate('Edit'), ['href' => 'module.php?mod=googlemap&mod_action=admin_place_edit&action=update&place_id=' . $place['place_id'] . '&parent_id=' . $place['parent_id'], 'class' => 'btn btn-primary']) ?>
3299 3299
 						</td>
3300 3300
 						<td>
3301 3301
 							<?php if ($noRows == 0): ?>
@@ -3304,7 +3304,7 @@  discard block
 block discarded – undo
3304 3304
 									<input type="hidden" name="place_id" value="<?= $place['place_id'] ?>">
3305 3305
 									<input type="hidden" name="inactive" value="<?= $inactive ?>">
3306 3306
 									<button type="submit" class="btn btn-danger">
3307
-										<?= FontAwesome::semanticIcon('delete',  I18N::translate('Delete')) ?>
3307
+										<?= FontAwesome::semanticIcon('delete', I18N::translate('Delete')) ?>
3308 3308
 									</button>
3309 3309
 								</form>
3310 3310
 							<?php else: ?>
Please login to merge, or discard this patch.
placelist.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -200,7 +200,8 @@  discard block
 block discarded – undo
200 200
 			<div class="tab-pane fade show active" role="tabpanel" id="individuals">
201 201
 				<?php if (empty($myindilist)): ?>
202 202
 					<p><?= I18N::translate('No results found.') ?></p>
203
-				<?php else: ?>
203
+				<?php else {
204
+	: ?>
204 205
 					<?= FunctionsPrintLists::individualTable($myindilist) ?>
205 206
 				<?php endif ?>
206 207
 			</div>
@@ -216,6 +217,7 @@  discard block
 block discarded – undo
216 217
 		<?php
217 218
 	}
218 219
 	echo '<h4><a href="placelist.php?display=list">', I18N::translate('Show all places in a list'), '</a></h4>';
220
+}
219 221
 
220 222
 	if ($gm_module && $gm_module->getPreference('GM_PLACE_HIERARCHY')) {
221 223
 		$gm_module->mapScripts($numfound, $level, $parent, $linklevels, $place_names);
Please login to merge, or discard this patch.
admin_trees_config.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1505,7 +1505,7 @@
 block discarded – undo
1505 1505
 						'0' => I18N::translateContext('Show the [first/last] [N] parts of a place name.', 'first'),
1506 1506
 						'1' => I18N::translateContext('Show the [first/last] [N] parts of a place name.', 'last'),
1507 1507
 					], $WT_TREE->getPreference('SHOW_PEDIGREE_PLACES_SUFFIX', ['name' => 'SHOW_PEDIGREE_PLACES_SUFFIX'])),
1508
-					Bootstrap4::select(FunctionsEdit::numericOptions(range(1,9)), $WT_TREE->getPreference('SHOW_PEDIGREE_PLACES'), ['name' => 'SHOW_PEDIGREE_PLACES'])
1508
+					Bootstrap4::select(FunctionsEdit::numericOptions(range(1, 9)), $WT_TREE->getPreference('SHOW_PEDIGREE_PLACES'), ['name' => 'SHOW_PEDIGREE_PLACES'])
1509 1509
 				) ?>
1510 1510
 				<p class="small text-muted">
1511 1511
 					<?= /* I18N: Help text for the “Abbreviate place names” configuration setting */ I18N::translate('Place names are frequently too long to fit on charts, lists, etc. They can be abbreviated by showing just the first few parts of the name, such as <i>village, county</i>, or the last few part of it, such as <i>region, country</i>.') ?>
Please login to merge, or discard this patch.
app/Module.php 2 patches
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -135,7 +135,7 @@
 block discarded – undo
135 135
 					}
136 136
 				} catch (\Exception $ex) {
137 137
 					// The module has been deleted or is broken? Disable it.
138
-					Log::addConfigurationLog("Module {$module_name} is missing or broken - disabling it. " . $ex->getMessage());
138
+					Log::addConfigurationLog("module {$module_name} is missing or broken - disabling it. " . $ex->getMessage());
139 139
 					Database::prepare(
140 140
 						"UPDATE `##module` SET status = 'disabled' WHERE module_name = :module_name"
141 141
 					)->execute([
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -280,7 +280,7 @@
 block discarded – undo
280 280
 		// Exclude disabled modules
281 281
 		$enabled_modules = Database::prepare("SELECT module_name, status FROM `##module` WHERE status='enabled'")->fetchOneColumn();
282 282
 
283
-		return array_filter($modules, function(AbstractModule $module) use ($enabled_modules) {
283
+		return array_filter($modules, function (AbstractModule $module) use ($enabled_modules) {
284 284
 			return in_array($module->getName(), $enabled_modules);
285 285
 		});
286 286
 	}
Please login to merge, or discard this patch.