fisharebest /
webtrees
| Conditions | 11 |
| Paths | 98 |
| Total Lines | 74 |
| Code Lines | 49 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 86 | public function handle(ServerRequestInterface $request): ResponseInterface |
||
| 87 | { |
||
| 88 | $tree = $request->getAttribute('tree'); |
||
| 89 | assert($tree instanceof Tree); |
||
| 90 | |||
| 91 | $base_url = $request->getAttribute('base_url'); |
||
| 92 | $body = Validator::parsedBody($request)->string('body') ?? ''; |
||
| 93 | $from_email = Validator::parsedBody($request)->string('from_email') ?? ''; |
||
| 94 | $from_name = Validator::parsedBody($request)->string('from_name') ?? ''; |
||
| 95 | $subject = Validator::parsedBody($request)->string('subject') ?? ''; |
||
| 96 | $to = Validator::parsedBody($request)->string('to') ?? ''; |
||
| 97 | $url = Validator::parsedBody($request)->localUrl($base_url)->string('url') ?? $base_url; |
||
| 98 | $ip = $request->getAttribute('client-ip'); |
||
| 99 | $to_user = $this->user_service->findByUserName($to); |
||
| 100 | |||
| 101 | if ($to_user === null) { |
||
| 102 | throw new HttpNotFoundException(); |
||
| 103 | } |
||
| 104 | |||
| 105 | if (!in_array($to_user, $this->message_service->validContacts($tree), false)) { |
||
| 106 | throw new HttpAccessDeniedException('Invalid contact user id'); |
||
| 107 | } |
||
| 108 | |||
| 109 | $errors = $body === '' || $subject === '' || $from_email === '' || $from_name === ''; |
||
| 110 | |||
| 111 | if ($this->captcha_service->isRobot($request)) { |
||
| 112 | FlashMessages::addMessage(I18N::translate('Please try again.'), 'danger'); |
||
| 113 | $errors = true; |
||
| 114 | } |
||
| 115 | |||
| 116 | if (!$this->email_service->isValidEmail($from_email)) { |
||
| 117 | FlashMessages::addMessage(I18N::translate('Please enter a valid email address.'), 'danger'); |
||
| 118 | $errors = true; |
||
| 119 | } |
||
| 120 | |||
| 121 | if (preg_match('/(?!' . preg_quote($base_url, '/') . ')(((?:ftp|http|https):\/\/)[a-zA-Z0-9.-]+)/', $subject . $body, $match)) { |
||
| 122 | FlashMessages::addMessage(I18N::translate('You are not allowed to send messages that contain external links.') . ' ' . /* I18N: e.g. ‘You should delete the “https://” from “https://www.example.com” and try again.’ */ |
||
| 123 | I18N::translate('You should delete the “%1$s” from “%2$s” and try again.', $match[2], $match[1]), 'danger'); |
||
| 124 | $errors = true; |
||
| 125 | } |
||
| 126 | |||
| 127 | if ($errors) { |
||
| 128 | return redirect(route(ContactPage::class, [ |
||
| 129 | 'body' => $body, |
||
| 130 | 'from_email' => $from_email, |
||
| 131 | 'from_name' => $from_name, |
||
| 132 | 'subject' => $subject, |
||
| 133 | 'to' => $to, |
||
| 134 | 'tree' => $tree->name(), |
||
| 135 | 'url' => $url, |
||
| 136 | ])); |
||
| 137 | } |
||
| 138 | |||
| 139 | $sender = new GuestUser($from_email, $from_name); |
||
| 140 | |||
| 141 | if ($this->message_service->deliverMessage($sender, $to_user, $subject, $body, $url, $ip)) { |
||
| 142 | FlashMessages::addMessage(I18N::translate('The message was successfully sent to %s.', e($to_user->realName())), 'success'); |
||
| 143 | |||
| 144 | return redirect($url); |
||
| 145 | } |
||
| 146 | |||
| 147 | FlashMessages::addMessage(I18N::translate('The message was not sent.'), 'danger'); |
||
| 148 | |||
| 149 | $redirect_url = route(ContactPage::class, [ |
||
| 150 | 'body' => $body, |
||
| 151 | 'from_email' => $from_email, |
||
| 152 | 'from_name' => $from_name, |
||
| 153 | 'subject' => $subject, |
||
| 154 | 'to' => $to, |
||
| 155 | 'tree' => $tree->name(), |
||
| 156 | 'url' => $url, |
||
| 157 | ]); |
||
| 158 | |||
| 159 | return redirect($redirect_url); |
||
| 160 | } |
||
| 162 |
