fisharebest /
webtrees
| Conditions | 11 |
| Paths | 180 |
| Total Lines | 59 |
| Code Lines | 41 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 42 | public function handle(ServerRequestInterface $request): ResponseInterface |
||
| 43 | { |
||
| 44 | $tree = Validator::attributes($request)->tree(); |
||
| 45 | $xref = Validator::attributes($request)->isXref()->string('xref'); |
||
| 46 | $individual = Registry::individualFactory()->make($xref, $tree); |
||
| 47 | $individual = Auth::checkIndividualAccess($individual, true); |
||
| 48 | $famid = Validator::parsedBody($request)->isXref()->string('famid'); |
||
| 49 | $PEDI = Validator::parsedBody($request)->string('PEDI'); |
||
| 50 | |||
| 51 | $family = Registry::familyFactory()->make($famid, $tree); |
||
| 52 | $family = Auth::checkFamilyAccess($family, true); |
||
| 53 | |||
| 54 | // Replace any existing child->family link (we may be changing the PEDI); |
||
| 55 | $fact_id = ''; |
||
| 56 | foreach ($individual->facts(['FAMC']) as $fact) { |
||
| 57 | if ($family === $fact->target()) { |
||
| 58 | $fact_id = $fact->id(); |
||
| 59 | break; |
||
| 60 | } |
||
| 61 | } |
||
| 62 | |||
| 63 | switch ($PEDI) { |
||
| 64 | case '': |
||
| 65 | $gedcom = "1 FAMC @$famid@"; |
||
| 66 | break; |
||
| 67 | case PedigreeLinkageType::VALUE_ADOPTED: |
||
| 68 | $gedcom = "1 FAMC @$famid@\n2 PEDI $PEDI\n1 ADOP\n2 FAMC @$famid@\n3 ADOP BOTH"; |
||
| 69 | break; |
||
| 70 | case PedigreeLinkageType::VALUE_SEALING: |
||
| 71 | $gedcom = "1 FAMC @$famid@\n2 PEDI $PEDI\n1 SLGC\n2 FAMC @$famid@"; |
||
| 72 | break; |
||
| 73 | case PedigreeLinkageType::VALUE_FOSTER: |
||
| 74 | $gedcom = "1 FAMC @$famid@\n2 PEDI $PEDI\n1 EVEN\n2 TYPE $PEDI"; |
||
| 75 | break; |
||
| 76 | default: |
||
| 77 | $gedcom = "1 FAMC @$famid@\n2 PEDI $PEDI"; |
||
| 78 | break; |
||
| 79 | } |
||
| 80 | |||
| 81 | if ($fact_id === '') { |
||
| 82 | $individual->createFact($gedcom, true); |
||
| 83 | } else { |
||
| 84 | $individual->updateFact($fact_id, $gedcom, true); |
||
| 85 | } |
||
| 86 | |||
| 87 | // Only set the family->child link if it does not already exist |
||
| 88 | $chil_link_exists = false; |
||
| 89 | foreach ($family->facts(['CHIL']) as $fact) { |
||
| 90 | if ($individual === $fact->target()) { |
||
| 91 | $chil_link_exists = true; |
||
| 92 | break; |
||
| 93 | } |
||
| 94 | } |
||
| 95 | |||
| 96 | if (!$chil_link_exists) { |
||
| 97 | $family->createFact('1 CHIL @' . $individual->xref() . '@', true); |
||
| 98 | } |
||
| 99 | |||
| 100 | return redirect($individual->url()); |
||
| 101 | } |
||
| 103 |
Loading history...
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths