fisharebest / webtrees

edit_interface.php

Unused Use Statements +2 added lines, -1 removed lines

@@ -23,7 +23,8 @@
 use Fisharebest\Webtrees\Functions\FunctionsEdit;
 use Fisharebest\Webtrees\Functions\FunctionsImport;
 use Fisharebest\Webtrees\Functions\FunctionsPrint;
-use Fisharebest\Webtrees\GedcomCode\GedcomCodeName;use Fisharebest\Webtrees\GedcomCode\GedcomCodePedi;
+use Fisharebest\Webtrees\GedcomCode\GedcomCodeName;
+use Fisharebest\Webtrees\GedcomCode\GedcomCodePedi;
 use Fisharebest\Webtrees\Module\CensusAssistantModule;
 
 require 'includes/session.php';

Spacing +2 added lines, -2 removed lines

@@ -23,7 +23,7 @@ 
 use Fisharebest\Webtrees\Functions\FunctionsEdit;
 use Fisharebest\Webtrees\Functions\FunctionsImport;
 use Fisharebest\Webtrees\Functions\FunctionsPrint;
-use Fisharebest\Webtrees\GedcomCode\GedcomCodeName;use Fisharebest\Webtrees\GedcomCode\GedcomCodePedi;
+use Fisharebest\Webtrees\GedcomCode\GedcomCodeName; use Fisharebest\Webtrees\GedcomCode\GedcomCodePedi;
 use Fisharebest\Webtrees\Module\CensusAssistantModule;
 
 require 'includes/session.php';
@@ -2968,7 +2968,7 @@ 
 	// First - standard name fields
 	foreach ($name_fields as $tag => $value) {
 		if (substr_compare($tag, '_', 0, 1) !== 0) {
-			echo FunctionsEdit::addSimpleTag('0 ' . $tag . ' ' . $value, '', '',  null, $person);
+			echo FunctionsEdit::addSimpleTag('0 ' . $tag . ' ' . $value, '', '', null, $person);
 		}
 	}
 

app/Statement.php

Doc Comments +1 added lines, -1 removed lines

@@ -106,7 +106,7 @@
 	 *
 	 * @param int $fetch_style
 	 *
-	 * @return stdClass|array|false
+	 * @return Tree
 	 */
 	public function fetch($fetch_style = PDO::FETCH_OBJ) {
 		if (!$this->executed) {

app/View.php

Doc Comments +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
 	/**
 	 * Createa view from a template name and optional data.
 	 *
-	 * @param       $name
+	 * @param       string $name
 	 * @param array $data
 	 */
 	public function __construct($name, $data = []) {

Spacing +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
 	 * @return string
 	 */
 	public static function getFilenameForView($view_name) {
-		$view_file  = $view_name . '.php';
+		$view_file = $view_name . '.php';
 		//$theme_view = WT_THEMES_DIR . Theme::theme()->themeId() . '/resources/views/' . $view_file;
 
 		//if (file_exists($theme_view)) {

app/Controller/SearchController.php

Unused Use Statements -1 removed lines

@@ -17,7 +17,6 @@
 
 use Fisharebest\Webtrees\Auth;
 use Fisharebest\Webtrees\Bootstrap4;
-use Fisharebest\Webtrees\Config;
 use Fisharebest\Webtrees\Family;
 use Fisharebest\Webtrees\Filter;
 use Fisharebest\Webtrees\FlashMessages;

search_advanced.php

Braces +6 added lines, -2 removed lines

@@ -146,7 +146,8 @@ 
 					value="<?= Html::escape($controller->getValue($i)) ?>">
 						<?php if (preg_match('/^NAME:/', $currentFieldSearch) > 0): ?>
 							<select class="form-control form-control-sm col-3" name="fields[<?= $i ?>]">
-								<option value="<?= $currentField ?>:EXACT" <?php if (preg_match('/:EXACT$/', $currentFieldSearch) > 0) echo 'selected' ?>>
+								<option value="<?= $currentField ?>:EXACT" <?php if (preg_match('/:EXACT$/', $currentFieldSearch) > 0) {
+	echo 'selected' ?>>
 									<?= I18N::translate('Exact') ?>
 								</option>
 								<option value="<?= $currentField ?>:BEGINS" <?php if (preg_match('/:BEGINS$/', $currentFieldSearch) > 0) echo 'selected' ?>>
@@ -161,13 +162,15 @@ 
 						<?php else: ?>
 							<input type="hidden" name="fields[<?= $i ?>]" value="<?= $controller->getField($i) ?>">
 						<?php endif;
+}
 						if (preg_match('/:DATE$/', $currentFieldSearch) > 0) {
 							?>
 							<select class="form-control form-control-sm col-3" name="plusminus[<?= $i ?>]">
 								<option value="">
 									<?= I18N::translate('Exact date') ?>
 								</option>
-								<option value="2" <?php if (!empty($controller->plusminus[$i]) && $controller->plusminus[$i] == 2) echo 'selected' ?>>
+								<option value="2" <?php if (!empty($controller->plusminus[$i]) && $controller->plusminus[$i] == 2) {
+	echo 'selected' ?>>
 									<?= I18N::plural('±%s year', '±%s years', 2, I18N::number(2)) ?>
 								</option>
 								<option value="5" <?php if (!empty($controller->plusminus[$i]) && $controller->plusminus[$i] == 5) echo 'selected' ?>>
@@ -183,6 +186,7 @@ 
 					//-- relative fields
 					if ($i == 0 && $fct > 4) {
 						$j = $fct;
+}
 						// Get the current options for Father’s and Mother’s name searches
 						$fatherGivnOption = 'SDX';
 						$fatherSurnOption = 'SDX';

app/Module/ResearchTaskModule.php

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
 			'jd'      => $end_jd,
 		])->fetchOneColumn();
 
-		$records = array_map(function($xref) use ($WT_TREE) {
+		$records = array_map(function ($xref) use ($WT_TREE) {
 			return GedcomRecord::getInstance($xref, $WT_TREE);
 		}, $xrefs);
 

resources/views/blocks/sign-in.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php use Fisharebest\Webtrees\Html; ?>
+<?php  ?>
 <?php use Fisharebest\Webtrees\I18N; ?>
 
 <form name="login-form" method="POST" action="<?= WT_LOGIN_URL ?>">

app/Functions/FunctionsPrintFacts.php

Braces +3 added lines, -1 removed lines

@@ -191,7 +191,8 @@ 
 			<div class="editfacts">
 				<?php if ($fact->getTag() === 'FILE' && $fact->getParent() instanceof Media): ?>
 					<?= FontAwesome::linkIcon('edit', I18N::translate('Edit'), ['class' => 'btn btn-link', 'href' => 'edit_interface.php?action=media-edit&xref=' . $parent->getXref() . '&fact_id=' . $fact->getFactId() . '&ged=' . $parent->getTree()->getNameHtml()]) ?>
-				<?php else: ?>
+				<?php else {
+	: ?>
 					<?= FontAwesome::linkIcon('edit', I18N::translate('Edit'), ['class' => 'btn btn-link', 'href' => 'edit_interface.php?action=edit&xref=' . $parent->getXref() . '&fact_id=' . $fact->getFactId() . '&ged=' . $parent->getTree()->getNameHtml()]) ?>
 					<?= FontAwesome::linkIcon('copy', I18N::translate('Copy'), ['class' => 'btn btn-link', 'href' => '#', 'onclick' => 'return copy_fact("' . $parent->getXref() . '", "' . $fact->getFactId() . '");']) ?>
 					<?= FontAwesome::linkIcon('delete', I18N::translate('Delete'), ['class' => 'btn btn-link', 'href' => '#', 'onclick' => 'return delete_fact("' . I18N::translate('Are you sure you want to delete this fact?') . '", "' . $parent->getXref() . '", "' . $fact->getFactId() . '");']) ?>
@@ -200,6 +201,7 @@ 
 		<?php
 		} else {
 			echo $label;
+}
 		}
 
 		echo '</th>';

Unused Use Statements -2 removed lines

@@ -30,8 +30,6 @@
 use Fisharebest\Webtrees\I18N;
 use Fisharebest\Webtrees\Individual;
 use Fisharebest\Webtrees\Media;
-use Fisharebest\Webtrees\Module;
-use Fisharebest\Webtrees\Module\CensusAssistantModule;
 use Fisharebest\Webtrees\Note;
 use Fisharebest\Webtrees\Repository;
 use Fisharebest\Webtrees\Source;

app/Module/RelativesTabModule.php

Indentation +1 added lines, -1 removed lines

@@ -177,7 +177,7 @@
 					$row_class .= ' old';
 				}
 				$icon = $controller->record === $person ? '<i class="icon-selected"></i>' : '';
-        ?>
+				?>
 				<tr class="<?= $row_class ?>">
 					<th scope="row">
 					<?= $icon ?>