Inspection of "Charts as modules - more work" - fisharebest/webtrees - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — charts ( 02447f )

by Greg

created 2016-04-10 16:49 UTC

Status

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -17,8 +17,8 @@
 block discarded – undo
 
 use Fisharebest\Webtrees\Auth;
 use Fisharebest\Webtrees\I18N;
-use Fisharebest\Webtrees\Menu;
 use Fisharebest\Webtrees\Individual;
+use Fisharebest\Webtrees\Menu;
 
 /**
  * Class TimelineChartModule

Please login to merge, or discard this patch.

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -56,7 +56,7 @@  discard block
 block discarded – undo
 	/**
 	 * Return a menu item for this chart.
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 */
 	public function getChartMenu(Individual $individual) {
 		return new Menu(
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
 	/**
 	 * Return a menu item for this chart - for use in individual boxes.
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 */
 	public function getBoxChartMenu(Individual $individual) {
 		return $this->getChartMenu($individual);

Please login to merge, or discard this patch.

app/Module/RelationshipsChartModule.php 2 patches

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -17,8 +17,8 @@
 block discarded – undo
 
 use Fisharebest\Webtrees\Auth;
 use Fisharebest\Webtrees\I18N;
-use Fisharebest\Webtrees\Menu;
 use Fisharebest\Webtrees\Individual;
+use Fisharebest\Webtrees\Menu;
 
 /**
  * Class TimelineChartModule

Please login to merge, or discard this patch.

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -56,7 +56,7 @@  discard block
 block discarded – undo
 	/**
 	 * Return a menu item for this chart.
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 */
 	public function getChartMenu(Individual $individual) {
 		$tree     = $individual->getTree();
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
 	/**
 	 * Return a menu item for this chart - for use in individual boxes.
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 */
 	public function getBoxChartMenu(Individual $individual) {
 		return $this->getChartMenu($individual);

Please login to merge, or discard this patch.

app/Module/StatisticsChartModule.php 2 patches

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -17,8 +17,8 @@
 block discarded – undo
 
 use Fisharebest\Webtrees\Auth;
 use Fisharebest\Webtrees\I18N;
-use Fisharebest\Webtrees\Menu;
 use Fisharebest\Webtrees\Individual;
+use Fisharebest\Webtrees\Menu;
 
 /**
  * Class TimelineChartModule

Please login to merge, or discard this patch.

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -500,7 +500,7 @@
 block discarded – undo
 	/**
 	 * A menu, to be added to the main application menu.
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 */
 	public function getMenu() {
 		$menu = new Menu($this->getTitle(), 'module.php?mod=' . $this->getName() . '&amp;mod_action=show_list', 'menu-story');

Please login to merge, or discard this patch.

app/Controller/FanchartController.php 1 patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -15,10 +15,8 @@
 block discarded – undo
  */
 namespace Fisharebest\Webtrees\Controller;
 
-use Fisharebest\Webtrees\Auth;
 use Fisharebest\Webtrees\Filter;
 use Fisharebest\Webtrees\I18N;
-use Fisharebest\Webtrees\Module;
 use Fisharebest\Webtrees\Theme;
 
 /**

Please login to merge, or discard this patch.

app/Theme/AbstractTheme.php 1 patch

Doc Comments +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1115,7 +1115,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param Individual $individual
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 *
 	 * @deprecated
 	 */
@@ -1130,7 +1130,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param Individual $individual
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 *
 	 * @deprecated
 	 */
@@ -1145,7 +1145,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param Individual $individual
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 *
 	 * @deprecated
 	 */
@@ -1160,7 +1160,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param Individual $individual
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 *
 	 * @deprecated
 	 */
@@ -1192,7 +1192,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param Individual $individual
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 *
 	 * @deprecated
 	 */
@@ -1207,7 +1207,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param Individual $individual
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 *
 	 * @deprecated
 	 */
@@ -1222,7 +1222,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param Individual $individual
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 *
 	 * @deprecated
 	 */
@@ -1237,7 +1237,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param Individual $individual
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 *
 	 * @deprecated
 	 */
@@ -1252,7 +1252,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param Individual $individual
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 *
 	 * @deprecated
 	 */
@@ -1267,7 +1267,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param Individual $individual
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 *
 	 * @deprecated
 	 */
@@ -1280,7 +1280,7 @@  discard block
 block discarded – undo
 	/**
 	 * Generate a menu item for the statistics charts.
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 *
 	 * @deprecated
 	 */
@@ -1295,7 +1295,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param Individual $individual
 	 *
-	 * @return Menu|null
+	 * @return Menu
 	 *
 	 * @deprecated
 	 */

Please login to merge, or discard this patch.

		@@ -500,7 +500,7 @@
		block discarded – undo
500	500	/**
501	501	* A menu, to be added to the main application menu.
502	502	*
503		- * @return Menu\|null
	503	+ * @return Menu
504	504	*/
505	505	public function getMenu() {
506	506	$menu = new Menu($this->getTitle(), 'module.php?mod=' . $this->getName() . '&mod_action=show_list', 'menu-story');

		@@ -1115,7 +1115,7 @@ discard block
		block discarded – undo
1115	1115	*
1116	1116	* @param Individual $individual
1117	1117	*
1118		- * @return Menu\|null
	1118	+ * @return Menu
1119	1119	*
1120	1120	* @deprecated
1121	1121	*/
		@@ -1130,7 +1130,7 @@ discard block
		block discarded – undo
1130	1130	*
1131	1131	* @param Individual $individual
1132	1132	*
1133		- * @return Menu\|null
	1133	+ * @return Menu
1134	1134	*
1135	1135	* @deprecated
1136	1136	*/
		@@ -1145,7 +1145,7 @@ discard block
		block discarded – undo
1145	1145	*
1146	1146	* @param Individual $individual
1147	1147	*
1148		- * @return Menu\|null
	1148	+ * @return Menu
1149	1149	*
1150	1150	* @deprecated
1151	1151	*/
		@@ -1160,7 +1160,7 @@ discard block
		block discarded – undo
1160	1160	*
1161	1161	* @param Individual $individual
1162	1162	*
1163		- * @return Menu\|null
	1163	+ * @return Menu
1164	1164	*
1165	1165	* @deprecated
1166	1166	*/
		@@ -1192,7 +1192,7 @@ discard block
		block discarded – undo
1192	1192	*
1193	1193	* @param Individual $individual
1194	1194	*
1195		- * @return Menu\|null
	1195	+ * @return Menu
1196	1196	*
1197	1197	* @deprecated
1198	1198	*/
		@@ -1207,7 +1207,7 @@ discard block
		block discarded – undo
1207	1207	*
1208	1208	* @param Individual $individual
1209	1209	*
1210		- * @return Menu\|null
	1210	+ * @return Menu
1211	1211	*
1212	1212	* @deprecated
1213	1213	*/
		@@ -1222,7 +1222,7 @@ discard block
		block discarded – undo
1222	1222	*
1223	1223	* @param Individual $individual
1224	1224	*
1225		- * @return Menu\|null
	1225	+ * @return Menu
1226	1226	*
1227	1227	* @deprecated
1228	1228	*/
		@@ -1237,7 +1237,7 @@ discard block
		block discarded – undo
1237	1237	*
1238	1238	* @param Individual $individual
1239	1239	*
1240		- * @return Menu\|null
	1240	+ * @return Menu
1241	1241	*
1242	1242	* @deprecated
1243	1243	*/
		@@ -1252,7 +1252,7 @@ discard block
		block discarded – undo
1252	1252	*
1253	1253	* @param Individual $individual
1254	1254	*
1255		- * @return Menu\|null
	1255	+ * @return Menu
1256	1256	*
1257	1257	* @deprecated
1258	1258	*/
		@@ -1267,7 +1267,7 @@ discard block
		block discarded – undo
1267	1267	*
1268	1268	* @param Individual $individual
1269	1269	*
1270		- * @return Menu\|null
	1270	+ * @return Menu
1271	1271	*
1272	1272	* @deprecated
1273	1273	*/
		@@ -1280,7 +1280,7 @@ discard block
		block discarded – undo
1280	1280	/**
1281	1281	* Generate a menu item for the statistics charts.
1282	1282	*
1283		- * @return Menu\|null
	1283	+ * @return Menu
1284	1284	*
1285	1285	* @deprecated
1286	1286	*/
		@@ -1295,7 +1295,7 @@ discard block
		block discarded – undo
1295	1295	*
1296	1296	* @param Individual $individual
1297	1297	*
1298		- * @return Menu\|null
	1298	+ * @return Menu
1299	1299	*
1300	1300	* @deprecated
1301	1301	*/

		@@ -17,8 +17,8 @@
		block discarded – undo
17	17
18	18	use Fisharebest\Webtrees\Auth;
19	19	use Fisharebest\Webtrees\I18N;
20		-use Fisharebest\Webtrees\Menu;
21	20	use Fisharebest\Webtrees\Individual;
	21	+use Fisharebest\Webtrees\Menu;
22	22
23	23	/**
24	24	* Class TimelineChartModule

		@@ -56,7 +56,7 @@ discard block
		block discarded – undo
56	56	/**
57	57	* Return a menu item for this chart.
58	58	*
59		- * @return Menu\|null
	59	+ * @return Menu
60	60	*/
61	61	public function getChartMenu(Individual $individual) {
62	62	return new Menu(
		@@ -70,7 +70,7 @@ discard block
		block discarded – undo
70	70	/**
71	71	* Return a menu item for this chart - for use in individual boxes.
72	72	*
73		- * @return Menu\|null
	73	+ * @return Menu
74	74	*/
75	75	public function getBoxChartMenu(Individual $individual) {
76	76	return $this->getChartMenu($individual);

		@@ -15,10 +15,8 @@
		block discarded – undo
15	15	*/
16	16	namespace Fisharebest\Webtrees\Controller;
17	17
18		-use Fisharebest\Webtrees\Auth;
19	18	use Fisharebest\Webtrees\Filter;
20	19	use Fisharebest\Webtrees\I18N;
21		-use Fisharebest\Webtrees\Module;
22	20	use Fisharebest\Webtrees\Theme;
23	21
24	22	/**

fisharebest / webtrees

Push — charts ( 02447f )

Status

Category

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

Doc Comments +12 added lines, -12 removed lines patch added patch discarded remove patch