Completed
Push — develop ( 0e5c0f...2f193e )
by Greg
16:08 queued 07:53
created
app/Controller/IndividualController.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,6 @@
 block discarded – undo
127 127
 	/**
128 128
 	 * Format a name record
129 129
 	 *
130
-	 * @param int  $primary
131 130
 	 * @param Fact $name_fact
132 131
 	 *
133 132
 	 * @return string
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 	public function getTabs() {
96 96
 		$active_tabs = Module::getActiveTabs($this->record->getTree());
97 97
 
98
-		return array_filter($active_tabs, function(ModuleTabInterface $tab) { return $tab->hasTabContent(); });
98
+		return array_filter($active_tabs, function (ModuleTabInterface $tab) { return $tab->hasTabContent(); });
99 99
 	}
100 100
 
101 101
 	/**
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 
144 144
 		if ($n === 0) {
145 145
 			$content_class = 'collapse show';
146
-			$aria  = 'true';
146
+			$aria = 'true';
147 147
 
148 148
 			// Display gender icon
149 149
 			foreach ($individual->getFacts('SEX') as $sex_fact) {
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
 		echo '<dd class="field">', $dummy->getFullName();
163 163
 		if ($this->record->canEdit() && !$name_fact->isPendingDeletion()) {
164 164
 			echo "<div class=\"deletelink\"><a class=\"deleteicon\" href=\"#\" onclick=\"return delete_fact('" . I18N::translate('Are you sure you want to delete this fact?') . "', '" . $this->record->getXref() . "', '" . $name_fact->getFactId() . "');\" title=\"" . I18N::translate('Delete this name') . '"><span class="link_text">' . I18N::translate('Delete this name') . '</span></a></div>';
165
-			echo '<div class="editlink"><a href="edit_interface.php?action=editname&amp;xref=' . $this->record->getXref() . '&amp;fact_id=' . $name_fact->getFactId() . '&amp;ged=' . $this->record->getTree()->getNameHtml() .  '" class="editicon" title="' . I18N::translate('Edit the name') . '"><span class="link_text">' . I18N::translate('Edit the name') . '</span></a></div>';
165
+			echo '<div class="editlink"><a href="edit_interface.php?action=editname&amp;xref=' . $this->record->getXref() . '&amp;fact_id=' . $name_fact->getFactId() . '&amp;ged=' . $this->record->getTree()->getNameHtml() . '" class="editicon" title="' . I18N::translate('Edit the name') . '"><span class="link_text">' . I18N::translate('Edit the name') . '</span></a></div>';
166 166
 		}
167 167
 		echo '</dd>';
168 168
 		$ct = preg_match_all('/\n2 (\w+) (.*)/', $name_fact->getGedcom(), $nmatch, PREG_SET_ORDER);
Please login to merge, or discard this patch.
individual.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@
 block discarded – undo
89 89
 if (Auth::isAdmin()) {
90 90
 	$user = User::findByGenealogyRecord($controller->record);
91 91
 	if ($user) {
92
-		$user_link =  ' —  <a href="admin_users.php?filter=' . Filter::escapeHtml($user->getUserName()) . '">' . Filter::escapeHtml($user->getUserName()) . '</a>';
92
+		$user_link = ' —  <a href="admin_users.php?filter=' . Filter::escapeHtml($user->getUserName()) . '">' . Filter::escapeHtml($user->getUserName()) . '</a>';
93 93
 	};
94 94
 }
95 95
 
Please login to merge, or discard this patch.
index_edit.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -146,7 +146,7 @@
 block discarded – undo
146 146
 			}
147 147
 		}
148 148
 	}
149
-	if ($user_id < 0 || $gedcom_id < 0 ) {
149
+	if ($user_id < 0 || $gedcom_id < 0) {
150 150
 		header('Location: ' . WT_BASE_URL . 'admin.php');
151 151
 	} elseif ($user_id > 0) {
152 152
 		header('Location: ' . WT_BASE_URL . 'index.php?ctype=user&ged=' . $WT_TREE->getNameUrl());
Please login to merge, or discard this patch.
app/Functions/FunctionsPrint.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -189,7 +189,7 @@
 block discarded – undo
189 189
 			    <div class="modal-content">
190 190
 			      <div class="modal-header">
191 191
 			        <h3 class="modal-title" id="wt-modal-title">' . $title . '</h3>
192
-			        <button type="button" class="close" data-dismiss="modal" aria-label="'. I18N::translate('close') .'">
192
+			        <button type="button" class="close" data-dismiss="modal" aria-label="'. I18N::translate('close') . '">
193 193
 			          <span aria-hidden="true">&times;</span>
194 194
 			        </button>
195 195
 			      </div>
Please login to merge, or discard this patch.
app/Module/UserMessagesModule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@
 block discarded – undo
127 127
 					$message->subject = I18N::translate('RE: ') . $message->subject;
128 128
 				}
129 129
 				if ($user) {
130
-					$content .= '<a class="btn btn-secondary" href="message.php?to=' . Filter::escapeUrl($message->sender) . '&amp;subject=' . Filter::escapeUrl($message->subject) . '&amp;ged=' . $WT_TREE->getNameUrl() .'" title="' . I18N::translate('Reply') .'">' . I18N::translate('Reply') . '</a> ';
130
+					$content .= '<a class="btn btn-secondary" href="message.php?to=' . Filter::escapeUrl($message->sender) . '&amp;subject=' . Filter::escapeUrl($message->subject) . '&amp;ged=' . $WT_TREE->getNameUrl() . '" title="' . I18N::translate('Reply') . '">' . I18N::translate('Reply') . '</a> ';
131 131
 				}
132 132
 				$content .= '<button type="button" onclick="if (confirm(\'' . I18N::translate('Are you sure you want to delete this message? It cannot be retrieved later.') . '\')) {$(\'#messageform :checkbox\').prop(\'checked\', false); $(\'#cb_message' . $message->message_id . '\').prop(\'checked\', true); document.messageform.submit();}">' . I18N::translate('Delete') . '</button></div></td></tr>';
133 133
 			}
Please login to merge, or discard this patch.
app/Theme/AbstractTheme.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -90,9 +90,9 @@
 block discarded – undo
90 90
 		'info'    => 'fa fa-info-circle',
91 91
 		'warning' => 'fa fa-exclamation-circle',
92 92
 
93
-	  // Icons for file types
94
-	  'mime-application-pdf' => '',
95
-	  'mime-text-html'       => '',
93
+		// Icons for file types
94
+		'mime-application-pdf' => '',
95
+		'mime-text-html'       => '',
96 96
 
97 97
 		// Other icons
98 98
 		'mail'    => 'fa fa-envelope-o',
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -819,7 +819,7 @@  discard block
 block discarded – undo
819 819
 				'<div class="icons">' .
820 820
 				'<span class="iconz icon-zoomin" title="' . I18N::translate('Zoom in/out on this box.') . '"></span>' .
821 821
 				'<div class="itr"><i class="icon-pedigree"></i><div class="popup">' .
822
-				'<ul class="' . $personBoxClass . '">' . implode('', array_map(function(Menu $menu) { return $menu->bootstrap4(); }, $this->individualBoxMenu($individual))) . '</ul>' .
822
+				'<ul class="' . $personBoxClass . '">' . implode('', array_map(function (Menu $menu) { return $menu->bootstrap4(); }, $this->individualBoxMenu($individual))) . '</ul>' .
823 823
 				'</div>' .
824 824
 				'</div>' .
825 825
 				'</div>';
@@ -871,7 +871,7 @@  discard block
 block discarded – undo
871 871
 				'<div class="icons">' .
872 872
 				'<span class="iconz icon-zoomin" title="' . I18N::translate('Zoom in/out on this box.') . '"></span>' .
873 873
 				'<div class="itr"><i class="icon-pedigree"></i><div class="popup">' .
874
-				'<ul class="' . $personBoxClass . '">' . implode('', array_map(function(Menu $menu) { return $menu->bootstrap4(); }, $this->individualBoxMenu($individual))) . '</ul>' .
874
+				'<ul class="' . $personBoxClass . '">' . implode('', array_map(function (Menu $menu) { return $menu->bootstrap4(); }, $this->individualBoxMenu($individual))) . '</ul>' .
875 875
 				'</div>' .
876 876
 				'</div>' .
877 877
 				'</div>';
Please login to merge, or discard this patch.
message.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 $controller->restrictAccess(!in_array($to, ['all', 'never_logged', 'last_6mo']) || Auth::isAdmin());
101 101
 $controller->pageHeader();
102 102
 
103
-$to_names = implode(I18N::$list_separator, array_map(function(User $user) { return $user->getRealName(); }, recipients($to)));
103
+$to_names = implode(I18N::$list_separator, array_map(function (User $user) { return $user->getRealName(); }, recipients($to)));
104 104
 
105 105
 ?>
106 106
 <h2><?= I18N::translate('Send a message') ?></h2>
@@ -185,13 +185,13 @@  discard block
 block discarded – undo
185 185
  */
186 186
 function recipients($to) {
187 187
 	if ($to === 'all') {
188
-		$recipients =	User::all();
188
+		$recipients = User::all();
189 189
 	} elseif ($to === 'last_6mo') {
190
-		$recipients = array_filter(User::all(), function(User $user) {
190
+		$recipients = array_filter(User::all(), function (User $user) {
191 191
 			return $user->getPreference('sessiontime') > 0 && WT_TIMESTAMP - $user->getPreference('sessiontime') > 60 * 60 * 24 * 30 * 6;
192 192
 		});
193 193
 	} elseif ($to === 'never_logged') {
194
-		$recipients = array_filter(User::all(), function(User $user) {
194
+		$recipients = array_filter(User::all(), function (User $user) {
195 195
 			return $user->getPreference('verified_by_admin') && $user->getPreference('reg_timestamp') > $user->getPreference('sessiontime');
196 196
 		});
197 197
 	} else {
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -128,7 +128,8 @@  discard block
 block discarded – undo
128 128
 				<div class="form-control"><?= Filter::escapeHtml(Auth::user()->getRealName()) ?></div>
129 129
 			</div>
130 130
 		</div>
131
-	<?php else: ?>
131
+	<?php else {
132
+	: ?>
132 133
 		<div class="form-group row">
133 134
 			<label class="col-sm-3 col-form-label" for="from-name">
134 135
 				<?= I18N::translate('Your name') ?>
@@ -186,6 +187,7 @@  discard block
 block discarded – undo
186 187
 function recipients($to) {
187 188
 	if ($to === 'all') {
188 189
 		$recipients =	User::all();
190
+}
189 191
 	} elseif ($to === 'last_6mo') {
190 192
 		$recipients = array_filter(User::all(), function(User $user) {
191 193
 			return $user->getPreference('sessiontime') > 0 && WT_TIMESTAMP - $user->getPreference('sessiontime') > 60 * 60 * 24 * 30 * 6;
Please login to merge, or discard this patch.
app/Date/JewishDate.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -247,7 +247,7 @@
 block discarded – undo
247 247
 	/**
248 248
 	 * Which months follows this one? Calendars with leap-months should provide their own implementation.
249 249
 	 *
250
-	 * @return int[]
250
+	 * @return integer[]
251 251
 	 */
252 252
 	protected function nextMonth() {
253 253
 		if ($this->m == 6 && !$this->isLeapYear()) {
Please login to merge, or discard this patch.
app/Controller/RelationshipController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 	 * @param string $xref2
159 159
 	 * @param int    $tree_id
160 160
 	 *
161
-	 * @return array
161
+	 * @return string[]
162 162
 	 */
163 163
 	private function allAncestors($xref1, $xref2, $tree_id) {
164 164
 		$ancestors = [$xref1, $xref2];
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
 	 * @param string $xref2
198 198
 	 * @param int    $tree_id
199 199
 	 *
200
-	 * @return array
200
+	 * @return string[]
201 201
 	 */
202 202
 	private function excludeFamilies($xref1, $xref2, $tree_id) {
203 203
 		return Database::prepare(
Please login to merge, or discard this patch.