Completed
Pull Request — master (#1083)
by Jonathan
12:31
created
admin_module_menus.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -98,8 +98,11 @@
 block discarded – undo
98 98
 				<td class="col-xs-1">
99 99
 					<?php if ($module instanceof ModuleConfigInterface): ?>
100 100
 					<a href="<?php echo $module->getConfigLink(); ?>"><?php echo $module->getTitle(); ?> <i class="fa fa-cogs"></i></a>
101
-					<?php else: ?>
102
-					<?php echo $module->getTitle(); ?>
101
+					<?php else {
102
+	: ?>
103
+					<?php echo $module->getTitle();
104
+}
105
+?>
103 106
 					<?php endif; ?>
104 107
 				</td>
105 108
 				<td class="col-xs-5"><?php echo $module->getDescription(); ?></td>
Please login to merge, or discard this patch.
admin_module_sidebar.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -98,8 +98,11 @@
 block discarded – undo
98 98
 				<td class="col-xs-1">
99 99
 					<?php if ($module instanceof ModuleConfigInterface): ?>
100 100
 					<a href="<?php echo $module->getConfigLink(); ?>"><?php echo $module->getTitle(); ?> <i class="fa fa-cogs"></i></a>
101
-					<?php else: ?>
102
-					<?php echo $module->getTitle(); ?>
101
+					<?php else {
102
+	: ?>
103
+					<?php echo $module->getTitle();
104
+}
105
+?>
103 106
 					<?php endif; ?>
104 107
 				</td>
105 108
 				<td class="col-xs-5"><?php echo $module->getDescription(); ?></td>
Please login to merge, or discard this patch.
app/Date/JewishDate.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -247,7 +247,7 @@
 block discarded – undo
247 247
 	/**
248 248
 	 * Which months follows this one?  Calendars with leap-months should provide their own implementation.
249 249
 	 *
250
-	 * @return int[]
250
+	 * @return integer[]
251 251
 	 */
252 252
 	protected function nextMonth() {
253 253
 		if ($this->m == 6 && !$this->isLeapYear()) {
Please login to merge, or discard this patch.
app/Date/CalendarDate.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -247,7 +247,7 @@
 block discarded – undo
247 247
 	/**
248 248
 	 * Which months follows this one?  Calendars with leap-months should provide their own implementation.
249 249
 	 *
250
-	 * @return int[]
250
+	 * @return integer[]
251 251
 	 */
252 252
 	protected function nextMonth() {
253 253
 		if ($this->m == 6 && !$this->isLeapYear()) {
Please login to merge, or discard this patch.
admin_module_charts.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -74,8 +74,11 @@
 block discarded – undo
74 74
 				<td class="col-xs-2">
75 75
 					<?php if ($module instanceof ModuleConfigInterface): ?>
76 76
 						<a href="<?php echo $module->getConfigLink(); ?>"><?php echo $module->getTitle(); ?> <i class="fa fa-cogs"></i></a>
77
-					<?php else: ?>
78
-						<?php echo $module->getTitle(); ?>
77
+					<?php else {
78
+	: ?>
79
+						<?php echo $module->getTitle();
80
+}
81
+?>
79 82
 					<?php endif; ?>
80 83
 				</td>
81 84
 				<td class="col-xs-5"><?php echo $module->getDescription(); ?></td>
Please login to merge, or discard this patch.
admin.php 1 patch
Braces   +35 added lines, -14 removed lines patch added patch discarded remove patch
@@ -611,8 +611,11 @@  discard block
 block discarded – undo
611 611
 					<a href="admin_site_upgrade.php" class="error">
612 612
 						<?php echo /* I18N: %s is a version number */ I18N::translate('Upgrade to webtrees %s.', Filter::escapeHtml($latest_version)); ?>
613 613
 					</a>
614
-					<?php else: ?>
615
-						<?php echo I18N::translate('This is the latest version of webtrees. No upgrade is available.'); ?>
614
+					<?php else {
615
+	: ?>
616
+						<?php echo I18N::translate('This is the latest version of webtrees. No upgrade is available.');
617
+}
618
+?>
616 619
 					<?php endif; ?>
617 620
 				</p>
618 621
 				<?php endif; ?>
@@ -774,9 +777,12 @@  discard block
 block discarded – undo
774 777
 									<?php echo I18N::number($changes[$tree->getTreeId()]); ?>
775 778
 									<span class="sr-only"><?php echo I18N::translate('Pending changes'); ?> <?php echo $tree->getTitleHtml(); ?></span>
776 779
 								</a>
777
-								<?php else: ?>
780
+								<?php else {
781
+	: ?>
778 782
 								-
779
-								<?php endif; ?>
783
+								<?php endif;
784
+}
785
+?>
780 786
 							</td>
781 787
 							<td class="text-right flip">
782 788
 								<?php if ($individuals[$tree->getTreeId()]): ?>
@@ -784,9 +790,12 @@  discard block
 block discarded – undo
784 790
 									<?php echo I18N::number($individuals[$tree->getTreeId()]); ?>
785 791
 									<span class="sr-only"><?php echo I18N::translate('Individuals'); ?> <?php echo $tree->getTitleHtml(); ?></span>
786 792
 								</a>
787
-								<?php else: ?>
793
+								<?php else {
794
+	: ?>
788 795
 									-
789
-								<?php endif; ?>
796
+								<?php endif;
797
+}
798
+?>
790 799
 								</td>
791 800
 							<td class="text-right flip">
792 801
 								<?php if ($families[$tree->getTreeId()]): ?>
@@ -794,9 +803,12 @@  discard block
 block discarded – undo
794 803
 									<?php echo I18N::number($families[$tree->getTreeId()]); ?>
795 804
 									<span class="sr-only"><?php echo I18N::translate('Families'); ?> <?php echo $tree->getTitleHtml(); ?></span>
796 805
 								</a>
797
-								<?php else: ?>
806
+								<?php else {
807
+	: ?>
798 808
 								-
799
-								<?php endif; ?>
809
+								<?php endif;
810
+}
811
+?>
800 812
 								</td>
801 813
 							<td class="text-right flip">
802 814
 								<?php if ($sources[$tree->getTreeId()]): ?>
@@ -804,9 +816,12 @@  discard block
 block discarded – undo
804 816
 									<?php echo I18N::number($sources[$tree->getTreeId()]); ?>
805 817
 									<span class="sr-only"><?php echo I18N::translate('Sources'); ?> <?php echo $tree->getTitleHtml(); ?></span>
806 818
 								</a>
807
-								<?php else: ?>
819
+								<?php else {
820
+	: ?>
808 821
 								-
809
-								<?php endif; ?>
822
+								<?php endif;
823
+}
824
+?>
810 825
 							</td>
811 826
 							<td class="text-right flip">
812 827
 								<?php if ($repositories[$tree->getTreeId()]): ?>
@@ -814,9 +829,12 @@  discard block
 block discarded – undo
814 829
 									<?php echo I18N::number($repositories[$tree->getTreeId()]); ?>
815 830
 									<span class="sr-only"><?php echo I18N::translate('Repositories'); ?> <?php echo $tree->getTitleHtml(); ?></span>
816 831
 								</a>
817
-								<?php else: ?>
832
+								<?php else {
833
+	: ?>
818 834
 									-
819
-								<?php endif; ?>
835
+								<?php endif;
836
+}
837
+?>
820 838
 							</td>
821 839
 							<td class="text-right flip">
822 840
 								<?php if ($media[$tree->getTreeId()]): ?>
@@ -824,9 +842,12 @@  discard block
 block discarded – undo
824 842
 									<?php echo I18N::number($media[$tree->getTreeId()]); ?>
825 843
 									<span class="sr-only"><?php echo I18N::translate('Media objects'); ?> <?php echo $tree->getTitleHtml(); ?></span>
826 844
 								</a>
827
-								<?php else: ?>
845
+								<?php else {
846
+	: ?>
828 847
 								-
829
-								<?php endif; ?>
848
+								<?php endif;
849
+}
850
+?>
830 851
 							</td>
831 852
 						</tr>
832 853
 						<?php endforeach; ?>
Please login to merge, or discard this patch.
relationship.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -101,7 +101,8 @@  discard block
 block discarded – undo
101 101
 					<?php if ($max_recursion == 0): ?>
102 102
 						<?php echo I18N::translate('Find the closest relationships') ?>
103 103
 						<input type="hidden" name="recursion" value="0">
104
-					<?php else: ?>
104
+					<?php else {
105
+	: ?>
105 106
 						<label>
106 107
 							<input type="radio" name="recursion" value="0" <?php echo $recursion == 0 ? 'checked' : '' ?>>
107 108
 							<?php echo I18N::translate('Find the closest relationships') ?>
@@ -113,7 +114,9 @@  discard block
 block discarded – undo
113 114
 								<?php echo I18N::translate('Find all possible relationships') ?>
114 115
 							<?php else: ?>
115 116
 								<?php echo I18N::translate('Find other relationships') ?>
116
-							<?php endif; ?>
117
+							<?php endif;
118
+}
119
+?>
117 120
 						</label>
118 121
 					<?php endif; ?>
119 122
 				</td>
Please login to merge, or discard this patch.
admin_modules.php 1 patch
Braces   +40 added lines, -16 removed lines patch added patch discarded remove patch
@@ -176,9 +176,12 @@  discard block
 block discarded – undo
176 176
 							<a href="<?php echo $module->getConfigLink() ?>">
177 177
 								<?php echo $module->getTitle() ?> <i class="fa fa-cogs"></i>
178 178
 							</a>
179
-						<?php else: ?>
179
+						<?php else {
180
+	: ?>
180 181
 							<?php echo $module->getTitle() ?>
181
-						<?php endif; ?>
182
+						<?php endif;
183
+}
184
+?>
182 185
 						<?php if (!in_array($module->getName(), Module::getCoreModuleNames())): ?>
183 186
 							<br>
184 187
 						<?php endif; ?>
@@ -202,23 +205,32 @@  discard block
 block discarded – undo
202 205
 					<td class="text-center text-muted hidden-xs">
203 206
 						<?php if ($module instanceof ModuleMenuInterface): ?>
204 207
 							<i class="fa fa-list-ul" title="<?php echo I18N::translate('Menu') ?>"></i>
205
-						<?php else: ?>
208
+						<?php else {
209
+	: ?>
206 210
 							-
207
-						<?php endif; ?>
211
+						<?php endif;
212
+}
213
+?>
208 214
 					</td>
209 215
 					<td class="text-center text-muted hidden-xs">
210 216
 						<?php if ($module instanceof ModuleTabInterface): ?>
211 217
 							<i class="fa fa-folder" title="<?php echo I18N::translate('Tab') ?>"></i>
212
-						<?php else: ?>
218
+						<?php else {
219
+	: ?>
213 220
 							-
214
-						<?php endif; ?>
221
+						<?php endif;
222
+}
223
+?>
215 224
 					</td>
216 225
 					<td class="text-center text-muted hidden-xs">
217 226
 						<?php if ($module instanceof ModuleSidebarInterface): ?>
218 227
 							<i class="fa fa-th-large" title="<?php echo I18N::translate('Sidebar') ?>"></i>
219
-						<?php else: ?>
228
+						<?php else {
229
+	: ?>
220 230
 							-
221
-						<?php endif; ?>
231
+						<?php endif;
232
+}
233
+?>
222 234
 					</td>
223 235
 					<td class="text-center text-muted hidden-xs">
224 236
 						<?php if ($module instanceof ModuleBlockInterface): ?>
@@ -228,30 +240,42 @@  discard block
 block discarded – undo
228 240
 							<?php if ($module->isUserBlock()): ?>
229 241
 								<i class="fa fa-tree" title="<?php echo I18N::translate('Home page') ?>"></i>
230 242
 							<?php endif; ?>
231
-						<?php else: ?>
243
+						<?php else {
244
+	: ?>
232 245
 							-
233
-						<?php endif; ?>
246
+						<?php endif;
247
+}
248
+?>
234 249
 					</td>
235 250
 					<td class="text-center text-muted hidden-xs">
236 251
 						<?php if ($module instanceof ModuleChartInterface): ?>
237 252
 							<i class="fa fa-share-alt" title="<?php echo I18N::translate('Chart') ?>"></i>
238
-						<?php else: ?>
253
+						<?php else {
254
+	: ?>
239 255
 							-
240
-						<?php endif; ?>
256
+						<?php endif;
257
+}
258
+?>
241 259
 					</td>
242 260
 					<td class="text-center text-muted hidden-xs">
243 261
 						<?php if ($module instanceof ModuleReportInterface): ?>
244 262
 							<i class="fa fa-file" title="<?php echo I18N::translate('Report') ?>"></i>
245
-						<?php else: ?>
263
+						<?php else {
264
+	: ?>
246 265
 							-
247
-						<?php endif; ?>
266
+						<?php endif;
267
+}
268
+?>
248 269
 					</td>
249 270
 					<td class="text-center text-muted hidden">
250 271
 						<?php if ($module instanceof ModuleThemeInterface): ?>
251 272
 							<i class="fa fa-check" title="<?php echo I18N::translate('Theme') ?>"></i>
252
-						<?php else: ?>
273
+						<?php else {
274
+	: ?>
253 275
 							-
254
-						<?php endif; ?>
276
+						<?php endif;
277
+}
278
+?>
255 279
 					</td>
256 280
 				</tr>
257 281
 			<?php endforeach; ?>
Please login to merge, or discard this patch.
app/Functions/FunctionsDb.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -647,7 +647,7 @@  discard block
 block discarded – undo
647 647
 	 * @param int $min The number of times a surname must occur before it is added to the array
648 648
 	 * @param Tree $tree
649 649
 	 *
650
-	 * @return int[]
650
+	 * @return string[]
651 651
 	 */
652 652
 	public static function getCommonSurnames($min, Tree $tree) {
653 653
 		return self::getTopSurnames($tree->getTreeId(), $min, 0);
@@ -660,7 +660,7 @@  discard block
 block discarded – undo
660 660
 	 * @param int $min only fetch surnames occuring this many times
661 661
 	 * @param int $max only fetch this number of surnames (0=all)
662 662
 	 *
663
-	 * @return int[]
663
+	 * @return string[]
664 664
 	 */
665 665
 	public static function getTopSurnames($ged_id, $min, $max) {
666 666
 		// Use n_surn, rather than n_surname, as it is used to generate URLs for
Please login to merge, or discard this patch.