| Conditions | 15 |
| Paths | 15 |
| Total Lines | 98 |
| Code Lines | 76 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 173 | public function handle(ServerRequestInterface $request): ResponseInterface |
||
| 174 | { |
||
| 175 | $topic = $request->getAttribute('topic'); |
||
| 176 | |||
| 177 | switch ($topic) { |
||
| 178 | case 'DATE': |
||
| 179 | switch ($this->dmyOrder()) { |
||
| 180 | case 'YMD': |
||
| 181 | $date_shortcuts = array_merge(self::DATE_SHORTCUTS, self::YMD_SHORTCUTS); |
||
| 182 | break; |
||
| 183 | case 'MDY': |
||
| 184 | $date_shortcuts = array_merge(self::DATE_SHORTCUTS, self::MDY_SHORTCUTS); |
||
| 185 | break; |
||
| 186 | case 'DMY': |
||
| 187 | default: |
||
| 188 | $date_shortcuts = array_merge(self::DATE_SHORTCUTS, self::DMY_SHORTCUTS); |
||
| 189 | break; |
||
| 190 | } |
||
| 191 | |||
| 192 | $title = I18N::translate('Date'); |
||
| 193 | $text = view('help/date', [ |
||
| 194 | 'date_dates' => $this->formatDates(array_keys($date_shortcuts)), |
||
| 195 | 'date_shortcuts' => $date_shortcuts, |
||
| 196 | 'date_period_dates' => $this->formatDates(array_keys(self::DATE_PERIOD_SHORTCUTS)), |
||
| 197 | 'date_period_shortcuts' => self::DATE_PERIOD_SHORTCUTS, |
||
| 198 | 'date_range_dates' => $this->formatDates(array_keys(self::DATE_RANGE_SHORTCUTS)), |
||
| 199 | 'date_range_shortcuts' => self::DATE_RANGE_SHORTCUTS, |
||
| 200 | 'french_dates' => $this->formatDates(self::FRENCH_DATES), |
||
| 201 | 'hijri_dates' => $this->formatDates(self::HIJRI_DATES), |
||
| 202 | 'jewish_dates' => $this->formatDates(self::JEWISH_DATES), |
||
| 203 | 'julian_dates' => $this->formatDates(self::JULIAN_DATES), |
||
| 204 | ]); |
||
| 205 | break; |
||
| 206 | |||
| 207 | case 'NAME': |
||
| 208 | $title = I18N::translate('Name'); |
||
| 209 | $text = view('help/name'); |
||
| 210 | break; |
||
| 211 | |||
| 212 | case 'SURN': |
||
| 213 | $title = I18N::translate('Surname'); |
||
| 214 | $text = view('help/surname'); |
||
| 215 | break; |
||
| 216 | |||
| 217 | case 'OBJE': |
||
| 218 | $title = I18N::translate('Media object'); |
||
| 219 | $text = view('help/media-object'); |
||
| 220 | break; |
||
| 221 | |||
| 222 | case 'PLAC': |
||
| 223 | $title = I18N::translate('Place'); |
||
| 224 | $text = view('help/place'); |
||
| 225 | break; |
||
| 226 | |||
| 227 | case 'RESN': |
||
| 228 | $title = I18N::translate('Restriction'); |
||
| 229 | $text = view('help/restriction'); |
||
| 230 | break; |
||
| 231 | |||
| 232 | case 'ROMN': |
||
| 233 | $title = I18N::translate('Romanized'); |
||
| 234 | $text = view('help/romanized'); |
||
| 235 | break; |
||
| 236 | |||
| 237 | case '_HEB': |
||
| 238 | $title = I18N::translate('Hebrew'); |
||
| 239 | $text = view('help/hebrew'); |
||
| 240 | break; |
||
| 241 | |||
| 242 | case 'edit_SOUR_EVEN': |
||
| 243 | $title = I18N::translate('Associate events with this source'); |
||
| 244 | $text = view('help/source-events'); |
||
| 245 | break; |
||
| 246 | |||
| 247 | case 'pending_changes': |
||
| 248 | $title = I18N::translate('Pending changes'); |
||
| 249 | $text = view('help/pending-changes', [ |
||
| 250 | 'is_admin' => Auth::isAdmin(), |
||
| 251 | ]); |
||
| 252 | break; |
||
| 253 | |||
| 254 | case 'relationship-privacy': |
||
| 255 | $title = I18N::translate('Restrict to immediate family'); |
||
| 256 | $text = view('help/relationship-privacy'); |
||
| 257 | break; |
||
| 258 | |||
| 259 | default: |
||
| 260 | $title = I18N::translate('Help'); |
||
| 261 | $text = I18N::translate('The help text has not been written for this item.'); |
||
| 262 | break; |
||
| 263 | } |
||
| 264 | |||
| 265 | $html = view('modals/help', [ |
||
| 266 | 'title' => $title, |
||
| 267 | 'text' => $text, |
||
| 268 | ]); |
||
| 269 | |||
| 270 | return response($html); |
||
| 271 | } |
||
| 305 |