Conditions | 93 |
Paths | > 20000 |
Total Lines | 388 |
Code Lines | 314 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
261 | private function advancedSearch() { |
||
262 | $this->myindilist = []; |
||
263 | $fct = count($this->fields); |
||
264 | if (!array_filter($this->values)) { |
||
265 | return; |
||
266 | } |
||
267 | |||
268 | // Dynamic SQL query, plus bind variables |
||
269 | $sql = 'SELECT DISTINCT ind.i_id AS xref, ind.i_gedcom AS gedcom FROM `##individuals` ind'; |
||
270 | $bind = []; |
||
271 | |||
272 | // Join the following tables |
||
273 | $father_name = false; |
||
274 | $mother_name = false; |
||
275 | $spouse_family = false; |
||
276 | $indi_name = false; |
||
277 | $indi_date = false; |
||
278 | $fam_date = false; |
||
279 | $indi_plac = false; |
||
280 | $fam_plac = false; |
||
281 | foreach ($this->fields as $n => $field) { |
||
282 | if ($this->values[$n]) { |
||
283 | if (substr($field, 0, 14) == 'FAMC:HUSB:NAME') { |
||
284 | $father_name = true; |
||
285 | } elseif (substr($field, 0, 14) == 'FAMC:WIFE:NAME') { |
||
286 | $mother_name = true; |
||
287 | } elseif (substr($field, 0, 4) == 'NAME') { |
||
288 | $indi_name = true; |
||
289 | } elseif (strpos($field, ':DATE') !== false) { |
||
290 | if (substr($field, 0, 4) == 'FAMS') { |
||
291 | $fam_date = true; |
||
292 | $spouse_family = true; |
||
293 | } else { |
||
294 | $indi_date = true; |
||
295 | } |
||
296 | } elseif (strpos($field, ':PLAC') !== false) { |
||
297 | if (substr($field, 0, 4) == 'FAMS') { |
||
298 | $fam_plac = true; |
||
299 | $spouse_family = true; |
||
300 | } else { |
||
301 | $indi_plac = true; |
||
302 | } |
||
303 | } elseif ($field == 'FAMS:NOTE') { |
||
304 | $spouse_family = true; |
||
305 | } |
||
306 | } |
||
307 | } |
||
308 | |||
309 | if ($father_name || $mother_name) { |
||
310 | $sql .= " JOIN `##link` l_1 ON (l_1.l_file=ind.i_file AND l_1.l_from=ind.i_id AND l_1.l_type='FAMC')"; |
||
311 | } |
||
312 | if ($father_name) { |
||
313 | $sql .= " JOIN `##link` l_2 ON (l_2.l_file=ind.i_file AND l_2.l_from=l_1.l_to AND l_2.l_type='HUSB')"; |
||
314 | $sql .= " JOIN `##name` f_n ON (f_n.n_file=ind.i_file AND f_n.n_id =l_2.l_to)"; |
||
315 | } |
||
316 | if ($mother_name) { |
||
317 | $sql .= " JOIN `##link` l_3 ON (l_3.l_file=ind.i_file AND l_3.l_from=l_1.l_to AND l_3.l_type='WIFE')"; |
||
318 | $sql .= " JOIN `##name` m_n ON (m_n.n_file=ind.i_file AND m_n.n_id =l_3.l_to)"; |
||
319 | } |
||
320 | if ($spouse_family) { |
||
321 | $sql .= " JOIN `##link` l_4 ON (l_4.l_file=ind.i_file AND l_4.l_from=ind.i_id AND l_4.l_type='FAMS')"; |
||
322 | $sql .= " JOIN `##families` fam ON (fam.f_file=ind.i_file AND fam.f_id =l_4.l_to)"; |
||
323 | } |
||
324 | if ($indi_name) { |
||
325 | $sql .= " JOIN `##name` i_n ON (i_n.n_file=ind.i_file AND i_n.n_id=ind.i_id)"; |
||
326 | } |
||
327 | if ($indi_date) { |
||
328 | $sql .= " JOIN `##dates` i_d ON (i_d.d_file=ind.i_file AND i_d.d_gid=ind.i_id)"; |
||
329 | } |
||
330 | if ($fam_date) { |
||
331 | $sql .= " JOIN `##dates` f_d ON (f_d.d_file=ind.i_file AND f_d.d_gid=fam.f_id)"; |
||
332 | } |
||
333 | if ($indi_plac) { |
||
334 | $sql .= " JOIN `##placelinks` i_pl ON (i_pl.pl_file=ind.i_file AND i_pl.pl_gid =ind.i_id)"; |
||
335 | $sql .= " JOIN (" . |
||
336 | "SELECT CONCAT_WS(', ', p1.p_place, p2.p_place, p3.p_place, p4.p_place, p5.p_place, p6.p_place, p7.p_place, p8.p_place, p9.p_place) AS place, p1.p_id AS id, p1.p_file AS file" . |
||
337 | " FROM `##places` AS p1" . |
||
338 | " LEFT JOIN `##places` AS p2 ON (p1.p_parent_id=p2.p_id)" . |
||
339 | " LEFT JOIN `##places` AS p3 ON (p2.p_parent_id=p3.p_id)" . |
||
340 | " LEFT JOIN `##places` AS p4 ON (p3.p_parent_id=p4.p_id)" . |
||
341 | " LEFT JOIN `##places` AS p5 ON (p4.p_parent_id=p5.p_id)" . |
||
342 | " LEFT JOIN `##places` AS p6 ON (p5.p_parent_id=p6.p_id)" . |
||
343 | " LEFT JOIN `##places` AS p7 ON (p6.p_parent_id=p7.p_id)" . |
||
344 | " LEFT JOIN `##places` AS p8 ON (p7.p_parent_id=p8.p_id)" . |
||
345 | " LEFT JOIN `##places` AS p9 ON (p8.p_parent_id=p9.p_id)" . |
||
346 | ") AS i_p ON (i_p.file =ind.i_file AND i_pl.pl_p_id= i_p.id)"; |
||
347 | } |
||
348 | if ($fam_plac) { |
||
349 | $sql .= " JOIN `##placelinks` f_pl ON (f_pl.pl_file=ind.i_file AND f_pl.pl_gid =fam.f_id)"; |
||
350 | $sql .= " JOIN (" . |
||
351 | "SELECT CONCAT_WS(', ', p1.p_place, p2.p_place, p3.p_place, p4.p_place, p5.p_place, p6.p_place, p7.p_place, p8.p_place, p9.p_place) AS place, p1.p_id AS id, p1.p_file AS file" . |
||
352 | " FROM `##places` AS p1" . |
||
353 | " LEFT JOIN `##places` AS p2 ON (p1.p_parent_id=p2.p_id)" . |
||
354 | " LEFT JOIN `##places` AS p3 ON (p2.p_parent_id=p3.p_id)" . |
||
355 | " LEFT JOIN `##places` AS p4 ON (p3.p_parent_id=p4.p_id)" . |
||
356 | " LEFT JOIN `##places` AS p5 ON (p4.p_parent_id=p5.p_id)" . |
||
357 | " LEFT JOIN `##places` AS p6 ON (p5.p_parent_id=p6.p_id)" . |
||
358 | " LEFT JOIN `##places` AS p7 ON (p6.p_parent_id=p7.p_id)" . |
||
359 | " LEFT JOIN `##places` AS p8 ON (p7.p_parent_id=p8.p_id)" . |
||
360 | " LEFT JOIN `##places` AS p9 ON (p8.p_parent_id=p9.p_id)" . |
||
361 | ") AS f_p ON (f_p.file =ind.i_file AND f_pl.pl_p_id= f_p.id)"; |
||
362 | } |
||
363 | // Add the where clause |
||
364 | $sql .= " WHERE ind.i_file=?"; |
||
365 | $bind[] = $this->tree()->getTreeId(); |
||
366 | for ($i = 0; $i < $fct; $i++) { |
||
367 | $field = $this->fields[$i]; |
||
368 | $value = $this->values[$i]; |
||
369 | if ($value === '') { |
||
370 | continue; |
||
371 | } |
||
372 | $parts = preg_split('/:/', $field . '::::'); |
||
373 | if ($parts[0] == 'NAME') { |
||
374 | // NAME:* |
||
375 | switch ($parts[1]) { |
||
376 | case 'GIVN': |
||
377 | switch ($parts[2]) { |
||
378 | case 'EXACT': |
||
379 | $sql .= " AND i_n.n_givn=?"; |
||
380 | $bind[] = $value; |
||
381 | break; |
||
382 | case 'BEGINS': |
||
383 | $sql .= " AND i_n.n_givn LIKE CONCAT(?, '%')"; |
||
384 | $bind[] = $value; |
||
385 | break; |
||
386 | case 'CONTAINS': |
||
387 | $sql .= " AND i_n.n_givn LIKE CONCAT('%', ?, '%')"; |
||
388 | $bind[] = $value; |
||
389 | break; |
||
390 | case 'SDX_STD': |
||
391 | $sdx = Soundex::russell($value); |
||
392 | if ($sdx !== null) { |
||
|
|||
393 | $sdx = explode(':', $sdx); |
||
394 | foreach ($sdx as $k => $v) { |
||
395 | $sdx[$k] = "i_n.n_soundex_givn_std LIKE CONCAT('%', ?, '%')"; |
||
396 | $bind[] = $v; |
||
397 | } |
||
398 | $sql .= ' AND (' . implode(' OR ', $sdx) . ')'; |
||
399 | } else { |
||
400 | // No phonetic content? Use a substring match |
||
401 | $sql .= " AND i_n.n_givn LIKE CONCAT('%', ?, '%')"; |
||
402 | $bind[] = $value; |
||
403 | } |
||
404 | break; |
||
405 | case 'SDX': // SDX uses DM by default. |
||
406 | case 'SDX_DM': |
||
407 | $sdx = Soundex::daitchMokotoff($value); |
||
408 | if ($sdx !== null) { |
||
409 | $sdx = explode(':', $sdx); |
||
410 | foreach ($sdx as $k => $v) { |
||
411 | $sdx[$k] = "i_n.n_soundex_givn_dm LIKE CONCAT('%', ?, '%')"; |
||
412 | $bind[] = $v; |
||
413 | } |
||
414 | $sql .= ' AND (' . implode(' OR ', $sdx) . ')'; |
||
415 | } else { |
||
416 | // No phonetic content? Use a substring match |
||
417 | $sql .= " AND i_n.n_givn LIKE CONCAT('%', ?, '%')"; |
||
418 | $bind[] = $value; |
||
419 | } |
||
420 | break; |
||
421 | } |
||
422 | break; |
||
423 | case 'SURN': |
||
424 | switch ($parts[2]) { |
||
425 | case 'EXACT': |
||
426 | $sql .= " AND i_n.n_surname=?"; |
||
427 | $bind[] = $value; |
||
428 | break; |
||
429 | case 'BEGINS': |
||
430 | $sql .= " AND i_n.n_surname LIKE CONCAT(?, '%')"; |
||
431 | $bind[] = $value; |
||
432 | break; |
||
433 | case 'CONTAINS': |
||
434 | $sql .= " AND i_n.n_surname LIKE CONCAT('%', ?, '%')"; |
||
435 | $bind[] = $value; |
||
436 | break; |
||
437 | case 'SDX_STD': |
||
438 | $sdx = Soundex::russell($value); |
||
439 | if ($sdx !== null) { |
||
440 | $sdx = explode(':', $sdx); |
||
441 | foreach ($sdx as $k => $v) { |
||
442 | $sdx[$k] = "i_n.n_soundex_surn_std LIKE CONCAT('%', ?, '%')"; |
||
443 | $bind[] = $v; |
||
444 | } |
||
445 | $sql .= " AND (" . implode(' OR ', $sdx) . ")"; |
||
446 | } else { |
||
447 | // No phonetic content? Use a substring match |
||
448 | $sql .= " AND i_n.n_surn LIKE CONCAT('%', ?, '%')"; |
||
449 | $bind[] = $value; |
||
450 | } |
||
451 | break; |
||
452 | case 'SDX': // SDX uses DM by default. |
||
453 | case 'SDX_DM': |
||
454 | $sdx = Soundex::daitchMokotoff($value); |
||
455 | if ($sdx !== null) { |
||
456 | $sdx = explode(':', $sdx); |
||
457 | foreach ($sdx as $k => $v) { |
||
458 | $sdx[$k] = "i_n.n_soundex_surn_dm LIKE CONCAT('%', ?, '%')"; |
||
459 | $bind[] = $v; |
||
460 | } |
||
461 | $sql .= " AND (" . implode(' OR ', $sdx) . ")"; |
||
462 | break; |
||
463 | } else { |
||
464 | // No phonetic content? Use a substring match |
||
465 | $sql .= " AND i_n.n_surn LIKE CONCAT('%', ?, '%')"; |
||
466 | $bind[] = $value; |
||
467 | } |
||
468 | } |
||
469 | break; |
||
470 | case 'NICK': |
||
471 | case '_MARNM': |
||
472 | case '_HEB': |
||
473 | case '_AKA': |
||
474 | $sql .= " AND i_n.n_type=? AND i_n.n_full LIKE CONCAT('%', ?, '%')"; |
||
475 | $bind[] = $parts[1]; |
||
476 | $bind[] = $value; |
||
477 | break; |
||
478 | } |
||
479 | } elseif ($parts[1] == 'DATE') { |
||
480 | // *:DATE |
||
481 | $date = new Date($value); |
||
482 | if ($date->isOK()) { |
||
483 | $jd1 = $date->minimumJulianDay(); |
||
484 | $jd2 = $date->maximumJulianDay(); |
||
485 | if (!empty($this->plusminus[$i])) { |
||
486 | $adjd = $this->plusminus[$i] * 365; |
||
487 | $jd1 -= $adjd; |
||
488 | $jd2 += $adjd; |
||
489 | } |
||
490 | $sql .= " AND i_d.d_fact=? AND i_d.d_julianday1>=? AND i_d.d_julianday2<=?"; |
||
491 | $bind[] = $parts[0]; |
||
492 | $bind[] = $jd1; |
||
493 | $bind[] = $jd2; |
||
494 | } |
||
495 | } elseif ($parts[0] == 'FAMS' && $parts[2] == 'DATE') { |
||
496 | // FAMS:*:DATE |
||
497 | $date = new Date($value); |
||
498 | if ($date->isOK()) { |
||
499 | $jd1 = $date->minimumJulianDay(); |
||
500 | $jd2 = $date->maximumJulianDay(); |
||
501 | if (!empty($this->plusminus[$i])) { |
||
502 | $adjd = $this->plusminus[$i] * 365; |
||
503 | $jd1 -= $adjd; |
||
504 | $jd2 += $adjd; |
||
505 | } |
||
506 | $sql .= " AND f_d.d_fact=? AND f_d.d_julianday1>=? AND f_d.d_julianday2<=?"; |
||
507 | $bind[] = $parts[1]; |
||
508 | $bind[] = $jd1; |
||
509 | $bind[] = $jd2; |
||
510 | } |
||
511 | } elseif ($parts[1] == 'PLAC') { |
||
512 | // *:PLAC |
||
513 | // SQL can only link a place to a person/family, not to an event. |
||
514 | $sql .= " AND i_p.place LIKE CONCAT('%', ?, '%')"; |
||
515 | $bind[] = $value; |
||
516 | } elseif ($parts[0] == 'FAMS' && $parts[2] == 'PLAC') { |
||
517 | // FAMS:*:PLAC |
||
518 | // SQL can only link a place to a person/family, not to an event. |
||
519 | $sql .= " AND f_p.place LIKE CONCAT('%', ?, '%')"; |
||
520 | $bind[] = $value; |
||
521 | } elseif ($parts[0] == 'FAMC' && $parts[2] == 'NAME') { |
||
522 | $table = $parts[1] == 'HUSB' ? 'f_n' : 'm_n'; |
||
523 | // NAME:* |
||
524 | switch ($parts[3]) { |
||
525 | case 'GIVN': |
||
526 | switch ($parts[4]) { |
||
527 | case 'EXACT': |
||
528 | $sql .= " AND {$table}.n_givn=?"; |
||
529 | $bind[] = $value; |
||
530 | break; |
||
531 | case 'BEGINS': |
||
532 | $sql .= " AND {$table}.n_givn LIKE CONCAT(?, '%')"; |
||
533 | $bind[] = $value; |
||
534 | break; |
||
535 | case 'CONTAINS': |
||
536 | $sql .= " AND {$table}.n_givn LIKE CONCAT('%', ?, '%')"; |
||
537 | $bind[] = $value; |
||
538 | break; |
||
539 | case 'SDX_STD': |
||
540 | $sdx = Soundex::russell($value); |
||
541 | if ($sdx !== null) { |
||
542 | $sdx = explode(':', $sdx); |
||
543 | foreach ($sdx as $k => $v) { |
||
544 | $sdx[$k] = "{$table}.n_soundex_givn_std LIKE CONCAT('%', ?, '%')"; |
||
545 | $bind[] = $v; |
||
546 | } |
||
547 | $sql .= ' AND (' . implode(' OR ', $sdx) . ')'; |
||
548 | } else { |
||
549 | // No phonetic content? Use a substring match |
||
550 | $sql .= " AND {$table}.n_givn = LIKE CONCAT('%', ?, '%')"; |
||
551 | $bind[] = $value; |
||
552 | } |
||
553 | break; |
||
554 | case 'SDX': // SDX uses DM by default. |
||
555 | case 'SDX_DM': |
||
556 | $sdx = Soundex::daitchMokotoff($value); |
||
557 | if ($sdx !== null) { |
||
558 | $sdx = explode(':', $sdx); |
||
559 | foreach ($sdx as $k => $v) { |
||
560 | $sdx[$k] = "{$table}.n_soundex_givn_dm LIKE CONCAT('%', ?, '%')"; |
||
561 | $bind[] = $v; |
||
562 | } |
||
563 | $sql .= ' AND (' . implode(' OR ', $sdx) . ')'; |
||
564 | break; |
||
565 | } else { |
||
566 | // No phonetic content? Use a substring match |
||
567 | $sql .= " AND {$table}.n_givn = LIKE CONCAT('%', ?, '%')"; |
||
568 | $bind[] = $value; |
||
569 | } |
||
570 | } |
||
571 | break; |
||
572 | case 'SURN': |
||
573 | switch ($parts[4]) { |
||
574 | case 'EXACT': |
||
575 | $sql .= " AND {$table}.n_surname=?"; |
||
576 | $bind[] = $value; |
||
577 | break; |
||
578 | case 'BEGINS': |
||
579 | $sql .= " AND {$table}.n_surname LIKE CONCAT(?, '%')"; |
||
580 | $bind[] = $value; |
||
581 | break; |
||
582 | case 'CONTAINS': |
||
583 | $sql .= " AND {$table}.n_surname LIKE CONCAT('%', ?, '%')"; |
||
584 | $bind[] = $value; |
||
585 | break; |
||
586 | case 'SDX_STD': |
||
587 | $sdx = Soundex::russell($value); |
||
588 | if ($sdx !== null) { |
||
589 | $sdx = explode(':', $sdx); |
||
590 | foreach ($sdx as $k => $v) { |
||
591 | $sdx[$k] = "{$table}.n_soundex_surn_std LIKE CONCAT('%', ?, '%')"; |
||
592 | $bind[] = $v; |
||
593 | } |
||
594 | $sql .= ' AND (' . implode(' OR ', $sdx) . ')'; |
||
595 | } else { |
||
596 | // No phonetic content? Use a substring match |
||
597 | $sql .= " AND {$table}.n_surn = LIKE CONCAT('%', ?, '%')"; |
||
598 | $bind[] = $value; |
||
599 | } |
||
600 | break; |
||
601 | case 'SDX': // SDX uses DM by default. |
||
602 | case 'SDX_DM': |
||
603 | $sdx = Soundex::daitchMokotoff($value); |
||
604 | if ($sdx !== null) { |
||
605 | $sdx = explode(':', $sdx); |
||
606 | foreach ($sdx as $k => $v) { |
||
607 | $sdx[$k] = "{$table}.n_soundex_surn_dm LIKE CONCAT('%', ?, '%')"; |
||
608 | $bind[] = $v; |
||
609 | } |
||
610 | $sql .= ' AND (' . implode(' OR ', $sdx) . ')'; |
||
611 | } else { |
||
612 | // No phonetic content? Use a substring match |
||
613 | $sql .= " AND {$table}.n_surn = LIKE CONCAT('%', ?, '%')"; |
||
614 | $bind[] = $value; |
||
615 | } |
||
616 | break; |
||
617 | } |
||
618 | break; |
||
619 | } |
||
620 | } elseif ($parts[0] === 'FAMS') { |
||
621 | // e.g. searches for occupation, religion, note, etc. |
||
622 | $sql .= " AND fam.f_gedcom REGEXP CONCAT('\n[0-9] ', ?, '(.*\n[0-9] CONT)* [^\n]*', ?)"; |
||
623 | $bind[] = $parts[1]; |
||
624 | $bind[] = $value; |
||
625 | } elseif ($parts[1] === 'TYPE') { |
||
626 | // e.g. FACT:TYPE or EVEN:TYPE |
||
627 | $sql .= " AND ind.i_gedcom REGEXP CONCAT('\n1 ', ?, '.*(\n[2-9] .*)*\n2 TYPE .*', ?)"; |
||
628 | $bind[] = $parts[0]; |
||
629 | $bind[] = $value; |
||
630 | } else { |
||
631 | // e.g. searches for occupation, religion, note, etc. |
||
632 | $sql .= " AND ind.i_gedcom REGEXP CONCAT('\n[0-9] ', ?, '(.*\n[0-9] CONT)* [^\n]*', ?)"; |
||
633 | $bind[] = $parts[0]; |
||
634 | $bind[] = $value; |
||
635 | } |
||
636 | } |
||
637 | $rows = Database::prepare($sql)->execute($bind)->fetchAll(); |
||
638 | foreach ($rows as $row) { |
||
639 | $person = Individual::getInstance($row->xref, $this->tree(), $row->gedcom); |
||
640 | // Check for XXXX:PLAC fields, which were only partially matched by SQL |
||
641 | foreach ($this->fields as $n => $field) { |
||
642 | if ($this->values[$n] && preg_match('/^(' . WT_REGEX_TAG . '):PLAC$/', $field, $match)) { |
||
643 | if (!preg_match('/\n1 ' . $match[1] . '(\n[2-9].*)*\n2 PLAC .*' . preg_quote($this->values[$n], '/') . '/i', $person->getGedcom())) { |
||
644 | continue 2; |
||
645 | } |
||
646 | } |
||
647 | } |
||
648 | $this->myindilist[] = $person; |
||
649 | } |
||
664 |