fisharebest /
webtrees
| Conditions | 7 |
| Paths | 1 |
| Total Lines | 75 |
| Code Lines | 55 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 73 | public function handle(ServerRequestInterface $request): ResponseInterface |
||
| 74 | { |
||
| 75 | $ignore_facts = [ |
||
| 76 | 'NAME', |
||
| 77 | 'SEX', |
||
| 78 | 'CHAN', |
||
| 79 | 'NOTE', |
||
| 80 | 'SOUR', |
||
| 81 | 'RESN', |
||
| 82 | ]; |
||
| 83 | |||
| 84 | $prefix = DB::connection()->getTablePrefix(); |
||
| 85 | |||
| 86 | $query = DB::table('media') |
||
| 87 | ->join('media_file', static function (JoinClause $join): void { |
||
| 88 | $join |
||
| 89 | ->on('media_file.m_file', '=', 'media.m_file') |
||
| 90 | ->on('media_file.m_id', '=', 'media.m_id'); |
||
| 91 | }) |
||
| 92 | ->join('link', static function (JoinClause $join): void { |
||
| 93 | $join |
||
| 94 | ->on('link.l_file', '=', 'media.m_file') |
||
| 95 | ->on('link.l_to', '=', 'media.m_id') |
||
| 96 | ->where('link.l_type', '=', 'OBJE'); |
||
| 97 | }) |
||
| 98 | ->join('individuals', static function (JoinClause $join): void { |
||
| 99 | $join |
||
| 100 | ->on('individuals.i_file', '=', 'link.l_file') |
||
| 101 | ->on('individuals.i_id', '=', 'link.l_from'); |
||
| 102 | }) |
||
| 103 | ->where('i_gedcom', 'LIKE', new Expression("('%\n1 OBJE @' || " . $prefix . "media.m_id || '@%')")) |
||
| 104 | ->orderBy('individuals.i_file') |
||
| 105 | ->orderBy('individuals.i_id') |
||
| 106 | ->orderBy('media.m_id') |
||
| 107 | ->where('descriptive_title', 'LIKE', '%' . addcslashes($request->getQueryParams()['search']['value'] ?? '', '\\%_') . '%') |
||
| 108 | ->select(['media.m_file', 'media.m_id', 'media.m_gedcom', 'individuals.i_id', 'individuals.i_gedcom']); |
||
| 109 | |||
| 110 | return $this->datatables_service->handleQuery($request, $query, [], [], function (stdClass $datum) use ($ignore_facts): array { |
||
| 111 | $tree = $this->tree_service->find((int) $datum->m_file); |
||
| 112 | $media = Registry::mediaFactory()->make($datum->m_id, $tree, $datum->m_gedcom); |
||
| 113 | $individual = Registry::individualFactory()->make($datum->i_id, $tree, $datum->i_gedcom); |
||
| 114 | |||
| 115 | $facts = $individual->facts([], true) |
||
| 116 | ->filter(static function (Fact $fact) use ($ignore_facts): bool { |
||
| 117 | return |
||
| 118 | !$fact->isPendingDeletion() && |
||
| 119 | !preg_match('/^@' . Gedcom::REGEX_XREF . '@$/', $fact->value()) && |
||
| 120 | !in_array($fact->getTag(), $ignore_facts, true); |
||
|
|
|||
| 121 | }); |
||
| 122 | |||
| 123 | // The link to the media object may have been deleted in a pending change. |
||
| 124 | $deleted = true; |
||
| 125 | foreach ($individual->facts(['OBJE']) as $fact) { |
||
| 126 | if ($fact->target() === $media && !$fact->isPendingDeletion()) { |
||
| 127 | $deleted = false; |
||
| 128 | } |
||
| 129 | } |
||
| 130 | if ($deleted) { |
||
| 131 | $facts = new Collection(); |
||
| 132 | } |
||
| 133 | |||
| 134 | $facts = $facts->map(static function (Fact $fact) use ($individual, $media): string { |
||
| 135 | return view('admin/fix-level-0-media-action', [ |
||
| 136 | 'fact' => $fact, |
||
| 137 | 'individual' => $individual, |
||
| 138 | 'media' => $media, |
||
| 139 | ]); |
||
| 140 | }); |
||
| 141 | |||
| 142 | return [ |
||
| 143 | $tree->name(), |
||
| 144 | $media->displayImage(100, 100, 'contain', ['class' => 'img-thumbnail']), |
||
| 145 | '<a href="' . e($media->url()) . '">' . $media->fullName() . '</a>', |
||
| 146 | '<a href="' . e($individual->url()) . '">' . $individual->fullName() . '</a>', |
||
| 147 | $facts->implode(' '), |
||
| 148 | ]; |
||
| 152 |
This function has been deprecated. The supplier of the function has supplied an explanatory message.
The explanatory message should give you some clue as to whether and when the function will be removed and what other function to use instead.