CreateMediaObjectAction::handle() - Code Metrics - Inspection of "Refactor controllers as request handlers" - fisharebest/webtrees - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 852ede...d4265d )

by Greg

created 2019-10-31 23:00 UTC

CreateMediaObjectAction::handle() A

↳ Parent: CreateMediaObjectAction

Complexity

Conditions	5
Paths	9

Size

Total Lines	59
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	35
c	1
b	0
f	0
nc	9
nop	1
dl	0
loc	59
rs	9.0488

How to fix Long Method

<?php

/**
 * webtrees: online genealogy
 * Copyright (C) 2019 webtrees development team
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

declare(strict_types=1);

namespace Fisharebest\Webtrees\Http\RequestHandlers;

use Fisharebest\Webtrees\I18N;
use Fisharebest\Webtrees\Services\MediaFileService;
use Fisharebest\Webtrees\Services\PendingChangesService;
use Fisharebest\Webtrees\Tree;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\RequestHandlerInterface;

use function assert;
use function in_array;

/**
 * Process a form to create a new media object.
 */
class CreateMediaObjectAction implements RequestHandlerInterface
{
    /** @var MediaFileService */
    private $media_file_service;

    /** @var PendingChangesService */
    private $pending_changes_service;

    /**
     * CreateMediaObjectAction constructor.
     *
     * @param MediaFileService      $media_file_service
     * @param PendingChangesService $pending_changes_service
     */
    public function __construct(MediaFileService $media_file_service, PendingChangesService $pending_changes_service)
    {
        $this->media_file_service      = $media_file_service;
        $this->pending_changes_service = $pending_changes_service;
    }

    /**
     * Process a form to create a new media object.
     *
     * @param ServerRequestInterface $request
     *
     * @return ResponseInterface
     */
    public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $tree = $request->getAttribute('tree');
        assert($tree instanceof Tree);

        $params              = $request->getParsedBody();
        $note                = $params['media-note'];
        $title               = $params['title'];
        $type                = $params['type'];
        $privacy_restriction = $params['privacy-restriction'];
        $edit_restriction    = $params['edit-restriction'];

        // Tidy whitespace
        $type  = trim(preg_replace('/\s+/', ' ', $type));
        $title = trim(preg_replace('/\s+/', ' ', $title));

        // Convert line endings to GEDDCOM continuations
        $note = str_replace([
            "\r\n",
            "\r",
            "\n",
        ], "\n1 CONT ", $note);

        $file = $this->media_file_service->uploadFile($request);

        if ($file === '') {
            return response(['error_message' => I18N::translate('There was an error uploading your file.')], 406);
        }

        $gedcom = "0 @@ OBJE\n" . $this->media_file_service->createMediaFileGedcom($file, $type, $title);

        if ($note !== '') {
            $gedcom .= "\n1 NOTE " . preg_replace('/\r?\n/', "\n2 CONT ", $note);
        }

        if (in_array($privacy_restriction, $this->media_file_service::PRIVACY_RESTRICTIONS, true)) {
            $gedcom .= "\n1 RESN " . $privacy_restriction;
        }

        if (in_array($edit_restriction, $this->media_file_service::EDIT_RESTRICTIONS, true)) {
            $gedcom .= "\n1 RESN " . $edit_restriction;
        }

        $record = $tree->createMediaObject($gedcom);

        // Accept the new record to keep the filesystem synchronized with the genealogy.
        $this->pending_changes_service->acceptRecord($record);

        // id and text are for select2 / autocomplete
        // html is for interactive modals
        return response([
            'id'   => $record->xref(),
            'text' => view('selects/media', [
                'media' => $record,
            ]),
            'html' => view('modals/record-created', [
                'title' => I18N::translate('The media object has been created'),
                'name'  => $record->fullName(),
                'url'   => $record->url(),
            ]),
        ]);
    }
}


1			<?php
2
3			/**
4			* webtrees: online genealogy
5			* Copyright (C) 2019 webtrees development team
6			* This program is free software: you can redistribute it and/or modify
7			* it under the terms of the GNU General Public License as published by
8			* the Free Software Foundation, either version 3 of the License, or
9			* (at your option) any later version.
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13			* GNU General Public License for more details.
14			* You should have received a copy of the GNU General Public License
15			* along with this program. If not, see <http://www.gnu.org/licenses/>.
16			*/
17
18			declare(strict_types=1);
19
20			namespace Fisharebest\Webtrees\Http\RequestHandlers;
21
22			use Fisharebest\Webtrees\I18N;
23			use Fisharebest\Webtrees\Services\MediaFileService;
24			use Fisharebest\Webtrees\Services\PendingChangesService;
25			use Fisharebest\Webtrees\Tree;
26			use Psr\Http\Message\ResponseInterface;
27			use Psr\Http\Message\ServerRequestInterface;
28			use Psr\Http\Server\RequestHandlerInterface;
29
30			use function assert;
31			use function in_array;
32
33			/**
34			* Process a form to create a new media object.
35			*/
36			class CreateMediaObjectAction implements RequestHandlerInterface
37			{
38			/** @var MediaFileService */
39			private $media_file_service;
40
41			/** @var PendingChangesService */
42			private $pending_changes_service;
43
44			/**
45			* CreateMediaObjectAction constructor.
46			*
47			* @param MediaFileService $media_file_service
48			* @param PendingChangesService $pending_changes_service
49			*/
50			public function __construct(MediaFileService $media_file_service, PendingChangesService $pending_changes_service)
51			{
52			$this->media_file_service = $media_file_service;
53			$this->pending_changes_service = $pending_changes_service;
54			}
55
56			/**
57			* Process a form to create a new media object.
58			*
59			* @param ServerRequestInterface $request
60			*
61			* @return ResponseInterface
62			*/
63			public function handle(ServerRequestInterface $request): ResponseInterface
64			{
65			$tree = $request->getAttribute('tree');
66			assert($tree instanceof Tree);
67
68			$params = $request->getParsedBody();
69			$note = $params['media-note'];
70			$title = $params['title'];
71			$type = $params['type'];
72			$privacy_restriction = $params['privacy-restriction'];
73			$edit_restriction = $params['edit-restriction'];
74
75			// Tidy whitespace
76			$type = trim(preg_replace('/\s+/', ' ', $type));
77			$title = trim(preg_replace('/\s+/', ' ', $title));
78
79			// Convert line endings to GEDDCOM continuations
80			$note = str_replace([
81			"\r\n",
82			"\r",
83			"\n",
84			], "\n1 CONT ", $note);
85
86			$file = $this->media_file_service->uploadFile($request);
87
88			if ($file === '') {
89			return response(['error_message' => I18N::translate('There was an error uploading your file.')], 406);
90			}
91
92			$gedcom = "0 @@ OBJE\n" . $this->media_file_service->createMediaFileGedcom($file, $type, $title);
93
94			if ($note !== '') {
95			$gedcom .= "\n1 NOTE " . preg_replace('/\r?\n/', "\n2 CONT ", $note);
96			}
97
98			if (in_array($privacy_restriction, $this->media_file_service::PRIVACY_RESTRICTIONS, true)) {
99			$gedcom .= "\n1 RESN " . $privacy_restriction;
100			}
101
102			if (in_array($edit_restriction, $this->media_file_service::EDIT_RESTRICTIONS, true)) {
103			$gedcom .= "\n1 RESN " . $edit_restriction;
104			}
105
106			$record = $tree->createMediaObject($gedcom);
107
108			// Accept the new record to keep the filesystem synchronized with the genealogy.
109			$this->pending_changes_service->acceptRecord($record);
110
111			// id and text are for select2 / autocomplete
112			// html is for interactive modals
113			return response([
114			'id' => $record->xref(),
115			'text' => view('selects/media', [
116			'media' => $record,
117			]),
118			'html' => view('modals/record-created', [
119			'title' => I18N::translate('The media object has been created'),
120			'name' => $record->fullName(),
121			'url' => $record->url(),
122			]),
123			]);
124			}
125			}
126

fisharebest / webtrees

Push — master ( 852ede...d4265d )

CreateMediaObjectAction::handle() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like