Completed
Pull Request — master (#926)
by Mark
11:23
created
app/Module/StatisticsChartModule.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -500,7 +500,7 @@
 block discarded – undo
500 500
 	/**
501 501
 	 * A menu, to be added to the main application menu.
502 502
 	 *
503
-	 * @return Menu|null
503
+	 * @return Menu
504 504
 	 */
505 505
 	public function getMenu() {
506 506
 		$menu = new Menu($this->getTitle(), 'module.php?mod=' . $this->getName() . '&mod_action=show_list', 'menu-story');
Please login to merge, or discard this patch.
app/Module/TimelineChartModule.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -500,7 +500,7 @@
 block discarded – undo
500 500
 	/**
501 501
 	 * A menu, to be added to the main application menu.
502 502
 	 *
503
-	 * @return Menu|null
503
+	 * @return Menu
504 504
 	 */
505 505
 	public function getMenu() {
506 506
 		$menu = new Menu($this->getTitle(), 'module.php?mod=' . $this->getName() . '&mod_action=show_list', 'menu-story');
Please login to merge, or discard this patch.
app/Theme/AbstractTheme.php 1 patch
Doc Comments   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1115,7 +1115,7 @@  discard block
 block discarded – undo
1115 1115
 	 *
1116 1116
 	 * @param Individual $individual
1117 1117
 	 *
1118
-	 * @return Menu|null
1118
+	 * @return Menu
1119 1119
 	 *
1120 1120
 	 * @deprecated
1121 1121
 	 */
@@ -1130,7 +1130,7 @@  discard block
 block discarded – undo
1130 1130
 	 *
1131 1131
 	 * @param Individual $individual
1132 1132
 	 *
1133
-	 * @return Menu|null
1133
+	 * @return Menu
1134 1134
 	 *
1135 1135
 	 * @deprecated
1136 1136
 	 */
@@ -1145,7 +1145,7 @@  discard block
 block discarded – undo
1145 1145
 	 *
1146 1146
 	 * @param Individual $individual
1147 1147
 	 *
1148
-	 * @return Menu|null
1148
+	 * @return Menu
1149 1149
 	 *
1150 1150
 	 * @deprecated
1151 1151
 	 */
@@ -1160,7 +1160,7 @@  discard block
 block discarded – undo
1160 1160
 	 *
1161 1161
 	 * @param Individual $individual
1162 1162
 	 *
1163
-	 * @return Menu|null
1163
+	 * @return Menu
1164 1164
 	 *
1165 1165
 	 * @deprecated
1166 1166
 	 */
@@ -1192,7 +1192,7 @@  discard block
 block discarded – undo
1192 1192
 	 *
1193 1193
 	 * @param Individual $individual
1194 1194
 	 *
1195
-	 * @return Menu|null
1195
+	 * @return Menu
1196 1196
 	 *
1197 1197
 	 * @deprecated
1198 1198
 	 */
@@ -1207,7 +1207,7 @@  discard block
 block discarded – undo
1207 1207
 	 *
1208 1208
 	 * @param Individual $individual
1209 1209
 	 *
1210
-	 * @return Menu|null
1210
+	 * @return Menu
1211 1211
 	 *
1212 1212
 	 * @deprecated
1213 1213
 	 */
@@ -1222,7 +1222,7 @@  discard block
 block discarded – undo
1222 1222
 	 *
1223 1223
 	 * @param Individual $individual
1224 1224
 	 *
1225
-	 * @return Menu|null
1225
+	 * @return Menu
1226 1226
 	 *
1227 1227
 	 * @deprecated
1228 1228
 	 */
@@ -1237,7 +1237,7 @@  discard block
 block discarded – undo
1237 1237
 	 *
1238 1238
 	 * @param Individual $individual
1239 1239
 	 *
1240
-	 * @return Menu|null
1240
+	 * @return Menu
1241 1241
 	 *
1242 1242
 	 * @deprecated
1243 1243
 	 */
@@ -1252,7 +1252,7 @@  discard block
 block discarded – undo
1252 1252
 	 *
1253 1253
 	 * @param Individual $individual
1254 1254
 	 *
1255
-	 * @return Menu|null
1255
+	 * @return Menu
1256 1256
 	 *
1257 1257
 	 * @deprecated
1258 1258
 	 */
@@ -1267,7 +1267,7 @@  discard block
 block discarded – undo
1267 1267
 	 *
1268 1268
 	 * @param Individual $individual
1269 1269
 	 *
1270
-	 * @return Menu|null
1270
+	 * @return Menu
1271 1271
 	 *
1272 1272
 	 * @deprecated
1273 1273
 	 */
@@ -1280,7 +1280,7 @@  discard block
 block discarded – undo
1280 1280
 	/**
1281 1281
 	 * Generate a menu item for the statistics charts.
1282 1282
 	 *
1283
-	 * @return Menu|null
1283
+	 * @return Menu
1284 1284
 	 *
1285 1285
 	 * @deprecated
1286 1286
 	 */
@@ -1295,7 +1295,7 @@  discard block
 block discarded – undo
1295 1295
 	 *
1296 1296
 	 * @param Individual $individual
1297 1297
 	 *
1298
-	 * @return Menu|null
1298
+	 * @return Menu
1299 1299
 	 *
1300 1300
 	 * @deprecated
1301 1301
 	 */
Please login to merge, or discard this patch.
app/Module/AncestorsChartModule.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 	/**
57 57
 	 * Return a menu item for this chart.
58 58
 	 *
59
-	 * @return Menu|null
59
+	 * @return Menu
60 60
 	 */
61 61
 	public function getChartMenu(Individual $individual) {
62 62
 		$tree     = $individual->getTree();
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 	/**
83 83
 	 * Return a menu item for this chart - for use in individual boxes.
84 84
 	 *
85
-	 * @return Menu|null
85
+	 * @return Menu
86 86
 	 */
87 87
 	public function getBoxChartMenu(Individual $individual) {
88 88
 		return $this->getChartMenu($individual);
Please login to merge, or discard this patch.
app/Module/CompactTreeChartModule.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 	/**
57 57
 	 * Return a menu item for this chart.
58 58
 	 *
59
-	 * @return Menu|null
59
+	 * @return Menu
60 60
 	 */
61 61
 	public function getChartMenu(Individual $individual) {
62 62
 		$tree     = $individual->getTree();
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 	/**
83 83
 	 * Return a menu item for this chart - for use in individual boxes.
84 84
 	 *
85
-	 * @return Menu|null
85
+	 * @return Menu
86 86
 	 */
87 87
 	public function getBoxChartMenu(Individual $individual) {
88 88
 		return $this->getChartMenu($individual);
Please login to merge, or discard this patch.
app/Module/DescendancyChartModule.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 	/**
57 57
 	 * Return a menu item for this chart.
58 58
 	 *
59
-	 * @return Menu|null
59
+	 * @return Menu
60 60
 	 */
61 61
 	public function getChartMenu(Individual $individual) {
62 62
 		$tree     = $individual->getTree();
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 	/**
83 83
 	 * Return a menu item for this chart - for use in individual boxes.
84 84
 	 *
85
-	 * @return Menu|null
85
+	 * @return Menu
86 86
 	 */
87 87
 	public function getBoxChartMenu(Individual $individual) {
88 88
 		return $this->getChartMenu($individual);
Please login to merge, or discard this patch.
app/Module/FamilyBookChartModule.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 	/**
57 57
 	 * Return a menu item for this chart.
58 58
 	 *
59
-	 * @return Menu|null
59
+	 * @return Menu
60 60
 	 */
61 61
 	public function getChartMenu(Individual $individual) {
62 62
 		$tree     = $individual->getTree();
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 	/**
83 83
 	 * Return a menu item for this chart - for use in individual boxes.
84 84
 	 *
85
-	 * @return Menu|null
85
+	 * @return Menu
86 86
 	 */
87 87
 	public function getBoxChartMenu(Individual $individual) {
88 88
 		return $this->getChartMenu($individual);
Please login to merge, or discard this patch.
app/Module/GoogleMapsModule.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 	/**
57 57
 	 * Return a menu item for this chart.
58 58
 	 *
59
-	 * @return Menu|null
59
+	 * @return Menu
60 60
 	 */
61 61
 	public function getChartMenu(Individual $individual) {
62 62
 		$tree     = $individual->getTree();
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 	/**
83 83
 	 * Return a menu item for this chart - for use in individual boxes.
84 84
 	 *
85
-	 * @return Menu|null
85
+	 * @return Menu
86 86
 	 */
87 87
 	public function getBoxChartMenu(Individual $individual) {
88 88
 		return $this->getChartMenu($individual);
Please login to merge, or discard this patch.
Braces   +19 added lines, -6 removed lines patch added patch discarded remove patch
@@ -3017,7 +3017,8 @@  discard block
 block discarded – undo
3017 3017
 		ob_start(); // TODO: rewrite print_gm_markers, and the functions called therein, to either return text or add JS directly.
3018 3018
 
3019 3019
 		if ($numfound == 0 && $level > 0) {
3020
-			if (isset($levelo[($level - 1)])) {  // ** BH not sure yet what this if statement is for ... TODO **
3020
+			if (isset($levelo[($level - 1)])) {
3021
+// ** BH not sure yet what this if statement is for ... TODO **
3021 3022
 				// show the current place on the map
3022 3023
 
3023 3024
 				$place = Database::prepare("SELECT pl_id AS place_id, pl_place AS place, pl_lati AS lati, pl_long AS `long`, pl_zoom AS zoom, pl_icon AS icon FROM `##placelocation` WHERE pl_id=?")
@@ -3851,7 +3852,8 @@  discard block
 block discarded – undo
3851 3852
 			}
3852 3853
 
3853 3854
 			function showLocation_level(address) {
3854
-				address += '<?php if ($level > 0) echo ', ', addslashes(implode(', ', array_reverse($where_am_i, true))) ?>';
3855
+				address += '<?php if ($level > 0) {
3856
+	echo ', ', addslashes(implode(', ', array_reverse($where_am_i, true))) ?>';
3855 3857
 				geocoder.geocode({'address': address}, addAddressToMap);
3856 3858
 			}
3857 3859
 
@@ -3896,8 +3898,13 @@  discard block
 block discarded – undo
3896 3898
 				<td class="optionbox" colspan="2">
3897 3899
 					<input type="text" id="NEW_PLACE_LATI" name="NEW_PLACE_LATI" placeholder="<?php echo /* I18N: Measure of latitude/longitude */ I18N::translate('degrees') ?>" value="<?php echo abs($place_lati) ?>" size="20" onchange="updateMap();">
3898 3900
 					<select name="LATI_CONTROL" id="LATI_CONTROL" onchange="updateMap();">
3899
-						<option value="PL_N" <?php if ($place_lati >= 0) echo "selected"; echo ">", I18N::translate('north') ?></option>
3900
-						<option value="PL_S" <?php if ($place_lati < 0) echo "selected"; echo ">", I18N::translate('south') ?></option>
3901
+						<option value="PL_N" <?php if ($place_lati >= 0) echo "selected";
3902
+}
3903
+echo ">", I18N::translate('north') ?></option>
3904
+						<option value="PL_S" <?php if ($place_lati < 0) {
3905
+	echo "selected";
3906
+}
3907
+echo ">", I18N::translate('south') ?></option>
3901 3908
 					</select>
3902 3909
 				</td>
3903 3910
 			</tr>
@@ -3906,8 +3913,14 @@  discard block
 block discarded – undo
3906 3913
 				<td class="optionbox" colspan="2">
3907 3914
 					<input type="text" id="NEW_PLACE_LONG" name="NEW_PLACE_LONG" placeholder="<?php echo I18N::translate('degrees') ?>" value="<?php echo abs($place_long) ?>" size="20" onchange="updateMap();">
3908 3915
 					<select name="LONG_CONTROL" id="LONG_CONTROL" onchange="updateMap();">
3909
-						<option value="PL_E" <?php if ($place_long >= 0) echo "selected"; echo ">", I18N::translate('east') ?></option>
3910
-						<option value="PL_W" <?php if ($place_long < 0) echo "selected"; echo ">", I18N::translate('west') ?></option>
3916
+						<option value="PL_E" <?php if ($place_long >= 0) {
3917
+	echo "selected";
3918
+}
3919
+echo ">", I18N::translate('east') ?></option>
3920
+						<option value="PL_W" <?php if ($place_long < 0) {
3921
+	echo "selected";
3922
+}
3923
+echo ">", I18N::translate('west') ?></option>
3911 3924
 					</select>
3912 3925
 				</td>
3913 3926
 			</tr>
Please login to merge, or discard this patch.
app/Module/HourglassChartModule.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 	/**
57 57
 	 * Return a menu item for this chart.
58 58
 	 *
59
-	 * @return Menu|null
59
+	 * @return Menu
60 60
 	 */
61 61
 	public function getChartMenu(Individual $individual) {
62 62
 		$tree     = $individual->getTree();
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 	/**
83 83
 	 * Return a menu item for this chart - for use in individual boxes.
84 84
 	 *
85
-	 * @return Menu|null
85
+	 * @return Menu
86 86
 	 */
87 87
 	public function getBoxChartMenu(Individual $individual) {
88 88
 		return $this->getChartMenu($individual);
Please login to merge, or discard this patch.