MergeFactsPage::handle() - Code Metrics - Inspection of "Update routing in merge-records" - fisharebest/webtrees - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 453a3d...5bbfbb )

by Greg

created 2019-11-04 21:09 UTC

MergeFactsPage::handle() C

↳ Parent: MergeFactsPage

Complexity

Conditions	16
Paths	37

Size

Total Lines	66
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	16
eloc	41
c	1
b	0
f	0
nc	37
nop	1
dl	0
loc	66
rs	5.5666

How to fix Long Method Complexity

<?php

/**
 * webtrees: online genealogy
 * Copyright (C) 2019 webtrees development team
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

declare(strict_types=1);

namespace Fisharebest\Webtrees\Http\RequestHandlers;

use Fisharebest\Webtrees\Family;
use Fisharebest\Webtrees\GedcomRecord;
use Fisharebest\Webtrees\Http\ViewResponseTrait;
use Fisharebest\Webtrees\I18N;
use Fisharebest\Webtrees\Individual;
use Fisharebest\Webtrees\Media;
use Fisharebest\Webtrees\Note;
use Fisharebest\Webtrees\Repository;
use Fisharebest\Webtrees\Source;
use Fisharebest\Webtrees\Tree;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\RequestHandlerInterface;

use function assert;
use function redirect;

/**
 * Merge records
 */
class MergeFactsPage implements RequestHandlerInterface
{
    use ViewResponseTrait;

    /**
     * Merge two genealogy records.
     *
     * @param ServerRequestInterface $request
     *
     * @return ResponseInterface
     */
    public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $this->layout = 'layouts/administration';

        $tree = $request->getAttribute('tree');
        assert($tree instanceof Tree);

        $xref1  = $request->getQueryParams()['xref1'] ?? '';
        $xref2  = $request->getQueryParams()['xref2'] ?? '';

        $title = I18N::translate('Merge records') . ' — ' . e($tree->title());

        $record1 = GedcomRecord::getInstance($xref1, $tree);
        $record2 = GedcomRecord::getInstance($xref2, $tree);

        if (
            $record1 === null ||
            $record2 === null ||
            $record1 === $record2 ||
            $record1::RECORD_TYPE !== $record2::RECORD_TYPE ||
            $record1->isPendingDeletion() ||
            $record2->isPendingDeletion()
        ) {
            return redirect(route(MergeRecordsPage::class, [
                'tree'  => $tree->name(),
                'xref1' => $xref1,
                'xref2' => $xref2,
            ]));
        }

        // Facts found both records
        $facts = [];

        // Facts found in only one record
        $facts1 = [];
        $facts2 = [];

        foreach ($record1->facts() as $fact) {
            if (!$fact->isPendingDeletion() && $fact->getTag() !== 'CHAN') {
                $facts1[$fact->id()] = $fact;
            }
        }

        foreach ($record2->facts() as $fact) {
            if (!$fact->isPendingDeletion() && $fact->getTag() !== 'CHAN') {
                $facts2[$fact->id()] = $fact;
            }
        }

        foreach ($facts1 as $id1 => $fact1) {
            foreach ($facts2 as $id2 => $fact2) {
                if ($fact1->id() === $fact2->id()) {
                    $facts[] = $fact1;
                    unset($facts1[$id1], $facts2[$id2]);
                }
            }
        }

        return $this->viewResponse('admin/merge-records-step-2', [
            'facts'   => $facts,
            'facts1'  => $facts1,
            'facts2'  => $facts2,
            'record1' => $record1,
            'record2' => $record2,
            'title'   => $title,
            'tree'    => $tree,
        ]);
    }
}


1			<?php
2
3			/**
4			* webtrees: online genealogy
5			* Copyright (C) 2019 webtrees development team
6			* This program is free software: you can redistribute it and/or modify
7			* it under the terms of the GNU General Public License as published by
8			* the Free Software Foundation, either version 3 of the License, or
9			* (at your option) any later version.
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13			* GNU General Public License for more details.
14			* You should have received a copy of the GNU General Public License
15			* along with this program. If not, see <http://www.gnu.org/licenses/>.
16			*/
17
18			declare(strict_types=1);
19
20			namespace Fisharebest\Webtrees\Http\RequestHandlers;
21
22			use Fisharebest\Webtrees\Family;
23			use Fisharebest\Webtrees\GedcomRecord;
24			use Fisharebest\Webtrees\Http\ViewResponseTrait;
25			use Fisharebest\Webtrees\I18N;
26			use Fisharebest\Webtrees\Individual;
27			use Fisharebest\Webtrees\Media;
28			use Fisharebest\Webtrees\Note;
29			use Fisharebest\Webtrees\Repository;
30			use Fisharebest\Webtrees\Source;
31			use Fisharebest\Webtrees\Tree;
32			use Psr\Http\Message\ResponseInterface;
33			use Psr\Http\Message\ServerRequestInterface;
34			use Psr\Http\Server\RequestHandlerInterface;
35
36			use function assert;
37			use function redirect;
38
39			/**
40			* Merge records
41			*/
42			class MergeFactsPage implements RequestHandlerInterface
43			{
44			use ViewResponseTrait;
45
46			/**
47			* Merge two genealogy records.
48			*
49			* @param ServerRequestInterface $request
50			*
51			* @return ResponseInterface
52			*/
53			public function handle(ServerRequestInterface $request): ResponseInterface
54			{
55			$this->layout = 'layouts/administration';
56
57			$tree = $request->getAttribute('tree');
58			assert($tree instanceof Tree);
59
60			$xref1 = $request->getQueryParams()['xref1'] ?? '';
61			$xref2 = $request->getQueryParams()['xref2'] ?? '';
62
63			$title = I18N::translate('Merge records') . ' — ' . e($tree->title());
64
65			$record1 = GedcomRecord::getInstance($xref1, $tree);
66			$record2 = GedcomRecord::getInstance($xref2, $tree);
67
68			if (
69			$record1 === null \|\|
70			$record2 === null \|\|
71			$record1 === $record2 \|\|
72			$record1::RECORD_TYPE !== $record2::RECORD_TYPE \|\|
73			$record1->isPendingDeletion() \|\|
74			$record2->isPendingDeletion()
75			) {
76			return redirect(route(MergeRecordsPage::class, [
77			'tree' => $tree->name(),
78			'xref1' => $xref1,
79			'xref2' => $xref2,
80			]));
81			}
82
83			// Facts found both records
84			$facts = [];
85
86			// Facts found in only one record
87			$facts1 = [];
88			$facts2 = [];
89
90			foreach ($record1->facts() as $fact) {
91			if (!$fact->isPendingDeletion() && $fact->getTag() !== 'CHAN') {
92			$facts1[$fact->id()] = $fact;
93			}
94			}
95
96			foreach ($record2->facts() as $fact) {
97			if (!$fact->isPendingDeletion() && $fact->getTag() !== 'CHAN') {
98			$facts2[$fact->id()] = $fact;
99			}
100			}
101
102			foreach ($facts1 as $id1 => $fact1) {
103			foreach ($facts2 as $id2 => $fact2) {
104			if ($fact1->id() === $fact2->id()) {
105			$facts[] = $fact1;
106			unset($facts1[$id1], $facts2[$id2]);
107			}
108			}
109			}
110
111			return $this->viewResponse('admin/merge-records-step-2', [
112			'facts' => $facts,
113			'facts1' => $facts1,
114			'facts2' => $facts2,
115			'record1' => $record1,
116			'record2' => $record2,
117			'title' => $title,
118			'tree' => $tree,
119			]);
120			}
121			}
122

fisharebest / webtrees

Push — master ( 453a3d...5bbfbb )

MergeFactsPage::handle() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like