Passed
Pull Request — master (#2335)
by Rico
06:20
created
app/Module/ChartsBlockModule.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
                         'generations' => 3,
111 111
                         'layout'      => PedigreeChartModule::ORIENTATION_RIGHT,
112 112
                     ]);
113
-                    $content   = view('modules/charts/chart', [
113
+                    $content = view('modules/charts/chart', [
114 114
                         'block_id'  => $block_id,
115 115
                         'chart_url' => $chart_url,
116 116
                     ]);
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
                         'generations' => 2,
126 126
                         'chart_style' => DescendancyChartModule::CHART_STYLE_LIST,
127 127
                     ]);
128
-                    $content   = view('modules/charts/chart', [
128
+                    $content = view('modules/charts/chart', [
129 129
                         'block_id'  => $block_id,
130 130
                         'chart_url' => $chart_url,
131 131
                     ]);
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
                         'ajax'        => true,
140 140
                         'generations' => 2,
141 141
                     ]);
142
-                    $content   = view('modules/charts/chart', [
142
+                    $content = view('modules/charts/chart', [
143 143
                         'block_id'  => $block_id,
144 144
                         'chart_url' => $chart_url,
145 145
                     ]);
Please login to merge, or discard this patch.
app/Http/Controllers/ListController.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -125,10 +125,10 @@  discard block
 block discarded – undo
125 125
         switch ($show_marnm) {
126 126
             case 'no':
127 127
             case 'yes':
128
-                $user->setPreference($families?'family-list-marnm':'individual-list-marnm', $show_marnm);
128
+                $user->setPreference($families ? 'family-list-marnm' : 'individual-list-marnm', $show_marnm);
129 129
                 break;
130 130
             default:
131
-                $show_marnm = $user->getPreference($families?'family-list-marnm':'individual-list-marnm');
131
+                $show_marnm = $user->getPreference($families ? 'family-list-marnm' : 'individual-list-marnm');
132 132
         }
133 133
 
134 134
         // Make sure selections are consistent.
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
                     'ged'      => $tree->name(),
161 161
                     'show_all' => 'yes',
162 162
                 ];
163
-                $show    = $request->get('show', 'surn');
163
+                $show = $request->get('show', 'surn');
164 164
             }
165 165
         } elseif ($surname) {
166 166
             $alpha    = $this->localization_service->initialLetter($surname); // so we can highlight the initial letter
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -233,7 +233,8 @@  discard block
 block discarded – undo
233 233
                     <li class="wt-initials-list-item d-flex">
234 234
                         <?php if ($count > 0) : ?>
235 235
                             <a href="<?= e(route('module', ['module' => $module, 'action' => $action, 'alpha' => $letter, 'ged' => $tree->name()])) ?>" class="wt-initial px-1<?= $letter === $alpha ? ' active' : '' ?> '" title="<?= I18N::number($count) ?>"><?= $this->surnameInitial((string) $letter) ?></a>
236
-                        <?php else : ?>
236
+                        <?php else {
237
+    : ?>
237 238
                             <span class="wt-initial px-1 text-muted"><?= $this->surnameInitial((string) $letter) ?></span>
238 239
 
239 240
                         <?php endif ?>
@@ -287,6 +288,7 @@  discard block
 block discarded – undo
287 288
 
288 289
             if ($show === 'indi' || $show === 'surn') {
289 290
                 $surns = $this->individual_list_service->surnames($surname, $alpha, $show_marnm === 'yes', $families, WT_LOCALE, I18N::collation());
291
+}
290 292
                 if ($show === 'surn') {
291 293
                     // Show the surname list
292 294
                     switch ($tree->getPreference('SURNAME_LIST_STYLE')) {
Please login to merge, or discard this patch.
app/Statistics/Repository/PlaceRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
      */
50 50
     public function __construct(Tree $tree)
51 51
     {
52
-        $this->tree          = $tree;
52
+        $this->tree = $tree;
53 53
         $this->country_service = new CountryService();
54 54
     }
55 55
 
Please login to merge, or discard this patch.
app/Module/ListsMenuModule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
     public function getMenu(Tree $tree): ?Menu
88 88
     {
89 89
         $submenus = $this->module_service->findByComponent(ModuleListInterface::class, $tree, Auth::user())
90
-            ->map(function (ModuleListInterface $module) use ($tree): ?Menu {
90
+            ->map(function (ModuleListInterface $module) use ($tree) : ?Menu {
91 91
                 return $module->listMenu($tree);
92 92
             })
93 93
             ->filter()
Please login to merge, or discard this patch.
app/Statistics.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2616,7 +2616,7 @@
 block discarded – undo
2616 2616
         /** @var ModuleBlockInterface|null $module */
2617 2617
         $module = $this->module_service
2618 2618
             ->findByComponent(ModuleBlockInterface::class, $this->tree, Auth::user())
2619
-            ->filter(function (ModuleInterface $module) use ($block): bool {
2619
+            ->filter(function (ModuleInterface $module) use ($block) : bool {
2620 2620
                 return $module->name() === $block && $module->name() !== 'html';
2621 2621
             })
2622 2622
             ->first();
Please login to merge, or discard this patch.
app/Module/HourglassChartModule.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
             if ($kcount == 0) {
292 292
                 echo "</td><td style='width:", app(ModuleThemeInterface::class)->parameter('chart-box-x'), "px'>";
293 293
             } else {
294
-                echo '<a href="#" title="' . I18N::translate('Children') . '" data-route="Descendants" data-xref="' .  e($pid) . '" data-spouses="' .  e($show_spouse) . '" data-tree="' .  e($individual->tree()->name()) . '">' . view('icons/arrow-left') . '</a>';
294
+                echo '<a href="#" title="' . I18N::translate('Children') . '" data-route="Descendants" data-xref="' . e($pid) . '" data-spouses="' . e($show_spouse) . '" data-tree="' . e($individual->tree()->name()) . '">' . view('icons/arrow-left') . '</a>';
295 295
 
296 296
                 //-- move the arrow up to line up with the correct box
297 297
                 if ($show_spouse) {
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
                 }
373 373
 
374 374
                 // filter out root person from children array so only siblings remain
375
-                $siblings       = $family->children()->filter(function (Individual $x) use ($individual): bool {
375
+                $siblings = $family->children()->filter(function (Individual $x) use ($individual): bool {
376 376
                     return $x !== $individual;
377 377
                 });
378 378
 
@@ -445,7 +445,7 @@  discard block
 block discarded – undo
445 445
                 echo '<td id="td_' . e($ARID) . '">';
446 446
 
447 447
                 if ($generation == $generations - 1 && $family->husband()->childFamilies()) {
448
-                    echo '<a href="#" title="' . I18N::translate('Parents') . '" data-route="Ancestors" data-xref="' .  e($ARID) . '" data-spouses="' .  e($show_spouse) . '" data-tree="' .  e($family->husband()->tree()->name()) . '">' . view('icons/arrow-right') . '</a>';
448
+                    echo '<a href="#" title="' . I18N::translate('Parents') . '" data-route="Ancestors" data-xref="' . e($ARID) . '" data-spouses="' . e($show_spouse) . '" data-tree="' . e($family->husband()->tree()->name()) . '">' . view('icons/arrow-right') . '</a>';
449 449
                 }
450 450
 
451 451
                 $this->printPersonPedigree($family->husband(), $generation + 1, $generations, $show_spouse);
@@ -476,7 +476,7 @@  discard block
 block discarded – undo
476 476
                 echo '<td id="td_' . e($ARID) . '">';
477 477
 
478 478
                 if ($generation == $generations - 1 && $family->wife()->childFamilies()) {
479
-                    echo '<a href="#" title="' . I18N::translate('Parents') . '" data-route="Ancestors" data-xref="' .  e($ARID) . '" data-spouses="' .  e($show_spouse) . '" data-tree="' .  e($family->wife()->tree()->name()) . '">' . view('icons/arrow-right') . '</a>';
479
+                    echo '<a href="#" title="' . I18N::translate('Parents') . '" data-route="Ancestors" data-xref="' . e($ARID) . '" data-spouses="' . e($show_spouse) . '" data-tree="' . e($family->wife()->tree()->name()) . '">' . view('icons/arrow-right') . '</a>';
480 480
                 }
481 481
 
482 482
                 $this->printPersonPedigree($family->wife(), $generation + 1, $generations, $show_spouse);
Please login to merge, or discard this patch.
app/Services/ModuleService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -555,7 +555,7 @@
 block discarded – undo
555 555
     public function findByName(string $module_name, bool $include_disabled = false): ?ModuleInterface
556 556
     {
557 557
         return $this->all($include_disabled)
558
-            ->filter(function (ModuleInterface $module) use ($module_name): bool {
558
+            ->filter(function (ModuleInterface $module) use ($module_name) : bool {
559 559
                 return $module->name() === $module_name;
560 560
             })
561 561
             ->first();
Please login to merge, or discard this patch.
app/View.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -252,7 +252,7 @@
 block discarded – undo
252 252
         [$namespace, $view_name] = explode(self::NAMESPACE_SEPARATOR, $view_name, 2);
253 253
 
254 254
         if ((self::$namespaces[$namespace] ?? null) === null) {
255
-            throw new RuntimeException('Namespace "' . e($namespace) .  '" not found.');
255
+            throw new RuntimeException('Namespace "' . e($namespace) . '" not found.');
256 256
         }
257 257
 
258 258
         $view_file = self::$namespaces[$namespace] . $view_name . self::TEMPLATE_EXTENSION;
Please login to merge, or discard this patch.
app/Module/PedigreeChartModule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -177,7 +177,7 @@
 block discarded – undo
177 177
 
178 178
         // Father’s ancestors link to the father’s pedigree
179 179
         // Mother’s ancestors link to the mother’s pedigree..
180
-        $links = $ancestors->map(function (?Individual $individual, $sosa) use ($ancestors, $orientation, $generations): string {
180
+        $links = $ancestors->map(function (?Individual $individual, $sosa) use ($ancestors, $orientation, $generations) : string {
181 181
             if ($individual instanceof Individual && $sosa >= 2 ** $generations / 2 && $individual->childFamilies()->isNotEmpty()) {
182 182
                 // The last row/column, and there are more generations.
183 183
                 if ($sosa >= 2 ** $generations * 3 / 4) {
Please login to merge, or discard this patch.