MEDIA_ctrl.php ➔ print_navigator_family() - Code Metrics - Inspection of "Fix #997 - Sort list of charts" - fisharebest/webtrees - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 152113...fddfbb )

by Greg

created 2016-06-21 23:58 UTC

MEDIA_ctrl.php ➔ print_navigator_family() D

↳ Parent: Project

Complexity

Conditions	9
Paths	9

Size

Total Lines	43
Code Lines	27

Duplication

Lines	40
Ratio	93.02 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	9
eloc	27
c	1
b	1
f	0
nc	9
nop	2
dl	40
loc	43
rs	4.909

<?php

/**
 * webtrees: online genealogy
 * Copyright (C) 2016 webtrees development team
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */
namespace Fisharebest\Webtrees;

/**
 * Defined in edit_interface.php
 *
 * @global Individual $person
 */
global $person;
function myFunction($a, $b) {
    // Do something
}
/**
 * Defined in edit_interface.php
 *
 * @global Controller\PageController $controller
 */
global $controller;
function myFunction($a, $b) {
    // Do something
}

?>
<style>
	/* Outer border around nav elements */
	.outer_nav {
		border: 3px #808080 outset;
	}

	#media-links table.facts_table {
		width: 270px;
	}

	/* top Search box */
	input[type='text'] {
		background: #fff;
		color: #000;
		border: 1px solid #000;
		width: 120px;
	}

	/* "Head" button images */
	.headimg {
		margin-top: -4px;
		border: 0;
	}

	/* Prevents clickable td for Search <td> */
	td #srch a {
		display: inline;
	}
</style>
<div id="media-links">
	<table class="facts_table center">
		<tr>
			<td class="topbottombar">
				<b><?php echo $controller->getPageTitle(); ?></b>
			</td>
		</tr>
		<tr>
			<td>
				<table class="outer_nav">
					<tr>
						<th class="descriptionbox"><?php echo I18N::translate('Find an individual'); ?></th>
					</tr>
					<tr>
						<td id="srch" class="optionbox center">
							<script>
								function findindi() {
									var findInput = document.getElementById('personid');
									var txt = findInput.value;
									if (txt === "") {
										alert("<?php echo I18N::translate('You must enter a name'); ?>");
									} else {
										window.open("module.php?mod=GEDFact_assistant&mod_action=media_find&callback=paste_id&action=filter&type=indi&multiple=&filter=" + txt, "win02", "resizable=1, menubar=0, scrollbars=1, top=180, left=600, height=600, width=450 ").focus();
									}
								}
							</script>
							<input id="personid" type="text" value="">
							<a type="submit" onclick="findindi();">
								<?php echo I18N::translate('Search'); ?>
							</a>
						</td>
					</tr>
					<tr>
						<td>
							<table width="100%" class="fact_table" cellspacing="0" border="0">
								<tr>
									<td colspan=3 class="descriptionbox wrap">
										<i class="headimg vmiddle icon-button_head"></i>
										<?php echo I18N::translate('View this family'); ?>
									</td>
								</tr>
								<?php
								foreach ($person->getChildFamilies() as $family) {
									echo '<tr><th colspan="2">', $family->getFullName(), '</td></tr>';
									print_navigator_family($family, $person);
								}

								foreach ($person->getChildStepFamilies() as $family) {
									echo '<tr><th colspan="2">', $family->getFullName(), '</td></tr>';
									print_navigator_family($family, $person);
								}

								foreach ($person->getSpouseFamilies() as $family) {
									echo '<tr><th colspan="2">', $family->getFullName(), '</td></tr>';
									print_navigator_family($family, $person);
								}
								?>
							</table>
						</td>
					</tr>
				</table>
			</td>
		</tr>
	</table>
</div>
<?php

/**
 * Display family members with clickable links
 *
 * @param Family     $family
 * @param Individual $individual
 */
function print_navigator_family(Family $family, Individual $individual) {
	foreach ($family->getSpouses() as $spouse) {
		?>
		<tr class="fact_value">
			<td class="facts_value" >
				<a href="#" onclick="opener.insertRowToTable('<?php echo $spouse->getXref(); ?>', '<?php echo Filter::escapeJs($spouse->getFullName()); ?>', '', '', '', '', '', '', '', ''); return false;">
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
					<?php echo $spouse === $individual ? '<b>' : ''; ?>
					<?php echo $spouse->getFullName(); ?> <?php echo $spouse->getLifeSpan(); ?>
					<?php echo $spouse === $individual ? '</b>' : ''; ?>
				</a>
			</td>
			<td class="facts_value">
				<?php if ($individual !== $spouse): ?>
					<a href="edit_interface.php?action=addmedia_links&amp;noteid=newnote&amp;pid=<?php echo $spouse->getXref(); ?>&amp;gedcom=<?php echo $spouse->getTree()->getNameUrl(); ?>">
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
						<i class="headimg vmiddle icon-button_head"></i>
					</a>
				<?php endif; ?>
			</td>
		<tr>
	<?php
	}

	foreach ($family->getChildren() as $child) {
		?>
		<tr>
			<td class="facts_value">
				<a href="#" onclick="opener.insertRowToTable('<?php echo $child->getXref(); ?>', '<?php echo Filter::escapeJs($child->getFullName()); ?>', '', '', '', '', '', '', '', ''); return false;">
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
					<?php echo $child === $individual ? '<b>' : ''; ?>
					<?php echo $child->getFullName(); ?> <?php echo $child->getLifeSpan(); ?>
				<?php echo $child === $individual ? '</b>' : ''; ?>
				</a>
			</td>
			<td class="facts_value" >
			<?php if ($individual !== $child): ?>
					<a href="edit_interface.php?action=addmedia_links&amp;noteid=newnote&amp;pid=<?php echo $child->getXref(); ?>&amp;gedcom=<?php echo $child->getTree()->getNameUrl(); ?>">
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
						<i class="headimg vmiddle icon-button_head"></i>
					</a>
				<?php endif; ?>
			</td>
		</tr>
	<?php
	}
}


Push — develop ( 152113...fddfbb )

MEDIA_ctrl.php ➔ print_navigator_family() D

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-02-04 22:19 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 134 and the first side effect is on line 23. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2		/**
3		* webtrees: online genealogy
4		* Copyright (C) 2016 webtrees development team
5		* This program is free software: you can redistribute it and/or modify
6		* it under the terms of the GNU General Public License as published by
7		* the Free Software Foundation, either version 3 of the License, or
8		* (at your option) any later version.
9		* This program is distributed in the hope that it will be useful,
10		* but WITHOUT ANY WARRANTY; without even the implied warranty of
11		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12		* GNU General Public License for more details.
13		* You should have received a copy of the GNU General Public License
14		* along with this program. If not, see <http://www.gnu.org/licenses/>.
15		*/
16		namespace Fisharebest\Webtrees;
17
18		/**
19		* Defined in edit_interface.php
20		*
21		* @global Individual $person
22		*/
23		global $person;
		0 ignored issues – show Compatibility Best Practice introduced 2015-11-21 10:27 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
24		/**
25		* Defined in edit_interface.php
26		*
27		* @global Controller\PageController $controller
28		*/
29		global $controller;
		0 ignored issues – show Compatibility Best Practice introduced 2015-11-21 10:27 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
30
31		?>
32		<style>
33		/* Outer border around nav elements */
34		.outer_nav {
35		border: 3px #808080 outset;
36		}
37
38		#media-links table.facts_table {
39		width: 270px;
40		}
41
42		/* top Search box */
43		input[type='text'] {
44		background: #fff;
45		color: #000;
46		border: 1px solid #000;
47		width: 120px;
48		}
49
50		/* "Head" button images */
51		.headimg {
52		margin-top: -4px;
53		border: 0;
54		}
55
56		/* Prevents clickable td for Search <td> */
57		td #srch a {
58		display: inline;
59		}
60		</style>
61		<div id="media-links">
62		<table class="facts_table center">
63		<tr>
64		<td class="topbottombar">
65		<b><?php echo $controller->getPageTitle(); ?></b>
66		</td>
67		</tr>
68		<tr>
69		<td>
70		<table class="outer_nav">
71		<tr>
72		<th class="descriptionbox"><?php echo I18N::translate('Find an individual'); ?></th>
73		</tr>
74		<tr>
75		<td id="srch" class="optionbox center">
76		<script>
77		function findindi() {
78		var findInput = document.getElementById('personid');
79		var txt = findInput.value;
80		if (txt === "") {
81		alert("<?php echo I18N::translate('You must enter a name'); ?>");
82		} else {
83		window.open("module.php?mod=GEDFact_assistant&mod_action=media_find&callback=paste_id&action=filter&type=indi&multiple=&filter=" + txt, "win02", "resizable=1, menubar=0, scrollbars=1, top=180, left=600, height=600, width=450 ").focus();
84		}
85		}
86		</script>
87		<input id="personid" type="text" value="">
88		<a type="submit" onclick="findindi();">
89		<?php echo I18N::translate('Search'); ?>
90		</a>
91		</td>
92		</tr>
93		<tr>
94		<td>
95		<table width="100%" class="fact_table" cellspacing="0" border="0">
96		<tr>
97		<td colspan=3 class="descriptionbox wrap">
98		<i class="headimg vmiddle icon-button_head"></i>
99		<?php echo I18N::translate('View this family'); ?>
100		</td>
101		</tr>
102		<?php
103		foreach ($person->getChildFamilies() as $family) {
104		echo '<tr><th colspan="2">', $family->getFullName(), '</td></tr>';
105		print_navigator_family($family, $person);
106		}
107
108		foreach ($person->getChildStepFamilies() as $family) {
109		echo '<tr><th colspan="2">', $family->getFullName(), '</td></tr>';
110		print_navigator_family($family, $person);
111		}
112
113		foreach ($person->getSpouseFamilies() as $family) {
114		echo '<tr><th colspan="2">', $family->getFullName(), '</td></tr>';
115		print_navigator_family($family, $person);
116		}
117		?>
118		</table>
119		</td>
120		</tr>
121		</table>
122		</td>
123		</tr>
124		</table>
125		</div>
126		<?php
127
128		/**
129		* Display family members with clickable links
130		*
131		* @param Family $family
132		* @param Individual $individual
133		*/
134		function print_navigator_family(Family $family, Individual $individual) {
135	View Code Duplication	foreach ($family->getSpouses() as $spouse) {
136		?>
137		<tr class="fact_value">
138		<td class="facts_value" >
139		<a href="#" onclick="opener.insertRowToTable('<?php echo $spouse->getXref(); ?>', '<?php echo Filter::escapeJs($spouse->getFullName()); ?>', '', '', '', '', '', '', '', ''); return false;">
		0 ignored issues – show Security Cross-Site Scripting introduced 2016-04-12 13:54 UTC by Report Bug Copy Issue Report `$spouse->getXref()` can contain request data and is used in html attribute with single-quotes context(s) leading to a potential security vulnerability. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
140		<?php echo $spouse === $individual ? '<b>' : ''; ?>
141		<?php echo $spouse->getFullName(); ?> <?php echo $spouse->getLifeSpan(); ?>
142		<?php echo $spouse === $individual ? '</b>' : ''; ?>
143		</a>
144		</td>
145		<td class="facts_value">
146		<?php if ($individual !== $spouse): ?>
147		<a href="edit_interface.php?action=addmedia_links&noteid=newnote&pid=<?php echo $spouse->getXref(); ?>&gedcom=<?php echo $spouse->getTree()->getNameUrl(); ?>">
		0 ignored issues – show Security Cross-Site Scripting introduced 2016-04-12 13:54 UTC by Report Bug Copy Issue Report `$spouse->getXref()` can contain request data and is used in html attribute with double-quotes context(s) leading to a potential security vulnerability. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
148		<i class="headimg vmiddle icon-button_head"></i>
149		</a>
150		<?php endif; ?>
151		</td>
152		<tr>
153		<?php
154		}
155
156	View Code Duplication	foreach ($family->getChildren() as $child) {
157		?>
158		<tr>
159		<td class="facts_value">
160		<a href="#" onclick="opener.insertRowToTable('<?php echo $child->getXref(); ?>', '<?php echo Filter::escapeJs($child->getFullName()); ?>', '', '', '', '', '', '', '', ''); return false;">
		0 ignored issues – show Security Cross-Site Scripting introduced 2016-04-12 13:54 UTC by Report Bug Copy Issue Report `$child->getXref()` can contain request data and is used in html attribute with single-quotes context(s) leading to a potential security vulnerability. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
161		<?php echo $child === $individual ? '<b>' : ''; ?>
162		<?php echo $child->getFullName(); ?> <?php echo $child->getLifeSpan(); ?>
163		<?php echo $child === $individual ? '</b>' : ''; ?>
164		</a>
165		</td>
166		<td class="facts_value" >
167		<?php if ($individual !== $child): ?>
168		<a href="edit_interface.php?action=addmedia_links&noteid=newnote&pid=<?php echo $child->getXref(); ?>&gedcom=<?php echo $child->getTree()->getNameUrl(); ?>">
		0 ignored issues – show Security Cross-Site Scripting introduced 2016-04-12 13:54 UTC by Report Bug Copy Issue Report `$child->getXref()` can contain request data and is used in html attribute with double-quotes context(s) leading to a potential security vulnerability. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
169		<i class="headimg vmiddle icon-button_head"></i>
170		</a>
171		<?php endif; ?>
172		</td>
173		</tr>
174		<?php
175		}
176		}
177

fisharebest / webtrees

Push — develop ( 152113...fddfbb )

MEDIA_ctrl.php ➔ print_navigator_family() D

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

Duplication Side-by-Side

Filter issues like