Completed
Pull Request — master (#2156)
by Rico
08:04
created
app/Module/ChartsBlockModule.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
                         'generations' => 3,
96 96
                         'layout'      => PedigreeChartModule::PORTRAIT,
97 97
                     ]);
98
-                    $content   = view('modules/charts/chart', [
98
+                    $content = view('modules/charts/chart', [
99 99
                         'block_id'  => $block_id,
100 100
                         'chart_url' => $chart_url,
101 101
                     ]);
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
                         'generations' => 2,
111 111
                         'chart_style' => DescendancyChartModule::CHART_STYLE_LIST,
112 112
                     ]);
113
-                    $content   = view('modules/charts/chart', [
113
+                    $content = view('modules/charts/chart', [
114 114
                         'block_id'  => $block_id,
115 115
                         'chart_url' => $chart_url,
116 116
                     ]);
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
                         'ajax'        => true,
125 125
                         'generations' => 2,
126 126
                     ]);
127
-                    $content   = view('modules/charts/chart', [
127
+                    $content = view('modules/charts/chart', [
128 128
                         'block_id'  => $block_id,
129 129
                         'chart_url' => $chart_url,
130 130
                     ]);
Please login to merge, or discard this patch.
app/Module/RelationshipsChartModule.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -318,14 +318,14 @@  discard block
 block discarded – undo
318 318
                         case 'sis':
319 319
                         case 'sib':
320 320
                             $table[$x + 1][$y] = '<div style="background:url(' . Theme::theme()->parameter('image-hline') . ') repeat-x center;  width: 94px; text-align: center"><div class="hline-text" style="height: 32px;">' . Functions::getRelationshipNameFromPath($relationships[$n], Individual::getInstance($path[$n - 1], $tree), Individual::getInstance($path[$n + 1], $tree)) . '</div><div style="height: 32px;">' . view('icons/arrow-end') . '</div></div>';
321
-                            $x                 += 2;
321
+                            $x += 2;
322 322
                             break;
323 323
                         case 'son':
324 324
                         case 'dau':
325 325
                         case 'chi':
326 326
                             if ($n > 2 && preg_match('/fat|mot|par/', $relationships[$n - 2])) {
327 327
                                 $table[$x + 1][$y - 1] = '<div style="background:url(' . $diagonal2 . '); width: 64px; height: 64px; text-align: center;"><div style="height: 32px; text-align: end;">' . Functions::getRelationshipNameFromPath($relationships[$n], Individual::getInstance($path[$n - 1], $tree), Individual::getInstance($path[$n + 1], $tree)) . '</div><div style="height: 32px; text-align: start;">' . view('icons/arrow-down') . '</div></div>';
328
-                                $x                     += 2;
328
+                                $x += 2;
329 329
                             } else {
330 330
                                 $table[$x][$y - 1] = '<div style="background:url(' . Theme::theme()
331 331
                                         ->parameter('image-vline') . ') repeat-y center; height: 64px; text-align: center;"><div class="vline-text" style="display: inline-block; width:50%; line-height: 64px;">' . Functions::getRelationshipNameFromPath($relationships[$n], Individual::getInstance($path[$n - 1], $tree), Individual::getInstance($path[$n + 1], $tree)) . '</div><div style="display: inline-block; width:50%; line-height: 64px;">' . view('icons/arrow-down') . '</div></div>';
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
                         case 'par':
338 338
                             if ($n > 2 && preg_match('/son|dau|chi/', $relationships[$n - 2])) {
339 339
                                 $table[$x + 1][$y + 1] = '<div style="background:url(' . $diagonal1 . '); background-position: top right; width: 64px; height: 64px; text-align: center;"><div style="height: 32px; text-align: start;">' . Functions::getRelationshipNameFromPath($relationships[$n], Individual::getInstance($path[$n - 1], $tree), Individual::getInstance($path[$n + 1], $tree)) . '</div><div style="height: 32px; text-align: end;">' . view('icons/arrow-down') . '</div></div>';
340
-                                $x                     += 2;
340
+                                $x += 2;
341 341
                             } else {
342 342
                                 $table[$x][$y + 1] = '<div style="background:url(' . Theme::theme()
343 343
                                         ->parameter('image-vline') . ') repeat-y center; height: 64px; text-align:center; "><div class="vline-text" style="display: inline-block; width: 50%; line-height: 64px;">' . Functions::getRelationshipNameFromPath($relationships[$n], Individual::getInstance($path[$n - 1], $tree), Individual::getInstance($path[$n + 1], $tree)) . '</div><div style="display: inline-block; width: 50%; line-height: 32px">' . view('icons/arrow-up') . '</div></div>';
@@ -478,17 +478,17 @@  discard block
 block discarded – undo
478 478
      */
479 479
     private function oldStyleRelationshipPath(Tree $tree, array $path): array
480 480
     {
481
-        $spouse_codes  = [
481
+        $spouse_codes = [
482 482
             'M' => 'hus',
483 483
             'F' => 'wif',
484 484
             'U' => 'spo',
485 485
         ];
486
-        $parent_codes  = [
486
+        $parent_codes = [
487 487
             'M' => 'fat',
488 488
             'F' => 'mot',
489 489
             'U' => 'par',
490 490
         ];
491
-        $child_codes   = [
491
+        $child_codes = [
492 492
             'M' => 'son',
493 493
             'F' => 'dau',
494 494
             'U' => 'chi',
Please login to merge, or discard this patch.
app/Module.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
     public static function findByName(string $module_name): ?ModuleInterface
309 309
     {
310 310
         return self::all()
311
-            ->filter(function (ModuleInterface $module) use ($module_name): bool {
311
+            ->filter(function (ModuleInterface $module) use ($module_name) : bool {
312 312
                 return $module->isEnabled() && $module->name() === $module_name;
313 313
             })
314 314
             ->first();
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
     public static function findByClass(string $class_name): ?ModuleInterface
325 325
     {
326 326
         return self::all()
327
-            ->filter(function (ModuleInterface $module) use ($class_name): bool {
327
+            ->filter(function (ModuleInterface $module) use ($class_name) : bool {
328 328
                 return $module->isEnabled() && $module instanceof $class_name;
329 329
             })
330 330
             ->first();
Please login to merge, or discard this patch.
app/Http/Controllers/ReportEngineController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
      */
56 56
     public function reportList(Tree $tree, User $user): Response
57 57
     {
58
-        $title   = I18N::translate('Choose a report to run');
58
+        $title = I18N::translate('Choose a report to run');
59 59
 
60 60
         return $this->viewResponse('report-select-page', [
61 61
             'reports' => Module::findByComponent('report', $tree, $user),
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
             }
252 252
         }
253 253
 
254
-        $report_xml =WT_ROOT . 'resources/xml/reports/' . $module->name() . '.xml';
254
+        $report_xml = WT_ROOT . 'resources/xml/reports/' . $module->name() . '.xml';
255 255
 
256 256
 
257 257
         switch ($output) {
Please login to merge, or discard this patch.
app/Http/Controllers/AdminController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -560,7 +560,7 @@
 block discarded – undo
560 560
         $data = array_map(function (string $thumbnail): array {
561 561
             $original = $this->findOriginalFileFromThumbnail($thumbnail);
562 562
 
563
-            $original_url  = route('unused-media-thumbnail', [
563
+            $original_url = route('unused-media-thumbnail', [
564 564
                 'folder' => dirname($original),
565 565
                 'file'   => basename($original),
566 566
                 'w'      => 100,
Please login to merge, or discard this patch.
app/Http/Controllers/BranchesController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
         $sosa = array_search($individual, $ancestors, true);
262 262
         if (is_int($sosa) && $module instanceof RelationshipsChartModule) {
263 263
             $sosa_class = 'search_hit';
264
-            $sosa_html = '<a class="details1 ' . $individual->getBoxStyle() . '" href="' . e($module->chartUrl($individual, ['xref2' => $individuals[1]->xref()])) . '" rel="nofollow" title="' . I18N::translate('Relationships') . '">' .  I18N::number($sosa) . '</a>' . self::sosaGeneration($sosa);
264
+            $sosa_html = '<a class="details1 ' . $individual->getBoxStyle() . '" href="' . e($module->chartUrl($individual, ['xref2' => $individuals[1]->xref()])) . '" rel="nofollow" title="' . I18N::translate('Relationships') . '">' . I18N::number($sosa) . '</a>' . self::sosaGeneration($sosa);
265 265
         } else {
266 266
             $sosa_class = '';
267 267
             $sosa_html  = '';
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
                     $sosa = array_search($spouse, $ancestors, true);
298 298
                     if (is_int($sosa) && $module instanceof RelationshipsChartModule) {
299 299
                         $sosa_class = 'search_hit';
300
-                        $sosa_html  = '<a class="details1 ' . $spouse->getBoxStyle() . '" href="' . e($module->chartUrl($individual, ['xref2' => $individuals[1]->xref()])) . '" rel="nofollow" title="' . I18N::translate('Relationships') . '">' .  I18N::number($sosa) . '</a>' . self::sosaGeneration($sosa);
300
+                        $sosa_html  = '<a class="details1 ' . $spouse->getBoxStyle() . '" href="' . e($module->chartUrl($individual, ['xref2' => $individuals[1]->xref()])) . '" rel="nofollow" title="' . I18N::translate('Relationships') . '">' . I18N::number($sosa) . '</a>' . self::sosaGeneration($sosa);
301 301
                     } else {
302 302
                         $sosa_class = '';
303 303
                         $sosa_html  = '';
Please login to merge, or discard this patch.
app/Functions/FunctionsExport.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -103,11 +103,11 @@
 block discarded – undo
103 103
         $record = GedcomRecord::getInstance('HEAD', $tree);
104 104
         $fact = $record->getFirstFact('COPR');
105 105
         if ($fact instanceof Fact) {
106
-            $COPR = "\n1 COPR " .$fact->value();
106
+            $COPR = "\n1 COPR " . $fact->value();
107 107
         }
108
-        $fact   = $record->getFirstFact('LANG');
108
+        $fact = $record->getFirstFact('LANG');
109 109
         if ($fact instanceof Fact) {
110
-            $LANG = "\n1 LANG " .$fact->value();
110
+            $LANG = "\n1 LANG " . $fact->value();
111 111
         }
112 112
         // Link to actual SUBM/SUBN records, if they exist
113 113
         $subn = DB::table('other')
Please login to merge, or discard this patch.
app/Census/CensusColumnNationality.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
         }
53 53
 
54 54
         // Did we emigrate or naturalise?
55
-        foreach ($individual->facts(['IMMI' ,'EMIG', 'NATU'], true) as $fact) {
55
+        foreach ($individual->facts(['IMMI', 'EMIG', 'NATU'], true) as $fact) {
56 56
             if (Date::compare($fact->date(), $this->date()) <= 0) {
57 57
                 $place = $fact->place()->gedcomName();
58 58
             }
Please login to merge, or discard this patch.
app/Http/Controllers/Admin/LocationController.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -519,7 +519,7 @@
 block discarded – undo
519 519
         // ... and process the differences
520 520
         $inserted = 0;
521 521
         if ($diff->isNotEmpty()) {
522
-            $nextRecordId    = 1 + (int) DB::table('placelocation')->max('pl_id');
522
+            $nextRecordId = 1 + (int) DB::table('placelocation')->max('pl_id');
523 523
 
524 524
             foreach ($diff as $place) {
525 525
                 // For Westminster, London, England, we must also create England and London, England
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -342,9 +342,11 @@
 block discarded – undo
342 342
             'fqpn',
343 343
         ];
344 344
 
345
-        if ($serverfile !== '') {  // first choice is file on server
345
+        if ($serverfile !== '') {
346
+// first choice is file on server
346 347
             $filename = WT_DATA_DIR . 'places/' . $serverfile;
347
-        } elseif ($_FILES['localfile']['error'] === UPLOAD_ERR_OK) { // 2nd choice is local file
348
+        } elseif ($_FILES['localfile']['error'] === UPLOAD_ERR_OK) {
349
+// 2nd choice is local file
348 350
             $filename = $_FILES['localfile']['tmp_name'];
349 351
         }
350 352
 
Please login to merge, or discard this patch.