For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 21 and the first side effect is on line 22.
The PSR-1: Basic Coding Standard recommends that a file should either introduce
new symbols, that is classes, functions, constants or similar, or have side effects.
Side effects are anything that executes logic, like for example printing output,
changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state
of an application. It also promotes a cleaner style of programming and makes your code
less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the
PSR-1.
Loading history...
2
/**
3
* webtrees: online genealogy
4
* Copyright (C) 2018 webtrees development team
5
* This program is free software: you can redistribute it and/or modify
6
* it under the terms of the GNU General Public License as published by
7
* the Free Software Foundation, either version 3 of the License, or
8
* (at your option) any later version.
9
* This program is distributed in the hope that it will be useful,
10
* but WITHOUT ANY WARRANTY; without even the implied warranty of
11
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12
* GNU General Public License for more details.
13
* You should have received a copy of the GNU General Public License
14
* along with this program. If not, see <http://www.gnu.org/licenses/>.
15
*/
16
namespace Fisharebest\Webtrees;
17
18
use Fisharebest\Webtrees\Controller\SearchController;
19
use Fisharebest\Webtrees\Functions\FunctionsPrint;
20
21
define('WT_SCRIPT_NAME', 'search.php');
22
require './includes/session.php';
23
24
$controller = new SearchController;
25
$controller
26
->pageHeader()
27
->addExternalJavascript(WT_AUTOCOMPLETE_JS_URL)
28
->addInlineJavascript('autocomplete();');
29
30
?>
31
<script>
32
function checknames(frm) {
33
action = "<?php echo $controller->action; ?>";
34
if (action === "general") {
35
if (frm.query.value.length<2) {
36
alert("<?php echo I18N::translate('Please enter more than one character.'); ?>");
fisharebest /
webtrees
Veit Olschinski
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.