Issues in logout.php - All Issues - Inspection of "Scrutinizer Auto-Fixes (#1524)" - fisharebest/webtrees - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — master (4a3c5b)

by Greg

created 2017-12-03 10:20 UTC

logout.php (1 issue)

Labels

Severity

Major 1

<?php
/**
 * webtrees: online genealogy
 * Copyright (C) 2017 webtrees development team
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */
namespace Fisharebest\Webtrees;

require 'includes/session.php';

// The current tree (if any).
$gedcom = Session::get('GEDCOM', '');

if (Auth::id()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
	Log::addAuthenticationLog('Logout: ' . Auth::user()->getUserName() . '/' . Auth::user()->getRealName());
	Auth::logout();
	FlashMessages::addMessage(I18N::translate('You have signed out.'), 'info');
}

header('Location: index.php?ged=' . rawurlencode($gedcom));


1			<?php
2			/**
3			* webtrees: online genealogy
4			* Copyright (C) 2017 webtrees development team
5			* This program is free software: you can redistribute it and/or modify
6			* it under the terms of the GNU General Public License as published by
7			* the Free Software Foundation, either version 3 of the License, or
8			* (at your option) any later version.
9			* This program is distributed in the hope that it will be useful,
10			* but WITHOUT ANY WARRANTY; without even the implied warranty of
11			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12			* GNU General Public License for more details.
13			* You should have received a copy of the GNU General Public License
14			* along with this program. If not, see <http://www.gnu.org/licenses/>.
15			*/
16			namespace Fisharebest\Webtrees;
17
18			require 'includes/session.php';
19
20			// The current tree (if any).
21			$gedcom = Session::get('GEDCOM', '');
22
23			if (Auth::id()) {
			0 ignored issues – show Bug Best Practice introduced 2017-12-03 10:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `Fisharebest\Webtrees\Auth::id()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
24			Log::addAuthenticationLog('Logout: ' . Auth::user()->getUserName() . '/' . Auth::user()->getRealName());
25			Auth::logout();
26			FlashMessages::addMessage(I18N::translate('You have signed out.'), 'info');
27			}
28
29			header('Location: index.php?ged=' . rawurlencode($gedcom));
30

fisharebest / webtrees

Branch — master (4a3c5b)

logout.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like