Total Complexity | 69 |
Total Lines | 803 |
Duplicated Lines | 0 % |
Changes | 3 | ||
Bugs | 0 | Features | 0 |
Complex classes like LocationController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use LocationController, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
81 | class LocationController extends AbstractAdminController |
||
82 | { |
||
83 | // Location of files to import |
||
84 | private const PLACES_FOLDER = 'places/'; |
||
85 | |||
86 | /** @var GedcomService */ |
||
87 | private $gedcom_service; |
||
88 | |||
89 | /** @var TreeService */ |
||
90 | private $tree_service; |
||
91 | |||
92 | /** |
||
93 | * Dependency injection. |
||
94 | * |
||
95 | * @param GedcomService $gedcom_service |
||
96 | * @param TreeService $tree_service |
||
97 | */ |
||
98 | public function __construct(GedcomService $gedcom_service, TreeService $tree_service) |
||
99 | { |
||
100 | $this->gedcom_service = $gedcom_service; |
||
101 | $this->tree_service = $tree_service; |
||
102 | } |
||
103 | |||
104 | /** |
||
105 | * @param ServerRequestInterface $request |
||
106 | * |
||
107 | * @return ResponseInterface |
||
108 | */ |
||
109 | public function mapData(ServerRequestInterface $request): ResponseInterface |
||
110 | { |
||
111 | $parent_id = (int) ($request->getQueryParams()['parent_id'] ?? 0); |
||
112 | $hierarchy = $this->getHierarchy($parent_id); |
||
113 | $title = I18N::translate('Geographic data'); |
||
114 | $breadcrumbs = [ |
||
115 | route(ControlPanel::class) => I18N::translate('Control panel'), |
||
116 | route('map-data') => $title, |
||
117 | ]; |
||
118 | |||
119 | foreach ($hierarchy as $row) { |
||
120 | $breadcrumbs[route('map-data', ['parent_id' => $row->pl_id])] = $row->pl_place; |
||
121 | } |
||
122 | $breadcrumbs[] = array_pop($breadcrumbs); |
||
123 | |||
124 | return $this->viewResponse('admin/locations', [ |
||
125 | 'title' => $title, |
||
126 | 'breadcrumbs' => $breadcrumbs, |
||
127 | 'parent_id' => $parent_id, |
||
128 | 'placelist' => $this->getPlaceListLocation($parent_id), |
||
129 | 'tree_titles' => $this->tree_service->titles(), |
||
130 | ]); |
||
131 | } |
||
132 | |||
133 | /** |
||
134 | * @param int $id |
||
135 | * |
||
136 | * @return array |
||
137 | */ |
||
138 | private function getHierarchy(int $id): array |
||
139 | { |
||
140 | $arr = []; |
||
141 | $fqpn = []; |
||
142 | |||
143 | while ($id !== 0) { |
||
144 | $row = DB::table('placelocation') |
||
145 | ->where('pl_id', '=', $id) |
||
146 | ->first(); |
||
147 | |||
148 | $fqpn[] = $row->pl_place; |
||
149 | $row->fqpn = implode(Gedcom::PLACE_SEPARATOR, $fqpn); |
||
150 | $id = (int) $row->pl_parent_id; |
||
151 | $arr[] = $row; |
||
152 | } |
||
153 | |||
154 | return array_reverse($arr); |
||
155 | } |
||
156 | |||
157 | /** |
||
158 | * Find all of the places in the hierarchy |
||
159 | * |
||
160 | * @param int $id |
||
161 | * |
||
162 | * @return stdClass[] |
||
163 | */ |
||
164 | private function getPlaceListLocation(int $id): array |
||
165 | { |
||
166 | // We know the id of the place in the placelocation table, |
||
167 | // now get the id of the same place in the places table |
||
168 | if ($id === 0) { |
||
169 | $fqpn = ''; |
||
170 | } else { |
||
171 | $hierarchy = $this->getHierarchy($id); |
||
172 | $fqpn = ', ' . $hierarchy[0]->fqpn; |
||
173 | } |
||
174 | |||
175 | $rows = DB::table('placelocation') |
||
176 | ->where('pl_parent_id', '=', $id) |
||
177 | ->orderBy('pl_place') |
||
178 | ->get(); |
||
179 | |||
180 | $list = []; |
||
181 | foreach ($rows as $row) { |
||
182 | // Find/count places without co-ordinates |
||
183 | $children = $this->childLocationStatus((int) $row->pl_id); |
||
184 | $active = $this->isLocationActive($row->pl_place . $fqpn); |
||
185 | |||
186 | if (!$active) { |
||
187 | $badge = 'danger'; |
||
188 | } elseif ((int) $children->no_coord > 0) { |
||
189 | $badge = 'warning'; |
||
190 | } elseif ((int) $children->child_count > 0) { |
||
191 | $badge = 'info'; |
||
192 | } else { |
||
193 | $badge = 'secondary'; |
||
194 | } |
||
195 | |||
196 | $row->child_count = (int) $children->child_count; |
||
197 | $row->badge = $badge; |
||
198 | |||
199 | $list[] = $row; |
||
200 | } |
||
201 | |||
202 | return $list; |
||
203 | } |
||
204 | |||
205 | /** |
||
206 | * How many children does place have? How many have co-ordinates? |
||
207 | * |
||
208 | * @param int $parent_id |
||
209 | * |
||
210 | * @return stdClass |
||
211 | */ |
||
212 | private function childLocationStatus(int $parent_id): stdClass |
||
241 | } |
||
242 | |||
243 | /** |
||
244 | * Is a place name used in any tree? |
||
245 | * |
||
246 | * @param string $place_name |
||
247 | * |
||
248 | * @return bool |
||
249 | */ |
||
250 | private function isLocationActive(string $place_name): bool |
||
269 | } |
||
270 | |||
271 | /** |
||
272 | * @param ServerRequestInterface $request |
||
273 | * |
||
274 | * @return ResponseInterface |
||
275 | */ |
||
276 | public function mapDataEdit(ServerRequestInterface $request): ResponseInterface |
||
277 | { |
||
278 | $parent_id = (int) $request->getQueryParams()['parent_id']; |
||
279 | $place_id = (int) $request->getQueryParams()['place_id']; |
||
280 | $hierarchy = $this->getHierarchy($place_id); |
||
281 | $fqpn = $hierarchy === [] ? '' : $hierarchy[0]->fqpn; |
||
282 | $location = new Location($fqpn); |
||
283 | |||
284 | if ($location->id() !== 0) { |
||
285 | $lat = $location->latitude(); |
||
286 | $lng = $location->longitude(); |
||
287 | $id = $place_id; |
||
288 | } else { |
||
289 | $lat = ''; |
||
290 | $lng = ''; |
||
291 | $id = $parent_id; |
||
292 | } |
||
293 | |||
294 | $title = e($location->locationName()); |
||
295 | |||
296 | $breadcrumbs = [ |
||
297 | route(ControlPanel::class) => I18N::translate('Control panel'), |
||
298 | route('map-data') => I18N::translate('Geographic data'), |
||
299 | ]; |
||
300 | |||
301 | foreach ($hierarchy as $row) { |
||
302 | $breadcrumbs[route('map-data', ['parent_id' => $row->pl_id])] = $row->pl_place; |
||
303 | } |
||
304 | |||
305 | if ($place_id === 0) { |
||
306 | $breadcrumbs[] = I18N::translate('Add'); |
||
307 | } else { |
||
308 | $breadcrumbs[] = I18N::translate('Edit'); |
||
309 | $title .= ' — ' . I18N::translate('Edit'); |
||
310 | } |
||
311 | |||
312 | return $this->viewResponse('admin/location-edit', [ |
||
313 | 'breadcrumbs' => $breadcrumbs, |
||
314 | 'title' => $title, |
||
315 | 'location' => $location, |
||
316 | 'place_id' => $place_id, |
||
317 | 'parent_id' => $parent_id, |
||
318 | 'hierarchy' => $hierarchy, |
||
319 | 'lat' => $lat, |
||
320 | 'lng' => $lng, |
||
321 | 'ref' => $id, |
||
322 | 'data' => $this->mapLocationData($id), |
||
323 | ]); |
||
324 | } |
||
325 | |||
326 | /** |
||
327 | * @param int $id |
||
328 | * |
||
329 | * @return array |
||
330 | */ |
||
331 | private function mapLocationData(int $id): array |
||
356 | } |
||
357 | |||
358 | /** |
||
359 | * @param ServerRequestInterface $request |
||
360 | * |
||
361 | * @return ResponseInterface |
||
362 | */ |
||
363 | public function mapDataSave(ServerRequestInterface $request): ResponseInterface |
||
364 | { |
||
365 | $params = (array) $request->getParsedBody(); |
||
366 | |||
367 | $parent_id = (int) $request->getQueryParams()['parent_id']; |
||
368 | $place_id = (int) $request->getQueryParams()['place_id']; |
||
369 | $lat = round($params['new_place_lati'], 5); // 5 decimal places (locate to within about 1 metre) |
||
370 | $lat = ($lat < 0 ? 'S' : 'N') . abs($lat); |
||
371 | $lng = round($params['new_place_long'], 5); |
||
372 | $lng = ($lng < 0 ? 'W' : 'E') . abs($lng); |
||
373 | $hierarchy = $this->getHierarchy($parent_id); |
||
374 | $level = count($hierarchy); |
||
375 | $icon = $params['icon']; |
||
376 | $zoom = (int) $params['new_zoom_factor']; |
||
377 | |||
378 | if ($place_id === 0) { |
||
379 | $place_id = 1 + (int) DB::table('placelocation')->max('pl_id'); |
||
380 | |||
381 | DB::table('placelocation')->insert([ |
||
382 | 'pl_id' => $place_id, |
||
383 | 'pl_parent_id' => $parent_id, |
||
384 | 'pl_level' => $level, |
||
385 | 'pl_place' => $params['new_place_name'], |
||
386 | 'pl_lati' => $lat, |
||
387 | 'pl_long' => $lng, |
||
388 | 'pl_zoom' => $zoom, |
||
389 | 'pl_icon' => $icon, |
||
390 | ]); |
||
391 | } else { |
||
392 | DB::table('placelocation') |
||
393 | ->where('pl_id', '=', $place_id) |
||
394 | ->update([ |
||
395 | 'pl_place' => $params['new_place_name'], |
||
396 | 'pl_lati' => $lat, |
||
397 | 'pl_long' => $lng, |
||
398 | 'pl_zoom' => $zoom, |
||
399 | 'pl_icon' => $icon, |
||
400 | ]); |
||
401 | } |
||
402 | |||
403 | FlashMessages::addMessage( |
||
404 | I18N::translate( |
||
405 | 'The details for “%s” have been updated.', |
||
406 | $params['new_place_name'] |
||
407 | ), |
||
408 | 'success' |
||
409 | ); |
||
410 | |||
411 | $url = route('map-data', ['parent_id' => $parent_id]); |
||
412 | |||
413 | return redirect($url); |
||
414 | } |
||
415 | |||
416 | /** |
||
417 | * @param ServerRequestInterface $request |
||
418 | * |
||
419 | * @return ResponseInterface |
||
420 | */ |
||
421 | public function mapDataDelete(ServerRequestInterface $request): ResponseInterface |
||
450 | } |
||
451 | |||
452 | /** |
||
453 | * @param ServerRequestInterface $request |
||
454 | * |
||
455 | * @return ResponseInterface |
||
456 | */ |
||
457 | public function exportLocations(ServerRequestInterface $request): ResponseInterface |
||
458 | { |
||
459 | $parent_id = (int) $request->getQueryParams()['parent_id']; |
||
460 | $format = $request->getQueryParams()['format']; |
||
461 | $maxlevel = (int) DB::table('placelocation')->max('pl_level'); |
||
462 | $startfqpn = []; |
||
463 | $hierarchy = $this->getHierarchy($parent_id); |
||
464 | |||
465 | // Create the file name |
||
466 | // $hierarchy[0] always holds the full placename |
||
467 | $place_name = $hierarchy === [] ? 'Global' : $hierarchy[0]->fqpn; |
||
468 | $place_name = str_replace(Gedcom::PLACE_SEPARATOR, '-', $place_name); |
||
469 | $filename = 'Places-' . preg_replace('/[^a-zA-Z0-9.-]/', '', $place_name); |
||
470 | |||
471 | // Fill in the place names for the starting conditions |
||
472 | foreach ($hierarchy as $level => $record) { |
||
473 | $startfqpn[$level] = $record->pl_place; |
||
474 | } |
||
475 | $startfqpn = array_pad($startfqpn, $maxlevel + 1, ''); |
||
476 | |||
477 | // Generate an array containing the data to output |
||
478 | $places = []; |
||
479 | $this->buildLevel($parent_id, $startfqpn, $places); |
||
480 | |||
481 | $places = array_filter($places, static function (array $place): bool { |
||
482 | return $place['pl_long'] !== 0.0 && $place['pl_lati'] !== 0.0; |
||
483 | }); |
||
484 | |||
485 | if ($format === 'csv') { |
||
486 | // Create the header line for the output file (always English) |
||
487 | $header = [ |
||
488 | I18N::translate('Level'), |
||
489 | ]; |
||
490 | |||
491 | for ($i = 0; $i <= $maxlevel; $i++) { |
||
492 | $header[] = 'Place' . ($i + 1); |
||
493 | } |
||
494 | |||
495 | $header[] = 'Longitude'; |
||
496 | $header[] = 'Latitude'; |
||
497 | $header[] = 'Zoom'; |
||
498 | $header[] = 'Icon'; |
||
499 | |||
500 | return $this->exportCSV($filename . '.csv', $header, $places); |
||
501 | } |
||
502 | |||
503 | return $this->exportGeoJSON($filename . '.geojson', $places, $maxlevel); |
||
504 | } |
||
505 | |||
506 | /** |
||
507 | * @param int $parent_id |
||
508 | * @param array $placename |
||
509 | * @param array $places |
||
510 | * |
||
511 | * @return void |
||
512 | * @throws Exception |
||
513 | */ |
||
514 | private function buildLevel(int $parent_id, array $placename, array &$places): void |
||
515 | { |
||
516 | $level = array_search('', $placename, true); |
||
517 | |||
518 | $rows = DB::table('placelocation') |
||
519 | ->where('pl_parent_id', '=', $parent_id) |
||
520 | ->orderBy('pl_place') |
||
521 | ->get(); |
||
522 | |||
523 | foreach ($rows as $row) { |
||
524 | $index = (int) $row->pl_id; |
||
525 | $placename[$level] = $row->pl_place; |
||
526 | $places[] = array_merge(['pl_level' => $row->pl_level], $placename, ['pl_long' => $row->pl_long, 'pl_lati' => $row->pl_lati, 'pl_zoom' => $row->pl_zoom, 'pl_icon' => $row->pl_icon]); |
||
527 | $this->buildLevel($index, $placename, $places); |
||
528 | } |
||
529 | } |
||
530 | |||
531 | /** |
||
532 | * @param string $filename |
||
533 | * @param string[] $columns |
||
534 | * @param string[][] $places |
||
535 | * |
||
536 | * @return ResponseInterface |
||
537 | */ |
||
538 | private function exportCSV(string $filename, array $columns, array $places): ResponseInterface |
||
555 | } |
||
556 | |||
557 | /** |
||
558 | * @param string $filename |
||
559 | * @param array $rows |
||
560 | * @param int $maxlevel |
||
561 | * |
||
562 | * @return ResponseInterface |
||
563 | */ |
||
564 | private function exportGeoJSON(string $filename, array $rows, int $maxlevel): ResponseInterface |
||
600 | } |
||
601 | |||
602 | /** |
||
603 | * @param ServerRequestInterface $request |
||
604 | * |
||
605 | * @return ResponseInterface |
||
606 | */ |
||
607 | public function importLocations(ServerRequestInterface $request): ResponseInterface |
||
608 | { |
||
609 | $data_filesystem = $request->getAttribute('filesystem.data'); |
||
610 | assert($data_filesystem instanceof FilesystemInterface); |
||
611 | |||
612 | $data_filesystem_name = $request->getAttribute('filesystem.data.name'); |
||
613 | assert(is_string($data_filesystem_name)); |
||
614 | |||
615 | $parent_id = (int) $request->getQueryParams()['parent_id']; |
||
616 | |||
617 | $files = Collection::make($data_filesystem->listContents('places')) |
||
618 | ->filter(static function (array $metadata): bool { |
||
619 | $extension = strtolower($metadata['extension'] ?? ''); |
||
620 | |||
621 | return $extension === 'csv' || $extension === 'geojson'; |
||
622 | }) |
||
623 | ->map(static function (array $metadata): string { |
||
624 | return $metadata['basename']; |
||
625 | }) |
||
626 | ->sort(); |
||
627 | |||
628 | return $this->viewResponse('admin/map-import-form', [ |
||
629 | 'place_folder' => $data_filesystem_name . self::PLACES_FOLDER, |
||
630 | 'title' => I18N::translate('Import geographic data'), |
||
631 | 'parent_id' => $parent_id, |
||
632 | 'files' => $files, |
||
633 | ]); |
||
634 | } |
||
635 | |||
636 | /** |
||
637 | * This function assumes the input file layout is |
||
638 | * level followed by a variable number of placename fields |
||
639 | * followed by Longitude, Latitude, Zoom & Icon |
||
640 | * |
||
641 | * @param ServerRequestInterface $request |
||
642 | * |
||
643 | * @return ResponseInterface |
||
644 | * @throws Exception |
||
645 | */ |
||
646 | public function importLocationsAction(ServerRequestInterface $request): ResponseInterface |
||
766 | } |
||
767 | |||
768 | /** |
||
769 | * @param ServerRequestInterface $request |
||
770 | * |
||
771 | * @return ResponseInterface |
||
772 | */ |
||
773 | public function importLocationsFromTree(ServerRequestInterface $request): ResponseInterface |
||
884 | } |
||
885 | } |
||
886 |