Completed
Pull Request — master (#3716)
by Greg
30:14 queued 21:16
created
app/Module/TimelineChartModule.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 {
47 47
     use ModuleChartTrait;
48 48
 
49
-    protected const ROUTE_URL  = '/tree/{tree}/timeline-{scale}';
49
+    protected const ROUTE_URL = '/tree/{tree}/timeline-{scale}';
50 50
 
51 51
     // Defaults
52 52
     protected const DEFAULT_SCALE      = 10;
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
         '_TODO',
68 68
         'CHAN',
69 69
     ];
70
-    protected const BHEIGHT   = 30;
70
+    protected const BHEIGHT = 30;
71 71
 
72 72
     // Box height
73 73
 
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 
153 153
         $params = (array) $request->getParsedBody();
154 154
 
155
-        $add  = $params['add'] ?? '';
155
+        $add = $params['add'] ?? '';
156 156
 
157 157
         Auth::checkComponentAccess($this, ModuleChartInterface::class, $tree, $user);
158 158
 
Please login to merge, or discard this patch.
app/Http/RequestHandlers/PendingChangesLogData.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@
 block discarded – undo
112 112
                 '<div class="gedcom-data" dir="ltr">' .
113 113
                 preg_replace_callback(
114 114
                     '/@(' . Gedcom::REGEX_XREF . ')@/',
115
-                    static function (array $match) use ($tree): string {
115
+                    static function (array $match) use ($tree) : string {
116 116
                         $record = Registry::gedcomRecordFactory()->make($match[1], $tree);
117 117
 
118 118
                         return $record ? '<a href="' . e($record->url()) . '">' . $match[0] . '</a>' : $match[0];
Please login to merge, or discard this patch.
app/Module/ChartsBlockModule.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
                             'generations' => 3,
118 118
                             'layout'      => PedigreeChartModule::STYLE_RIGHT,
119 119
                         ]);
120
-                        $content   = view('modules/charts/chart', [
120
+                        $content = view('modules/charts/chart', [
121 121
                             'block_id'  => $block_id,
122 122
                             'chart_url' => $chart_url,
123 123
                             'class'     => 'wt-chart-pedigree',
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
                             'generations' => 2,
139 139
                             'chart_style' => DescendancyChartModule::CHART_STYLE_TREE,
140 140
                         ]);
141
-                        $content   = view('modules/charts/chart', [
141
+                        $content = view('modules/charts/chart', [
142 142
                             'block_id'  => $block_id,
143 143
                             'chart_url' => $chart_url,
144 144
                             'class'     => 'wt-chart-descendants',
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
                     break;
152 152
 
153 153
                 case 'hourglass':
154
-                    $module    = $this->module_service->findByInterface(HourglassChartModule::class)->first();
154
+                    $module = $this->module_service->findByInterface(HourglassChartModule::class)->first();
155 155
 
156 156
                     if ($module instanceof HourglassChartModule) {
157 157
                         $title     = $module->chartTitle($individual);
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
                             'ajax'        => true,
160 160
                             'generations' => 2,
161 161
                         ]);
162
-                        $content   = view('modules/charts/chart', [
162
+                        $content = view('modules/charts/chart', [
163 163
                             'block_id'  => $block_id,
164 164
                             'chart_url' => $chart_url,
165 165
                             'class'     => 'wt-chart-hourglass',
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
         $default_xref     = $gedcomid ?: $PEDIGREE_ROOT_ID;
266 266
 
267 267
         $type = $this->getBlockSetting($block_id, 'type', 'pedigree');
268
-        $xref  = $this->getBlockSetting($block_id, 'pid', $default_xref);
268
+        $xref = $this->getBlockSetting($block_id, 'pid', $default_xref);
269 269
 
270 270
         $charts = [
271 271
             'pedigree'    => I18N::translate('Pedigree'),
Please login to merge, or discard this patch.
app/Http/RequestHandlers/DataFixUpdateAll.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
         /** @var Collection<GedcomRecord> $records */
95 95
         $records = $rows->map(function (stdClass $row) use ($tree): ?GedcomRecord {
96 96
             return $this->data_fix_service->getRecordByType($row->xref, $tree, $row->type);
97
-        })->filter(static function (?GedcomRecord $record) use ($module, $params): bool {
97
+        })->filter(static function (?GedcomRecord $record) use ($module, $params) : bool {
98 98
             return $record instanceof GedcomRecord && !$record->isPendingDeletion() && $module->doesRecordNeedUpdate($record, $params);
99 99
         });
100 100
 
Please login to merge, or discard this patch.
app/Http/RequestHandlers/ManageMediaData.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
                     $create_form = '';
233 233
                     foreach ($media_trees as $media_tree => $media_directory) {
234 234
                         if (str_starts_with($row[0], $media_directory)) {
235
-                            $tmp         = substr($row[0], strlen($media_directory));
235
+                            $tmp = substr($row[0], strlen($media_directory));
236 236
                             $create_form .=
237 237
                                 '<p><a href="#" data-toggle="modal" data-backdrop="static" data-target="#modal-create-media-from-file" data-file="' . e($tmp) . '" data-url="' . e(route(CreateMediaObjectFromFile::class, ['tree' => $media_tree])) . '" onclick="document.getElementById(\'modal-create-media-from-file-form\').action=this.dataset.url; document.getElementById(\'file\').value=this.dataset.file;">' . I18N::translate('Create') . '</a> — ' . e($media_tree) . '<p>';
238 238
                         }
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
327 327
                 // This will work for local filesystems.  For remote filesystems, we will
328 328
                 // need to copy the file locally to work out the image size.
329 329
                 $imgsize = getimagesize(Webtrees::DATA_DIR . $file);
330
-                $html    .= '<dt>' . I18N::translate('Image dimensions') . '</dt>';
330
+                $html .= '<dt>' . I18N::translate('Image dimensions') . '</dt>';
331 331
                 /* I18N: image dimensions, width × height */
332 332
                 $html .= '<dd>' . I18N::translate('%1$s × %2$s pixels', I18N::number($imgsize['0']), I18N::number($imgsize['1'])) . '</dd>';
333 333
             } catch (Throwable $ex) {
Please login to merge, or discard this patch.
app/Http/RequestHandlers/MapDataList.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@
 block discarded – undo
85 85
         }
86 86
 
87 87
         // Request for a non-existent location?
88
-        if ($parent_id !== null &&  $parent->id() === null) {
88
+        if ($parent_id !== null && $parent->id() === null) {
89 89
             return redirect(route(__CLASS__));
90 90
         }
91 91
 
Please login to merge, or discard this patch.
app/Services/UserService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
      */
53 53
     public function find(?int $user_id): ?User
54 54
     {
55
-        return Registry::cache()->array()->remember('user-' . $user_id, static function () use ($user_id): ?User {
55
+        return Registry::cache()->array()->remember('user-' . $user_id, static function () use ($user_id) : ?User {
56 56
             return DB::table('user')
57 57
                 ->where('user_id', '=', $user_id)
58 58
                 ->get()
Please login to merge, or discard this patch.
app/Report/PdfRenderer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -180,7 +180,7 @@
 block discarded – undo
180 180
         $this->headerElements[] = $element;
181 181
     // set default header data
182 182
         if ($done == 0) {
183
-            $this->tcpdf->SetHeaderData('', 0, $element->getValue(), '', array(0,0,0), array(255,255,255));
183
+            $this->tcpdf->SetHeaderData('', 0, $element->getValue(), '', array(0, 0, 0), array(255, 255, 255));
184 184
             $done++;
185 185
         }
186 186
     }
Please login to merge, or discard this patch.
app/Report/TcpdfWrapper.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
         $f = $this->getHeaderFont();
60 60
         $f[2] = 12;
61 61
         $this->setHeaderFont($f);
62
-        $this->header_line_color = array(255,255,255);  // the line cuts through the pedigree chart in landscape mode
62
+        $this->header_line_color = array(255, 255, 255); // the line cuts through the pedigree chart in landscape mode
63 63
     // and no line gives a nicer look
64 64
 
65 65
         if ($this->header_xobjid === false) {
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
         // print header template
112 112
         $xx = 0;
113 113
         if ($this->original_lMargin < 15) {
114
-            $xx = 15;   // approx 5mm (15/72*25.4)  // my Lexmark printer masks ~2 mm at the paper edge
114
+            $xx = 15; // approx 5mm (15/72*25.4)  // my Lexmark printer masks ~2 mm at the paper edge
115 115
                     // only applicable on pedigree charts(?)
116 116
         }
117 117
         $dx = 0;
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,8 @@
 block discarded – undo
99 99
             $this->SetFont($headerfont[0], 'B', $headerfont[2] + 1);
100 100
             $this->SetX($header_x);
101 101
             $this->Cell($cw, $cell_height, $headerdata['title'], 0, 1, 'C', 0, '', 0);
102
-            if ($this->page == 1) {   // allows for a second line, not used (yet)
102
+            if ($this->page == 1) {
103
+// allows for a second line, not used (yet)
103 104
                 // header string
104 105
                 $this->SetFont($headerfont[0], $headerfont[1], $headerfont[2]);
105 106
                 $this->SetX($header_x);
Please login to merge, or discard this patch.