fisharebest / webtrees

app/Date/JewishDate.php

Doc Comments +1 added lines, -1 removed lines

@@ -247,7 +247,7 @@
 	/**
 	 * Which months follows this one? Calendars with leap-months should provide their own implementation.
 	 *
-	 * @return int[]
+	 * @return integer[]
 	 */
 	protected function nextMonth() {
 		if ($this->m == 6 && !$this->isLeapYear()) {

app/Date/CalendarDate.php

Doc Comments +1 added lines, -1 removed lines

@@ -842,7 +842,7 @@
 	/**
 	 * Which months follows this one? Calendars with leap-months should provide their own implementation.
 	 *
-	 * @return int[]
+	 * @return integer[]
 	 */
 	protected function nextMonth() {
 		return [$this->m === $this->calendar->monthsInYear() ? $this->nextYear($this->y) : $this->y, ($this->m % $this->calendar->monthsInYear()) + 1];

app/Module/StoriesModule.php

Braces +3 added lines, -1 removed lines

@@ -381,7 +381,8 @@ 
 						<a href="<?= $individual->getHtmlUrl() ?>#tab-stories">
 							<?= $individual->getFullName() ?>
 						</a>
-						<?php else: ?>
+						<?php else {
+	: ?>
 							<?= $story->xref ?>
 						<?php endif ?>
 						</td>
@@ -410,6 +411,7 @@ 
 	 */
 	private function showList() {
 		global $controller, $WT_TREE;
+}
 
 		$controller = new PageController;
 		$controller

app/Mail.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -16,8 +16,8 @@
 namespace Fisharebest\Webtrees;
 
 use Exception;
-use Swift_Mailer;
 use Swift_MailTransport;
+use Swift_Mailer;
 use Swift_Message;
 use Swift_NullTransport;
 use Swift_Preferences;

app/Theme/CloudsTheme.php

Spacing +1 added lines, -1 removed lines

@@ -106,7 +106,7 @@
 			if (!empty($menu->getSubmenus())) {
 				// Insert a dummy menu / label into the submenu
 				$submenus = $menu->getSubmenus();
-				array_unshift($submenus, new Menu($menu->getLabel(), null, null, [ 'onclick' => 'return false;']));
+				array_unshift($submenus, new Menu($menu->getLabel(), null, null, ['onclick' => 'return false;']));
 				$menu->setSubmenus($submenus);
 			}
 

app/Module/GoogleMapsModule.php

Switch Indentation +18 added lines, -18 removed lines

@@ -1120,24 +1120,24 @@
 										if ($latlongval[$i] == $latlongval[$k]) {
 											$dups++;
 											switch ($dups) {
-												case 1:
-													$marker_number = $curgen . 'L';
-													break;
-												case 2:
-													$marker_number = $curgen . 'R';
-													break;
-												case 3:
-													$marker_number = $curgen . 'Ls';
-													break;
-												case 4:
-													$marker_number = $curgen . 'Rs';
-													break;
-												case 5: //adjust position where markers have same coodinates
-												default:
-													$marker_number = $curgen;
-													$lon[$i] += 0.0025;
-													$lat[$i] += 0.0025;
-													break;
+											case 1:
+												$marker_number = $curgen . 'L';
+												break;
+											case 2:
+												$marker_number = $curgen . 'R';
+												break;
+											case 3:
+												$marker_number = $curgen . 'Ls';
+												break;
+											case 4:
+												$marker_number = $curgen . 'Rs';
+												break;
+											case 5: //adjust position where markers have same coodinates
+											default:
+												$marker_number = $curgen;
+												$lon[$i] += 0.0025;
+												$lat[$i] += 0.0025;
+												break;
 											}
 										}
 									}

Spacing +5 added lines, -5 removed lines

@@ -2235,7 +2235,7 @@ 
 				'place_id' => $place_id,
 			]);
 		} catch (\Exception $ex) {
-			FlashMessages::addMessage(I18N::translate('Location not removed: this location contains sub-locations'),'danger');
+			FlashMessages::addMessage(I18N::translate('Location not removed: this location contains sub-locations'), 'danger');
 		}
 
 		header('Location: module.php?mod=googlemap&mod_action=admin_places&parent_id=' . $parent_id . '&inactive=' . $inactive);
@@ -2582,7 +2582,7 @@ 
 			[0 => I18N::translate('Geographic data')] +
 			$this->placeIdToHierarchy($place_id === 0 ? $parent_id : $place_id);
 		foreach ($hierarchy as $id => $name) {
-				$breadcrumbs += ['module.php?mod=googlemap&mod_action=admin_places&parent_id=' . $id .'&inactive=' . $inactive => Filter::escapeHtml($name)];
+				$breadcrumbs += ['module.php?mod=googlemap&mod_action=admin_places&parent_id=' . $id . '&inactive=' . $inactive => Filter::escapeHtml($name)];
 		}
 		echo Bootstrap4::breadcrumbs($breadcrumbs, $place_id === 0 ? I18N::translate('Add') : I18N::translate('Edit'));
 
@@ -3088,7 +3088,7 @@ 
 			[0 => I18N::translate('Geographic data')] +
 			$this->placeIdToHierarchy($parent_id);
 		foreach (array_slice($hierarchy, 0, -1, true) as $id => $name) {
-				$breadcrumbs += ['module.php?mod=googlemap&mod_action=admin_places&parent_id=' . $id .'&inactive=' . $inactive => Filter::escapeHtml($name)];
+				$breadcrumbs += ['module.php?mod=googlemap&mod_action=admin_places&parent_id=' . $id . '&inactive=' . $inactive => Filter::escapeHtml($name)];
 		}
 		echo Bootstrap4::breadcrumbs($breadcrumbs, end($hierarchy));
 
@@ -3280,7 +3280,7 @@ 
 								<?php endif ?>
 						</td>
 						<td>
-							<?= FontAwesome::linkIcon('edit',  I18N::translate('Edit'), ['href' => 'module.php?mod=googlemap&mod_action=admin_place_edit&action=update&place_id=' . $place['place_id'] . '&parent_id=' . $place['parent_id'], 'class' => 'btn btn-primary']) ?>
+							<?= FontAwesome::linkIcon('edit', I18N::translate('Edit'), ['href' => 'module.php?mod=googlemap&mod_action=admin_place_edit&action=update&place_id=' . $place['place_id'] . '&parent_id=' . $place['parent_id'], 'class' => 'btn btn-primary']) ?>
 						</td>
 						<td>
 							<?php if ($noRows == 0): ?>
@@ -3289,7 +3289,7 @@ 
 									<input type="hidden" name="place_id" value="<?= $place['place_id'] ?>">
 									<input type="hidden" name="inactive" value="<?= $inactive ?>">
 									<button type="submit" class="btn btn-danger">
-										<?= FontAwesome::semanticIcon('delete',  I18N::translate('Delete')) ?>
+										<?= FontAwesome::semanticIcon('delete', I18N::translate('Delete')) ?>
 									</button>
 								</form>
 							<?php else: ?>

app/Database.php

Spacing +2 added lines, -3 removed lines

@@ -85,8 +85,7 @@ 
 		// Create the underlying PDO object
 		self::$pdo = new PDO(
 			(substr($DBHOST, 0, 1) === '/' ?
-				"mysql:unix_socket={$DBHOST};dbname={$DBNAME}" :
-				"mysql:host={$DBHOST};dbname={$DBNAME};port={$DBPORT}"
+				"mysql:unix_socket={$DBHOST};dbname={$DBNAME}" : "mysql:host={$DBHOST};dbname={$DBNAME};port={$DBPORT}"
 			),
 			$DBUSER, $DBPASS,
 			[
@@ -161,7 +160,7 @@ 
 			}
 		}
 		$milliseconds = sprintf('%.3f', $microseconds * 1000);
-		self::$log[] = '<tr><td>' .$stack . '</td><td>' . $query . '</td><td>' . $rows . '</td><td>' . $milliseconds . '</td></tr>';
+		self::$log[] = '<tr><td>' . $stack . '</td><td>' . $query . '</td><td>' . $rows . '</td><td>' . $milliseconds . '</td></tr>';
 	}
 
 	/**

app/Controller/FamilyController.php

Spacing +2 added lines, -2 removed lines

@@ -77,11 +77,11 @@
 			$menu->addSubmenu(new Menu(I18N::translate('Change family members'), 'edit_interface.php?action=changefamily&ged=' . $this->record->getTree()->getNameHtml() . '&xref=' . $this->record->getXref(), 'menu-fam-change'));
 
 			// edit_fam / add child
-			$menu->addSubmenu(new Menu(I18N::translate('Add a child to this family'), 'edit_interface.php?action=add_child_to_family&ged=' . $this->record->getTree()->getNameHtml() .'&xref=' . $this->record->getXref() . '&gender=U', 'menu-fam-addchil'));
+			$menu->addSubmenu(new Menu(I18N::translate('Add a child to this family'), 'edit_interface.php?action=add_child_to_family&ged=' . $this->record->getTree()->getNameHtml() . '&xref=' . $this->record->getXref() . '&gender=U', 'menu-fam-addchil'));
 
 			// edit_fam / reorder_children
 			if ($this->record->getNumberOfChildren() > 1) {
-				$menu->addSubmenu(new Menu(I18N::translate('Re-order children'), 'edit_interface.php?action=reorder_children&ged=' . $this->record->getTree()->getNameHtml() .'&xref=' . $this->record->getXref(), 'menu-fam-orderchil'));
+				$menu->addSubmenu(new Menu(I18N::translate('Re-order children'), 'edit_interface.php?action=reorder_children&ged=' . $this->record->getTree()->getNameHtml() . '&xref=' . $this->record->getXref(), 'menu-fam-orderchil'));
 			}
 
 			// delete

app/Functions/FunctionsPrintLists.php

Spacing +3 added lines, -3 removed lines

@@ -1080,7 +1080,7 @@ 
 			"SELECT CONCAT(l_to, '@', l_file), COUNT(*) FROM `##sources` JOIN `##link` ON l_from = s_id AND l_file = s_file AND l_type = 'NOTE' GROUP BY l_to, l_file"
 		)->fetchAssoc();
 
-		$html     = '';
+		$html = '';
 		$html .= '<table ' . Datatables::noteTableAttributes() . '><thead><tr>';
 		$html .= '<th>' . I18N::translate('Title') . '</th>';
 		$html .= '<th>' . I18N::translate('Individuals') . '</th>';
@@ -1146,7 +1146,7 @@ 
 		)->fetchAssoc();
 
 		$html = '';
-		$html .= '<table ' . Datatables::repositoryTableAttributes() . '><thead><tr>';		$html .= '<th>' . I18N::translate('Repository name') . '</th>';
+		$html .= '<table ' . Datatables::repositoryTableAttributes() . '><thead><tr>'; $html .= '<th>' . I18N::translate('Repository name') . '</th>';
 		$html .= '<th>' . I18N::translate('Sources') . '</th>';
 		$html .= '<th>' . I18N::translate('Last change') . '</th>';
 		$html .= '<th>' . I18N::translate('Delete') . '</th>';
@@ -1573,7 +1573,7 @@ 
 					if ($endjd === $startjd) {
 						$html .= I18N::translate('No events exist for tomorrow.');
 					} else {
-						$html .=  /* I18N: translation for %s==1 is unused; it is translated separately as “tomorrow” */ I18N::plural('No events exist for the next %s day.', 'No events exist for the next %s days.', $endjd - $startjd + 1, I18N::number($endjd - $startjd + 1));
+						$html .= /* I18N: translation for %s==1 is unused; it is translated separately as “tomorrow” */ I18N::plural('No events exist for the next %s day.', 'No events exist for the next %s days.', $endjd - $startjd + 1, I18N::number($endjd - $startjd + 1));
 					}
 				} else {
 					if ($endjd === $startjd) {