| Conditions | 12 |
| Paths | 32 |
| Total Lines | 177 |
| Code Lines | 114 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 197 | public function data(ServerRequestInterface $request, DatatablesService $datatables_service): ResponseInterface |
||
| 198 | { |
||
| 199 | $files = $request->getQueryParams()['files']; // local|external|unused |
||
| 200 | $search = $request->getQueryParams()['search']; |
||
| 201 | $search = $search['value']; |
||
| 202 | $start = (int) $request->getQueryParams()['start']; |
||
| 203 | $length = (int) $request->getQueryParams()['length']; |
||
| 204 | |||
| 205 | // Files within this folder |
||
| 206 | $media_folder = $request->getQueryParams()['media_folder']; |
||
| 207 | |||
| 208 | // subfolders within $media_path |
||
| 209 | $subfolders = $request->getQueryParams()['subfolders']; // include|exclude |
||
| 210 | |||
| 211 | $search_columns = ['multimedia_file_refn', 'descriptive_title']; |
||
| 212 | |||
| 213 | $sort_columns = [ |
||
| 214 | 0 => 'multimedia_file_refn', |
||
| 215 | 2 => new Expression('descriptive_title || multimedia_file_refn'), |
||
| 216 | ]; |
||
| 217 | |||
| 218 | switch ($files) { |
||
| 219 | case 'local': |
||
| 220 | $query = DB::table('media_file') |
||
| 221 | ->join('media', static function (JoinClause $join): void { |
||
| 222 | $join |
||
| 223 | ->on('media.m_file', '=', 'media_file.m_file') |
||
| 224 | ->on('media.m_id', '=', 'media_file.m_id'); |
||
| 225 | }) |
||
| 226 | ->join('gedcom_setting', 'gedcom_id', '=', 'media.m_file') |
||
| 227 | ->where('setting_name', '=', 'MEDIA_DIRECTORY') |
||
| 228 | ->where('multimedia_file_refn', 'NOT LIKE', 'http://%') |
||
| 229 | ->where('multimedia_file_refn', 'NOT LIKE', 'https://%') |
||
| 230 | ->select(['media.*', 'multimedia_file_refn', 'descriptive_title']); |
||
| 231 | |||
| 232 | $query->where(new Expression('setting_value || multimedia_file_refn'), 'LIKE', $media_folder . '%'); |
||
| 233 | |||
| 234 | if ($subfolders === 'exclude') { |
||
| 235 | $query->where(new Expression('setting_value || multimedia_file_refn'), 'NOT LIKE', $media_folder . '%/%'); |
||
| 236 | } |
||
| 237 | |||
| 238 | return $datatables_service->handle($request, $query, $search_columns, $sort_columns, function (stdClass $row): array { |
||
| 239 | /** @var Media $media */ |
||
| 240 | $media = Media::rowMapper()($row); |
||
| 241 | |||
| 242 | $media_files = $media->mediaFiles() |
||
| 243 | ->filter(static function (MediaFile $media_file) use ($row): bool { |
||
| 244 | return $media_file->filename() == $row->multimedia_file_refn; |
||
| 245 | }) |
||
| 246 | ->map(static function (MediaFile $media_file): string { |
||
| 247 | return $media_file->displayImage(150, 150, '', []); |
||
| 248 | }) |
||
| 249 | ->implode(''); |
||
| 250 | |||
| 251 | return [ |
||
| 252 | $row->multimedia_file_refn, |
||
| 253 | $media_files, |
||
| 254 | $this->mediaObjectInfo($media), |
||
| 255 | ]; |
||
| 256 | }); |
||
| 257 | |||
| 258 | case 'external': |
||
| 259 | $query = DB::table('media_file') |
||
| 260 | ->join('media', static function (JoinClause $join): void { |
||
| 261 | $join |
||
| 262 | ->on('media.m_file', '=', 'media_file.m_file') |
||
| 263 | ->on('media.m_id', '=', 'media_file.m_id'); |
||
| 264 | }) |
||
| 265 | ->where(static function (Builder $query): void { |
||
| 266 | $query |
||
| 267 | ->where('multimedia_file_refn', 'LIKE', 'http://%') |
||
| 268 | ->orWhere('multimedia_file_refn', 'LIKE', 'https://%'); |
||
| 269 | }) |
||
| 270 | ->select(['media.*', 'multimedia_file_refn', 'descriptive_title']); |
||
| 271 | |||
| 272 | return $datatables_service->handle($request, $query, $search_columns, $sort_columns, function (stdClass $row): array { |
||
| 273 | /** @var Media $media */ |
||
| 274 | $media = Media::rowMapper()($row); |
||
| 275 | |||
| 276 | $media_files = $media->mediaFiles() |
||
| 277 | ->filter(static function (MediaFile $media_file) use ($row): bool { |
||
| 278 | return $media_file->filename() === $row->multimedia_file_refn; |
||
| 279 | }) |
||
| 280 | ->map(static function (MediaFile $media_file): string { |
||
| 281 | return $media_file->displayImage(150, 150, '', []); |
||
| 282 | }) |
||
| 283 | ->implode(''); |
||
| 284 | |||
| 285 | return [ |
||
| 286 | $row->multimedia_file_refn, |
||
| 287 | $media_files, |
||
| 288 | $this->mediaObjectInfo($media), |
||
| 289 | ]; |
||
| 290 | }); |
||
| 291 | |||
| 292 | case 'unused': |
||
| 293 | // Which trees use which media folder? |
||
| 294 | $media_trees = DB::table('gedcom') |
||
| 295 | ->join('gedcom_setting', 'gedcom_setting.gedcom_id', '=', 'gedcom.gedcom_id') |
||
| 296 | ->where('setting_name', '=', 'MEDIA_DIRECTORY') |
||
| 297 | ->where('gedcom.gedcom_id', '>', 0) |
||
| 298 | ->pluck('setting_value', 'gedcom_name'); |
||
| 299 | |||
| 300 | $disk_files = $this->allDiskFiles($media_folder, $subfolders); |
||
| 301 | $db_files = $this->allMediaFiles($media_folder, $subfolders); |
||
| 302 | |||
| 303 | // All unused files |
||
| 304 | $unused_files = array_diff($disk_files, $db_files); |
||
| 305 | $recordsTotal = count($unused_files); |
||
| 306 | |||
| 307 | // Filter unused files |
||
| 308 | if ($search) { |
||
| 309 | $unused_files = array_filter($unused_files, static function (string $x) use ($search): bool { |
||
| 310 | return strpos($x, $search) !== false; |
||
| 311 | }); |
||
| 312 | } |
||
| 313 | $recordsFiltered = count($unused_files); |
||
| 314 | |||
| 315 | // Sort files - only option is column 0 |
||
| 316 | sort($unused_files); |
||
| 317 | $order = $request->getQueryParams()['order']; |
||
| 318 | if ($order && $order[0]['dir'] === 'desc') { |
||
| 319 | $unused_files = array_reverse($unused_files); |
||
| 320 | } |
||
| 321 | |||
| 322 | // Paginate unused files |
||
| 323 | $unused_files = array_slice($unused_files, $start, $length); |
||
| 324 | |||
| 325 | $data = []; |
||
| 326 | foreach ($unused_files as $unused_file) { |
||
| 327 | $imgsize = getimagesize(WT_DATA_DIR . $media_folder . $unused_file); |
||
| 328 | // We can’t create a URL (not in public_html) or use the media firewall (no such object) |
||
| 329 | if ($imgsize === false) { |
||
| 330 | $img = '-'; |
||
| 331 | } else { |
||
| 332 | $url = route('unused-media-thumbnail', [ |
||
| 333 | 'folder' => $media_folder, |
||
| 334 | 'file' => $unused_file, |
||
| 335 | 'w' => 100, |
||
| 336 | 'h' => 100, |
||
| 337 | ]); |
||
| 338 | $img = '<img src="' . e($url) . '">'; |
||
| 339 | } |
||
| 340 | |||
| 341 | // Form to create new media object in each tree |
||
| 342 | $create_form = ''; |
||
| 343 | foreach ($media_trees as $media_tree => $media_directory) { |
||
| 344 | if (Str::startsWith($media_folder . $unused_file, $media_directory)) { |
||
| 345 | $tmp = substr($media_folder . $unused_file, strlen($media_directory)); |
||
| 346 | $create_form .= |
||
| 347 | '<p><a href="#" data-toggle="modal" data-target="#modal-create-media-from-file" data-file="' . e($tmp) . '" data-tree="' . e($media_tree) . '" onclick="document.getElementById(\'file\').value=this.dataset.file; document.getElementById(\'ged\').value=this.dataset.tree;">' . I18N::translate('Create') . '</a> — ' . e($media_tree) . '<p>'; |
||
| 348 | } |
||
| 349 | } |
||
| 350 | |||
| 351 | $delete_link = '<p><a data-confirm="' . I18N::translate('Are you sure you want to delete “%s”?', e($unused_file)) . '" data-url="' . e(route('admin-media-delete', [ |
||
| 352 | 'file' => $unused_file, |
||
| 353 | 'folder' => $media_folder, |
||
| 354 | ])) . '" onclick="if (confirm(this.dataset.confirm)) jQuery.post(this.dataset.url, function (){document.location.reload();})" href="#">' . I18N::translate('Delete') . '</a></p>'; |
||
| 355 | |||
| 356 | $data[] = [ |
||
| 357 | $this->mediaFileInfo($media_folder, $unused_file) . $delete_link, |
||
| 358 | $img, |
||
| 359 | $create_form, |
||
| 360 | ]; |
||
| 361 | } |
||
| 362 | break; |
||
| 363 | |||
| 364 | default: |
||
| 365 | throw new BadRequestHttpException(); |
||
| 366 | } |
||
| 367 | |||
| 368 | // See http://www.datatables.net/usage/server-side |
||
| 369 | return response([ |
||
| 370 | 'draw' => (int) $request->getQueryParams()['draw'], |
||
| 371 | 'recordsTotal' => $recordsTotal, |
||
| 372 | 'recordsFiltered' => $recordsFiltered, |
||
| 373 | 'data' => $data, |
||
| 374 | ]); |
||
| 579 |