Conditions | 17 |
Paths | 17 |
Total Lines | 108 |
Code Lines | 84 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
174 | public function handle(ServerRequestInterface $request): ResponseInterface |
||
175 | { |
||
176 | $topic = $request->getAttribute('topic'); |
||
177 | |||
178 | switch ($topic) { |
||
179 | case 'DATE': |
||
180 | switch ($this->dmyOrder()) { |
||
181 | case 'YMD': |
||
182 | $date_shortcuts = array_merge(self::DATE_SHORTCUTS, self::YMD_SHORTCUTS); |
||
183 | break; |
||
184 | case 'MDY': |
||
185 | $date_shortcuts = array_merge(self::DATE_SHORTCUTS, self::MDY_SHORTCUTS); |
||
186 | break; |
||
187 | case 'DMY': |
||
188 | default: |
||
189 | $date_shortcuts = array_merge(self::DATE_SHORTCUTS, self::DMY_SHORTCUTS); |
||
190 | break; |
||
191 | } |
||
192 | |||
193 | $title = I18N::translate('Date'); |
||
194 | $text = view('help/date', [ |
||
195 | 'date_dates' => $this->formatDates(array_keys($date_shortcuts)), |
||
196 | 'date_shortcuts' => $date_shortcuts, |
||
197 | 'date_period_dates' => $this->formatDates(array_keys(self::DATE_PERIOD_SHORTCUTS)), |
||
198 | 'date_period_shortcuts' => self::DATE_PERIOD_SHORTCUTS, |
||
199 | 'date_range_dates' => $this->formatDates(array_keys(self::DATE_RANGE_SHORTCUTS)), |
||
200 | 'date_range_shortcuts' => self::DATE_RANGE_SHORTCUTS, |
||
201 | 'french_dates' => $this->formatDates(self::FRENCH_DATES), |
||
202 | 'hijri_dates' => $this->formatDates(self::HIJRI_DATES), |
||
203 | 'jewish_dates' => $this->formatDates(self::JEWISH_DATES), |
||
204 | 'julian_dates' => $this->formatDates(self::JULIAN_DATES), |
||
205 | ]); |
||
206 | break; |
||
207 | |||
208 | case 'NAME': |
||
209 | $title = I18N::translate('Name'); |
||
210 | $text = view('help/name'); |
||
211 | break; |
||
212 | |||
213 | case 'SURN': |
||
214 | $title = I18N::translate('Surname'); |
||
215 | $text = view('help/surname'); |
||
216 | break; |
||
217 | |||
218 | case 'OBJE': |
||
219 | $title = I18N::translate('Media object'); |
||
220 | $text = view('help/media-object'); |
||
221 | break; |
||
222 | |||
223 | case 'PLAC': |
||
224 | $title = I18N::translate('Place'); |
||
225 | $text = view('help/place'); |
||
226 | break; |
||
227 | |||
228 | case 'RESN': |
||
229 | $title = I18N::translate('Restriction'); |
||
230 | $text = view('help/restriction'); |
||
231 | break; |
||
232 | |||
233 | case 'ROMN': |
||
234 | $title = I18N::translate('Romanized'); |
||
235 | $text = view('help/romanized'); |
||
236 | break; |
||
237 | |||
238 | case '_HEB': |
||
239 | $title = I18N::translate('Hebrew'); |
||
240 | $text = view('help/hebrew'); |
||
241 | break; |
||
242 | |||
243 | case 'edit_SOUR_EVEN': |
||
244 | $title = I18N::translate('Associate events with this source'); |
||
245 | $text = view('help/source-events'); |
||
246 | break; |
||
247 | |||
248 | case 'pending_changes': |
||
249 | $title = I18N::translate('Pending changes'); |
||
250 | $text = view('help/pending-changes', [ |
||
251 | 'is_admin' => Auth::isAdmin(), |
||
252 | ]); |
||
253 | break; |
||
254 | |||
255 | case 'relationship-privacy': |
||
256 | $title = I18N::translate('Restrict to immediate family'); |
||
257 | $text = view('help/relationship-privacy'); |
||
258 | break; |
||
259 | |||
260 | case 'iso-8859-1': |
||
261 | $title = I18N::translate('Convert from UTF-8 to ISO-8859-1'); |
||
262 | $text = view('help/iso-8859-1'); |
||
263 | break; |
||
264 | |||
265 | case 'zip-gedcom': |
||
266 | $title = I18N::translate('Compress the GEDCOM file'); |
||
267 | $text = view('help/zip-gedcom'); |
||
268 | break; |
||
269 | |||
270 | default: |
||
271 | $title = I18N::translate('Help'); |
||
272 | $text = I18N::translate('The help text has not been written for this item.'); |
||
273 | break; |
||
274 | } |
||
275 | |||
276 | $html = view('modals/help', [ |
||
277 | 'title' => $title, |
||
278 | 'text' => $text, |
||
279 | ]); |
||
280 | |||
281 | return response($html); |
||
282 | } |
||
316 |