fisharebest /
webtrees
| Conditions | 9 |
| Paths | 192 |
| Total Lines | 78 |
| Code Lines | 49 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 55 | public function createSourceAction(ServerRequestInterface $request): ResponseInterface |
||
| 56 | { |
||
| 57 | $tree = $request->getAttribute('tree'); |
||
| 58 | assert($tree instanceof Tree); |
||
| 59 | |||
| 60 | $params = $request->getParsedBody(); |
||
| 61 | $title = $params['source-title']; |
||
| 62 | $abbreviation = $params['source-abbreviation']; |
||
| 63 | $author = $params['source-author']; |
||
| 64 | $publication = $params['source-publication']; |
||
| 65 | $repository = $params['source-repository']; |
||
| 66 | $call_number = $params['source-call-number']; |
||
| 67 | $text = $params['source-text']; |
||
| 68 | $privacy_restriction = $params['privacy-restriction']; |
||
| 69 | $edit_restriction = $params['edit-restriction']; |
||
| 70 | |||
| 71 | // Fix whitespace |
||
| 72 | $title = trim(preg_replace('/\s+/', ' ', $title)); |
||
| 73 | $abbreviation = trim(preg_replace('/\s+/', ' ', $abbreviation)); |
||
| 74 | $author = trim(preg_replace('/\s+/', ' ', $author)); |
||
| 75 | $publication = trim(preg_replace('/\s+/', ' ', $publication)); |
||
| 76 | $repository = trim(preg_replace('/\s+/', ' ', $repository)); |
||
| 77 | $call_number = trim(preg_replace('/\s+/', ' ', $call_number)); |
||
| 78 | |||
| 79 | // Convert line endings to GEDDCOM continuations |
||
| 80 | $text = str_replace([ |
||
| 81 | "\r\n", |
||
| 82 | "\r", |
||
| 83 | "\n", |
||
| 84 | ], "\n1 CONT ", $text); |
||
| 85 | |||
| 86 | $gedcom = "0 @@ SOUR\n\n1 TITL " . $title; |
||
| 87 | |||
| 88 | if ($abbreviation !== '') { |
||
| 89 | $gedcom .= "\n1 ABBR " . $abbreviation; |
||
| 90 | } |
||
| 91 | |||
| 92 | if ($author !== '') { |
||
| 93 | $gedcom .= "\n1 AUTH " . $author; |
||
| 94 | } |
||
| 95 | |||
| 96 | if ($publication !== '') { |
||
| 97 | $gedcom .= "\n1 PUBL " . $publication; |
||
| 98 | } |
||
| 99 | |||
| 100 | if ($text !== '') { |
||
| 101 | $gedcom .= "\n1 TEXT " . $text; |
||
| 102 | } |
||
| 103 | |||
| 104 | if ($repository !== '') { |
||
| 105 | $gedcom .= "\n1 REPO @" . $repository . '@'; |
||
| 106 | |||
| 107 | if ($call_number !== '') { |
||
| 108 | $gedcom .= "\n2 CALN " . $call_number; |
||
| 109 | } |
||
| 110 | } |
||
| 111 | |||
| 112 | if (in_array($privacy_restriction, ['none', 'privacy', 'confidential'], true)) { |
||
| 113 | $gedcom .= "\n1 RESN " . $privacy_restriction; |
||
| 114 | } |
||
| 115 | |||
| 116 | if ($edit_restriction === 'locked') { |
||
| 117 | $gedcom .= "\n1 RESN " . $edit_restriction; |
||
| 118 | } |
||
| 119 | |||
| 120 | $record = $tree->createRecord($gedcom); |
||
| 121 | |||
| 122 | // id and text are for select2 / autocomplete |
||
| 123 | // html is for interactive modals |
||
| 124 | return response([ |
||
| 125 | 'id' => $record->xref(), |
||
| 126 | 'text' => view('selects/source', [ |
||
| 127 | 'source' => $record, |
||
| 128 | ]), |
||
| 129 | 'html' => view('modals/record-created', [ |
||
| 130 | 'title' => I18N::translate('The source has been created'), |
||
| 131 | 'name' => $record->fullName(), |
||
| 132 | 'url' => $record->url(), |
||
| 133 | ]), |
||
| 137 |
