Fisharebest\Webtrees\Http\Middleware\UpdateDatabaseSchema::process()

Complexity

Conditions	6
Paths	24

Size

Total Lines	55
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $this->migration_service
            ->updateSchema('\Fisharebest\Webtrees\Schema', 'WT_SCHEMA_VERSION', Webtrees::SCHEMA_VERSION);

        $platform = DB::getDBALConnection()->getDatabasePlatform();
        $platform->registerDoctrineTypeMapping(dbType: 'enum', doctrineType: 'string');

        $schema_manager = DB::getDBALConnection()->createSchemaManager();
        $comparator     = $schema_manager->createComparator();
        $source         = $schema_manager->introspectSchema();
        $target         = WebtreesSchema::schema();

        // doctrine/dbal 4.0 does not have the concept of "saveSQL"
        foreach ($source->getTables() as $table) {
            if (!$target->hasTable($table->getName())) {
                $source->dropTable($table->getName());
            }
        }

        $schema_diff = $comparator->compareSchemas(oldSchema: $source, newSchema: $target);
        $queries     = $platform->getAlterSchemaSQL(diff: $schema_diff);

        // SQLite, PostgreSQL and SQL-Server all support DDL in transactions
        if (DB::getDBALConnection()->getDriver() instanceof AbstractMySQLDriver) {
            $queries = [
                'SET FOREIGN_KEY_CHECKS := 0',
                ...$queries,
                'SET FOREIGN_KEY_CHECKS := 1',
            ];
        } else {
            $queries = [
                'START TRANSACTION',
                ...$queries,
                'COMMIT',
            ];
        }


        foreach ($queries as $query) {
            echo '<p>', $query, ';';

Are you sure $query of type array|string can be used in echo?

            $t = microtime(true);

            try {
                DB::getDBALConnection()->executeStatement(sql: $query);

It seems like $query can also be of type array; however, parameter $sql of Doctrine\DBAL\Connection::executeStatement() does only seem to accept string, maybe add an additional type check?

                echo ' /* ', (int) (1000.8 * (microtime(true) - $t)), 'ms */';
            } catch (Throwable $ex) {
                echo ' <span style="color:red">', $ex->getMessage(), '</span>';
            }
            echo '</p>';
        }

        exit;

Using exit here is not recommended.

        return $handler->handle($request);

return $handler->handle($request) is not reachable.

    }