Completed
Push — develop ( 0fd37b...5cb4f0 )
by Greg
13:35
created
app/Stats.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5362,7 +5362,7 @@
 block discarded – undo
5362 5362
 	/**
5363 5363
 	 * Find common surnames.
5364 5364
 	 *
5365
-	 * @return string
5365
+	 * @return integer|null
5366 5366
 	 */
5367 5367
 	public function getCommonSurname() {
5368 5368
 		$surnames = array_keys(FunctionsDb::getTopSurnames($this->tree->getTreeId(), 1, 1));
Please login to merge, or discard this patch.
calendar.php 1 patch
Upper-Lower-Casing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -67,14 +67,14 @@
 block discarded – undo
67 67
 	if (strlen($match[1]) > strlen($match[2])) {
68 68
 		$match[2] = substr($match[1], 0, strlen($match[1]) - strlen($match[2])) . $match[2];
69 69
 	}
70
-	$ged_date = new Date("FROM {$cal} {$match[1]} TO {$cal} {$match[2]}");
70
+	$ged_date = new Date("from {$cal} {$match[1]} TO {$cal} {$match[2]}");
71 71
 	$view     = 'year';
72 72
 } else {
73 73
 	// advanced-year "decade/century wildcard"
74 74
 	if (preg_match('/^(\d+)(\?+)$/', $year, $match)) {
75 75
 		$y1       = $match[1] . str_replace('?', '0', $match[2]);
76 76
 		$y2       = $match[1] . str_replace('?', '9', $match[2]);
77
-		$ged_date = new Date("FROM {$cal} {$y1} TO {$cal} {$y2}");
77
+		$ged_date = new Date("from {$cal} {$y1} TO {$cal} {$y2}");
78 78
 		$view     = 'year';
79 79
 	} else {
80 80
 		if ($year < 0) {
Please login to merge, or discard this patch.
app/Functions/FunctionsDb.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -647,7 +647,7 @@  discard block
 block discarded – undo
647 647
 	 * @param int $min The number of times a surname must occur before it is added to the array
648 648
 	 * @param Tree $tree
649 649
 	 *
650
-	 * @return int[]
650
+	 * @return string[]
651 651
 	 */
652 652
 	public static function getCommonSurnames($min, Tree $tree) {
653 653
 		return self::getTopSurnames($tree->getTreeId(), $min, 0);
@@ -660,7 +660,7 @@  discard block
 block discarded – undo
660 660
 	 * @param int $min only fetch surnames occuring this many times
661 661
 	 * @param int $max only fetch this number of surnames (0=all)
662 662
 	 *
663
-	 * @return int[]
663
+	 * @return string[]
664 664
 	 */
665 665
 	public static function getTopSurnames($ged_id, $min, $max) {
666 666
 		// Use n_surn, rather than n_surname, as it is used to generate URLs for
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,6 @@
 block discarded – undo
26 26
 use Fisharebest\Webtrees\Date\JulianDate;
27 27
 use Fisharebest\Webtrees\Fact;
28 28
 use Fisharebest\Webtrees\Family;
29
-use Fisharebest\Webtrees\Filter;
30 29
 use Fisharebest\Webtrees\I18N;
31 30
 use Fisharebest\Webtrees\Individual;
32 31
 use Fisharebest\Webtrees\Note;
Please login to merge, or discard this patch.
app/Family.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 	/**
102 102
 	 * Get the male (or first female) partner of the family
103 103
 	 *
104
-	 * @param $access_level int|null
104
+	 * @param integer $access_level int|null
105 105
 	 *
106 106
 	 * @return Individual|null
107 107
 	 */
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 	/**
119 119
 	 * Get the female (or second male) partner of the family
120 120
 	 *
121
-	 * @param $access_level int|null
121
+	 * @param integer $access_level int|null
122 122
 	 *
123 123
 	 * @return Individual|null
124 124
 	 */
Please login to merge, or discard this patch.
admin_users.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -770,13 +770,15 @@
 block discarded – undo
770 770
 		<p>
771 771
 		<?php if ($ucnt): ?>
772 772
 			<input type="submit" value="<?= I18N::translate('delete') ?>">
773
-			<?php else: ?>
773
+			<?php else {
774
+	: ?>
774 775
 			<?= I18N::translate('Nothing found to cleanup') ?>
775 776
 			<?php endif ?>
776 777
 		</p>
777 778
 	</form>
778 779
 	<?php
779 780
 	break;
781
+}
780 782
 
781 783
 case 'cleanup2':
782 784
 	foreach (User::all() as $user) {
Please login to merge, or discard this patch.
app/Module/FamilyNavigatorModule.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -176,7 +176,7 @@
 block discarded – undo
176 176
 	/**
177 177
 	 * Format an individual.
178 178
 	 *
179
-	 * @param      $person
179
+	 * @param      Individual|null $person
180 180
 	 * @param bool $showUnknown
181 181
 	 *
182 182
 	 * @return string
Please login to merge, or discard this patch.
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -143,7 +143,8 @@  discard block
 block discarded – undo
143 143
 							<div class="small">
144 144
 								<?= $spouse->getLifeSpan() ?>
145 145
 							</div>
146
-							<?php else: ?>
146
+							<?php else {
147
+	: ?>
147 148
 								<?= $spouse->getFullName() ?>
148 149
 							<?php endif ?>
149 150
 						</td>
@@ -153,6 +154,7 @@  discard block
 block discarded – undo
153 154
 
154 155
 				foreach ($family->getChildren() as $child) {
155 156
 					$icon = $individual === $child ? '<i class="icon-selected"></i>' : '';
157
+}
156 158
 					$menu = new Menu($icon . Functions::getCloseRelationshipName($individual, $child));
157 159
 					$menu->addSubmenu(new Menu($this->getFamily($child)));
158 160
 					?>
@@ -170,7 +172,8 @@  discard block
 block discarded – undo
170 172
 							<div class="small">
171 173
 								<?= $child->getLifeSpan() ?>
172 174
 							</div>
173
-							<?php else: ?>
175
+							<?php else {
176
+	: ?>
174 177
 								<?= $child->getFullName() ?>
175 178
 							<?php endif ?>
176 179
 						</td>
@@ -194,6 +197,7 @@  discard block
 block discarded – undo
194 197
 	private function getHTML($person, $showUnknown = false) {
195 198
 		if ($person instanceof Individual) {
196 199
 			return sprintf(self::LNK, e($person->url()), $person->getFullName());
200
+}
197 201
 		} elseif ($showUnknown) {
198 202
 			return sprintf(self::MSG, I18N::translate('unknown'));
199 203
 		} else {
Please login to merge, or discard this patch.
app/Date/JewishDate.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -247,7 +247,7 @@
 block discarded – undo
247 247
 	/**
248 248
 	 * Which months follows this one? Calendars with leap-months should provide their own implementation.
249 249
 	 *
250
-	 * @return int[]
250
+	 * @return integer[]
251 251
 	 */
252 252
 	protected function nextMonth() {
253 253
 		if ($this->m == 6 && !$this->isLeapYear()) {
Please login to merge, or discard this patch.
app/Date/CalendarDate.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -842,7 +842,7 @@
 block discarded – undo
842 842
 	/**
843 843
 	 * Which months follows this one? Calendars with leap-months should provide their own implementation.
844 844
 	 *
845
-	 * @return int[]
845
+	 * @return integer[]
846 846
 	 */
847 847
 	protected function nextMonth() {
848 848
 		return [$this->m === $this->calendar->monthsInYear() ? $this->nextYear($this->y) : $this->y, ($this->m % $this->calendar->monthsInYear()) + 1];
Please login to merge, or discard this patch.
app/Mail.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@
 block discarded – undo
16 16
 namespace Fisharebest\Webtrees;
17 17
 
18 18
 use Exception;
19
-use Swift_Mailer;
20 19
 use Swift_MailTransport;
20
+use Swift_Mailer;
21 21
 use Swift_Message;
22 22
 use Swift_NullTransport;
23 23
 use Swift_Preferences;
Please login to merge, or discard this patch.