Passed
Push — analysis-a651WW ( 2809e3 )
by Greg
16:23
created
app/Report/RightToLeftSupport.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
                         $currentLen        = $endPos + 2;
200 200
                         $directive         = substr($workingText, 0, $currentLen);
201 201
                         $workingText       = substr($workingText, $currentLen);
202
-                        $result            .= self::$waitingText . $directive;
202
+                        $result .= self::$waitingText . $directive;
203 203
                         self::$waitingText = '';
204 204
                         break;
205 205
                     }
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
                             break;
309 309
                         }
310 310
                         self::$waitingText .= $currentLetter;
311
-                        $workingText       = substr($workingText, $currentLen);
311
+                        $workingText = substr($workingText, $currentLen);
312 312
                         if ($openParIndex !== false) {
313 313
                             // Opening parentheses always inherit the following directionality
314 314
                             while (true) {
@@ -318,13 +318,13 @@  discard block
 block discarded – undo
318 318
                                 if (str_starts_with($workingText, ' ')) {
319 319
                                     // Spaces following this left parenthesis inherit the following directionality too
320 320
                                     self::$waitingText .= ' ';
321
-                                    $workingText       = substr($workingText, 1);
321
+                                    $workingText = substr($workingText, 1);
322 322
                                     continue;
323 323
                                 }
324 324
                                 if (str_starts_with($workingText, ' ')) {
325 325
                                     // Spaces following this left parenthesis inherit the following directionality too
326 326
                                     self::$waitingText .= ' ';
327
-                                    $workingText       = substr($workingText, 6);
327
+                                    $workingText = substr($workingText, 6);
328 328
                                     continue;
329 329
                                 }
330 330
                                 break;
@@ -341,7 +341,7 @@  discard block
 block discarded – undo
341 341
                         // Exceptions to this rule will be handled later during final clean-up.
342 342
                         //
343 343
                         if (self::$currentState !== '') {
344
-                            $result            .= self::$waitingText;
344
+                            $result .= self::$waitingText;
345 345
                             self::$waitingText = '';
346 346
                         }
347 347
                         break 2; // double break because we're waiting for more information
@@ -470,7 +470,7 @@  discard block
 block discarded – undo
470 470
                 }
471 471
                 if (substr($result . "\n", 0, self::LENGTH_START) !== self::START_LTR && substr($result . "\n", 0, self::LENGTH_START) !== self::START_RTL) {
472 472
                     $leadingText .= substr($result, 0, 1);
473
-                    $result      = substr($result, 1);
473
+                    $result = substr($result, 1);
474 474
                     continue;
475 475
                 }
476 476
                 $result = substr($result, 0, self::LENGTH_START) . $leadingText . substr($result, self::LENGTH_START);
@@ -612,11 +612,11 @@  discard block
 block discarded – undo
612 612
     private static function breakCurrentSpan(string &$result): void
613 613
     {
614 614
         // Interrupt the current span, insert that <br>, and then continue the current span
615
-        $result            .= self::$waitingText;
615
+        $result .= self::$waitingText;
616 616
         self::$waitingText = '';
617 617
 
618 618
         $breakString = '<' . self::$currentState . 'br>';
619
-        $result      .= $breakString;
619
+        $result .= $breakString;
620 620
     }
621 621
 
622 622
     /**
@@ -673,7 +673,7 @@  discard block
 block discarded – undo
673 673
                 break;
674 674
             } // No more numeric strings
675 675
 
676
-            $tempResult    .= substr($textSpan, 0, $posLRE + 3); // Copy everything preceding the numeric string
676
+            $tempResult .= substr($textSpan, 0, $posLRE + 3); // Copy everything preceding the numeric string
677 677
             $numericString = substr($textSpan, $posLRE + 3, $posPDF - $posLRE); // Separate the entire numeric string
678 678
             $textSpan      = substr($textSpan, $posPDF + 3);
679 679
             $posColon      = strpos($numericString, ':');
@@ -1140,7 +1140,7 @@  discard block
 block discarded – undo
1140 1140
 
1141 1141
             // We're done: finish the span
1142 1142
             $textSpan = self::starredName($textSpan, 'RTL'); // Wrap starred name in <u> and </u> tags
1143
-            $result   .= $textSpan . self::END_RTL;
1143
+            $result .= $textSpan . self::END_RTL;
1144 1144
         }
1145 1145
 
1146 1146
         if (self::$currentState !== 'LTR' && self::$currentState !== 'RTL') {
Please login to merge, or discard this patch.
app/Validator.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
      */
121 121
     public function isBetween(int $minimum, int $maximum): self
122 122
     {
123
-        $this->rules[] = static function (?int $value) use ($minimum, $maximum): ?int {
123
+        $this->rules[] = static function (?int $value) use ($minimum, $maximum) : ?int {
124 124
             if (is_int($value) && $value >= $minimum && $value <= $maximum) {
125 125
                 return $value;
126 126
             }
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
      */
159 159
     public function isNotEmpty(): self
160 160
     {
161
-        $this->rules[] = static fn (?string $value): ?string => $value !== null && $value !== '' ? $value : null;
161
+        $this->rules[] = static fn (?string $value) : ?string => $value !== null && $value !== '' ? $value : null;
162 162
 
163 163
         return $this;
164 164
     }
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
     {
171 171
         $base_url = $this->request->getAttribute('base_url', '');
172 172
 
173
-        $this->rules[] = static function (?string $value) use ($base_url): ?string {
173
+        $this->rules[] = static function (?string $value) use ($base_url) : ?string {
174 174
             if ($value !== null) {
175 175
                 $value_info    = parse_url($value);
176 176
                 $base_url_info = parse_url($base_url);
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
             throw new HttpBadRequestException(I18N::translate('The parameter ā€œ%sā€ is missing.', $parameter));
269 269
         }
270 270
 
271
-        $callback = static fn (?array $value, Closure $rule): ?array => $rule($value);
271
+        $callback = static fn (?array $value, Closure $rule) : ?array => $rule($value);
272 272
 
273 273
         return array_reduce($this->rules, $callback, $value) ?? [];
274 274
     }
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
295 295
             $value = null;
296 296
         }
297 297
 
298
-        $callback = static fn (?int $value, Closure $rule): ?int => $rule($value);
298
+        $callback = static fn (?int $value, Closure $rule) : ?int => $rule($value);
299 299
 
300 300
         $value = array_reduce($this->rules, $callback, $value) ?? $default;
301 301
 
@@ -336,9 +336,9 @@  discard block
 block discarded – undo
336 336
             $value = null;
337 337
         }
338 338
 
339
-        $callback = static fn (?string $value, Closure $rule): ?string => $rule($value);
339
+        $callback = static fn (?string $value, Closure $rule) : ?string => $rule($value);
340 340
 
341
-        $value =  array_reduce($this->rules, $callback, $value) ?? $default;
341
+        $value = array_reduce($this->rules, $callback, $value) ?? $default;
342 342
 
343 343
         if ($value === null) {
344 344
             throw new HttpBadRequestException(I18N::translate('The parameter ā€œ%sā€ is missing.', $parameter));
Please login to merge, or discard this patch.
app/Module/IndividualListModule.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -660,11 +660,11 @@
 block discarded – undo
660 660
      */
661 661
     protected function surnameInitials(array $all_surnames): array
662 662
     {
663
-        $initials    = [];
663
+        $initials = [];
664 664
 
665 665
         // Ensure our own language comes before others.
666 666
         foreach (I18N::language()->alphabet() as $initial) {
667
-            $initials[$initial]    = 0;
667
+            $initials[$initial] = 0;
668 668
         }
669 669
 
670 670
         foreach ($all_surnames as $surn => $surnames) {
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -313,7 +313,8 @@  discard block
 block discarded – undo
313 313
                     <li class="wt-initials-list-item d-flex">
314 314
                         <?php if ($count > 0) : ?>
315 315
                             <a href="<?= e($this->listUrl($tree, ['alpha' => $letter, 'tree' => $tree->name()])) ?>" class="wt-initial px-1<?= $letter === $alpha ? ' active' : '' ?> '" title="<?= I18N::number($count) ?>"><?= $this->displaySurnameInitial((string) $letter) ?></a>
316
-                        <?php else : ?>
316
+                        <?php else {
317
+    : ?>
317 318
                             <span class="wt-initial px-1 text-muted"><?= $this->displaySurnameInitial((string) $letter) ?></span>
318 319
 
319 320
                         <?php endif ?>
@@ -368,6 +369,7 @@  discard block
 block discarded – undo
368 369
                 switch ($alpha) {
369 370
                     case '@':
370 371
                         $surns = array_filter($all_surnames, static fn (string $x): bool => $x === Individual::NOMEN_NESCIO, ARRAY_FILTER_USE_KEY);
372
+}
371 373
                         break;
372 374
                     case ',':
373 375
                         $surns = array_filter($all_surnames, static fn (string $x): bool => $x === '', ARRAY_FILTER_USE_KEY);
Please login to merge, or discard this patch.