fisharebest /
webtrees
| Conditions | 9 |
| Paths | 192 |
| Total Lines | 75 |
| Code Lines | 46 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 40 | public function handle(ServerRequestInterface $request): ResponseInterface |
||
| 41 | { |
||
| 42 | $tree = $request->getAttribute('tree'); |
||
| 43 | assert($tree instanceof Tree); |
||
| 44 | |||
| 45 | $params = $request->getParsedBody(); |
||
| 46 | $title = $params['source-title']; |
||
| 47 | $abbreviation = $params['source-abbreviation']; |
||
| 48 | $author = $params['source-author']; |
||
| 49 | $publication = $params['source-publication']; |
||
| 50 | $repository = $params['source-repository']; |
||
| 51 | $call_number = $params['source-call-number']; |
||
| 52 | $text = $params['source-text']; |
||
| 53 | $privacy_restriction = $params['privacy-restriction']; |
||
| 54 | $edit_restriction = $params['edit-restriction']; |
||
| 55 | |||
| 56 | // Fix whitespace |
||
| 57 | $title = trim(preg_replace('/\s+/', ' ', $title)); |
||
| 58 | $abbreviation = trim(preg_replace('/\s+/', ' ', $abbreviation)); |
||
| 59 | $author = trim(preg_replace('/\s+/', ' ', $author)); |
||
| 60 | $publication = trim(preg_replace('/\s+/', ' ', $publication)); |
||
| 61 | $repository = trim(preg_replace('/\s+/', ' ', $repository)); |
||
| 62 | $call_number = trim(preg_replace('/\s+/', ' ', $call_number)); |
||
| 63 | |||
| 64 | // Convert line endings to GEDCOM continuations |
||
| 65 | $text = strtr($text, ["\r\n" => "\n"]); |
||
| 66 | $text = strtr($text, ["\n" => "\n2 CONT "]); |
||
| 67 | |||
| 68 | $gedcom = "0 @@ SOUR\n\n1 TITL " . $title; |
||
| 69 | |||
| 70 | if ($abbreviation !== '') { |
||
| 71 | $gedcom .= "\n1 ABBR " . $abbreviation; |
||
| 72 | } |
||
| 73 | |||
| 74 | if ($author !== '') { |
||
| 75 | $gedcom .= "\n1 AUTH " . $author; |
||
| 76 | } |
||
| 77 | |||
| 78 | if ($publication !== '') { |
||
| 79 | $gedcom .= "\n1 PUBL " . $publication; |
||
| 80 | } |
||
| 81 | |||
| 82 | if ($text !== '') { |
||
| 83 | $gedcom .= "\n1 TEXT " . $text; |
||
| 84 | } |
||
| 85 | |||
| 86 | if ($repository !== '') { |
||
| 87 | $gedcom .= "\n1 REPO @" . $repository . '@'; |
||
| 88 | |||
| 89 | if ($call_number !== '') { |
||
| 90 | $gedcom .= "\n2 CALN " . $call_number; |
||
| 91 | } |
||
| 92 | } |
||
| 93 | |||
| 94 | if (in_array($privacy_restriction, ['none', 'privacy', 'confidential'], true)) { |
||
| 95 | $gedcom .= "\n1 RESN " . $privacy_restriction; |
||
| 96 | } |
||
| 97 | |||
| 98 | if ($edit_restriction === 'locked') { |
||
| 99 | $gedcom .= "\n1 RESN " . $edit_restriction; |
||
| 100 | } |
||
| 101 | |||
| 102 | $record = $tree->createRecord($gedcom); |
||
| 103 | |||
| 104 | // id and text are for select2 / autocomplete |
||
| 105 | // html is for interactive modals |
||
| 106 | return response([ |
||
| 107 | 'id' => $record->xref(), |
||
| 108 | 'text' => view('selects/source', [ |
||
| 109 | 'source' => $record, |
||
| 110 | ]), |
||
| 111 | 'html' => view('modals/record-created', [ |
||
| 112 | 'title' => I18N::translate('The source has been created'), |
||
| 113 | 'name' => $record->fullName(), |
||
| 114 | 'url' => $record->url(), |
||
| 115 | ]), |
||
| 119 |
