Passed
Pull Request — master (#2216)
by Rico
07:06
created
app/Services/ModuleService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -504,7 +504,7 @@  discard block
 block discarded – undo
504 504
     public function findByName(string $module_name): ?ModuleInterface
505 505
     {
506 506
         return $this->all()
507
-            ->filter(function (ModuleInterface $module) use ($module_name): bool {
507
+            ->filter(function (ModuleInterface $module) use ($module_name) : bool {
508 508
                 return $module->isEnabled() && $module->name() === $module_name;
509 509
             })
510 510
             ->first();
@@ -520,7 +520,7 @@  discard block
 block discarded – undo
520 520
     public function findByClass(string $class_name): ?ModuleInterface
521 521
     {
522 522
         return $this->all()
523
-            ->filter(function (ModuleInterface $module) use ($class_name): bool {
523
+            ->filter(function (ModuleInterface $module) use ($class_name) : bool {
524 524
                 return $module->isEnabled() && $module instanceof $class_name;
525 525
             })
526 526
             ->first();
Please login to merge, or discard this patch.
app/Http/Controllers/Admin/ImportThumbnailsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -560,7 +560,7 @@
 block discarded – undo
560 560
         $data = array_map(function (string $thumbnail): array {
561 561
             $original = $this->findOriginalFileFromThumbnail($thumbnail);
562 562
 
563
-            $original_url  = route('unused-media-thumbnail', [
563
+            $original_url = route('unused-media-thumbnail', [
564 564
                 'folder' => dirname($original),
565 565
                 'file'   => basename($original),
566 566
                 'w'      => 100,
Please login to merge, or discard this patch.
app/Http/Controllers/Admin/MediaController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@
 block discarded – undo
120 120
         $length = (int) $request->get('length');
121 121
 
122 122
         // Files within this folder
123
-        $media_folder  = $request->get('media_folder', '');
123
+        $media_folder = $request->get('media_folder', '');
124 124
 
125 125
         // subfolders within $media_path
126 126
         $subfolders = $request->get('subfolders', ''); // include|exclude
Please login to merge, or discard this patch.
app/Http/Controllers/ReportEngineController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
                     break;
136 136
 
137 137
                 case 'DATE':
138
-                    $attributes       += [
138
+                    $attributes += [
139 139
                         'type'  => 'text',
140 140
                         'value' => $input['default'],
141 141
                         'dir'   => 'ltr',
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
                 default:
149 149
                     switch ($input['type']) {
150 150
                         case 'text':
151
-                            $attributes       += [
151
+                            $attributes += [
152 152
                                 'type'  => 'text',
153 153
                                 'value' => $input['default'],
154 154
                             ];
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
                             break;
157 157
 
158 158
                         case 'checkbox':
159
-                            $attributes       += [
159
+                            $attributes += [
160 160
                                 'type'    => 'checkbox',
161 161
                                 'checked' => (bool) $input['default'],
162 162
                             ];
Please login to merge, or discard this patch.
app/Module/HourglassChartModule.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
             if ($kcount == 0) {
294 294
                 echo "</td><td style='width:", app()->make(ModuleThemeInterface::class)->parameter('chart-box-x'), "px'>";
295 295
             } else {
296
-                echo '<a href="#" title="' . I18N::translate('Children') . '" data-route="Descendants" data-xref="' .  e($pid) . '" data-spouses="' .  e($show_spouse) . '" data-tree="' .  e($individual->tree()->name()) . '">' . view('icons/arrow-left') . '</a>';
296
+                echo '<a href="#" title="' . I18N::translate('Children') . '" data-route="Descendants" data-xref="' . e($pid) . '" data-spouses="' . e($show_spouse) . '" data-tree="' . e($individual->tree()->name()) . '">' . view('icons/arrow-left') . '</a>';
297 297
 
298 298
                 //-- move the arrow up to line up with the correct box
299 299
                 if ($show_spouse) {
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
447 447
                 echo '<td id="td_' . e($ARID) . '">';
448 448
 
449 449
                 if ($generation == $generations - 1 && $family->getHusband()->getChildFamilies()) {
450
-                    echo '<a href="#" title="' . I18N::translate('Parents') . '" data-route="Ancestors" data-xref="' .  e($ARID) . '" data-spouses="' .  e($show_spouse) . '" data-tree="' .  e($family->getHusband()->tree()->name()) . '">' . view('icons/arrow-right') . '</a>';
450
+                    echo '<a href="#" title="' . I18N::translate('Parents') . '" data-route="Ancestors" data-xref="' . e($ARID) . '" data-spouses="' . e($show_spouse) . '" data-tree="' . e($family->getHusband()->tree()->name()) . '">' . view('icons/arrow-right') . '</a>';
451 451
                 }
452 452
 
453 453
                 $this->printPersonPedigree($family->getHusband(), $generation + 1, $generations, $show_spouse);
@@ -478,7 +478,7 @@  discard block
 block discarded – undo
478 478
                 echo '<td id="td_' . e($ARID) . '">';
479 479
 
480 480
                 if ($generation == $generations - 1 && $family->getWife()->getChildFamilies()) {
481
-                    echo '<a href="#" title="' . I18N::translate('Parents') . '" data-route="Ancestors" data-xref="' .  e($ARID) . '" data-spouses="' .  e($show_spouse) . '" data-tree="' .  e($family->getWife()->tree()->name()) . '">' . view('icons/arrow-right') . '</a>';
481
+                    echo '<a href="#" title="' . I18N::translate('Parents') . '" data-route="Ancestors" data-xref="' . e($ARID) . '" data-spouses="' . e($show_spouse) . '" data-tree="' . e($family->getWife()->tree()->name()) . '">' . view('icons/arrow-right') . '</a>';
482 482
                 }
483 483
 
484 484
                 $this->printPersonPedigree($family->getWife(), $generation + 1, $generations, $show_spouse);
Please login to merge, or discard this patch.
app/Module/RelationshipsChartModule.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -320,14 +320,14 @@  discard block
 block discarded – undo
320 320
                         case 'sis':
321 321
                         case 'sib':
322 322
                             $table[$x + 1][$y] = '<div style="background:url(' . e(asset('css/images/hline.png')) . ') repeat-x center;  width: 94px; text-align: center"><div class="hline-text" style="height: 32px;">' . Functions::getRelationshipNameFromPath($relationships[$n], Individual::getInstance($path[$n - 1], $tree), Individual::getInstance($path[$n + 1], $tree)) . '</div><div style="height: 32px;">' . view('icons/arrow-right') . '</div></div>';
323
-                            $x                 += 2;
323
+                            $x += 2;
324 324
                             break;
325 325
                         case 'son':
326 326
                         case 'dau':
327 327
                         case 'chi':
328 328
                             if ($n > 2 && preg_match('/fat|mot|par/', $relationships[$n - 2])) {
329 329
                                 $table[$x + 1][$y - 1] = '<div style="background:url(' . $diagonal2 . '); width: 64px; height: 64px; text-align: center;"><div style="height: 32px; text-align: end;">' . Functions::getRelationshipNameFromPath($relationships[$n], Individual::getInstance($path[$n - 1], $tree), Individual::getInstance($path[$n + 1], $tree)) . '</div><div style="height: 32px; text-align: start;">' . view('icons/arrow-down') . '</div></div>';
330
-                                $x                     += 2;
330
+                                $x += 2;
331 331
                             } else {
332 332
                                 $table[$x][$y - 1] = '<div style="background:url(' . e('"' . asset('css/images/vline.png') . '"') . ') repeat-y center; height: 64px; text-align: center;"><div class="vline-text" style="display: inline-block; width:50%; line-height: 64px;">' . Functions::getRelationshipNameFromPath($relationships[$n], Individual::getInstance($path[$n - 1], $tree), Individual::getInstance($path[$n + 1], $tree)) . '</div><div style="display: inline-block; width:50%; line-height: 64px;">' . view('icons/arrow-down') . '</div></div>';
333 333
                             }
@@ -338,9 +338,9 @@  discard block
 block discarded – undo
338 338
                         case 'par':
339 339
                             if ($n > 2 && preg_match('/son|dau|chi/', $relationships[$n - 2])) {
340 340
                                 $table[$x + 1][$y + 1] = '<div style="background:url(' . $diagonal1 . '); background-position: top right; width: 64px; height: 64px; text-align: center;"><div style="height: 32px; text-align: start;">' . Functions::getRelationshipNameFromPath($relationships[$n], Individual::getInstance($path[$n - 1], $tree), Individual::getInstance($path[$n + 1], $tree)) . '</div><div style="height: 32px; text-align: end;">' . view('icons/arrow-down') . '</div></div>';
341
-                                $x                     += 2;
341
+                                $x += 2;
342 342
                             } else {
343
-                                $table[$x][$y + 1] = '<div style="background:url(' . e('"' . asset('css/images/vline.png') . '"')  . ') repeat-y center; height: 64px; text-align:center; "><div class="vline-text" style="display: inline-block; width: 50%; line-height: 64px;">' . Functions::getRelationshipNameFromPath($relationships[$n], Individual::getInstance($path[$n - 1], $tree), Individual::getInstance($path[$n + 1], $tree)) . '</div><div style="display: inline-block; width: 50%; line-height: 32px">' . view('icons/arrow-up') . '</div></div>';
343
+                                $table[$x][$y + 1] = '<div style="background:url(' . e('"' . asset('css/images/vline.png') . '"') . ') repeat-y center; height: 64px; text-align:center; "><div class="vline-text" style="display: inline-block; width: 50%; line-height: 64px;">' . Functions::getRelationshipNameFromPath($relationships[$n], Individual::getInstance($path[$n - 1], $tree), Individual::getInstance($path[$n + 1], $tree)) . '</div><div style="display: inline-block; width: 50%; line-height: 32px">' . view('icons/arrow-up') . '</div></div>';
344 344
                             }
345 345
                             $y += 2;
346 346
                             break;
@@ -478,17 +478,17 @@  discard block
 block discarded – undo
478 478
      */
479 479
     private function oldStyleRelationshipPath(Tree $tree, array $path): array
480 480
     {
481
-        $spouse_codes  = [
481
+        $spouse_codes = [
482 482
             'M' => 'hus',
483 483
             'F' => 'wif',
484 484
             'U' => 'spo',
485 485
         ];
486
-        $parent_codes  = [
486
+        $parent_codes = [
487 487
             'M' => 'fat',
488 488
             'F' => 'mot',
489 489
             'U' => 'par',
490 490
         ];
491
-        $child_codes   = [
491
+        $child_codes = [
492 492
             'M' => 'son',
493 493
             'F' => 'dau',
494 494
             'U' => 'chi',
Please login to merge, or discard this patch.
app/Module/DescendancyChartModule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
         echo '<td>';
265 265
         foreach ($person->getChildFamilies() as $cfamily) {
266 266
             foreach ($cfamily->getSpouses() as $parent) {
267
-                echo '<a href="' . e($this->chartUrl($parent, ['generations' => $generations])) . '" title="' .  I18N::translate('Start at parents') . '">' . view('icons/arrow-up') . '<span class="sr-only">' .  I18N::translate('Start at parents') . '</span></a>';
267
+                echo '<a href="' . e($this->chartUrl($parent, ['generations' => $generations])) . '" title="' . I18N::translate('Start at parents') . '">' . view('icons/arrow-up') . '<span class="sr-only">' . I18N::translate('Start at parents') . '</span></a>';
268 268
                 // only show the arrow for one of the parents
269 269
                 break;
270 270
             }
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
         if ($spouse) {
344 344
             foreach ($spouse->getChildFamilies() as $cfamily) {
345 345
                 foreach ($cfamily->getSpouses() as $parent) {
346
-                    echo '<a href="' . e($this->chartUrl($parent, ['generations' => $generations])) . '" title="' .  strip_tags($this->chartTitle($parent)) . '">' . view('icons/arrow-up') . '<span class="sr-only">' .  strip_tags($this->chartTitle($parent)) . '</span></a>';
346
+                    echo '<a href="' . e($this->chartUrl($parent, ['generations' => $generations])) . '" title="' . strip_tags($this->chartTitle($parent)) . '">' . view('icons/arrow-up') . '<span class="sr-only">' . strip_tags($this->chartTitle($parent)) . '</span></a>';
347 347
                     // only show the arrow for one of the parents
348 348
                     break;
349 349
                 }
Please login to merge, or discard this patch.
app/Module/PedigreeChartModule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -419,7 +419,7 @@  discard block
 block discarded – undo
419 419
             $html = '<div id="childarrow"><a href="#" class="menuselect">' . $this->arrows->menu . '</a><div id="childbox-pedigree">';
420 420
 
421 421
             foreach ($families as $family) {
422
-                $html   .= '<span class="name1">' . I18N::translate('Family') . '</span>';
422
+                $html .= '<span class="name1">' . I18N::translate('Family') . '</span>';
423 423
                 $spouse = $family->getSpouse($root);
424 424
                 if ($spouse) {
425 425
                     $html .= '<a class="name1" href="' . e($this->chartUrl($spouse, ['generations' => $generations, 'orientation' => $orientation])) . '">' . $spouse->getFullName() . '</a>';
@@ -465,7 +465,7 @@  discard block
 block discarded – undo
465 465
         $html = '';
466 466
         if ($chart_has_ancestors) {
467 467
             if ($this->nodes[$index]['indi'] && $this->nodes[$index]['indi']->getChildFamilies()) {
468
-                $html         .= '<div class="ancestorarrow">';
468
+                $html .= '<div class="ancestorarrow">';
469 469
                 $rootParentId = 1;
470 470
                 if ($index > (int) ($this->treesize / 2) + (int) ($this->treesize / 4)) {
471 471
                     $rootParentId++;
Please login to merge, or discard this patch.
app/Statistics/Google/ChartCommonGiven.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
         ];
60 60
 
61 61
         foreach ($given as $name => $count) {
62
-            $data[] = [ $name, $count ];
62
+            $data[] = [$name, $count];
63 63
         }
64 64
 
65 65
         $data[] = [
Please login to merge, or discard this patch.