Completed
Pull Request — master (#1854)
by Rico
149:06 queued 135:36
created
app/Http/Controllers/AdminTreesController.php 1 patch
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -407,9 +407,9 @@  discard block
 block discarded – undo
407 407
     public function exportClient(Request $request, Tree $tree): Response
408 408
     {
409 409
         // Validate user parameters
410
-        $convert          = (bool)$request->get('convert');
411
-        $zip              = (bool)$request->get('zip');
412
-        $media            = (bool)$request->get('media');
410
+        $convert          = (bool) $request->get('convert');
411
+        $zip              = (bool) $request->get('zip');
412
+        $media            = (bool) $request->get('media');
413 413
         $media_path       = $request->get('media-path');
414 414
         $privatize_export = $request->get('privatize_export');
415 415
 
@@ -539,8 +539,8 @@  discard block
 block discarded – undo
539 539
     public function importAction(Request $request, Tree $tree): RedirectResponse
540 540
     {
541 541
         $source             = $request->get('source');
542
-        $keep_media         = (bool)$request->get('keep_media');
543
-        $WORD_WRAPPED_NOTES = (bool)$request->get('WORD_WRAPPED_NOTES');
542
+        $keep_media         = (bool) $request->get('keep_media');
543
+        $WORD_WRAPPED_NOTES = (bool) $request->get('WORD_WRAPPED_NOTES');
544 544
         $GEDCOM_MEDIA_PATH  = $request->get('GEDCOM_MEDIA_PATH');
545 545
 
546 546
         // Save these choices as defaults
@@ -603,7 +603,7 @@  discard block
 block discarded – undo
603 603
      */
604 604
     public function index(Tree $tree = null): Response
605 605
     {
606
-        $multiple_tree_threshold = (int)Site::getPreference('MULTIPLE_TREE_THRESHOLD', self::MULTIPLE_TREE_THRESHOLD);
606
+        $multiple_tree_threshold = (int) Site::getPreference('MULTIPLE_TREE_THRESHOLD', self::MULTIPLE_TREE_THRESHOLD);
607 607
         $gedcom_files            = $this->gedcomFiles(WT_DATA_DIR);
608 608
 
609 609
         $all_trees = Tree::getAll();
@@ -1034,16 +1034,16 @@  discard block
 block discarded – undo
1034 1034
     public function preferencesUpdate(Request $request, Tree $tree): RedirectResponse
1035 1035
     {
1036 1036
         // Coming soon
1037
-        if ((bool)$request->get('all_trees')) {
1037
+        if ((bool) $request->get('all_trees')) {
1038 1038
             FlashMessages::addMessage(I18N::translate('The preferences for all family trees have been updated.'), 'success');
1039 1039
         }
1040
-        if ((bool)$request->get('new_trees')) {
1040
+        if ((bool) $request->get('new_trees')) {
1041 1041
             FlashMessages::addMessage(I18N::translate('The preferences for new family trees have been updated.'), 'success');
1042 1042
         }
1043 1043
 
1044 1044
         $tree->setPreference('ADVANCED_NAME_FACTS', implode(',', $request->get('ADVANCED_NAME_FACTS', [])));
1045 1045
         $tree->setPreference('ADVANCED_PLAC_FACTS', implode(',', $request->get('ADVANCED_PLAC_FACTS', [])));
1046
-        $tree->setPreference('ALLOW_THEME_DROPDOWN', (string)(bool)$request->get('ALLOW_THEME_DROPDOWN'));
1046
+        $tree->setPreference('ALLOW_THEME_DROPDOWN', (string) (bool) $request->get('ALLOW_THEME_DROPDOWN'));
1047 1047
         // For backwards compatibility with webtrees 1.x we store the two calendar formats in one variable
1048 1048
         // e.g. "gregorian_and_jewish"
1049 1049
         $tree->setPreference('CALENDAR_FORMAT', implode('_and_', array_unique([
@@ -1052,57 +1052,57 @@  discard block
 block discarded – undo
1052 1052
         ])));
1053 1053
         $tree->setPreference('CHART_BOX_TAGS', implode(',', $request->get('CHART_BOX_TAGS', [])));
1054 1054
         $tree->setPreference('CONTACT_USER_ID', $request->get('CONTACT_USER_ID'));
1055
-        $tree->setPreference('DEFAULT_PEDIGREE_GENERATIONS', (string)(int)$request->get('DEFAULT_PEDIGREE_GENERATIONS'));
1056
-        $tree->setPreference('EXPAND_NOTES', (string)(bool)$request->get('EXPAND_NOTES'));
1057
-        $tree->setPreference('EXPAND_SOURCES', (string)(bool)$request->get('EXPAND_SOURCES'));
1055
+        $tree->setPreference('DEFAULT_PEDIGREE_GENERATIONS', (string) (int) $request->get('DEFAULT_PEDIGREE_GENERATIONS'));
1056
+        $tree->setPreference('EXPAND_NOTES', (string) (bool) $request->get('EXPAND_NOTES'));
1057
+        $tree->setPreference('EXPAND_SOURCES', (string) (bool) $request->get('EXPAND_SOURCES'));
1058 1058
         $tree->setPreference('FAM_FACTS_ADD', implode(',', $request->get('FAM_FACTS_ADD', [])));
1059 1059
         $tree->setPreference('FAM_FACTS_QUICK', implode(',', $request->get('FAM_FACTS_QUICK', [])));
1060 1060
         $tree->setPreference('FAM_FACTS_UNIQUE', implode(',', $request->get('FAM_FACTS_UNIQUE', [])));
1061
-        $tree->setPreference('FULL_SOURCES', (string)(bool)$request->get('FULL_SOURCES'));
1061
+        $tree->setPreference('FULL_SOURCES', (string) (bool) $request->get('FULL_SOURCES'));
1062 1062
         $tree->setPreference('FORMAT_TEXT', $request->get('FORMAT_TEXT'));
1063
-        $tree->setPreference('GENERATE_UIDS', (string)(bool)$request->get('GENERATE_UIDS'));
1063
+        $tree->setPreference('GENERATE_UIDS', (string) (bool) $request->get('GENERATE_UIDS'));
1064 1064
         $tree->setPreference('GEONAMES_ACCOUNT', $request->get('GEONAMES_ACCOUNT'));
1065
-        $tree->setPreference('HIDE_GEDCOM_ERRORS', (string)(bool)$request->get('HIDE_GEDCOM_ERRORS'));
1065
+        $tree->setPreference('HIDE_GEDCOM_ERRORS', (string) (bool) $request->get('HIDE_GEDCOM_ERRORS'));
1066 1066
         $tree->setPreference('INDI_FACTS_ADD', implode(',', $request->get('INDI_FACTS_ADD', [])));
1067 1067
         $tree->setPreference('INDI_FACTS_QUICK', implode(',', $request->get('INDI_FACTS_QUICK', [])));
1068 1068
         $tree->setPreference('INDI_FACTS_UNIQUE', implode(',', $request->get('INDI_FACTS_UNIQUE', [])));
1069 1069
         $tree->setPreference('LANGUAGE', $request->get('LANGUAGE'));
1070
-        $tree->setPreference('MAX_DESCENDANCY_GENERATIONS', (string)(int)$request->get('MAX_DESCENDANCY_GENERATIONS'));
1071
-        $tree->setPreference('MAX_PEDIGREE_GENERATIONS', (string)(int)$request->get('MAX_PEDIGREE_GENERATIONS'));
1070
+        $tree->setPreference('MAX_DESCENDANCY_GENERATIONS', (string) (int) $request->get('MAX_DESCENDANCY_GENERATIONS'));
1071
+        $tree->setPreference('MAX_PEDIGREE_GENERATIONS', (string) (int) $request->get('MAX_PEDIGREE_GENERATIONS'));
1072 1072
         $tree->setPreference('MEDIA_UPLOAD', $request->get('MEDIA_UPLOAD'));
1073 1073
         $tree->setPreference('META_DESCRIPTION', $request->get('META_DESCRIPTION'));
1074 1074
         $tree->setPreference('META_TITLE', $request->get('META_TITLE'));
1075
-        $tree->setPreference('NO_UPDATE_CHAN', (string)(bool)$request->get('NO_UPDATE_CHAN'));
1076
-        $tree->setPreference('PEDIGREE_LAYOUT', (string)(bool)$request->get('PEDIGREE_LAYOUT'));
1075
+        $tree->setPreference('NO_UPDATE_CHAN', (string) (bool) $request->get('NO_UPDATE_CHAN'));
1076
+        $tree->setPreference('PEDIGREE_LAYOUT', (string) (bool) $request->get('PEDIGREE_LAYOUT'));
1077 1077
         $tree->setPreference('PEDIGREE_ROOT_ID', $request->get('PEDIGREE_ROOT_ID', WT_REGEX_XREF));
1078
-        $tree->setPreference('PEDIGREE_SHOW_GENDER', (string)(bool)$request->get('PEDIGREE_SHOW_GENDER'));
1078
+        $tree->setPreference('PEDIGREE_SHOW_GENDER', (string) (bool) $request->get('PEDIGREE_SHOW_GENDER'));
1079 1079
         $tree->setPreference('PREFER_LEVEL2_SOURCES', $request->get('PREFER_LEVEL2_SOURCES'));
1080 1080
         $tree->setPreference('QUICK_REQUIRED_FACTS', implode(',', $request->get('QUICK_REQUIRED_FACTS', [])));
1081 1081
         $tree->setPreference('QUICK_REQUIRED_FAMFACTS', implode(',', $request->get('QUICK_REQUIRED_FAMFACTS', [])));
1082 1082
         $tree->setPreference('REPO_FACTS_ADD', implode(',', $request->get('REPO_FACTS_ADD', [])));
1083 1083
         $tree->setPreference('REPO_FACTS_QUICK', implode(',', $request->get('REPO_FACTS_QUICK', [])));
1084 1084
         $tree->setPreference('REPO_FACTS_UNIQUE', implode(',', $request->get('REPO_FACTS_UNIQUE', [])));
1085
-        $tree->setPreference('SHOW_COUNTER', (string)(bool)$request->get('SHOW_COUNTER'));
1086
-        $tree->setPreference('SHOW_EST_LIST_DATES', (string)(bool)$request->get('SHOW_EST_LIST_DATES'));
1087
-        $tree->setPreference('SHOW_FACT_ICONS', (string)(bool)$request->get('SHOW_FACT_ICONS'));
1088
-        $tree->setPreference('SHOW_GEDCOM_RECORD', (string)(bool)$request->get('SHOW_GEDCOM_RECORD'));
1089
-        $tree->setPreference('SHOW_HIGHLIGHT_IMAGES', (string)(bool)$request->get('SHOW_HIGHLIGHT_IMAGES'));
1090
-        $tree->setPreference('SHOW_LAST_CHANGE', (string)(bool)$request->get('SHOW_LAST_CHANGE'));
1091
-        $tree->setPreference('SHOW_LDS_AT_GLANCE', (string)(bool)$request->get('SHOW_LDS_AT_GLANCE'));
1085
+        $tree->setPreference('SHOW_COUNTER', (string) (bool) $request->get('SHOW_COUNTER'));
1086
+        $tree->setPreference('SHOW_EST_LIST_DATES', (string) (bool) $request->get('SHOW_EST_LIST_DATES'));
1087
+        $tree->setPreference('SHOW_FACT_ICONS', (string) (bool) $request->get('SHOW_FACT_ICONS'));
1088
+        $tree->setPreference('SHOW_GEDCOM_RECORD', (string) (bool) $request->get('SHOW_GEDCOM_RECORD'));
1089
+        $tree->setPreference('SHOW_HIGHLIGHT_IMAGES', (string) (bool) $request->get('SHOW_HIGHLIGHT_IMAGES'));
1090
+        $tree->setPreference('SHOW_LAST_CHANGE', (string) (bool) $request->get('SHOW_LAST_CHANGE'));
1091
+        $tree->setPreference('SHOW_LDS_AT_GLANCE', (string) (bool) $request->get('SHOW_LDS_AT_GLANCE'));
1092 1092
         $tree->setPreference('SHOW_MEDIA_DOWNLOAD', $request->get('SHOW_MEDIA_DOWNLOAD'));
1093 1093
         $tree->setPreference('SHOW_NO_WATERMARK', $request->get('SHOW_NO_WATERMARK'));
1094
-        $tree->setPreference('SHOW_PARENTS_AGE', (string)(bool)$request->get('SHOW_PARENTS_AGE'));
1094
+        $tree->setPreference('SHOW_PARENTS_AGE', (string) (bool) $request->get('SHOW_PARENTS_AGE'));
1095 1095
         $tree->setPreference('SHOW_PEDIGREE_PLACES', $request->get('SHOW_PEDIGREE_PLACES'));
1096
-        $tree->setPreference('SHOW_PEDIGREE_PLACES_SUFFIX', (string)(bool)$request->get('SHOW_PEDIGREE_PLACES_SUFFIX'));
1096
+        $tree->setPreference('SHOW_PEDIGREE_PLACES_SUFFIX', (string) (bool) $request->get('SHOW_PEDIGREE_PLACES_SUFFIX'));
1097 1097
         $tree->setPreference('SHOW_RELATIVES_EVENTS', implode(',', $request->get('SHOW_RELATIVES_EVENTS', [])));
1098 1098
         $tree->setPreference('SOUR_FACTS_ADD', implode(',', $request->get('SOUR_FACTS_ADD', [])));
1099 1099
         $tree->setPreference('SOUR_FACTS_QUICK', implode(',', $request->get('SOUR_FACTS_QUICK', [])));
1100 1100
         $tree->setPreference('SOUR_FACTS_UNIQUE', implode(',', $request->get('SOUR_FACTS_UNIQUE', [])));
1101
-        $tree->setPreference('SUBLIST_TRIGGER_I', (string)(int)$request->get('SUBLIST_TRIGGER_I', 200));
1101
+        $tree->setPreference('SUBLIST_TRIGGER_I', (string) (int) $request->get('SUBLIST_TRIGGER_I', 200));
1102 1102
         $tree->setPreference('SURNAME_LIST_STYLE', $request->get('SURNAME_LIST_STYLE'));
1103 1103
         $tree->setPreference('SURNAME_TRADITION', $request->get('SURNAME_TRADITION'));
1104 1104
         $tree->setPreference('THEME_DIR', $request->get('THEME_DIR'));
1105
-        $tree->setPreference('USE_SILHOUETTE', (string)(bool)$request->get('USE_SILHOUETTE'));
1105
+        $tree->setPreference('USE_SILHOUETTE', (string) (bool) $request->get('USE_SILHOUETTE'));
1106 1106
         $tree->setPreference('WEBMASTER_USER_ID', $request->get('WEBMASTER_USER_ID'));
1107 1107
         $tree->setPreference('WEBTREES_EMAIL', $request->get('WEBTREES_EMAIL'));
1108 1108
         $tree->setPreference('title', $request->get('title'));
@@ -1607,7 +1607,7 @@  discard block
 block discarded – undo
1607 1607
 
1608 1608
         foreach ($gedcom_files as $gedcom_file) {
1609 1609
             // Only import files that have changed
1610
-            $filemtime = (string)filemtime(WT_DATA_DIR . $gedcom_file);
1610
+            $filemtime = (string) filemtime(WT_DATA_DIR . $gedcom_file);
1611 1611
 
1612 1612
             $tree = Tree::findByName($gedcom_file) ?? Tree::create($gedcom_file, $gedcom_file);
1613 1613
 
@@ -1640,7 +1640,7 @@  discard block
 block discarded – undo
1640 1640
      */
1641 1641
     public function unconnected(Request $request, Tree $tree, User $user): Response
1642 1642
     {
1643
-        $associates = (bool)$request->get('associates');
1643
+        $associates = (bool) $request->get('associates');
1644 1644
 
1645 1645
         if ($associates) {
1646 1646
             $sql = "SELECT l_from, l_to FROM `##link` WHERE l_file = :tree_id AND l_type IN ('FAMS', 'FAMC', 'ASSO', '_ASSO')";
Please login to merge, or discard this patch.
app/Http/Controllers/AdminSiteController.php 1 patch
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -263,35 +263,35 @@  discard block
 block discarded – undo
263 263
 
264 264
         $args = [];
265 265
         if ($search) {
266
-            $sql            .= " AND log_message LIKE CONCAT('%', :search, '%')";
266
+            $sql .= " AND log_message LIKE CONCAT('%', :search, '%')";
267 267
             $args['search'] = $search;
268 268
         }
269 269
         if ($from) {
270
-            $sql          .= " AND log_time >= :from";
270
+            $sql .= " AND log_time >= :from";
271 271
             $args['from'] = $from;
272 272
         }
273 273
         if ($to) {
274
-            $sql        .= " AND log_time < TIMESTAMPADD(DAY, 1 , :to)"; // before end of the day
274
+            $sql .= " AND log_time < TIMESTAMPADD(DAY, 1 , :to)"; // before end of the day
275 275
             $args['to'] = $to;
276 276
         }
277 277
         if ($type) {
278
-            $sql          .= " AND log_type = :type";
278
+            $sql .= " AND log_type = :type";
279 279
             $args['type'] = $type;
280 280
         }
281 281
         if ($text) {
282
-            $sql          .= " AND log_message LIKE CONCAT('%', :text, '%')";
282
+            $sql .= " AND log_message LIKE CONCAT('%', :text, '%')";
283 283
             $args['text'] = $text;
284 284
         }
285 285
         if ($ip) {
286
-            $sql        .= " AND ip_address LIKE CONCAT('%', :ip, '%')";
286
+            $sql .= " AND ip_address LIKE CONCAT('%', :ip, '%')";
287 287
             $args['ip'] = $ip;
288 288
         }
289 289
         if ($username) {
290
-            $sql          .= " AND user_name LIKE CONCAT('%', :user, '%')";
290
+            $sql .= " AND user_name LIKE CONCAT('%', :user, '%')";
291 291
             $args['user'] = $username;
292 292
         }
293 293
         if ($gedc) {
294
-            $sql          .= " AND gedcom_name = :gedc";
294
+            $sql .= " AND gedcom_name = :gedc";
295 295
             $args['gedc'] = $gedc;
296 296
         }
297 297
 
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
317 317
         }
318 318
 
319 319
         if ($length) {
320
-            $sql            .= " LIMIT :limit OFFSET :offset";
320
+            $sql .= " LIMIT :limit OFFSET :offset";
321 321
             $args['limit']  = $length;
322 322
             $args['offset'] = $start;
323 323
         }
@@ -375,35 +375,35 @@  discard block
 block discarded – undo
375 375
 
376 376
         $args = [];
377 377
         if ($search) {
378
-            $sql            .= " AND log_message LIKE CONCAT('%', :search, '%')";
378
+            $sql .= " AND log_message LIKE CONCAT('%', :search, '%')";
379 379
             $args['search'] = $search;
380 380
         }
381 381
         if ($from) {
382
-            $sql          .= " AND log_time >= :from";
382
+            $sql .= " AND log_time >= :from";
383 383
             $args['from'] = $from;
384 384
         }
385 385
         if ($to) {
386
-            $sql        .= " AND log_time < TIMESTAMPADD(DAY, 1 , :to)"; // before end of the day
386
+            $sql .= " AND log_time < TIMESTAMPADD(DAY, 1 , :to)"; // before end of the day
387 387
             $args['to'] = $to;
388 388
         }
389 389
         if ($type) {
390
-            $sql          .= " AND log_type = :type";
390
+            $sql .= " AND log_type = :type";
391 391
             $args['type'] = $type;
392 392
         }
393 393
         if ($text) {
394
-            $sql          .= " AND log_message LIKE CONCAT('%', :text, '%')";
394
+            $sql .= " AND log_message LIKE CONCAT('%', :text, '%')";
395 395
             $args['text'] = $text;
396 396
         }
397 397
         if ($ip) {
398
-            $sql        .= " AND ip_address LIKE CONCAT('%', :ip, '%')";
398
+            $sql .= " AND ip_address LIKE CONCAT('%', :ip, '%')";
399 399
             $args['ip'] = $ip;
400 400
         }
401 401
         if ($username) {
402
-            $sql          .= " AND user_name LIKE CONCAT('%', :user, '%')";
402
+            $sql .= " AND user_name LIKE CONCAT('%', :user, '%')";
403 403
             $args['user'] = $username;
404 404
         }
405 405
         if ($gedc) {
406
-            $sql          .= " AND gedcom_name = :gedc";
406
+            $sql .= " AND gedcom_name = :gedc";
407 407
             $args['gedc'] = $gedc;
408 408
         }
409 409
 
@@ -436,31 +436,31 @@  discard block
 block discarded – undo
436 436
 
437 437
         $args = [];
438 438
         if ($from) {
439
-            $sql          .= " AND log_time >= :from";
439
+            $sql .= " AND log_time >= :from";
440 440
             $args['from'] = $from;
441 441
         }
442 442
         if ($to) {
443
-            $sql        .= " AND log_time < TIMESTAMPADD(DAY, 1 , :to)"; // before end of the day
443
+            $sql .= " AND log_time < TIMESTAMPADD(DAY, 1 , :to)"; // before end of the day
444 444
             $args['to'] = $to;
445 445
         }
446 446
         if ($type) {
447
-            $sql          .= " AND log_type = :type";
447
+            $sql .= " AND log_type = :type";
448 448
             $args['type'] = $type;
449 449
         }
450 450
         if ($text) {
451
-            $sql          .= " AND log_message LIKE CONCAT('%', :text, '%')";
451
+            $sql .= " AND log_message LIKE CONCAT('%', :text, '%')";
452 452
             $args['text'] = $text;
453 453
         }
454 454
         if ($ip) {
455
-            $sql        .= " AND ip_address LIKE CONCAT('%', :ip, '%')";
455
+            $sql .= " AND ip_address LIKE CONCAT('%', :ip, '%')";
456 456
             $args['ip'] = $ip;
457 457
         }
458 458
         if ($username) {
459
-            $sql          .= " AND user_name LIKE CONCAT('%', :user, '%')";
459
+            $sql .= " AND user_name LIKE CONCAT('%', :user, '%')";
460 460
             $args['user'] = $username;
461 461
         }
462 462
         if ($gedc) {
463
-            $sql          .= " AND gedcom_name = :gedc";
463
+            $sql .= " AND gedcom_name = :gedc";
464 464
             $args['gedc'] = $gedc;
465 465
         }
466 466
 
Please login to merge, or discard this patch.
app/Http/Controllers/AdminUsersController.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -240,7 +240,7 @@
 block discarded – undo
240 240
             // Link to send email to other users.
241 241
             if ($user_id != $user->getUserId()) {
242 242
                 $datum[4] = '<a href="' . e(route('message', ['to'  => $datum[2],
243
-                                                              'url' => route('admin-users'),
243
+                                                                'url' => route('admin-users'),
244 244
                     ])) . '">' . $datum[4] . '</a>';
245 245
             }
246 246
 
Please login to merge, or discard this patch.
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
      */
51 51
     public function cleanup(Request $request): Response
52 52
     {
53
-        $months = (int)$request->get('months', 6);
53
+        $months = (int) $request->get('months', 6);
54 54
 
55 55
         $inactive_threshold   = time() - $months * 30 * self::SECONDS_PER_DAY;
56 56
         $unverified_threshold = time() - 7 * self::SECONDS_PER_DAY;
@@ -59,9 +59,9 @@  discard block
 block discarded – undo
59 59
 
60 60
         $inactive_users = array_filter($users, function (User $user) use ($inactive_threshold): bool {
61 61
             if ($user->getPreference('sessiontime') === '0') {
62
-                $datelogin = (int)$user->getPreference('reg_timestamp');
62
+                $datelogin = (int) $user->getPreference('reg_timestamp');
63 63
             } else {
64
-                $datelogin = (int)$user->getPreference('sessiontime');
64
+                $datelogin = (int) $user->getPreference('sessiontime');
65 65
             }
66 66
 
67 67
             return $datelogin < $inactive_threshold && $user->getPreference('verified');
@@ -69,9 +69,9 @@  discard block
 block discarded – undo
69 69
 
70 70
         $unverified_users = array_filter($users, function (User $user) use ($unverified_threshold): bool {
71 71
             if ($user->getPreference('sessiontime') === '0') {
72
-                $datelogin = (int)$user->getPreference('reg_timestamp');
72
+                $datelogin = (int) $user->getPreference('reg_timestamp');
73 73
             } else {
74
-                $datelogin = (int)$user->getPreference('sessiontime');
74
+                $datelogin = (int) $user->getPreference('sessiontime');
75 75
             }
76 76
 
77 77
             return $datelogin < $unverified_threshold && !$user->getPreference('verified');
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
     public function cleanupAction(Request $request): RedirectResponse
99 99
     {
100 100
         foreach (User::all() as $user) {
101
-            if ((bool)$request->get('del_' . $user->getUserId())) {
101
+            if ((bool) $request->get('del_' . $user->getUserId())) {
102 102
                 Log::addAuthenticationLog('Deleted user: ' . $user->getUserName());
103 103
                 $user->delete();
104 104
 
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 
124 124
         $all_users = User::all();
125 125
 
126
-        $page_size = (int)$user->getPreference(' admin_users_page_size', 10);
126
+        $page_size = (int) $user->getPreference(' admin_users_page_size', 10);
127 127
 
128 128
         $title = I18N::translate('User administration');
129 129
 
@@ -145,10 +145,10 @@  discard block
 block discarded – undo
145 145
     public function data(Request $request, User $user): JsonResponse
146 146
     {
147 147
         $search = $request->get('search')['value'];
148
-        $start  = (int)$request->get('start');
149
-        $length = (int)$request->get('length');
148
+        $start  = (int) $request->get('start');
149
+        $length = (int) $request->get('length');
150 150
         $order  = $request->get('order', []);
151
-        $draw   = (int)$request->get('draw');
151
+        $draw   = (int) $request->get('draw');
152 152
 
153 153
         $sql_select =
154 154
             "SELECT SQL_CALC_FOUND_ROWS u.user_id, user_name, real_name, email, us1.setting_value AS language, us2.setting_value AS registered_at, us3.setting_value AS active_at, us4.setting_value AS verified, us5.setting_value AS verified_by_admin" .
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
         $args = [];
164 164
 
165 165
         if ($search) {
166
-            $sql_select       .= " AND (user_name LIKE CONCAT('%', :search_1, '%') OR real_name LIKE CONCAT('%', :search_2, '%') OR email LIKE CONCAT('%', :search_3, '%'))";
166
+            $sql_select .= " AND (user_name LIKE CONCAT('%', :search_1, '%') OR real_name LIKE CONCAT('%', :search_2, '%') OR email LIKE CONCAT('%', :search_3, '%'))";
167 167
             $args['search_1'] = $search;
168 168
             $args['search_2'] = $search;
169 169
             $args['search_3'] = $search;
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 
193 193
         if ($length) {
194 194
             $user->setPreference('admin_users_page_size', $length);
195
-            $sql_select     .= " LIMIT :limit OFFSET :offset";
195
+            $sql_select .= " LIMIT :limit OFFSET :offset";
196 196
             $args['limit']  = $length;
197 197
             $args['offset'] = $start;
198 198
         }
@@ -200,8 +200,8 @@  discard block
 block discarded – undo
200 200
         $rows = Database::prepare($sql_select)->execute($args)->fetchAll();
201 201
 
202 202
         // Total filtered/unfiltered rows
203
-        $recordsFiltered = (int)Database::prepare("SELECT FOUND_ROWS()")->fetchOne();
204
-        $recordsTotal    = (int)Database::prepare("SELECT COUNT(*) FROM `##user` WHERE user_id > 0")->fetchOne();
203
+        $recordsFiltered = (int) Database::prepare("SELECT FOUND_ROWS()")->fetchOne();
204
+        $recordsTotal    = (int) Database::prepare("SELECT COUNT(*) FROM `##user` WHERE user_id > 0")->fetchOne();
205 205
 
206 206
         $installed_languages = [];
207 207
         foreach (I18N::installedLocales() as $installed_locale) {
@@ -289,7 +289,7 @@  discard block
 block discarded – undo
289 289
      */
290 290
     public function edit(Request $request): Response
291 291
     {
292
-        $user_id = (int)$request->get('user_id');
292
+        $user_id = (int) $request->get('user_id');
293 293
         $user    = User::find($user_id);
294 294
 
295 295
         if ($user === null) {
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
      */
373 373
     public function update(Request $request, User $user): RedirectResponse
374 374
     {
375
-        $user_id        = (int)$request->get('user_id');
375
+        $user_id        = (int) $request->get('user_id');
376 376
         $username       = $request->get('username');
377 377
         $real_name      = $request->get('real_name');
378 378
         $email          = $request->get('email');
@@ -382,11 +382,11 @@  discard block
 block discarded – undo
382 382
         $timezone       = $request->get('timezone');
383 383
         $contact_method = $request->get('contact_method');
384 384
         $comment        = $request->get('comment');
385
-        $auto_accept    = (bool)$request->get('auto_accept');
386
-        $canadmin       = (bool)$request->get('canadmin');
387
-        $visible_online = (bool)$request->get('visible_online');
388
-        $verified       = (bool)$request->get('verified');
389
-        $approved       = (bool)$request->get('approved');
385
+        $auto_accept    = (bool) $request->get('auto_accept');
386
+        $canadmin       = (bool) $request->get('canadmin');
387
+        $visible_online = (bool) $request->get('visible_online');
388
+        $verified       = (bool) $request->get('verified');
389
+        $approved       = (bool) $request->get('approved');
390 390
 
391 391
         $edit_user = User::find($user_id);
392 392
 
@@ -403,10 +403,10 @@  discard block
 block discarded – undo
403 403
             ->setPreference('TIMEZONE', $timezone)
404 404
             ->setPreference('contactmethod', $contact_method)
405 405
             ->setPreference('comment', $comment)
406
-            ->setPreference('auto_accept', (string)$auto_accept)
407
-            ->setPreference('visibleonline', (string)$visible_online)
408
-            ->setPreference('verified', (string)$verified)
409
-            ->setPreference('verified_by_admin', (string)$approved);
406
+            ->setPreference('auto_accept', (string) $auto_accept)
407
+            ->setPreference('visibleonline', (string) $visible_online)
408
+            ->setPreference('verified', (string) $verified)
409
+            ->setPreference('verified_by_admin', (string) $approved);
410 410
 
411 411
         if ($pass1 !== '') {
412 412
             $edit_user->setPassword($pass1);
@@ -418,7 +418,7 @@  discard block
 block discarded – undo
418 418
         }
419 419
 
420 420
         foreach (Tree::getAll() as $tree) {
421
-            $path_length = (int)$request->get('RELATIONSHIP_PATH_LENGTH' . $tree->getTreeId());
421
+            $path_length = (int) $request->get('RELATIONSHIP_PATH_LENGTH' . $tree->getTreeId());
422 422
             $gedcom_id   = $request->get('gedcomid' . $tree->getTreeId(), '');
423 423
             $can_edit    = $request->get('canedit' . $tree->getTreeId(), '');
424 424
 
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
 
430 430
             $tree->setUserPreference($edit_user, 'gedcomid', $gedcom_id);
431 431
             $tree->setUserPreference($edit_user, 'canedit', $can_edit);
432
-            $tree->setUserPreference($edit_user, 'RELATIONSHIP_PATH_LENGTH', (string)$path_length);
432
+            $tree->setUserPreference($edit_user, 'RELATIONSHIP_PATH_LENGTH', (string) $path_length);
433 433
         }
434 434
 
435 435
         $url = route('admin-users');
Please login to merge, or discard this patch.
app/Services/UpgradeService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
     {
74 74
         $latest_version = $this->fetchLatestVersion();
75 75
 
76
-        list(, , $url) = explode('|', $latest_version . '||');
76
+        list(,, $url) = explode('|', $latest_version . '||');
77 77
 
78 78
         return $url;
79 79
     }
Please login to merge, or discard this patch.
app/Functions/FunctionsPrintLists.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
                 } else {
54 54
                     $size = 75.0 + 125.0 * ($count - $minimum) / ($maximum - $minimum);
55 55
                 }
56
-                $url  = route($route, [
56
+                $url = route($route, [
57 57
                     'surname' => $surn,
58 58
                     'ged'     => $tree->getName(),
59 59
                 ]);
@@ -130,13 +130,13 @@  discard block
 block discarded – undo
130 130
                 }
131 131
                 $newcol = ceil($count / $col);
132 132
                 $html2  = '<table class="list_table"><tr>';
133
-                $html2  .= '<td class="list_value" style="padding: 14px;">';
133
+                $html2 .= '<td class="list_value" style="padding: 14px;">';
134 134
 
135 135
                 foreach ($html as $surns) {
136 136
                     $html2 .= $surns . '<br>';
137 137
                     $i++;
138 138
                     if ($i == $newcol && $i < $count) {
139
-                        $html2  .= '</td><td class="list_value" style="padding: 14px;">';
139
+                        $html2 .= '</td><td class="list_value" style="padding: 14px;">';
140 140
                         $newcol = $i + ceil($count / $col);
141 141
                     }
142 142
                 }
Please login to merge, or discard this patch.
app/Module/TopSurnamesModule.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@
 block discarded – undo
72 72
 
73 73
         extract($cfg, EXTR_OVERWRITE);
74 74
 
75
-         // Use the count of base surnames.
75
+            // Use the count of base surnames.
76 76
         $top_surnames = Database::prepare(
77 77
             "SELECT n_surn FROM `##name`" .
78 78
             " WHERE n_file = :tree_id AND n_type != '_MARNM' AND n_surn NOT IN ('@N.N.', '')" .
Please login to merge, or discard this patch.
app/I18N.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -841,23 +841,23 @@
 block discarded – undo
841 841
         $year   = 365 * $day;
842 842
 
843 843
         if ($seconds > $year) {
844
-            $years = (int)($seconds / $year);
844
+            $years = (int) ($seconds / $year);
845 845
 
846 846
             return self::plural('%s year ago', '%s years ago', $years, self::number($years));
847 847
         } elseif ($seconds > $month) {
848
-            $months = (int)($seconds / $month);
848
+            $months = (int) ($seconds / $month);
849 849
 
850 850
             return self::plural('%s month ago', '%s months ago', $months, self::number($months));
851 851
         } elseif ($seconds > $day) {
852
-            $days = (int)($seconds / $day);
852
+            $days = (int) ($seconds / $day);
853 853
 
854 854
             return self::plural('%s day ago', '%s days ago', $days, self::number($days));
855 855
         } elseif ($seconds > $hour) {
856
-            $hours = (int)($seconds / $hour);
856
+            $hours = (int) ($seconds / $hour);
857 857
 
858 858
             return self::plural('%s hour ago', '%s hours ago', $hours, self::number($hours));
859 859
         } elseif ($seconds > $minute) {
860
-            $minutes = (int)($seconds / $minute);
860
+            $minutes = (int) ($seconds / $minute);
861 861
 
862 862
             return self::plural('%s minute ago', '%s minutes ago', $minutes, self::number($minutes));
863 863
         } else {
Please login to merge, or discard this patch.
app/Report/ReportParserGenerate.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -1843,7 +1843,7 @@  discard block
 block discarded – undo
1843 1843
         // Some filters/sorts can be applied using SQL, while others require PHP
1844 1844
         switch ($listname) {
1845 1845
             case 'pending':
1846
-                $rows       = Database::prepare(
1846
+                $rows = Database::prepare(
1847 1847
                     "SELECT xref, CASE new_gedcom WHEN '' THEN old_gedcom ELSE new_gedcom END AS gedcom" .
1848 1848
                     " FROM `##change`" . " WHERE (xref, change_id) IN (" .
1849 1849
                     "  SELECT xref, MAX(change_id)" .
@@ -1882,7 +1882,7 @@  discard block
 block discarded – undo
1882 1882
                                 $sql_params[$attr . 'date'] = $date->minimumJulianDay();
1883 1883
                             }
1884 1884
                             if ($sortby == $match[1]) {
1885
-                                $sortby       = "";
1885
+                                $sortby = "";
1886 1886
                                 $sql_order_by .= ($sql_order_by ? ", " : " ORDER BY ") . "{$attr}.d_julianday1";
1887 1887
                             }
1888 1888
                             unset($attrs[$attr]); // This filter has been fully processed
@@ -1894,13 +1894,13 @@  discard block
 block discarded – undo
1894 1894
                                 if ($match[1] != '') {
1895 1895
                                     $names = explode(' ', $match[1]);
1896 1896
                                     foreach ($names as $n => $name) {
1897
-                                        $sql_where                       .= " AND {$attr}.n_full LIKE CONCAT('%', :{$attr}name{$n}, '%')";
1897
+                                        $sql_where .= " AND {$attr}.n_full LIKE CONCAT('%', :{$attr}name{$n}, '%')";
1898 1898
                                         $sql_params[$attr . 'name' . $n] = $name;
1899 1899
                                     }
1900 1900
                                 }
1901 1901
                                 // Let the DB do the name sorting even when no name was entered
1902 1902
                                 if ($sortby == 'NAME') {
1903
-                                    $sortby       = '';
1903
+                                    $sortby = '';
1904 1904
                                     $sql_order_by .= ($sql_order_by ? ', ' : ' ORDER BY ') . "{$attr}.n_sort";
1905 1905
                                 }
1906 1906
                             }
@@ -1917,7 +1917,7 @@  discard block
 block discarded – undo
1917 1917
                             $sql_params[$attr . 'place'] = $match[1];
1918 1918
                             // Don't unset this filter. This is just initial filtering
1919 1919
                         } elseif (preg_match('/^(\w*):*(\w*) CONTAINS (.+)$/', $value, $match)) {
1920
-                            $sql_where                       .= " AND i_gedcom LIKE CONCAT('%', :{$attr}contains1, '%', :{$attr}contains2, '%', :{$attr}contains3, '%')";
1920
+                            $sql_where .= " AND i_gedcom LIKE CONCAT('%', :{$attr}contains1, '%', :{$attr}contains2, '%', :{$attr}contains3, '%')";
1921 1921
                             $sql_params[$attr . 'contains1'] = $match[1];
1922 1922
                             $sql_params[$attr . 'contains2'] = $match[2];
1923 1923
                             $sql_params[$attr . 'contains3'] = $match[3];
@@ -1959,7 +1959,7 @@  discard block
 block discarded – undo
1959 1959
                                 $sql_params[$attr . 'date'] = $date->minimumJulianDay();
1960 1960
                             }
1961 1961
                             if ($sortby == $match[1]) {
1962
-                                $sortby       = '';
1962
+                                $sortby = '';
1963 1963
                                 $sql_order_by .= ($sql_order_by ? ', ' : ' ORDER BY ') . "{$attr}.d_julianday1";
1964 1964
                             }
1965 1965
                             unset($attrs[$attr]); // This filter has been fully processed
@@ -1976,13 +1976,13 @@  discard block
 block discarded – undo
1976 1976
                                 if ($match[1] != '') {
1977 1977
                                     $names = explode(' ', $match[1]);
1978 1978
                                     foreach ($names as $n => $name) {
1979
-                                        $sql_where                       .= " AND {$attr}.n_full LIKE CONCAT('%', :{$attr}name{$n}, '%')";
1979
+                                        $sql_where .= " AND {$attr}.n_full LIKE CONCAT('%', :{$attr}name{$n}, '%')";
1980 1980
                                         $sql_params[$attr . 'name' . $n] = $name;
1981 1981
                                     }
1982 1982
                                 }
1983 1983
                                 // Let the DB do the name sorting even when no name was entered
1984 1984
                                 if ($sortby == 'NAME') {
1985
-                                    $sortby       = '';
1985
+                                    $sortby = '';
1986 1986
                                     $sql_order_by .= ($sql_order_by ? ', ' : ' ORDER BY ') . "{$attr}.n_sort";
1987 1987
                                 }
1988 1988
                             }
@@ -1994,7 +1994,7 @@  discard block
 block discarded – undo
1994 1994
                             $sql_params[$attr . 'place'] = $match[1];
1995 1995
                             // Don't unset this filter. This is just initial filtering
1996 1996
                         } elseif (preg_match('/^(\w*):*(\w*) CONTAINS (.+)$/', $value, $match)) {
1997
-                            $sql_where                       .= " AND f_gedcom LIKE CONCAT('%', :{$attr}contains1, '%', :{$attr}contains2, '%', :{$attr}contains3, '%')";
1997
+                            $sql_where .= " AND f_gedcom LIKE CONCAT('%', :{$attr}contains1, '%', :{$attr}contains2, '%', :{$attr}contains3, '%')";
1998 1998
                             $sql_params[$attr . 'contains1'] = $match[1];
1999 1999
                             $sql_params[$attr . 'contains2'] = $match[2];
2000 2000
                             $sql_params[$attr . 'contains3'] = $match[3];
Please login to merge, or discard this patch.
app/Http/Controllers/AdminMediaController.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -119,8 +119,8 @@  discard block
 block discarded – undo
119 119
         $files  = $request->get('files'); // local|external|unused
120 120
         $search = $request->get('search');
121 121
         $search = $search['value'];
122
-        $start  = (int)$request->get('start');
123
-        $length = (int)$request->get('length');
122
+        $start  = (int) $request->get('start');
123
+        $length = (int) $request->get('length');
124 124
 
125 125
         // family tree setting MEDIA_DIRECTORY
126 126
         $media_folders = $this->allMediaFolders();
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
                     "  OR   descriptive_title LIKE CONCAT('%', :search_2, '%'))" .
157 157
                     " AND   multimedia_file_refn NOT LIKE 'http://%'" .
158 158
                     " AND   multimedia_file_refn NOT LIKE 'https://%'";
159
-                $ARGS1   = [
159
+                $ARGS1 = [
160 160
                     'media_path_1' => $media_path,
161 161
                     'media_folder' => $media_folder,
162 162
                     'media_path_2' => Database::escapeLike($media_path),
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
                     " AND   multimedia_file_refn LIKE CONCAT(:media_path_3, '%')" .
174 174
                     " AND   multimedia_file_refn NOT LIKE 'http://%'" .
175 175
                     " AND   multimedia_file_refn NOT LIKE 'https://%'";
176
-                $ARGS2   = [
176
+                $ARGS2 = [
177 177
                     'media_folder' => $media_folder,
178 178
                     'media_path_3' => $media_path,
179 179
                 ];
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
                     $ARGS2['media_path_4'] = Database::escapeLike($media_path);
186 186
                 }
187 187
 
188
-                $order   = $request->get('order', []);
188
+                $order = $request->get('order', []);
189 189
                 $SELECT1 .= " ORDER BY ";
190 190
                 if ($order) {
191 191
                     foreach ($order as $key => $value) {
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
                 }
210 210
 
211 211
                 if ($length > 0) {
212
-                    $SELECT1         .= " LIMIT :length OFFSET :start";
212
+                    $SELECT1 .= " LIMIT :length OFFSET :start";
213 213
                     $ARGS1['length'] = $length;
214 214
                     $ARGS1['start']  = $start;
215 215
                 }
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
                     " JOIN  `##media_file` USING (m_id, m_file)" .
243 243
                     " WHERE (multimedia_file_refn LIKE 'http://%' OR multimedia_file_refn LIKE 'https://%')" .
244 244
                     " AND   (multimedia_file_refn LIKE CONCAT('%', :search_1, '%') OR descriptive_title LIKE CONCAT('%', :search_2, '%'))";
245
-                $ARGS1   = [
245
+                $ARGS1 = [
246 246
                     'search_1' => Database::escapeLike($search),
247 247
                     'search_2' => Database::escapeLike($search),
248 248
                 ];
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
278 278
                 }
279 279
 
280 280
                 if ($length > 0) {
281
-                    $SELECT1         .= " LIMIT :length OFFSET :start";
281
+                    $SELECT1 .= " LIMIT :length OFFSET :start";
282 282
                     $ARGS1['length'] = $length;
283 283
                     $ARGS1['start']  = $start;
284 284
                 }
@@ -660,7 +660,7 @@  discard block
 block discarded – undo
660 660
         $full_path = WT_DATA_DIR . $media_folder . $media_path . $file;
661 661
         try {
662 662
             $size = filesize($full_path);
663
-            $size = (int)(($size + 1023) / 1024); // Round up to next KB
663
+            $size = (int) (($size + 1023) / 1024); // Round up to next KB
664 664
             /* I18N: size of file in KB */
665 665
             $size = I18N::translate('%s KB', I18N::number($size));
666 666
             $html .= '<dt>' . I18N::translate('File size') . '</dt>';
Please login to merge, or discard this patch.