Completed
Branch develop (bfa16a)
by Greg
10:11
created
message.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 $controller->restrictAccess(!in_array($to, ['all', 'never_logged', 'last_6mo']) || Auth::isAdmin());
101 101
 $controller->pageHeader();
102 102
 
103
-$to_names = implode(I18N::$list_separator, array_map(function(User $user) { return $user->getRealName(); }, recipients($to)));
103
+$to_names = implode(I18N::$list_separator, array_map(function (User $user) { return $user->getRealName(); }, recipients($to)));
104 104
 
105 105
 ?>
106 106
 <h2><?= I18N::translate('Send a message') ?></h2>
@@ -185,13 +185,13 @@  discard block
 block discarded – undo
185 185
  */
186 186
 function recipients($to) {
187 187
 	if ($to === 'all') {
188
-		$recipients =	User::all();
188
+		$recipients = User::all();
189 189
 	} elseif ($to === 'last_6mo') {
190
-		$recipients = array_filter(User::all(), function(User $user) {
190
+		$recipients = array_filter(User::all(), function (User $user) {
191 191
 			return $user->getPreference('sessiontime') > 0 && WT_TIMESTAMP - $user->getPreference('sessiontime') > 60 * 60 * 24 * 30 * 6;
192 192
 		});
193 193
 	} elseif ($to === 'never_logged') {
194
-		$recipients = array_filter(User::all(), function(User $user) {
194
+		$recipients = array_filter(User::all(), function (User $user) {
195 195
 			return $user->getPreference('verified_by_admin') && $user->getPreference('reg_timestamp') > $user->getPreference('sessiontime');
196 196
 		});
197 197
 	} else {
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -128,7 +128,8 @@  discard block
 block discarded – undo
128 128
 				<div class="form-control"><?= Filter::escapeHtml(Auth::user()->getRealName()) ?></div>
129 129
 			</div>
130 130
 		</div>
131
-	<?php else: ?>
131
+	<?php else {
132
+	: ?>
132 133
 		<div class="form-group row">
133 134
 			<label class="col-sm-3 col-form-label" for="from-name">
134 135
 				<?= I18N::translate('Your name') ?>
@@ -186,6 +187,7 @@  discard block
 block discarded – undo
186 187
 function recipients($to) {
187 188
 	if ($to === 'all') {
188 189
 		$recipients =	User::all();
190
+}
189 191
 	} elseif ($to === 'last_6mo') {
190 192
 		$recipients = array_filter(User::all(), function(User $user) {
191 193
 			return $user->getPreference('sessiontime') > 0 && WT_TIMESTAMP - $user->getPreference('sessiontime') > 60 * 60 * 24 * 30 * 6;
Please login to merge, or discard this patch.
app/Date/JewishDate.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -247,7 +247,7 @@
 block discarded – undo
247 247
 	/**
248 248
 	 * Which months follows this one? Calendars with leap-months should provide their own implementation.
249 249
 	 *
250
-	 * @return int[]
250
+	 * @return integer[]
251 251
 	 */
252 252
 	protected function nextMonth() {
253 253
 		if ($this->m == 6 && !$this->isLeapYear()) {
Please login to merge, or discard this patch.
app/Date/CalendarDate.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -842,7 +842,7 @@
 block discarded – undo
842 842
 	/**
843 843
 	 * Which months follows this one? Calendars with leap-months should provide their own implementation.
844 844
 	 *
845
-	 * @return int[]
845
+	 * @return integer[]
846 846
 	 */
847 847
 	protected function nextMonth() {
848 848
 		return [$this->m === $this->calendar->monthsInYear() ? $this->nextYear($this->y) : $this->y, ($this->m % $this->calendar->monthsInYear()) + 1];
Please login to merge, or discard this patch.
app/Module/StoriesModule.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -381,7 +381,8 @@  discard block
 block discarded – undo
381 381
 						<a href="<?= $individual->getHtmlUrl() ?>#tab-stories">
382 382
 							<?= $individual->getFullName() ?>
383 383
 						</a>
384
-						<?php else: ?>
384
+						<?php else {
385
+	: ?>
385 386
 							<?= $story->xref ?>
386 387
 						<?php endif ?>
387 388
 						</td>
@@ -410,6 +411,7 @@  discard block
 block discarded – undo
410 411
 	 */
411 412
 	private function showList() {
412 413
 		global $controller, $WT_TREE;
414
+}
413 415
 
414 416
 		$controller = new PageController;
415 417
 		$controller
Please login to merge, or discard this patch.
app/Mail.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@
 block discarded – undo
16 16
 namespace Fisharebest\Webtrees;
17 17
 
18 18
 use Exception;
19
-use Swift_Mailer;
20 19
 use Swift_MailTransport;
20
+use Swift_Mailer;
21 21
 use Swift_Message;
22 22
 use Swift_NullTransport;
23 23
 use Swift_Preferences;
Please login to merge, or discard this patch.
app/Theme/CloudsTheme.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
 			if (!empty($menu->getSubmenus())) {
107 107
 				// Insert a dummy menu / label into the submenu
108 108
 				$submenus = $menu->getSubmenus();
109
-				array_unshift($submenus, new Menu($menu->getLabel(), null, null, [ 'onclick' => 'return false;']));
109
+				array_unshift($submenus, new Menu($menu->getLabel(), null, null, ['onclick' => 'return false;']));
110 110
 				$menu->setSubmenus($submenus);
111 111
 			}
112 112
 
Please login to merge, or discard this patch.
app/Module/GoogleMapsModule.php 2 patches
Switch Indentation   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -1120,24 +1120,24 @@
 block discarded – undo
1120 1120
 										if ($latlongval[$i] == $latlongval[$k]) {
1121 1121
 											$dups++;
1122 1122
 											switch ($dups) {
1123
-												case 1:
1124
-													$marker_number = $curgen . 'L';
1125
-													break;
1126
-												case 2:
1127
-													$marker_number = $curgen . 'R';
1128
-													break;
1129
-												case 3:
1130
-													$marker_number = $curgen . 'Ls';
1131
-													break;
1132
-												case 4:
1133
-													$marker_number = $curgen . 'Rs';
1134
-													break;
1135
-												case 5: //adjust position where markers have same coodinates
1136
-												default:
1137
-													$marker_number = $curgen;
1138
-													$lon[$i] += 0.0025;
1139
-													$lat[$i] += 0.0025;
1140
-													break;
1123
+											case 1:
1124
+												$marker_number = $curgen . 'L';
1125
+												break;
1126
+											case 2:
1127
+												$marker_number = $curgen . 'R';
1128
+												break;
1129
+											case 3:
1130
+												$marker_number = $curgen . 'Ls';
1131
+												break;
1132
+											case 4:
1133
+												$marker_number = $curgen . 'Rs';
1134
+												break;
1135
+											case 5: //adjust position where markers have same coodinates
1136
+											default:
1137
+												$marker_number = $curgen;
1138
+												$lon[$i] += 0.0025;
1139
+												$lat[$i] += 0.0025;
1140
+												break;
1141 1141
 											}
1142 1142
 										}
1143 1143
 									}
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -2235,7 +2235,7 @@  discard block
 block discarded – undo
2235 2235
 				'place_id' => $place_id,
2236 2236
 			]);
2237 2237
 		} catch (\Exception $ex) {
2238
-			FlashMessages::addMessage(I18N::translate('Location not removed: this location contains sub-locations'),'danger');
2238
+			FlashMessages::addMessage(I18N::translate('Location not removed: this location contains sub-locations'), 'danger');
2239 2239
 		}
2240 2240
 
2241 2241
 		header('Location: ' . WT_BASE_URL . 'module.php?mod=googlemap&mod_action=admin_places&parent_id=' . $parent_id . '&inactive=' . $inactive);
@@ -2582,7 +2582,7 @@  discard block
 block discarded – undo
2582 2582
 			[0 => I18N::translate('Geographic data')] +
2583 2583
 			$this->placeIdToHierarchy($place_id === 0 ? $parent_id : $place_id);
2584 2584
 		foreach ($hierarchy as $id => $name) {
2585
-				$breadcrumbs += ['module.php?mod=googlemap&mod_action=admin_places&parent_id=' . $id .'&inactive=' . $inactive => Filter::escapeHtml($name)];
2585
+				$breadcrumbs += ['module.php?mod=googlemap&mod_action=admin_places&parent_id=' . $id . '&inactive=' . $inactive => Filter::escapeHtml($name)];
2586 2586
 		}
2587 2587
 		echo Bootstrap4::breadcrumbs($breadcrumbs, $place_id === 0 ? I18N::translate('Add') : I18N::translate('Edit'));
2588 2588
 
@@ -3088,7 +3088,7 @@  discard block
 block discarded – undo
3088 3088
 			[0 => I18N::translate('Geographic data')] +
3089 3089
 			$this->placeIdToHierarchy($parent_id);
3090 3090
 		foreach (array_slice($hierarchy, 0, -1, true) as $id => $name) {
3091
-				$breadcrumbs += ['module.php?mod=googlemap&mod_action=admin_places&parent_id=' . $id .'&inactive=' . $inactive => Filter::escapeHtml($name)];
3091
+				$breadcrumbs += ['module.php?mod=googlemap&mod_action=admin_places&parent_id=' . $id . '&inactive=' . $inactive => Filter::escapeHtml($name)];
3092 3092
 		}
3093 3093
 		echo Bootstrap4::breadcrumbs($breadcrumbs, end($hierarchy));
3094 3094
 
@@ -3280,7 +3280,7 @@  discard block
 block discarded – undo
3280 3280
 								<?php endif ?>
3281 3281
 						</td>
3282 3282
 						<td>
3283
-							<?= FontAwesome::linkIcon('edit',  I18N::translate('Edit'), ['href' => 'module.php?mod=googlemap&mod_action=admin_place_edit&action=update&place_id=' . $place['place_id'] . '&parent_id=' . $place['parent_id'], 'class' => 'btn btn-primary']) ?>
3283
+							<?= FontAwesome::linkIcon('edit', I18N::translate('Edit'), ['href' => 'module.php?mod=googlemap&mod_action=admin_place_edit&action=update&place_id=' . $place['place_id'] . '&parent_id=' . $place['parent_id'], 'class' => 'btn btn-primary']) ?>
3284 3284
 						</td>
3285 3285
 						<td>
3286 3286
 							<?php if ($noRows == 0): ?>
@@ -3289,7 +3289,7 @@  discard block
 block discarded – undo
3289 3289
 									<input type="hidden" name="place_id" value="<?= $place['place_id'] ?>">
3290 3290
 									<input type="hidden" name="inactive" value="<?= $inactive ?>">
3291 3291
 									<button type="submit" class="btn btn-danger">
3292
-										<?= FontAwesome::semanticIcon('delete',  I18N::translate('Delete')) ?>
3292
+										<?= FontAwesome::semanticIcon('delete', I18N::translate('Delete')) ?>
3293 3293
 									</button>
3294 3294
 								</form>
3295 3295
 							<?php else: ?>
Please login to merge, or discard this patch.
app/Database.php 1 patch
Spacing   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -85,8 +85,7 @@  discard block
 block discarded – undo
85 85
 		// Create the underlying PDO object
86 86
 		self::$pdo = new PDO(
87 87
 			(substr($DBHOST, 0, 1) === '/' ?
88
-				"mysql:unix_socket={$DBHOST};dbname={$DBNAME}" :
89
-				"mysql:host={$DBHOST};dbname={$DBNAME};port={$DBPORT}"
88
+				"mysql:unix_socket={$DBHOST};dbname={$DBNAME}" : "mysql:host={$DBHOST};dbname={$DBNAME};port={$DBPORT}"
90 89
 			),
91 90
 			$DBUSER, $DBPASS,
92 91
 			[
@@ -161,7 +160,7 @@  discard block
 block discarded – undo
161 160
 			}
162 161
 		}
163 162
 		$milliseconds = sprintf('%.3f', $microseconds * 1000);
164
-		self::$log[] = '<tr><td>' .$stack . '</td><td>' . $query . '</td><td>' . $rows . '</td><td>' . $milliseconds . '</td></tr>';
163
+		self::$log[] = '<tr><td>' . $stack . '</td><td>' . $query . '</td><td>' . $rows . '</td><td>' . $milliseconds . '</td></tr>';
165 164
 	}
166 165
 
167 166
 	/**
Please login to merge, or discard this patch.
app/Functions/FunctionsCharts.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -297,9 +297,9 @@
 block discarded – undo
297 297
 
298 298
 		if ($sosa == 0 && Auth::isEditor($family->getTree())) {
299 299
 			echo '<br>';
300
-			echo '<a href="edit_interface.php?action=add_child_to_family&amp;ged=' . $family->getTree()->getNameHtml() .'&amp;xref=' . $family->getXref() . '&amp;gender=U">' . I18N::translate('Add a child to this family') . '</a>';
301
-			echo ' <a class="icon-sex_m_15x15" href="edit_interface.php?action=add_child_to_family&amp;ged=' . $family->getTree()->getNameHtml() .'&amp;xref=' . $family->getXref() . '&amp;gender=M" title="', I18N::translate('son'), '"></a>';
302
-			echo ' <a class="icon-sex_f_15x15" href="edit_interface.php?action=add_child_to_family&amp;ged=' . $family->getTree()->getNameHtml() .'&amp;xref=' . $family->getXref() . '&amp;gender=F" title="', I18N::translate('daughter'), '"></a>';
300
+			echo '<a href="edit_interface.php?action=add_child_to_family&amp;ged=' . $family->getTree()->getNameHtml() . '&amp;xref=' . $family->getXref() . '&amp;gender=U">' . I18N::translate('Add a child to this family') . '</a>';
301
+			echo ' <a class="icon-sex_m_15x15" href="edit_interface.php?action=add_child_to_family&amp;ged=' . $family->getTree()->getNameHtml() . '&amp;xref=' . $family->getXref() . '&amp;gender=M" title="', I18N::translate('son'), '"></a>';
302
+			echo ' <a class="icon-sex_f_15x15" href="edit_interface.php?action=add_child_to_family&amp;ged=' . $family->getTree()->getNameHtml() . '&amp;xref=' . $family->getXref() . '&amp;gender=F" title="', I18N::translate('daughter'), '"></a>';
303 303
 			echo '<br><br>';
304 304
 		}
305 305
 		echo '</td>';
Please login to merge, or discard this patch.