Completed
Branch develop (bfa16a)
by Greg
10:11
created
medialist.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@
 block discarded – undo
109 109
 						</option>
110 110
 					</select>
111 111
 				</td>
112
-				<?php else: ?>
112
+				<?php else : ?>
113 113
 					<td class="descriptionbox wrap"></td>
114 114
 					<td class="optionbox wrap"></td>
115 115
 				<?php endif ?>
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -109,7 +109,8 @@  discard block
 block discarded – undo
109 109
 						</option>
110 110
 					</select>
111 111
 				</td>
112
-				<?php else: ?>
112
+				<?php else {
113
+	: ?>
113 114
 					<td class="descriptionbox wrap"></td>
114 115
 					<td class="optionbox wrap"></td>
115 116
 				<?php endif ?>
@@ -133,6 +134,7 @@  discard block
 block discarded – undo
133 134
 						<?php
134 135
 						foreach (['10', '20', '30', '40', '50', '75', '100', '125', '150', '200'] as $selectEntry) {
135 136
 							echo '<option value="', $selectEntry, '" ';
137
+}
136 138
 							if ($selectEntry == $max) {
137 139
 								echo 'selected';
138 140
 							}
Please login to merge, or discard this patch.
admin_users.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -770,13 +770,15 @@
 block discarded – undo
770 770
 		<p>
771 771
 		<?php if ($ucnt): ?>
772 772
 			<input type="submit" value="<?= I18N::translate('delete') ?>">
773
-			<?php else: ?>
773
+			<?php else {
774
+	: ?>
774 775
 			<?= I18N::translate('Nothing found to cleanup') ?>
775 776
 			<?php endif ?>
776 777
 		</p>
777 778
 	</form>
778 779
 	<?php
779 780
 	break;
781
+}
780 782
 
781 783
 case 'cleanup2':
782 784
 	foreach (User::all() as $user) {
Please login to merge, or discard this patch.
search_advanced.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -154,7 +154,8 @@  discard block
 block discarded – undo
154 154
 				<input type="text" id="value<?= $i ?>" name="values[<?= $i ?>]" value="<?= Filter::escapeHtml($controller->getValue($i)) ?>"<?= substr($controller->getField($i), -4) == 'PLAC' ? 'data-autocomplete-type="PLAC"' : '' ?>>
155 155
 			<?php if (preg_match('/^NAME:/', $currentFieldSearch) > 0) { ?>
156 156
 				<select name="fields[<?= $i ?>]">
157
-					<option value="<?= $currentField ?>:EXACT" <?php if (preg_match('/:EXACT$/', $currentFieldSearch) > 0) echo 'selected' ?>><?= I18N::translate('Exact') ?></option>
157
+					<option value="<?= $currentField ?>:EXACT" <?php if (preg_match('/:EXACT$/', $currentFieldSearch) > 0) {
158
+	echo 'selected' ?>><?= I18N::translate('Exact') ?></option>
158 159
 					<option value="<?= $currentField ?>:BEGINS" <?php if (preg_match('/:BEGINS$/', $currentFieldSearch) > 0) echo 'selected' ?>><?= I18N::translate('Begins with') ?></option>
159 160
 					<option value="<?= $currentField ?>:CONTAINS" <?php if (preg_match('/:CONTAINS$/', $currentFieldSearch) > 0) echo 'selected' ?>><?= I18N::translate('Contains') ?></option>
160 161
 					<option value="<?= $currentField ?>:SDX" <?php if (preg_match('/:SDX$/', $currentFieldSearch) > 0) echo 'selected' ?>><?= I18N::translate('Sounds like') ?></option>
@@ -176,6 +177,7 @@  discard block
 block discarded – undo
176 177
 		//-- relative fields
177 178
 		if ($i == 0 && $fct > 4) {
178 179
 			$j = $fct;
180
+}
179 181
 			// Get the current options for Father’s and Mother’s name searches
180 182
 			$fatherGivnOption = 'SDX';
181 183
 			$fatherSurnOption = 'SDX';
Please login to merge, or discard this patch.
app/Module/BatchUpdate/BatchUpdateBasePlugin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -148,7 +148,7 @@
 block discarded – undo
148 148
 	public static function createEditLinks($gedrec, GedcomRecord $record) {
149 149
 		return preg_replace(
150 150
 			"/@([^#@\n]+)@/m",
151
-			'<a href="edit_interface.php?action=editraw&amp;ged=' . $record->getTree()->getNameHtml() . '&amp;xref=' . $record->getXref() .'">@\\1@</a>',
151
+			'<a href="edit_interface.php?action=editraw&amp;ged=' . $record->getTree()->getNameHtml() . '&amp;xref=' . $record->getXref() . '">@\\1@</a>',
152 152
 			$gedrec
153 153
 		);
154 154
 	}
Please login to merge, or discard this patch.
app/Datatables.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
 
65 65
 		return [
66 66
 			'data-language'    => json_encode($language),
67
-		  'data-length-menu' => json_encode([array_keys($length_menu), array_values($length_menu)])
67
+			'data-length-menu' => json_encode([array_keys($length_menu), array_values($length_menu)])
68 68
 		];
69 69
 	}
70 70
 
Please login to merge, or discard this patch.
individual.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@
 block discarded – undo
89 89
 if (Auth::isAdmin()) {
90 90
 	$user = User::findByGenealogyRecord($controller->record);
91 91
 	if ($user) {
92
-		$user_link =  ' —  <a href="admin_users.php?filter=' . Filter::escapeHtml($user->getUserName()) . '">' . Filter::escapeHtml($user->getUserName()) . '</a>';
92
+		$user_link = ' —  <a href="admin_users.php?filter=' . Filter::escapeHtml($user->getUserName()) . '">' . Filter::escapeHtml($user->getUserName()) . '</a>';
93 93
 	};
94 94
 }
95 95
 
Please login to merge, or discard this patch.
app/Module/FamilyNavigatorModule.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -176,7 +176,7 @@
 block discarded – undo
176 176
 	/**
177 177
 	 * Format an individual.
178 178
 	 *
179
-	 * @param      $person
179
+	 * @param      Individual|null $person
180 180
 	 * @param bool $showUnknown
181 181
 	 *
182 182
 	 * @return string
Please login to merge, or discard this patch.
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -140,7 +140,8 @@  discard block
 block discarded – undo
140 140
 					<div class="font9">
141 141
 						<?= $spouse->getLifeSpan() ?>
142 142
 					</div>
143
-					<?php else: ?>
143
+					<?php else {
144
+	: ?>
144 145
 						<?= $spouse->getFullName() ?>
145 146
 					<?php endif ?>
146 147
 				</td>
@@ -150,6 +151,7 @@  discard block
 block discarded – undo
150 151
 
151 152
 		foreach ($family->getChildren() as $child) {
152 153
 			$menu = new Menu(Functions::getCloseRelationshipName($controller->record, $child));
154
+}
153 155
 			$menu->addSubmenu(new Menu($this->getFamily($child)));
154 156
 			?>
155 157
 			<tr>
@@ -166,7 +168,8 @@  discard block
 block discarded – undo
166 168
 					<div class="font9">
167 169
 						<?= $child->getLifeSpan() ?>
168 170
 					</div>
169
-					<?php else: ?>
171
+					<?php else {
172
+	: ?>
170 173
 						<?= $child->getFullName() ?>
171 174
 					<?php endif ?>
172 175
 				</td>
@@ -186,6 +189,7 @@  discard block
 block discarded – undo
186 189
 	private function getHTML($person, $showUnknown = false) {
187 190
 		if ($person instanceof Individual) {
188 191
 			return sprintf(self::LNK, $person->getHtmlUrl(), $person->getFullName());
192
+}
189 193
 		} elseif ($showUnknown) {
190 194
 			return sprintf(self::MSG, I18N::translate('unknown'));
191 195
 		} else {
Please login to merge, or discard this patch.
app/Functions/FunctionsPrint.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -189,7 +189,7 @@
 block discarded – undo
189 189
 			    <div class="modal-content">
190 190
 			      <div class="modal-header">
191 191
 			        <h3 class="modal-title" id="wt-modal-title">' . $title . '</h3>
192
-			        <button type="button" class="close" data-dismiss="modal" aria-label="'. I18N::translate('close') .'">
192
+			        <button type="button" class="close" data-dismiss="modal" aria-label="'. I18N::translate('close') . '">
193 193
 			          <span aria-hidden="true">&times;</span>
194 194
 			        </button>
195 195
 			      </div>
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,6 @@
 block discarded – undo
15 15
  */
16 16
 namespace Fisharebest\Webtrees\Functions;
17 17
 
18
-use Fisharebest\Webtrees\Bootstrap4;
19 18
 use Fisharebest\Webtrees\Config;
20 19
 use Fisharebest\Webtrees\Date;
21 20
 use Fisharebest\Webtrees\Fact;
Please login to merge, or discard this patch.
app/Module/UserMessagesModule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@
 block discarded – undo
127 127
 					$message->subject = I18N::translate('RE: ') . $message->subject;
128 128
 				}
129 129
 				if ($user) {
130
-					$content .= '<a class="btn btn-secondary" href="message.php?to=' . Filter::escapeUrl($message->sender) . '&amp;subject=' . Filter::escapeUrl($message->subject) . '&amp;ged=' . $WT_TREE->getNameUrl() .'" title="' . I18N::translate('Reply') .'">' . I18N::translate('Reply') . '</a> ';
130
+					$content .= '<a class="btn btn-secondary" href="message.php?to=' . Filter::escapeUrl($message->sender) . '&amp;subject=' . Filter::escapeUrl($message->subject) . '&amp;ged=' . $WT_TREE->getNameUrl() . '" title="' . I18N::translate('Reply') . '">' . I18N::translate('Reply') . '</a> ';
131 131
 				}
132 132
 				$content .= '<button type="button" onclick="if (confirm(\'' . I18N::translate('Are you sure you want to delete this message? It cannot be retrieved later.') . '\')) {$(\'#messageform :checkbox\').prop(\'checked\', false); $(\'#cb_message' . $message->message_id . '\').prop(\'checked\', true); document.messageform.submit();}">' . I18N::translate('Delete') . '</button></div></td></tr>';
133 133
 			}
Please login to merge, or discard this patch.