Conditions | 43 |
Paths | 100 |
Total Lines | 420 |
Code Lines | 302 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
186 | private function childFacts(Individual $person, Family $family, string $option, string $relation, Date $min_date, Date $max_date): Collection |
||
187 | { |
||
188 | $SHOW_RELATIVES_EVENTS = $person->tree()->getPreference('SHOW_RELATIVES_EVENTS'); |
||
189 | |||
190 | $birth_of_a_child = [ |
||
191 | 'INDI:BIRT' => [ |
||
192 | 'M' => I18N::translate('Birth of a son'), |
||
193 | 'F' => I18N::translate('Birth of a daughter'), |
||
194 | 'U' => I18N::translate('Birth of a child'), |
||
195 | ], |
||
196 | 'INDI:CHR' => [ |
||
197 | 'M' => I18N::translate('Christening of a son'), |
||
198 | 'F' => I18N::translate('Christening of a daughter'), |
||
199 | 'U' => I18N::translate('Christening of a child'), |
||
200 | ], |
||
201 | 'INDI:BAPM' => [ |
||
202 | 'M' => I18N::translate('Baptism of a son'), |
||
203 | 'F' => I18N::translate('Baptism of a daughter'), |
||
204 | 'U' => I18N::translate('Baptism of a child'), |
||
205 | ], |
||
206 | 'INDI:ADOP' => [ |
||
207 | 'M' => I18N::translate('Adoption of a son'), |
||
208 | 'F' => I18N::translate('Adoption of a daughter'), |
||
209 | 'U' => I18N::translate('Adoption of a child'), |
||
210 | ], |
||
211 | ]; |
||
212 | |||
213 | $birth_of_a_sibling = [ |
||
214 | 'INDI:BIRT' => [ |
||
215 | 'M' => I18N::translate('Birth of a brother'), |
||
216 | 'F' => I18N::translate('Birth of a sister'), |
||
217 | 'U' => I18N::translate('Birth of a sibling'), |
||
218 | ], |
||
219 | 'INDI:CHR' => [ |
||
220 | 'M' => I18N::translate('Christening of a brother'), |
||
221 | 'F' => I18N::translate('Christening of a sister'), |
||
222 | 'U' => I18N::translate('Christening of a sibling'), |
||
223 | ], |
||
224 | 'INDI:BAPM' => [ |
||
225 | 'M' => I18N::translate('Baptism of a brother'), |
||
226 | 'F' => I18N::translate('Baptism of a sister'), |
||
227 | 'U' => I18N::translate('Baptism of a sibling'), |
||
228 | ], |
||
229 | 'INDI:ADOP' => [ |
||
230 | 'M' => I18N::translate('Adoption of a brother'), |
||
231 | 'F' => I18N::translate('Adoption of a sister'), |
||
232 | 'U' => I18N::translate('Adoption of a sibling'), |
||
233 | ], |
||
234 | ]; |
||
235 | |||
236 | $birth_of_a_half_sibling = [ |
||
237 | 'INDI:BIRT' => [ |
||
238 | 'M' => I18N::translate('Birth of a half-brother'), |
||
239 | 'F' => I18N::translate('Birth of a half-sister'), |
||
240 | 'U' => I18N::translate('Birth of a half-sibling'), |
||
241 | ], |
||
242 | 'INDI:CHR' => [ |
||
243 | 'M' => I18N::translate('Christening of a half-brother'), |
||
244 | 'F' => I18N::translate('Christening of a half-sister'), |
||
245 | 'U' => I18N::translate('Christening of a half-sibling'), |
||
246 | ], |
||
247 | 'INDI:BAPM' => [ |
||
248 | 'M' => I18N::translate('Baptism of a half-brother'), |
||
249 | 'F' => I18N::translate('Baptism of a half-sister'), |
||
250 | 'U' => I18N::translate('Baptism of a half-sibling'), |
||
251 | ], |
||
252 | 'INDI:ADOP' => [ |
||
253 | 'M' => I18N::translate('Adoption of a half-brother'), |
||
254 | 'F' => I18N::translate('Adoption of a half-sister'), |
||
255 | 'U' => I18N::translate('Adoption of a half-sibling'), |
||
256 | ], |
||
257 | ]; |
||
258 | |||
259 | $birth_of_a_grandchild = [ |
||
260 | 'INDI:BIRT' => [ |
||
261 | 'M' => I18N::translate('Birth of a grandson'), |
||
262 | 'F' => I18N::translate('Birth of a granddaughter'), |
||
263 | 'U' => I18N::translate('Birth of a grandchild'), |
||
264 | ], |
||
265 | 'INDI:CHR' => [ |
||
266 | 'M' => I18N::translate('Christening of a grandson'), |
||
267 | 'F' => I18N::translate('Christening of a granddaughter'), |
||
268 | 'U' => I18N::translate('Christening of a grandchild'), |
||
269 | ], |
||
270 | 'INDI:BAPM' => [ |
||
271 | 'M' => I18N::translate('Baptism of a grandson'), |
||
272 | 'F' => I18N::translate('Baptism of a granddaughter'), |
||
273 | 'U' => I18N::translate('Baptism of a grandchild'), |
||
274 | ], |
||
275 | 'INDI:ADOP' => [ |
||
276 | 'M' => I18N::translate('Adoption of a grandson'), |
||
277 | 'F' => I18N::translate('Adoption of a granddaughter'), |
||
278 | 'U' => I18N::translate('Adoption of a grandchild'), |
||
279 | ], |
||
280 | ]; |
||
281 | |||
282 | $birth_of_a_grandchild1 = [ |
||
283 | 'INDI:BIRT' => [ |
||
284 | 'M' => I18N::translateContext('daughter’s son', 'Birth of a grandson'), |
||
285 | 'F' => I18N::translateContext('daughter’s daughter', 'Birth of a granddaughter'), |
||
286 | 'U' => I18N::translate('Birth of a grandchild'), |
||
287 | ], |
||
288 | 'INDI:CHR' => [ |
||
289 | 'M' => I18N::translateContext('daughter’s son', 'Christening of a grandson'), |
||
290 | 'F' => I18N::translateContext('daughter’s daughter', 'Christening of a granddaughter'), |
||
291 | 'U' => I18N::translate('Christening of a grandchild'), |
||
292 | ], |
||
293 | 'INDI:BAPM' => [ |
||
294 | 'M' => I18N::translateContext('daughter’s son', 'Baptism of a grandson'), |
||
295 | 'F' => I18N::translateContext('daughter’s daughter', 'Baptism of a granddaughter'), |
||
296 | 'U' => I18N::translate('Baptism of a grandchild'), |
||
297 | ], |
||
298 | 'INDI:ADOP' => [ |
||
299 | 'M' => I18N::translateContext('daughter’s son', 'Adoption of a grandson'), |
||
300 | 'F' => I18N::translateContext('daughter’s daughter', 'Adoption of a granddaughter'), |
||
301 | 'U' => I18N::translate('Adoption of a grandchild'), |
||
302 | ], |
||
303 | ]; |
||
304 | |||
305 | $birth_of_a_grandchild2 = [ |
||
306 | 'INDI:BIRT' => [ |
||
307 | 'M' => I18N::translateContext('son’s son', 'Birth of a grandson'), |
||
308 | 'F' => I18N::translateContext('son’s daughter', 'Birth of a granddaughter'), |
||
309 | 'U' => I18N::translate('Birth of a grandchild'), |
||
310 | ], |
||
311 | 'INDI:CHR' => [ |
||
312 | 'M' => I18N::translateContext('son’s son', 'Christening of a grandson'), |
||
313 | 'F' => I18N::translateContext('son’s daughter', 'Christening of a granddaughter'), |
||
314 | 'U' => I18N::translate('Christening of a grandchild'), |
||
315 | ], |
||
316 | 'INDI:BAPM' => [ |
||
317 | 'M' => I18N::translateContext('son’s son', 'Baptism of a grandson'), |
||
318 | 'F' => I18N::translateContext('son’s daughter', 'Baptism of a granddaughter'), |
||
319 | 'U' => I18N::translate('Baptism of a grandchild'), |
||
320 | ], |
||
321 | 'INDI:ADOP' => [ |
||
322 | 'M' => I18N::translateContext('son’s son', 'Adoption of a grandson'), |
||
323 | 'F' => I18N::translateContext('son’s daughter', 'Adoption of a granddaughter'), |
||
324 | 'U' => I18N::translate('Adoption of a grandchild'), |
||
325 | ], |
||
326 | ]; |
||
327 | |||
328 | $death_of_a_child = [ |
||
329 | 'INDI:DEAT' => [ |
||
330 | 'M' => I18N::translate('Death of a son'), |
||
331 | 'F' => I18N::translate('Death of a daughter'), |
||
332 | 'U' => I18N::translate('Death of a child'), |
||
333 | ], |
||
334 | 'INDI:BURI' => [ |
||
335 | 'M' => I18N::translate('Burial of a son'), |
||
336 | 'F' => I18N::translate('Burial of a daughter'), |
||
337 | 'U' => I18N::translate('Burial of a child'), |
||
338 | ], |
||
339 | 'INDI:CREM' => [ |
||
340 | 'M' => I18N::translate('Cremation of a son'), |
||
341 | 'F' => I18N::translate('Cremation of a daughter'), |
||
342 | 'U' => I18N::translate('Cremation of a child'), |
||
343 | ], |
||
344 | ]; |
||
345 | |||
346 | $death_of_a_sibling = [ |
||
347 | 'INDI:DEAT' => [ |
||
348 | 'M' => I18N::translate('Death of a brother'), |
||
349 | 'F' => I18N::translate('Death of a sister'), |
||
350 | 'U' => I18N::translate('Death of a sibling'), |
||
351 | ], |
||
352 | 'INDI:BURI' => [ |
||
353 | 'M' => I18N::translate('Burial of a brother'), |
||
354 | 'F' => I18N::translate('Burial of a sister'), |
||
355 | 'U' => I18N::translate('Burial of a sibling'), |
||
356 | ], |
||
357 | 'INDI:CREM' => [ |
||
358 | 'M' => I18N::translate('Cremation of a brother'), |
||
359 | 'F' => I18N::translate('Cremation of a sister'), |
||
360 | 'U' => I18N::translate('Cremation of a sibling'), |
||
361 | ], |
||
362 | ]; |
||
363 | |||
364 | $death_of_a_half_sibling = [ |
||
365 | 'INDI:DEAT' => [ |
||
366 | 'M' => I18N::translate('Death of a half-brother'), |
||
367 | 'F' => I18N::translate('Death of a half-sister'), |
||
368 | 'U' => I18N::translate('Death of a half-sibling'), |
||
369 | ], |
||
370 | 'INDI:BURI' => [ |
||
371 | 'M' => I18N::translate('Burial of a half-brother'), |
||
372 | 'F' => I18N::translate('Burial of a half-sister'), |
||
373 | 'U' => I18N::translate('Burial of a half-sibling'), |
||
374 | ], |
||
375 | 'INDI:CREM' => [ |
||
376 | 'M' => I18N::translate('Cremation of a half-brother'), |
||
377 | 'F' => I18N::translate('Cremation of a half-sister'), |
||
378 | 'U' => I18N::translate('Cremation of a half-sibling'), |
||
379 | ], |
||
380 | ]; |
||
381 | |||
382 | $death_of_a_grandchild = [ |
||
383 | 'INDI:DEAT' => [ |
||
384 | 'M' => I18N::translate('Death of a grandson'), |
||
385 | 'F' => I18N::translate('Death of a granddaughter'), |
||
386 | 'U' => I18N::translate('Death of a grandchild'), |
||
387 | ], |
||
388 | 'INDI:BURI' => [ |
||
389 | 'M' => I18N::translate('Burial of a grandson'), |
||
390 | 'F' => I18N::translate('Burial of a granddaughter'), |
||
391 | 'U' => I18N::translate('Burial of a grandchild'), |
||
392 | ], |
||
393 | 'INDI:CREM' => [ |
||
394 | 'M' => I18N::translate('Cremation of a grandson'), |
||
395 | 'F' => I18N::translate('Cremation of a granddaughter'), |
||
396 | 'U' => I18N::translate('Baptism of a grandchild'), |
||
397 | ], |
||
398 | ]; |
||
399 | |||
400 | $death_of_a_grandchild1 = [ |
||
401 | 'INDI:DEAT' => [ |
||
402 | 'M' => I18N::translateContext('daughter’s son', 'Death of a grandson'), |
||
403 | 'F' => I18N::translateContext('daughter’s daughter', 'Death of a granddaughter'), |
||
404 | 'U' => I18N::translate('Death of a grandchild'), |
||
405 | ], |
||
406 | 'INDI:BURI' => [ |
||
407 | 'M' => I18N::translateContext('daughter’s son', 'Burial of a grandson'), |
||
408 | 'F' => I18N::translateContext('daughter’s daughter', 'Burial of a granddaughter'), |
||
409 | 'U' => I18N::translate('Burial of a grandchild'), |
||
410 | ], |
||
411 | 'INDI:CREM' => [ |
||
412 | 'M' => I18N::translateContext('daughter’s son', 'Cremation of a grandson'), |
||
413 | 'F' => I18N::translateContext('daughter’s daughter', 'Cremation of a granddaughter'), |
||
414 | 'U' => I18N::translate('Baptism of a grandchild'), |
||
415 | ], |
||
416 | ]; |
||
417 | |||
418 | $death_of_a_grandchild2 = [ |
||
419 | 'INDI:DEAT' => [ |
||
420 | 'M' => I18N::translateContext('son’s son', 'Death of a grandson'), |
||
421 | 'F' => I18N::translateContext('son’s daughter', 'Death of a granddaughter'), |
||
422 | 'U' => I18N::translate('Death of a grandchild'), |
||
423 | ], |
||
424 | 'INDI:BURI' => [ |
||
425 | 'M' => I18N::translateContext('son’s son', 'Burial of a grandson'), |
||
426 | 'F' => I18N::translateContext('son’s daughter', 'Burial of a granddaughter'), |
||
427 | 'U' => I18N::translate('Burial of a grandchild'), |
||
428 | ], |
||
429 | 'INDI:CREM' => [ |
||
430 | 'M' => I18N::translateContext('son’s son', 'Cremation of a grandson'), |
||
431 | 'F' => I18N::translateContext('son’s daughter', 'Cremation of a granddaughter'), |
||
432 | 'U' => I18N::translate('Cremation of a grandchild'), |
||
433 | ], |
||
434 | ]; |
||
435 | |||
436 | $marriage_of_a_child = [ |
||
437 | 'M' => I18N::translate('Marriage of a son'), |
||
438 | 'F' => I18N::translate('Marriage of a daughter'), |
||
439 | 'U' => I18N::translate('Marriage of a child'), |
||
440 | ]; |
||
441 | |||
442 | $marriage_of_a_grandchild = [ |
||
443 | 'M' => I18N::translate('Marriage of a grandson'), |
||
444 | 'F' => I18N::translate('Marriage of a granddaughter'), |
||
445 | 'U' => I18N::translate('Marriage of a grandchild'), |
||
446 | ]; |
||
447 | |||
448 | $marriage_of_a_grandchild1 = [ |
||
449 | 'M' => I18N::translateContext('daughter’s son', 'Marriage of a grandson'), |
||
450 | 'F' => I18N::translateContext('daughter’s daughter', 'Marriage of a granddaughter'), |
||
451 | 'U' => I18N::translate('Marriage of a grandchild'), |
||
452 | ]; |
||
453 | |||
454 | $marriage_of_a_grandchild2 = [ |
||
455 | 'M' => I18N::translateContext('son’s son', 'Marriage of a grandson'), |
||
456 | 'F' => I18N::translateContext('son’s daughter', 'Marriage of a granddaughter'), |
||
457 | 'U' => I18N::translate('Marriage of a grandchild'), |
||
458 | ]; |
||
459 | |||
460 | $marriage_of_a_sibling = [ |
||
461 | 'M' => I18N::translate('Marriage of a brother'), |
||
462 | 'F' => I18N::translate('Marriage of a sister'), |
||
463 | 'U' => I18N::translate('Marriage of a sibling'), |
||
464 | ]; |
||
465 | |||
466 | $marriage_of_a_half_sibling = [ |
||
467 | 'M' => I18N::translate('Marriage of a half-brother'), |
||
468 | 'F' => I18N::translate('Marriage of a half-sister'), |
||
469 | 'U' => I18N::translate('Marriage of a half-sibling'), |
||
470 | ]; |
||
471 | |||
472 | $facts = new Collection(); |
||
473 | |||
474 | // Deal with recursion. |
||
475 | if ($option === '_CHIL') { |
||
476 | // Add grandchildren |
||
477 | foreach ($family->children() as $child) { |
||
478 | foreach ($child->spouseFamilies() as $cfamily) { |
||
479 | switch ($child->sex()) { |
||
480 | case 'M': |
||
481 | foreach ($this->childFacts($person, $cfamily, '_GCHI', 'son', $min_date, $max_date) as $fact) { |
||
482 | $facts[] = $fact; |
||
483 | } |
||
484 | break; |
||
485 | case 'F': |
||
486 | foreach ($this->childFacts($person, $cfamily, '_GCHI', 'dau', $min_date, $max_date) as $fact) { |
||
487 | $facts[] = $fact; |
||
488 | } |
||
489 | break; |
||
490 | default: |
||
491 | foreach ($this->childFacts($person, $cfamily, '_GCHI', 'chi', $min_date, $max_date) as $fact) { |
||
492 | $facts[] = $fact; |
||
493 | } |
||
494 | break; |
||
495 | } |
||
496 | } |
||
497 | } |
||
498 | } |
||
499 | |||
500 | // For each child in the family |
||
501 | foreach ($family->children() as $child) { |
||
502 | if ($child->xref() === $person->xref()) { |
||
503 | // We are not our own sibling! |
||
504 | continue; |
||
505 | } |
||
506 | // add child’s birth |
||
507 | if (str_contains($SHOW_RELATIVES_EVENTS, '_BIRT' . str_replace('_HSIB', '_SIBL', $option))) { |
||
508 | foreach ($child->facts(['BIRT', 'CHR', 'BAPM', 'ADOP']) as $fact) { |
||
509 | // Always show _BIRT_CHIL, even if the dates are not known |
||
510 | if ($option === '_CHIL' || $this->includeFact($fact, $min_date, $max_date)) { |
||
511 | switch ($option) { |
||
512 | case '_GCHI': |
||
513 | switch ($relation) { |
||
514 | case 'dau': |
||
515 | $facts[] = $this->convertEvent($fact, $birth_of_a_grandchild1[$fact->tag()], $fact->record()->sex()); |
||
516 | break; |
||
517 | case 'son': |
||
518 | $facts[] = $this->convertEvent($fact, $birth_of_a_grandchild2[$fact->tag()], $fact->record()->sex()); |
||
519 | break; |
||
520 | case 'chil': |
||
521 | $facts[] = $this->convertEvent($fact, $birth_of_a_grandchild[$fact->tag()], $fact->record()->sex()); |
||
522 | break; |
||
523 | } |
||
524 | break; |
||
525 | case '_SIBL': |
||
526 | $facts[] = $this->convertEvent($fact, $birth_of_a_sibling[$fact->tag()], $fact->record()->sex()); |
||
527 | break; |
||
528 | case '_HSIB': |
||
529 | $facts[] = $this->convertEvent($fact, $birth_of_a_half_sibling[$fact->tag()], $fact->record()->sex()); |
||
530 | break; |
||
531 | case '_CHIL': |
||
532 | $facts[] = $this->convertEvent($fact, $birth_of_a_child[$fact->tag()], $fact->record()->sex()); |
||
533 | break; |
||
534 | } |
||
535 | } |
||
536 | } |
||
537 | } |
||
538 | // add child’s death |
||
539 | if (str_contains($SHOW_RELATIVES_EVENTS, '_DEAT' . str_replace('_HSIB', '_SIBL', $option))) { |
||
540 | foreach ($child->facts(['DEAT', 'BURI', 'CREM']) as $fact) { |
||
541 | if ($this->includeFact($fact, $min_date, $max_date)) { |
||
542 | switch ($option) { |
||
543 | case '_GCHI': |
||
544 | switch ($relation) { |
||
545 | case 'dau': |
||
546 | $facts[] = $this->convertEvent($fact, $death_of_a_grandchild1[$fact->tag()], $fact->record()->sex()); |
||
547 | break; |
||
548 | case 'son': |
||
549 | $facts[] = $this->convertEvent($fact, $death_of_a_grandchild2[$fact->tag()], $fact->record()->sex()); |
||
550 | break; |
||
551 | case 'chi': |
||
552 | $facts[] = $this->convertEvent($fact, $death_of_a_grandchild[$fact->tag()], $fact->record()->sex()); |
||
553 | break; |
||
554 | } |
||
555 | break; |
||
556 | case '_SIBL': |
||
557 | $facts[] = $this->convertEvent($fact, $death_of_a_sibling[$fact->tag()], $fact->record()->sex()); |
||
558 | break; |
||
559 | case '_HSIB': |
||
560 | $facts[] = $this->convertEvent($fact, $death_of_a_half_sibling[$fact->tag()], $fact->record()->sex()); |
||
561 | break; |
||
562 | case '_CHIL': |
||
563 | $facts[] = $this->convertEvent($fact, $death_of_a_child[$fact->tag()], $fact->record()->sex()); |
||
564 | break; |
||
565 | } |
||
566 | } |
||
567 | } |
||
568 | } |
||
569 | |||
570 | // add child’s marriage |
||
571 | if (str_contains($SHOW_RELATIVES_EVENTS, '_MARR' . str_replace('_HSIB', '_SIBL', $option))) { |
||
572 | foreach ($child->spouseFamilies() as $sfamily) { |
||
573 | foreach ($sfamily->facts(['MARR']) as $fact) { |
||
574 | if ($this->includeFact($fact, $min_date, $max_date)) { |
||
575 | switch ($option) { |
||
576 | case '_GCHI': |
||
577 | switch ($relation) { |
||
578 | case 'dau': |
||
579 | $facts[] = $this->convertEvent($fact, $marriage_of_a_grandchild1, $child->sex()); |
||
580 | break; |
||
581 | case 'son': |
||
582 | $facts[] = $this->convertEvent($fact, $marriage_of_a_grandchild2, $child->sex()); |
||
583 | break; |
||
584 | case 'chi': |
||
585 | $facts[] = $this->convertEvent($fact, $marriage_of_a_grandchild, $child->sex()); |
||
586 | break; |
||
587 | } |
||
588 | break; |
||
589 | case '_SIBL': |
||
590 | $facts[] = $this->convertEvent($fact, $marriage_of_a_sibling, $child->sex()); |
||
591 | break; |
||
592 | case '_HSIB': |
||
593 | $facts[] = $this->convertEvent($fact, $marriage_of_a_half_sibling, $child->sex()); |
||
594 | break; |
||
595 | case '_CHIL': |
||
596 | $facts[] = $this->convertEvent($fact, $marriage_of_a_child, $child->sex()); |
||
597 | break; |
||
598 | } |
||
599 | } |
||
600 | } |
||
601 | } |
||
602 | } |
||
603 | } |
||
604 | |||
605 | return $facts; |
||
606 | } |
||
869 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"]
, you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths