| Conditions | 7 |
| Paths | 2 |
| Total Lines | 56 |
| Code Lines | 44 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 60 | public function handle(ServerRequestInterface $request): ResponseInterface |
||
| 61 | { |
||
| 62 | $mail_ssl_options = $this->email_service->mailSslOptions(); |
||
| 63 | $mail_transport_options = $this->email_service->mailTransportOptions(); |
||
| 64 | |||
| 65 | $title = I18N::translate('Sending email'); |
||
| 66 | |||
| 67 | $SMTP_ACTIVE = Site::getPreference('SMTP_ACTIVE'); |
||
| 68 | $SMTP_AUTH = Site::getPreference('SMTP_AUTH'); |
||
| 69 | $SMTP_AUTH_USER = Site::getPreference('SMTP_AUTH_USER'); |
||
| 70 | $SMTP_DISP_NAME = Site::getPreference('SMTP_DISP_NAME'); |
||
| 71 | $SMTP_FROM_NAME = Site::getPreference('SMTP_FROM_NAME'); |
||
| 72 | $SMTP_HELO = Site::getPreference('SMTP_HELO'); |
||
| 73 | $SMTP_HOST = Site::getPreference('SMTP_HOST'); |
||
| 74 | $SMTP_PORT = Site::getPreference('SMTP_PORT'); |
||
| 75 | $SMTP_SSL = Site::getPreference('SMTP_SSL'); |
||
| 76 | $DKIM_DOMAIN = Site::getPreference('DKIM_DOMAIN'); |
||
| 77 | $DKIM_SELECTOR = Site::getPreference('DKIM_SELECTOR'); |
||
| 78 | $DKIM_KEY = Site::getPreference('DKIM_KEY'); |
||
| 79 | |||
| 80 | $hostname = gethostname() ?: 'localhost'; |
||
| 81 | $ip = gethostbyname($hostname); |
||
| 82 | |||
| 83 | if ($ip !== $hostname) { |
||
| 84 | $hostname = gethostbyaddr($ip); |
||
| 85 | } |
||
| 86 | |||
| 87 | // Defaults |
||
| 88 | $SMTP_PORT = $SMTP_PORT ?: '25'; |
||
| 89 | $SMTP_HELO = $SMTP_HELO ?: $hostname; |
||
| 90 | $SMTP_FROM_NAME = $SMTP_FROM_NAME ?: ('no-reply@' . $SMTP_HELO); |
||
| 91 | $SMTP_DISP_NAME = $SMTP_DISP_NAME ?: Webtrees::NAME; |
||
| 92 | |||
| 93 | $smtp_from_name_valid = $this->email_service->isValidEmail($SMTP_FROM_NAME); |
||
| 94 | $smtp_helo_valid = filter_var($SMTP_HELO, FILTER_VALIDATE_DOMAIN); |
||
| 95 | |||
| 96 | $this->layout = 'layouts/administration'; |
||
| 97 | |||
| 98 | return $this->viewResponse('admin/site-mail', [ |
||
| 99 | 'mail_ssl_options' => $mail_ssl_options, |
||
| 100 | 'mail_transport_options' => $mail_transport_options, |
||
| 101 | 'title' => $title, |
||
| 102 | 'smtp_helo_valid' => $smtp_helo_valid, |
||
| 103 | 'smtp_from_name_valid' => $smtp_from_name_valid, |
||
| 104 | 'SMTP_ACTIVE' => $SMTP_ACTIVE, |
||
| 105 | 'SMTP_AUTH' => $SMTP_AUTH, |
||
| 106 | 'SMTP_AUTH_USER' => $SMTP_AUTH_USER, |
||
| 107 | 'SMTP_DISP_NAME' => $SMTP_DISP_NAME, |
||
| 108 | 'SMTP_FROM_NAME' => $SMTP_FROM_NAME, |
||
| 109 | 'SMTP_HELO' => $SMTP_HELO, |
||
| 110 | 'SMTP_HOST' => $SMTP_HOST, |
||
| 111 | 'SMTP_PORT' => $SMTP_PORT, |
||
| 112 | 'SMTP_SSL' => $SMTP_SSL, |
||
| 113 | 'DKIM_DOMAIN' => $DKIM_DOMAIN, |
||
| 114 | 'DKIM_SELECTOR' => $DKIM_SELECTOR, |
||
| 115 | 'DKIM_KEY' => $DKIM_KEY, |
||
| 116 | ]); |
||
| 119 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths