Conditions | 30 |
Paths | > 20000 |
Total Lines | 191 |
Code Lines | 128 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
65 | public function handle(ServerRequestInterface $request): ResponseInterface |
||
66 | { |
||
67 | $tree = Validator::attributes($request)->tree(); |
||
68 | $view = Validator::attributes($request)->isInArray(['day', 'month', 'year'])->string('view'); |
||
69 | $cal = Validator::queryParams($request)->string('cal'); |
||
70 | $day = Validator::queryParams($request)->string('day'); |
||
71 | $month = Validator::queryParams($request)->string('month'); |
||
72 | $year = Validator::queryParams($request)->string('year'); |
||
73 | $filterev = Validator::queryParams($request)->string('filterev'); |
||
74 | $filterof = Validator::queryParams($request)->string('filterof'); |
||
75 | $filtersx = Validator::queryParams($request)->string('filtersx'); |
||
76 | |||
77 | $ged_date = new Date($cal . ' ' . $day . ' ' . $month . ' ' . $year); |
||
78 | $cal_date = $ged_date->minimumDate(); |
||
79 | $today = $cal_date->today(); |
||
80 | |||
81 | $days_in_month = $cal_date->daysInMonth(); |
||
82 | $days_in_week = $cal_date->daysInWeek(); |
||
83 | |||
84 | $CALENDAR_FORMAT = $tree->getPreference('CALENDAR_FORMAT'); |
||
85 | |||
86 | // Day and year share the same layout. |
||
87 | if ($view !== 'month') { |
||
88 | if ($view === 'day') { |
||
89 | $anniversary_facts = $this->calendar_service->getAnniversaryEvents($cal_date->minimumJulianDay(), $filterev, $tree, $filterof, $filtersx); |
||
90 | } else { |
||
91 | $ged_year = new Date($cal . ' ' . $year); |
||
92 | $anniversary_facts = $this->calendar_service->getCalendarEvents($ged_year->minimumJulianDay(), $ged_year->maximumJulianDay(), $filterev, $tree, $filterof, $filtersx); |
||
93 | } |
||
94 | |||
95 | $anniversaries = Collection::make($anniversary_facts) |
||
96 | ->unique() |
||
97 | ->sort(static fn (Fact $x, Fact $y): int => $x->date()->minimumJulianDay() <=> $y->date()->minimumJulianDay()); |
||
98 | |||
99 | $family_anniversaries = $anniversaries->filter(static fn (Fact $f): bool => $f->record() instanceof Family); |
||
100 | |||
101 | $individual_anniversaries = $anniversaries->filter(static fn (Fact $f): bool => $f->record() instanceof Individual); |
||
102 | |||
103 | $family_count = $family_anniversaries |
||
104 | ->map(static fn (Fact $x): string => $x->record()->xref()) |
||
105 | ->unique() |
||
106 | ->count(); |
||
107 | |||
108 | $individual_count = $individual_anniversaries |
||
109 | ->map(static fn (Fact $x): string => $x->record()->xref()) |
||
110 | ->unique() |
||
111 | ->count(); |
||
112 | |||
113 | return response(view('calendar-list', [ |
||
114 | 'family_anniversaries' => $family_anniversaries, |
||
115 | 'individual_anniversaries' => $individual_anniversaries, |
||
116 | 'family_count' => $family_count, |
||
117 | 'individual_count' => $individual_count, |
||
118 | ])); |
||
119 | } |
||
120 | |||
121 | $found_facts = []; |
||
122 | |||
123 | $cal_date->day = 0; |
||
124 | $cal_date->setJdFromYmd(); |
||
125 | // Make a separate list for each day. Unspecified/invalid days go in day 0. |
||
126 | for ($d = 0; $d <= $days_in_month; ++$d) { |
||
127 | $found_facts[$d] = []; |
||
128 | } |
||
129 | // Fetch events for each day |
||
130 | $jds = range($cal_date->minimumJulianDay(), $cal_date->maximumJulianDay()); |
||
131 | |||
132 | foreach ($jds as $jd) { |
||
133 | foreach ($this->calendar_service->getAnniversaryEvents($jd, $filterev, $tree, $filterof, $filtersx) as $fact) { |
||
134 | $tmp = $fact->date()->minimumDate(); |
||
135 | if ($tmp->day >= 1 && $tmp->day <= $tmp->daysInMonth()) { |
||
136 | // If the day is valid (for its own calendar), display it in the |
||
137 | // anniversary day (for the display calendar). |
||
138 | $found_facts[$jd - $cal_date->minimumJulianDay() + 1][] = $fact; |
||
139 | } else { |
||
140 | // Otherwise, display it in the "Day not set" box. |
||
141 | $found_facts[0][] = $fact; |
||
142 | } |
||
143 | } |
||
144 | } |
||
145 | |||
146 | $cal_facts = []; |
||
147 | |||
148 | foreach ($found_facts as $d => $facts) { |
||
149 | $cal_facts[$d] = []; |
||
150 | foreach ($facts as $fact) { |
||
151 | $xref = $fact->record()->xref(); |
||
152 | $text = $fact->label() . ' — ' . $fact->date()->display($tree); |
||
153 | if ($fact->anniv > 0) { |
||
154 | $text .= ' (' . I18N::translate('%s year anniversary', I18N::number($fact->anniv)) . ')'; |
||
155 | } |
||
156 | if (empty($cal_facts[$d][$xref])) { |
||
157 | $cal_facts[$d][$xref] = $text; |
||
158 | } else { |
||
159 | $cal_facts[$d][$xref] .= '<br>' . $text; |
||
160 | } |
||
161 | } |
||
162 | } |
||
163 | // We use JD%7 = 0/Mon…6/Sun. Standard definitions use 0/Sun…6/Sat. |
||
164 | $week_start = (I18N::locale()->territory()->firstDay() + 6) % 7; |
||
165 | $weekend_start = (I18N::locale()->territory()->weekendStart() + 6) % 7; |
||
166 | $weekend_end = (I18N::locale()->territory()->weekendEnd() + 6) % 7; |
||
167 | |||
168 | // The French calendar has a 10-day week, which starts on primidi. |
||
169 | if ($days_in_week === 10) { |
||
170 | $week_start = 0; |
||
171 | $weekend_start = -1; |
||
172 | $weekend_end = -1; |
||
173 | } |
||
174 | |||
175 | ob_start(); |
||
176 | |||
177 | echo '<table class="w-100 wt-calendar-month"><thead><tr>'; |
||
178 | for ($week_day = 0; $week_day < $days_in_week; ++$week_day) { |
||
179 | $day_name = $cal_date->dayNames(($week_day + $week_start) % $days_in_week); |
||
180 | if ($week_day === $weekend_start || $week_day === $weekend_end) { |
||
181 | echo '<th class="wt-page-options-label weekend" width="', 100 / $days_in_week, '%">', $day_name, '</th>'; |
||
182 | } else { |
||
183 | echo '<th class="wt-page-options-label" width="', 100 / $days_in_week, '%">', $day_name, '</th>'; |
||
184 | } |
||
185 | } |
||
186 | echo '</tr>'; |
||
187 | echo '</thead>'; |
||
188 | echo '<tbody>'; |
||
189 | // Print days 1 to n of the month, but extend to cover "empty" days before/after the month to make whole weeks. |
||
190 | // e.g. instead of 1 -> 30 (=30 days), we might have -1 -> 33 (=35 days) |
||
191 | $start_d = 1 - ($cal_date->minimumJulianDay() - $week_start) % $days_in_week; |
||
192 | $end_d = $days_in_month + ($days_in_week - ($cal_date->maximumJulianDay() - $week_start + 1) % $days_in_week) % $days_in_week; |
||
193 | // Make sure that there is an empty box for any leap/missing days |
||
194 | if ($start_d === 1 && $end_d === $days_in_month && count($found_facts[0]) > 0) { |
||
195 | $end_d += $days_in_week; |
||
196 | } |
||
197 | for ($d = $start_d; $d <= $end_d; ++$d) { |
||
198 | if (($d + $cal_date->minimumJulianDay() - $week_start) % $days_in_week === 1) { |
||
199 | echo '<tr>'; |
||
200 | } |
||
201 | |||
202 | if ($d === $today->day && $cal_date->month === $today->month) { |
||
203 | $today_class = 'wt-calendar-today'; |
||
204 | } else { |
||
205 | $today_class = ''; |
||
206 | } |
||
207 | |||
208 | echo '<td class="wt-page-options-value ' . $today_class . '">'; |
||
209 | if ($d < 1 || $d > $days_in_month) { |
||
210 | if (count($cal_facts[0]) > 0) { |
||
211 | echo '<div class="cal_day">', I18N::translate('Day not set'), '</div>'; |
||
212 | echo '<div class="small" style="height: 180px; overflow: auto;">'; |
||
213 | echo $this->calendarListText($cal_facts[0], $tree); |
||
214 | echo '</div>'; |
||
215 | $cal_facts[0] = []; |
||
216 | } |
||
217 | } else { |
||
218 | // Format the day number using the calendar |
||
219 | $tmp = new Date($cal_date->format('%@ ' . $d . ' %O %E')); |
||
220 | $d_fmt = $tmp->minimumDate()->format('%j'); |
||
221 | echo '<div class="d-flex d-flex justify-content-between">'; |
||
222 | echo '<span class="cal_day">', $d_fmt, '</span>'; |
||
223 | |||
224 | // Show a converted date |
||
225 | foreach (explode('_and_', $CALENDAR_FORMAT) as $convcal) { |
||
226 | $alt_date = match ($convcal) { |
||
227 | 'french' => new FrenchDate($cal_date->minimumJulianDay() + $d - 1), |
||
228 | 'gregorian' => new GregorianDate($cal_date->minimumJulianDay() + $d - 1), |
||
229 | 'jewish' => new JewishDate($cal_date->minimumJulianDay() + $d - 1), |
||
230 | 'julian' => new JulianDate($cal_date->minimumJulianDay() + $d - 1), |
||
231 | 'hijri' => new HijriDate($cal_date->minimumJulianDay() + $d - 1), |
||
232 | 'jalali' => new JalaliDate($cal_date->minimumJulianDay() + $d - 1), |
||
233 | default => $cal_date, |
||
234 | }; |
||
235 | |||
236 | if (get_class($alt_date) !== get_class($cal_date) && $alt_date->inValidRange()) { |
||
237 | echo '<span class="rtl_cal_day">' . $alt_date->format('%j %M') . '</span>'; |
||
238 | // Just show the first conversion |
||
239 | break; |
||
240 | } |
||
241 | } |
||
242 | echo '</div>'; |
||
243 | echo '<div class="small" style="height: 180px; overflow: auto;">'; |
||
244 | echo $this->calendarListText($cal_facts[$d], $tree); |
||
245 | echo '</div>'; |
||
246 | } |
||
247 | echo '</td>'; |
||
248 | if (($d + $cal_date->minimumJulianDay() - $week_start) % $days_in_week === 0) { |
||
249 | echo '</tr>'; |
||
250 | } |
||
251 | } |
||
252 | echo '</tbody>'; |
||
253 | echo '</table>'; |
||
254 | |||
255 | return response(ob_get_clean()); |
||
256 | } |
||
276 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"]
, you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths