fisharebest /
webtrees
| Conditions | 106 |
| Paths | > 20000 |
| Total Lines | 351 |
| Code Lines | 251 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 96 | public static function printFact(Fact $fact, GedcomRecord $record): void |
||
| 97 | { |
||
| 98 | $parent = $fact->record(); |
||
| 99 | $tree = $parent->tree(); |
||
| 100 | $tag = $fact->getTag(); |
||
| 101 | $label = $fact->label(); |
||
| 102 | $value = $fact->value(); |
||
| 103 | $type = $fact->attribute('TYPE'); |
||
| 104 | $id = $fact->id(); |
||
| 105 | |||
| 106 | $element = Registry::elementFactory()->make($fact->tag()); |
||
| 107 | |||
| 108 | // This preference is named HIDE instead of SHOW |
||
| 109 | $hide_errors = $tree->getPreference('HIDE_GEDCOM_ERRORS') === '0'; |
||
| 110 | |||
| 111 | // Some facts don't get printed here ... |
||
| 112 | switch ($tag) { |
||
| 113 | case 'NOTE': |
||
| 114 | self::printMainNotes($fact, 1); |
||
| 115 | |||
| 116 | return; |
||
| 117 | case 'SOUR': |
||
| 118 | self::printMainSources($fact, 1); |
||
| 119 | |||
| 120 | return; |
||
| 121 | case 'OBJE': |
||
| 122 | self::printMainMedia($fact, 1); |
||
| 123 | |||
| 124 | return; |
||
| 125 | case 'FAMC': |
||
| 126 | case 'FAMS': |
||
| 127 | case 'CHIL': |
||
| 128 | case 'HUSB': |
||
| 129 | case 'WIFE': |
||
| 130 | // These are internal links, not facts |
||
| 131 | return; |
||
| 132 | case '_WT_OBJE_SORT': |
||
| 133 | // These links were once used internally to record the sort order. |
||
| 134 | return; |
||
| 135 | default: |
||
| 136 | // Hide unrecognized/custom tags? |
||
| 137 | if ($hide_errors && !GedcomTag::isTag($tag)) { |
||
| 138 | return; |
||
| 139 | } |
||
| 140 | break; |
||
| 141 | } |
||
| 142 | |||
| 143 | // New or deleted facts need different styling |
||
| 144 | $styles = []; |
||
| 145 | if ($fact->isPendingAddition()) { |
||
| 146 | $styles[] = 'wt-new'; |
||
| 147 | } |
||
| 148 | if ($fact->isPendingDeletion()) { |
||
| 149 | $styles[] = 'wt-old'; |
||
| 150 | } |
||
| 151 | |||
| 152 | // Event of close relative |
||
| 153 | if ($tag === 'EVEN' && $value === 'CLOSE_RELATIVE') { |
||
| 154 | $styles[] = 'wt-relation-fact collapse'; |
||
| 155 | } |
||
| 156 | |||
| 157 | // Event of close associates |
||
| 158 | if ($id === 'asso') { |
||
| 159 | $styles[] = 'wt-relation-fact collapse'; |
||
| 160 | } |
||
| 161 | |||
| 162 | // historical facts |
||
| 163 | if ($id === 'histo') { |
||
| 164 | $styles[] = 'wt-historic-fact collapse'; |
||
| 165 | } |
||
| 166 | |||
| 167 | // Use marriage type as the label. e.g. "Civil partnership" |
||
| 168 | if ($tag === 'MARR') { |
||
| 169 | $label = $fact->label(); |
||
| 170 | $type = ''; |
||
| 171 | } |
||
| 172 | |||
| 173 | echo '<tr class="', implode(' ', $styles), '">'; |
||
| 174 | echo '<th scope="row">'; |
||
| 175 | echo $label; |
||
| 176 | |||
| 177 | if ($id !== 'histo' && $id !== 'asso' && $fact->canEdit()) { |
||
| 178 | echo '<div class="editfacts nowrap">'; |
||
| 179 | echo view('edit/icon-fact-edit', ['fact' => $fact, 'url' => $record->url()]); |
||
| 180 | echo view('edit/icon-fact-copy', ['fact' => $fact]); |
||
| 181 | echo view('edit/icon-fact-delete', ['fact' => $fact]); |
||
| 182 | echo '</div>'; |
||
| 183 | } |
||
| 184 | |||
| 185 | if ($tree->getPreference('SHOW_FACT_ICONS')) { |
||
| 186 | echo '<span class="wt-fact-icon wt-fact-icon-' . $tag . '" title="' . strip_tags($label) . '"></span>'; |
||
| 187 | } |
||
| 188 | |||
| 189 | echo '</th>'; |
||
| 190 | echo '<td>'; |
||
| 191 | |||
| 192 | // Event from another record? |
||
| 193 | if ($parent !== $record) { |
||
| 194 | if ($parent instanceof Family) { |
||
| 195 | foreach ($parent->spouses() as $spouse) { |
||
| 196 | if ($record !== $spouse) { |
||
| 197 | echo '<a href="', e($spouse->url()), '">', $spouse->fullName(), '</a> — '; |
||
| 198 | } |
||
| 199 | } |
||
| 200 | echo '<a href="', e($parent->url()), '">', I18N::translate('View this family'), '</a><br>'; |
||
| 201 | } elseif ($parent instanceof Individual) { |
||
| 202 | echo '<a href="', e($parent->url()), '">', $parent->fullName(), '</a><br>'; |
||
| 203 | } |
||
| 204 | } |
||
| 205 | |||
| 206 | // Print the value of this fact/event |
||
| 207 | switch ($tag) { |
||
| 208 | case 'ADDR': |
||
| 209 | case 'AFN': |
||
| 210 | case 'LANG': |
||
| 211 | case 'PUBL': |
||
| 212 | case 'RESN': |
||
| 213 | echo '<div class="field">' . $element->value($value, $tree) . '</div>'; |
||
| 214 | break; |
||
| 215 | case 'ASSO': |
||
| 216 | // we handle this later, in format_asso_rela_record() |
||
| 217 | break; |
||
| 218 | case 'EMAIL': |
||
| 219 | case 'EMAI': |
||
| 220 | case '_EMAIL': |
||
| 221 | echo '<div class="field"><a href="mailto:', e($value), '">', e($value), '</a></div>'; |
||
| 222 | break; |
||
| 223 | case 'REPO': |
||
| 224 | $repository = $fact->target(); |
||
| 225 | if ($repository instanceof Repository) { |
||
| 226 | echo '<div><a class="field" href="', e($repository->url()), '">', $repository->fullName(), '</a></div>'; |
||
| 227 | } else { |
||
| 228 | echo '<div class="error">', e($value), '</div>'; |
||
| 229 | } |
||
| 230 | break; |
||
| 231 | case 'SUBM': |
||
| 232 | $submitter = $fact->target(); |
||
| 233 | if ($submitter instanceof Submitter) { |
||
| 234 | echo '<div><a class="field" href="', e($submitter->url()), '">', $submitter->fullName(), '</a></div>'; |
||
| 235 | } else { |
||
| 236 | echo '<div class="error">', e($value), '</div>'; |
||
| 237 | } |
||
| 238 | break; |
||
| 239 | case 'SUBN': |
||
| 240 | $submission = $fact->target(); |
||
| 241 | if ($submission instanceof Submission) { |
||
| 242 | echo '<div><a class="field" href="', e($submission->url()), '">', $submission->fullName(), '</a></div>'; |
||
| 243 | } else { |
||
| 244 | echo '<div class="error">', e($value), '</div>'; |
||
| 245 | } |
||
| 246 | break; |
||
| 247 | case 'URL': |
||
| 248 | case '_URL': |
||
| 249 | case 'WWW': |
||
| 250 | echo '<div class="field"><a href="', e($value), '">', e($value), '</a></div>'; |
||
| 251 | break; |
||
| 252 | case 'TEXT': // 0 SOUR / 1 TEXT |
||
| 253 | echo Filter::formatText($value, $tree); |
||
| 254 | break; |
||
| 255 | case '_GOV': |
||
| 256 | echo '<div class="field"><a href="https://gov.genealogy.net/item/show/', e($value), '">', e($value), '</a></div>'; |
||
| 257 | break; |
||
| 258 | default: |
||
| 259 | // Display the value for all other facts/events |
||
| 260 | switch ($value) { |
||
| 261 | case '': |
||
| 262 | case 'CLOSE_RELATIVE': |
||
| 263 | // Nothing to display |
||
| 264 | break; |
||
| 265 | case 'N': |
||
| 266 | // Not valid GEDCOM |
||
| 267 | echo '<div class="field">', I18N::translate('No'), '</div>'; |
||
| 268 | break; |
||
| 269 | case 'Y': |
||
| 270 | echo '<div class="field">', I18N::translate('Yes'), '</div>'; |
||
| 271 | break; |
||
| 272 | default: |
||
| 273 | if (preg_match('/^@(' . Gedcom::REGEX_XREF . ')@$/', $value, $match)) { |
||
| 274 | $target = $fact->target(); |
||
| 275 | if ($target instanceof GedcomRecord) { |
||
| 276 | echo '<div><a href="', e($target->url()), '">', $target->fullName(), '</a></div>'; |
||
| 277 | } else { |
||
| 278 | echo '<div class="error">', e($value), '</div>'; |
||
| 279 | } |
||
| 280 | } else { |
||
| 281 | echo '<div class="field"><span dir="auto">', e($value), '</span></div>'; |
||
| 282 | } |
||
| 283 | break; |
||
| 284 | } |
||
| 285 | break; |
||
| 286 | } |
||
| 287 | |||
| 288 | // Print the type of this fact/event |
||
| 289 | if ($type !== '' && $tag !== 'EVEN' && $tag !== 'FACT') { |
||
| 290 | // Allow (custom) translations for other types |
||
| 291 | $type = I18N::translate($type); |
||
| 292 | echo GedcomTag::getLabelValue('TYPE', e($type)); |
||
| 293 | } |
||
| 294 | |||
| 295 | // Print the date of this fact/event |
||
| 296 | echo FunctionsPrint::formatFactDate($fact, $record, true, true); |
||
| 297 | |||
| 298 | // Print the place of this fact/event |
||
| 299 | echo '<div class="place">', FunctionsPrint::formatFactPlace($fact, true, true, true), '</div>'; |
||
| 300 | // A blank line between the primary attributes (value, date, place) and the secondary ones |
||
| 301 | echo '<br>'; |
||
| 302 | |||
| 303 | $addr = $fact->attribute('ADDR'); |
||
| 304 | if ($addr !== '') { |
||
| 305 | $addr = e($addr); |
||
| 306 | if (str_contains($addr, "\n")) { |
||
| 307 | $addr = '<span class="d-block" style="white-space: pre-wrap">' . $addr . '</span'; |
||
| 308 | } |
||
| 309 | |||
| 310 | echo GedcomTag::getLabelValue($fact->tag() . ':ADDR', $addr); |
||
| 311 | } |
||
| 312 | |||
| 313 | // Print the associates of this fact/event |
||
| 314 | if ($id !== 'asso') { |
||
| 315 | echo self::formatAssociateRelationship($fact); |
||
| 316 | } |
||
| 317 | |||
| 318 | // Print any other "2 XXXX" attributes, in the order in which they appear. |
||
| 319 | preg_match_all('/\n2 (' . Gedcom::REGEX_TAG . ') (.+)/', $fact->gedcom(), $matches, PREG_SET_ORDER); |
||
| 320 | |||
| 321 | //0 SOUR / 1 DATA / 2 EVEN / 3 DATE and 3 PLAC must be collected separately |
||
| 322 | preg_match_all('/\n2 EVEN .*((\n[3].*)*)/', $fact->gedcom(), $evenMatches, PREG_SET_ORDER); |
||
| 323 | $currentEvenMatch = 0; |
||
| 324 | |||
| 325 | foreach ($matches as $match) { |
||
| 326 | switch ($match[1]) { |
||
| 327 | case 'DATE': |
||
| 328 | case 'TIME': |
||
| 329 | case 'AGE': |
||
| 330 | case 'HUSB': |
||
| 331 | case 'WIFE': |
||
| 332 | case 'PLAC': |
||
| 333 | case 'ADDR': |
||
| 334 | case 'ALIA': |
||
| 335 | case 'ASSO': |
||
| 336 | case '_ASSO': |
||
| 337 | case 'DESC': |
||
| 338 | case 'RELA': |
||
| 339 | case 'STAT': |
||
| 340 | case 'TEMP': |
||
| 341 | case 'TYPE': |
||
| 342 | case 'FAMS': |
||
| 343 | case 'CONT': |
||
| 344 | // These were already shown at the beginning |
||
| 345 | break; |
||
| 346 | case 'NOTE': |
||
| 347 | case 'OBJE': |
||
| 348 | case 'SOUR': |
||
| 349 | // These will be shown at the end |
||
| 350 | break; |
||
| 351 | case '_UID': |
||
| 352 | case 'RIN': |
||
| 353 | // These don't belong at level 2, so do not display them. |
||
| 354 | // They are only shown when editing. |
||
| 355 | break; |
||
| 356 | case 'EVEN': // 0 SOUR / 1 DATA / 2 EVEN / 3 DATE / 3 PLAC |
||
| 357 | $events = []; |
||
| 358 | foreach (preg_split('/ *, */', $match[2]) as $event) { |
||
| 359 | $events[] = GedcomTag::getLabel($event); |
||
| 360 | } |
||
| 361 | echo GedcomTag::getLabelValue('EVEN', implode(I18N::$list_separator, $events)); |
||
| 362 | |||
| 363 | if (preg_match('/\n3 DATE (.+)/', $evenMatches[$currentEvenMatch][0], $date_match)) { |
||
| 364 | $date = new Date($date_match[1]); |
||
| 365 | echo GedcomTag::getLabelValue('DATE', $date->display()); |
||
| 366 | } |
||
| 367 | if (preg_match('/\n3 PLAC (.+)/', $evenMatches[$currentEvenMatch][0], $plac_match)) { |
||
| 368 | echo GedcomTag::getLabelValue('PLAC', $plac_match[1]); |
||
| 369 | } |
||
| 370 | $currentEvenMatch++; |
||
| 371 | |||
| 372 | break; |
||
| 373 | case 'FAMC': // 0 INDI / 1 ADOP / 2 FAMC / 3 ADOP |
||
| 374 | $family = Registry::familyFactory()->make(str_replace('@', '', $match[2]), $tree); |
||
| 375 | if ($family instanceof Family) { |
||
| 376 | echo GedcomTag::getLabelValue('FAM', '<a href="' . e($family->url()) . '">' . $family->fullName() . '</a>'); |
||
| 377 | if (preg_match('/\n3 ADOP (HUSB|WIFE|BOTH)/', $fact->gedcom(), $adop_match)) { |
||
| 378 | echo Registry::elementFactory()->make('INDI:ADOP:FAMC:ADOP')->labelValue($adop_match[1], $tree); |
||
| 379 | } |
||
| 380 | } else { |
||
| 381 | echo GedcomTag::getLabelValue('FAM', '<span class="error">' . $match[2] . '</span>'); |
||
| 382 | } |
||
| 383 | break; |
||
| 384 | case '_WT_USER': |
||
| 385 | if (Auth::check()) { |
||
| 386 | $user = (new UserService())->findByIdentifier($match[2]); // may not exist |
||
| 387 | if ($user instanceof UserInterface) { |
||
| 388 | echo GedcomTag::getLabelValue('_WT_USER', '<span dir="auto">' . e($user->realName()) . '</span>'); |
||
| 389 | } else { |
||
| 390 | echo GedcomTag::getLabelValue('_WT_USER', e($match[2])); |
||
| 391 | } |
||
| 392 | } |
||
| 393 | break; |
||
| 394 | case 'RESN': |
||
| 395 | switch ($match[2]) { |
||
| 396 | case 'none': |
||
| 397 | // Note: "2 RESN none" is not valid gedcom. |
||
| 398 | // However, webtrees privacy rules will interpret it as "show an otherwise private fact to public". |
||
| 399 | echo GedcomTag::getLabelValue('RESN', '<i class="icon-resn-none"></i> ' . I18N::translate('Show to visitors')); |
||
| 400 | break; |
||
| 401 | case 'privacy': |
||
| 402 | echo GedcomTag::getLabelValue('RESN', '<i class="icon-resn-privacy"></i> ' . I18N::translate('Show to members')); |
||
| 403 | break; |
||
| 404 | case 'confidential': |
||
| 405 | echo GedcomTag::getLabelValue('RESN', '<i class="icon-resn-confidential"></i> ' . I18N::translate('Show to managers')); |
||
| 406 | break; |
||
| 407 | case 'locked': |
||
| 408 | echo GedcomTag::getLabelValue('RESN', '<i class="icon-resn-locked"></i> ' . I18N::translate('Only managers can edit')); |
||
| 409 | break; |
||
| 410 | default: |
||
| 411 | echo GedcomTag::getLabelValue('RESN', e($match[2])); |
||
| 412 | break; |
||
| 413 | } |
||
| 414 | break; |
||
| 415 | case 'CALN': |
||
| 416 | echo GedcomTag::getLabelValue('CALN', Filter::expandUrls($match[2], $tree)); |
||
| 417 | break; |
||
| 418 | case 'URL': |
||
| 419 | case '_URL': |
||
| 420 | case 'WWW': |
||
| 421 | $link = '<a href="' . e($match[2]) . '">' . e($match[2]) . '</a>'; |
||
| 422 | echo GedcomTag::getLabelValue($tag . ':' . $match[1], $link); |
||
| 423 | break; |
||
| 424 | default: |
||
| 425 | if (!$hide_errors || GedcomTag::isTag($match[1])) { |
||
| 426 | if (preg_match('/^@(' . Gedcom::REGEX_XREF . ')@$/', $match[2], $xmatch)) { |
||
| 427 | // Links |
||
| 428 | $linked_record = Registry::gedcomRecordFactory()->make($xmatch[1], $tree); |
||
| 429 | if ($linked_record) { |
||
| 430 | $link = '<a href="' . e($linked_record->url()) . '">' . $linked_record->fullName() . '</a>'; |
||
| 431 | echo GedcomTag::getLabelValue($tag . ':' . $match[1], $link); |
||
| 432 | } else { |
||
| 433 | echo GedcomTag::getLabelValue($tag . ':' . $match[1], e($match[2])); |
||
| 434 | } |
||
| 435 | } else { |
||
| 436 | // Non links |
||
| 437 | echo GedcomTag::getLabelValue($tag . ':' . $match[1], e($match[2])); |
||
| 438 | } |
||
| 439 | } |
||
| 440 | break; |
||
| 441 | } |
||
| 442 | } |
||
| 443 | echo self::printFactSources($tree, $fact->gedcom(), 2); |
||
| 444 | echo FunctionsPrint::printFactNotes($tree, $fact->gedcom(), 2); |
||
| 445 | self::printMediaLinks($tree, $fact->gedcom(), 2); |
||
| 446 | echo '</td></tr>'; |
||
| 447 | } |
||
| 1047 |
