firefly-iii / firefly-iii

app/Api/V1/Requests/BudgetLimitRequest.php

<?php
/**
 * BudgetLimitRequest.php
 * Copyright (c) 2018 thegrumpydictator@gmail.com
 *
 * This file is part of Firefly III.
 *
 * Firefly III is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * Firefly III is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
 */

declare(strict_types=1);

namespace FireflyIII\Api\V1\Requests;


/**
 * Class BudgetLimitRequest
 */
class BudgetLimitRequest extends Request
{
    /**
     * Authorize logged in users.
     *
     * @return bool
     */
    public function authorize(): bool
    {
        // Only allow authenticated users
        return auth()->check();
    }

    /**
     * Get all data from the request.
     *
     * @return array
     */
    public function getAll(): array
    {
        return [
            'budget_id'     => $this->integer('budget_id'),
            'start'         => $this->date('start'),
            'end'           => $this->date('end'),
            'amount'        => $this->string('amount'),
            'currency_id'   => $this->integer('currency_id'),
            'currency_code' => $this->string('currency_code'),
        ];
    }

    /**
     * The rules that the incoming request must be matched against.
     *
     * @return array
     */
    public function rules(): array
    {
        $rules = [
            'budget_id'     => 'required|exists:budgets,id|belongsToUser:budgets,id',
            'start'         => 'required|before:end|date',
            'end'           => 'required|after:start|date',
            'amount'        => 'required|more:0',
            'currency_id'   => 'numeric|exists:transaction_currencies,id',
            'currency_code' => 'min:3|max:3|exists:transaction_currencies,code',
        ];
        switch ($this->method()) {
            default:
                break;
            case 'PUT':
            case 'PATCH':
                $rules['budget_id'] = 'required|exists:budgets,id|belongsToUser:budgets,id';
                break;
        }
        // if request has a budget already, drop the rule.
        $budget = $this->route()->parameter('budget');
        if (null !== $budget) {

The condition null !== $budget is always true.

            unset($rules['budget_id']);
        }


        return $rules;
    }

}