firefly-iii / csv-importer

app/Http/Controllers/TokenController.php

Spacing +4 added lines, -4 removed lines

@@ -45,8 +45,8 @@ 
     public function doValidate(): JsonResponse
     {
         $response = ['result' => 'OK', 'message' => null];
-        $uri   = (string)config('csv_importer.uri');
-        $token   = (string)config('csv_importer.access_token');
+        $uri = (string)config('csv_importer.uri');
+        $token = (string)config('csv_importer.access_token');
         $request  = new SystemInformationRequest($uri, $token);
         try {
             $result = $request->get();
@@ -57,14 +57,14 @@ 
         // 0 = OK (same version)
         // 1 = NOK (too low a version)
 
-        $minimum = (string) config('csv_importer.minimum_version');
+        $minimum = (string)config('csv_importer.minimum_version');
         $compare = version_compare($minimum, $result->version);
         if (1 === $compare) {
             $errorMessage = sprintf(
                 'Your Firefly III version %s is below the minimum required version %s',
                 $result->version, $minimum
             );
-            $response     = ['result' => 'NOK', 'message' => $errorMessage];
+            $response = ['result' => 'NOK', 'message' => $errorMessage];
         }
 
         return response()->json($response);

app/Console/Commands/Import.php

Spacing +2 added lines, -2 removed lines

@@ -68,8 +68,8 @@
 
         $this->info(sprintf('Welcome to the Firefly III CSV importer, v%s', config('csv_importer.version')));
         Log::debug(sprintf('Now in %s', __METHOD__));
-        $file   = (string) $this->argument('file');
-        $config = (string) $this->argument('config');
+        $file   = (string)$this->argument('file');
+        $config = (string)$this->argument('config');
         if (!file_exists($file) || (file_exists($file) && !is_file($file))) {
             $message = sprintf('The importer can\'t import: CSV file "%s" does not exist or could not be read.', $file);
             $this->error($message);

app/Console/Commands/AutoImport.php

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
             return 1;
         }
 
-        $this->directory = (string) ($this->argument('directory') ?? './');
+        $this->directory = (string)($this->argument('directory') ?? './');
         $this->line(sprintf('Going to automatically import everything found in %s', $this->directory));
 
         $files = $this->getFiles();

app/Services/Import/Task/Amount.php

Spacing +7 added lines, -7 removed lines

@@ -73,33 +73,33 @@
     {
         Log::debug(sprintf('Now at the start of processAmount("%s")', $transaction['amount']));
         $amount = null;
-        if (null === $amount && $this->validAmount((string) $transaction['amount'])) {
+        if (null === $amount && $this->validAmount((string)$transaction['amount'])) {
             Log::debug('Transaction["amount"] value is not NULL, assume this is the correct value.');
             $amount = $transaction['amount'];
         }
 
-        if (null === $amount && $this->validAmount((string) $transaction['amount_debit'])) {
+        if (null === $amount && $this->validAmount((string)$transaction['amount_debit'])) {
             Log::debug(sprintf('Transaction["amount_debit"] value is not NULL ("%s"), assume this is the correct value.', $transaction['amount_debit']));
             $amount = $transaction['amount_debit'];
         }
 
-        if (null === $amount && $this->validAmount((string) $transaction['amount_credit'])) {
+        if (null === $amount && $this->validAmount((string)$transaction['amount_credit'])) {
             Log::debug(sprintf('Transaction["amount_credit"] value is not NULL ("%s"), assume this is the correct value.', $transaction['amount_credit']));
             $amount = $transaction['amount_credit'];
         }
 
-        if (null === $amount && $this->validAmount((string) $transaction['amount_negated'])) {
+        if (null === $amount && $this->validAmount((string)$transaction['amount_negated'])) {
             Log::debug(sprintf('Transaction["amount_negated"] value is not NULL ("%s"), assume this is the correct value.', $transaction['amount_negated']));
             $amount = $transaction['amount_negated'];
         }
 
         if (array_key_exists('amount_modifier', $transaction)) {
-            $transaction['amount_modifier'] = (string) $transaction['amount_modifier'];
+            $transaction['amount_modifier'] = (string)$transaction['amount_modifier'];
         }
         if (array_key_exists('foreign_amount', $transaction)) {
-            $transaction['foreign_amount'] = (string) $transaction['foreign_amount'];
+            $transaction['foreign_amount'] = (string)$transaction['foreign_amount'];
         }
-        $amount = (string) $amount;
+        $amount = (string)$amount;
         if ('' === $amount) {
             Log::error('Amount is EMPTY. This will give problems further ahead.', $transaction);
 

app/Mail/ImportFinished.php

Spacing +2 added lines, -2 removed lines

@@ -41,8 +41,8 @@
      */
     public function build()
     {
-        $address = (string) config('mail.from.address');
-        $name    = (string) config('mail.from.name');
+        $address = (string)config('mail.from.address');
+        $name    = (string)config('mail.from.name');
 
         return $this->from($address, $name)->markdown('emails.import.finished');
     }

app/Services/CSV/Converter/Iban.php

Spacing +2 added lines, -2 removed lines

@@ -60,7 +60,7 @@ 
 
         $search  = [' ', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z'];
         $replace = ['', '10', '11', '12', '13', '14', '15', '16', '17', '18', '19', '20', '21', '22', '23', '24', '25', '26', '27', '28', '29', '30', '31',
-                    '32', '33', '34', '35',];
+                    '32', '33', '34', '35', ];
 
         // take
         $first = substr($value, 0, 4);
@@ -74,7 +74,7 @@ 
             $checksum = 2;
         }
 
-        return 1 === (int) $checksum;
+        return 1 === (int)$checksum;
     }
 
     /**

app/Services/Import/Task/Accounts.php

Spacing +14 added lines, -14 removed lines

@@ -97,7 +97,7 @@ 
         // if the ID is set, at least search for the ID.
         if (is_int($array['id']) && $array['id'] > 0) {
             Log::debug('Find by ID field.');
-            $result = $this->findById((string) $array['id']);
+            $result = $this->findById((string)$array['id']);
         }
         if (null !== $result) {
             $return = $result->toArray();
@@ -107,10 +107,10 @@ 
         }
 
         // if the IBAN is set, search for the IBAN.
-        if (isset($array['iban']) && '' !== (string) $array['iban']) {
+        if (isset($array['iban']) && '' !== (string)$array['iban']) {
             Log::debug('Find by IBAN.');
-            $transactionType = (string) ($array['transaction_type'] ?? null);
-            $result          = $this->findByIban((string) $array['iban'], $transactionType);
+            $transactionType = (string)($array['transaction_type'] ?? null);
+            $result          = $this->findByIban((string)$array['iban'], $transactionType);
         }
         if (null !== $result) {
             $return = $result->toArray();
@@ -120,9 +120,9 @@ 
         }
 
         // find by name, return only if it's an asset or liability account.
-        if (isset($array['name']) && '' !== (string) $array['name']) {
+        if (isset($array['name']) && '' !== (string)$array['name']) {
             Log::debug('Find by name.');
-            $result = $this->findByName((string) $array['name']);
+            $result = $this->findByName((string)$array['name']);
         }
         if (null !== $result) {
             $return = $result->toArray();
@@ -199,8 +199,8 @@ 
     private function findById(string $value): ?Account
     {
         Log::debug(sprintf('Going to search account with ID "%s"', $value));
-        $uri     = (string) config('csv_importer.uri');
-        $token   = (string) config('csv_importer.access_token');
+        $uri     = (string)config('csv_importer.uri');
+        $token   = (string)config('csv_importer.access_token');
         $request = new GetSearchAccountRequest($uri, $token);
         $request->setField('id');
         $request->setQuery($value);
@@ -239,8 +239,8 @@ 
     private function findByIban(string $iban, string $transactionType): ?Account
     {
         Log::debug(sprintf('Going to search account with IBAN "%s"', $iban));
-        $uri     = (string) config('csv_importer.uri');
-        $token   = (string) config('csv_importer.access_token');
+        $uri     = (string)config('csv_importer.uri');
+        $token   = (string)config('csv_importer.access_token');
         $request = new GetSearchAccountRequest($uri, $token);
         $request->setField('iban');
         $request->setQuery($iban);
@@ -285,8 +285,8 @@ 
     private function findByName(string $name): ?Account
     {
         Log::debug(sprintf('Going to search account with name "%s"', $name));
-        $uri     = (string) config('csv_importer.uri');
-        $token   = (string) config('csv_importer.access_token');
+        $uri     = (string)config('csv_importer.uri');
+        $token   = (string)config('csv_importer.access_token');
         $request = new GetSearchAccountRequest($uri, $token);
         $request->setField('name');
         $request->setQuery($name);
@@ -381,10 +381,10 @@ 
         $transaction         = $this->setDestination($transaction, $destination);
         $transaction['type'] = $this->determineType($source['type'], $destination['type']);
 
-        $amount = (string) $transaction['amount'];
+        $amount = (string)$transaction['amount'];
         $amount = '' === $amount ? '0' : $amount;
 
-        if('0'===$amount) {
+        if ('0' === $amount) {
             Log::error('Amount is ZERO. This will give trouble further down the line.');
         }
 

app/Services/Import/Task/EmptyAccounts.php

Spacing +3 added lines, -3 removed lines

@@ -118,16 +118,16 @@
 
         if ('withdrawal' === $transaction['type']) {
             $destName = $transaction['destination_name'] ?? '';
-            $destId   = (int) ($transaction['destination_id'] ?? 0);
+            $destId   = (int)($transaction['destination_id'] ?? 0);
             $destIban = $transaction['destination_iban'] ?? '';
-            if ('' === $destName && 0 === $destId && ''=== $destIban) {
+            if ('' === $destName && 0 === $destId && '' === $destIban) {
                 Log::debug('Destination name + ID + IBAN of withdrawal are empty, set to "(no name)".');
                 $transaction['destination_name'] = '(no name)';
             }
         }
         if ('deposit' === $transaction['type']) {
             $sourceName = $transaction['source_name'] ?? '';
-            $sourceId   = (int) ($transaction['source_id'] ?? 0);
+            $sourceId   = (int)($transaction['source_id'] ?? 0);
             $sourceIban = $transaction['source_iban'] ?? '';
             if ('' === $sourceName && 0 === $sourceId && '' === $sourceIban) {
                 Log::debug('Source name + IBAN + ID of deposit are empty, set to "(no name)".');

app/Services/Import/Routine/APISubmitter.php

Spacing +6 added lines, -6 removed lines

@@ -88,7 +88,7 @@ 
             return;
         }
 
-        $groupId = (int) $groupInfo['group_id'];
+        $groupId = (int)$groupInfo['group_id'];
         Log::debug(sprintf('Going to add import tag to transaction group #%d', $groupId));
         $body = [
             'transactions' => [],
@@ -104,8 +104,8 @@ 
                 'tags'                   => $currentTags,
             ];
         }
-        $uri     = (string) config('csv_importer.uri');
-        $token   = (string) config('csv_importer.access_token');
+        $uri     = (string)config('csv_importer.uri');
+        $token   = (string)config('csv_importer.access_token');
         $request = new PutTransactionRequest($uri, $token, $groupId);
         $request->setBody($body);
         $request->put();
@@ -160,8 +160,8 @@ 
     private function processTransaction(int $index, array $line): array
     {
         $response = [];
-        $uri      = (string) config('csv_importer.uri');
-        $token    = (string) config('csv_importer.access_token');
+        $uri      = (string)config('csv_importer.uri');
+        $token    = (string)config('csv_importer.access_token');
         $request  = new PostTransactionRequest($uri, $token);
         Log::debug('Submitting to Firefly III:', $line);
         $request->setBody($line);
@@ -237,7 +237,7 @@ 
     private function getOriginalValue(string $key, array $transaction): string
     {
         $parts = explode('.', $key);
-        if(1 === count($parts)) {
+        if (1 === count($parts)) {
             return $transaction[$key] ?? '(not found)';
         }
         if (3 !== count($parts)) {