Conditions | 12 |
Paths | 10 |
Total Lines | 67 |
Code Lines | 30 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
41 | private function startSync(array $configuration): int |
||
42 | { |
||
43 | app('log')->debug(sprintf('Now in %s', __METHOD__)); |
||
44 | $configObject = Configuration::fromFile($configuration); |
||
45 | |||
46 | // first download from bunq |
||
47 | $manager = new SyncRoutineManager; |
||
48 | $manager->setDownloadIdentifier($this->downloadIdentifier); |
||
49 | try { |
||
50 | $manager->setConfiguration($configObject); |
||
51 | } catch (ImportException $e) { |
||
52 | $this->error($e->getMessage()); |
||
|
|||
53 | |||
54 | return 1; |
||
55 | } |
||
56 | try { |
||
57 | $manager->start(); |
||
58 | } catch (ImportException $e) { |
||
59 | $this->error($e->getMessage()); |
||
60 | |||
61 | return 1; |
||
62 | } |
||
63 | |||
64 | $messages = $manager->getAllMessages(); |
||
65 | $warnings = $manager->getAllWarnings(); |
||
66 | $errors = $manager->getAllErrors(); |
||
67 | |||
68 | if (count($errors) > 0) { |
||
69 | /** |
||
70 | * @var int $index |
||
71 | * @var array $error |
||
72 | */ |
||
73 | foreach ($errors as $index => $error) { |
||
74 | /** @var string $line */ |
||
75 | foreach ($error as $line) { |
||
76 | $this->error(sprintf('ERROR in line #%d: %s', $index + 1, $line)); |
||
77 | } |
||
78 | } |
||
79 | } |
||
80 | |||
81 | if (count($warnings) > 0) { |
||
82 | /** |
||
83 | * @var int $index |
||
84 | * @var array $warning |
||
85 | */ |
||
86 | foreach ($warnings as $index => $warning) { |
||
87 | /** @var string $line */ |
||
88 | foreach ($warning as $line) { |
||
89 | $this->warn(sprintf('Warning from line #%d: %s', $index + 1, $line)); |
||
90 | } |
||
91 | } |
||
92 | } |
||
93 | |||
94 | if (count($messages) > 0) { |
||
95 | /** |
||
96 | * @var int $index |
||
97 | * @var array $message |
||
98 | */ |
||
99 | foreach ($messages as $index => $message) { |
||
100 | /** @var string $line */ |
||
101 | foreach ($message as $line) { |
||
102 | $this->info(sprintf('Message from line #%d: %s', $index + 1, strip_tags($line))); |
||
103 | } |
||
104 | } |
||
105 | } |
||
106 | |||
107 | return 0; |
||
108 | } |
||
110 |