App\Console\StartDownload::startDownload()

Complexity

Conditions	12
Paths	10

Size

Total Lines	67
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    private function startDownload(array $configuration): int
    {
        app('log')->debug(sprintf('Now in %s', __METHOD__));
        $configObject = Configuration::fromFile($configuration);

        // first download from bunq
        $manager = new DownloadRoutineMananger;
        try {
            $manager->setConfiguration($configObject);
        } catch (ImportException $e) {
            $this->error($e->getMessage());

It seems like error() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return 1;
        }
        try {
            $manager->start();
        } catch (ImportException $e) {
            $this->error($e->getMessage());

            return 1;
        }

        $messages = $manager->getAllMessages();
        $warnings = $manager->getAllWarnings();
        $errors   = $manager->getAllErrors();

        if (count($errors) > 0) {
            /**
             * @var int   $index
             * @var array $error
             */
            foreach ($errors as $index => $error) {
                /** @var string $line */
                foreach ($error as $line) {
                    $this->error(sprintf('ERROR in line     #%d: %s', $index + 1, $line));
                }
            }
        }

        if (count($warnings) > 0) {
            /**
             * @var int   $index
             * @var array $warning
             */
            foreach ($warnings as $index => $warning) {
                /** @var string $line */
                foreach ($warning as $line) {
                    $this->warn(sprintf('Warning from line #%d: %s', $index + 1, $line));

It seems like warn() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                }
            }
        }

        if (count($messages) > 0) {
            /**
             * @var int   $index
             * @var array $message
             */
            foreach ($messages as $index => $message) {
                /** @var string $line */
                foreach ($message as $line) {
                    $this->info(sprintf('Message from line #%d: %s', $index + 1, strip_tags($line)));

It seems like info() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                }
            }
        }
        $this->downloadIdentifier = $manager->getDownloadIdentifier();

The property downloadIdentifier does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return 0;
    }