Misc::isAjaxRequest() - Code Metrics - Inspection of "Move utility functions to the utility class, fix #..." - filp/whoops - Measure and Improve Code Quality continuously with Scrutinizer

Cancelled

Push — fix-util-funcs ( 5f3763 )

by Denis

created 2015-12-20 16:45 UTC

Misc::isAjaxRequest() A

↳ Parent: Misc

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	6
rs	9.4286
cc	2
eloc	4
nc	2
nop	0

<?php
/**
 * Whoops - php errors for cool kids
 * @author Filipe Dobreira <http://github.com/filp>
 */

namespace Whoops\Util;

class Misc
{
    /**
	 * Can we at this point in time send HTTP headers?
	 *
	 * Currently this checks if we are even serving an HTTP request,
	 * as opposed to running from a command line.
	 *
	 * If we are serving an HTTP request, we check if it's not too late.
	 *
	 * @return bool
	 */
    public static function canSendHeaders()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return isset($_SERVER["REQUEST_URI"]) && !headers_sent();
    }

    public static function isAjaxRequest()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return (
            !empty($_SERVER['HTTP_X_REQUESTED_WITH'])
            && strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) == 'xmlhttprequest');
    }

    /**
     * Check, if possible, that this execution was triggered by a command line.
     * @return bool
     */
    public static function isCommandLine()
    {
        return PHP_SAPI == 'cli';
    }

    /**
	 * Translate ErrorException code into the represented constant.
	 *
	 * @param int $error_code
	 * @return string
	 */
    public static function translateErrorCode($error_code)
    {
        $constants = get_defined_constants(true);
        if (array_key_exists('Core' , $constants)) {
            foreach ($constants['Core'] as $constant => $value) {
                if (substr($constant, 0, 2) == 'E_' && $value == $error_code) {
                    return $constant;
                }
            }
        }
        return "E_UNKNOWN";
    }
    
    /**
     * Determine if an error level is fatal (halts execution)
     * 
     * @param int $level
     * @return bool
     */
    public static function isLevelFatal($level)
    {
        $errors = E_ERROR;
        $errors |= E_PARSE;
        $errors |= E_CORE_ERROR;
        $errors |= E_CORE_WARNING;
        $errors |= E_COMPILE_ERROR;
        $errors |= E_COMPILE_WARNING;
        return ($level & $errors) > 0;
    }
}


1			<?php
2			/**
3			* Whoops - php errors for cool kids
4			* @author Filipe Dobreira <http://github.com/filp>
5			*/
6
7			namespace Whoops\Util;
8
9			class Misc
10			{
11			/**
12			* Can we at this point in time send HTTP headers?
13			*
14			* Currently this checks if we are even serving an HTTP request,
15			* as opposed to running from a command line.
16			*
17			* If we are serving an HTTP request, we check if it's not too late.
18			*
19			* @return bool
20			*/
21			public static function canSendHeaders()
			1 ignored issue – show Coding Style introduced 2015-11-21 13:08 UTC by Report Bug Copy Issue Report `canSendHeaders` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
22			{
23			return isset($_SERVER["REQUEST_URI"]) && !headers_sent();
24			}
25
26			public static function isAjaxRequest()
			1 ignored issue – show Coding Style introduced 2015-12-20 17:50 UTC by Report Bug Copy Issue Report `isAjaxRequest` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
27			{
28			return (
29			!empty($_SERVER['HTTP_X_REQUESTED_WITH'])
30			&& strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) == 'xmlhttprequest');
31			}
32
33			/**
34			* Check, if possible, that this execution was triggered by a command line.
35			* @return bool
36			*/
37			public static function isCommandLine()
38			{
39			return PHP_SAPI == 'cli';
40			}
41
42			/**
43			* Translate ErrorException code into the represented constant.
44			*
45			* @param int $error_code
46			* @return string
47			*/
48			public static function translateErrorCode($error_code)
49			{
50			$constants = get_defined_constants(true);
51			if (array_key_exists('Core' , $constants)) {
52			foreach ($constants['Core'] as $constant => $value) {
53			if (substr($constant, 0, 2) == 'E_' && $value == $error_code) {
54			return $constant;
55			}
56			}
57			}
58			return "E_UNKNOWN";
59			}
60
61			/**
62			* Determine if an error level is fatal (halts execution)
63			*
64			* @param int $level
65			* @return bool
66			*/
67			public static function isLevelFatal($level)
68			{
69			$errors = E_ERROR;
70			$errors \|= E_PARSE;
71			$errors \|= E_CORE_ERROR;
72			$errors \|= E_CORE_WARNING;
73			$errors \|= E_COMPILE_ERROR;
74			$errors \|= E_COMPILE_WARNING;
75			return ($level & $errors) > 0;
76			}
77			}
78

filp / whoops

Push — fix-util-funcs ( 5f3763 )

Misc::isAjaxRequest() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like