HubicController::listAction() - Code Metrics - Inspection of "[TASK] Add some try catch and some optimizations" - filoucrackeur/hubic - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/add-some-features ( b1826d...0758cc )

by Philippe

created 2018-03-27 19:46 UTC

HubicController::listAction() A

↳ Parent: HubicController

Complexity

Conditions	3
Paths	5

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3.0261

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
ccs	6
cts	7
cp	0.8571
rs	9.4285
cc	3
eloc	7
nc	5
nop	0
crap	3.0261

<?php

namespace Filoucrackeur\Hubic\Controller;

use Filoucrackeur\Hubic\Domain\Model\Account;
use Filoucrackeur\Hubic\Domain\Repository\AccountRepository;
use Filoucrackeur\Hubic\Service\HubicService;
use TYPO3\CMS\Extbase\Mvc\Controller\ActionController;

class HubicController extends ActionController
{
    /**
     * @var \Filoucrackeur\Hubic\Service\HubicService
     */
    protected $hubicService;

    /**
     * @var \Filoucrackeur\Hubic\Domain\Repository\AccountRepository
     */
    protected $accountRepository;

    public function listAction()
    {
        try {

            /** @var Account $account */
            $account = $this->accountRepository->findByIdentifier($this->settings['account']);
            if ($account) {
                $this->hubicService->setAccount($account);
                $this->view->assign('links', $this->hubicService->getAllLinks());
            }
        } catch(\Exception $e) {

        }
    }

    /**
     * @param AccountRepository $accountRepository
     */
    public function injectAccountRepository(AccountRepository $accountRepository)
    {
        $this->accountRepository = $accountRepository;
    }

    /**
     * @param HubicService $hubicService
     */
    public function injectHubicService(HubicService $hubicService)
    {
        $this->hubicService = $hubicService;
    }
}


1		<?php
2
3		namespace Filoucrackeur\Hubic\Controller;
4
5		use Filoucrackeur\Hubic\Domain\Model\Account;
6		use Filoucrackeur\Hubic\Domain\Repository\AccountRepository;
7		use Filoucrackeur\Hubic\Service\HubicService;
8		use TYPO3\CMS\Extbase\Mvc\Controller\ActionController;
9
10		class HubicController extends ActionController
11		{
12		/**
13		* @var \Filoucrackeur\Hubic\Service\HubicService
14		*/
15		protected $hubicService;
16
17		/**
18		* @var \Filoucrackeur\Hubic\Domain\Repository\AccountRepository
19		*/
20		protected $accountRepository;
21
22	1	public function listAction()
23		{
24		try {
25
26		/** @var Account $account */
27	1	$account = $this->accountRepository->findByIdentifier($this->settings['account']);
28	1	if ($account) {
29	1	$this->hubicService->setAccount($account);
30	1	$this->view->assign('links', $this->hubicService->getAllLinks());
31		}
32		} catch(\Exception $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-03-27 19:49 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
33		}
34	1	}
35
36		/**
37		* @param AccountRepository $accountRepository
38		*/
39	1	public function injectAccountRepository(AccountRepository $accountRepository)
40		{
41	1	$this->accountRepository = $accountRepository;
42	1	}
43
44		/**
45		* @param HubicService $hubicService
46		*/
47	1	public function injectHubicService(HubicService $hubicService)
48		{
49	1	$this->hubicService = $hubicService;
50	1	}
51		}
52

filoucrackeur / hubic

Push — feature/add-some-features ( b1826d...0758cc )

HubicController::listAction() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like