FilmTools\Developing\DevelopingFactory

Complexity

Total Complexity

6

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

92.86%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	3
A	__invoke()	0	14	3

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 6 and the first side effect is on line 51.

namespace FilmTools\Developing;

use FilmTools\Commons\Zones;

class DevelopingFactory
{

    /**
     * PHP class name (FQDN) of the DevelopingInterface instance this factory produces.
     *
     * @var string
     */
    public $developing_php_class;


    /**
     * @param string|null $developing_php_class DevelopingInterface instance FQDN
     *
     * @throws InvalidArgumentException         If FQDN does not implement DevelopingInterface
     */
    public function __construct( string $developing_php_class = null )
    {
        $this->developing_php_class = $developing_php_class ?: Developing::class;

        if (!is_subclass_of($this->developing_php_class, DevelopingInterface::class ))

Due to PHP Bug #53727, is_subclass_of might return inconsistent results on some PHP versions if \FilmTools\Developing\DevelopingInterface::class can be an interface. If so, you could instead use ReflectionClass::implementsInterface.

            throw new \InvalidArgumentException("Class name must implement DevelopingInterface.");
    }


    /**
     * The factory method.
     *
     * Expects an array with at least elements "time", "densities", and "exposures".
     *
     * If no "exposures" are given, but "zones" numbers are instead, the zone numbers
     * will be converted internally.
     *
     * @param  array $developing
     * @return DevelopingInterface
     */
    public function __invoke( $developing )
    {
        $time      = $developing['time']      ?? null;
        $densities = $developing['densities'] ?? array();
        $zones     = $developing['zones']     ?? array();
        $exposures = $developing['exposures'] ?? array();

        if (empty($exposures) and !empty($zones)):

Using logical operators such as and instead of && is generally not recommended.

            $exposures = new Zones( $zones );
        endif;

        $developing_php_class = $this->developing_php_class;

It is generally advisable to only define one property per statement.

The visibility should be declared for property $developing_php_class.

        return new $developing_php_class( $exposures, $densities, $time );

It is generally advisable to only define one property per statement.

The visibility should be declared for property $developing_php_class.

    }
}