Developing::get() - Code Metrics - Inspection of "Merge branch 'release/2.0.0'" - filmtools/developing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02a3c4...5798f5 )

by Carsten

created 2018-07-31 05:30 UTC

Developing::get() A

↳ Parent: Developing

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	6
cts	6
cp	1
rs	9.9
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2

<?php
namespace FilmTools\Developing;

use FilmTools\Commons\DataLengthMismatchException;
use FilmTools\Commons\FilmToolsInvalidArgumentException;
use FilmTools\Commons\Exposures;
use FilmTools\Commons\ExposuresInterface;
use FilmTools\Commons\ExposuresProviderInterface;
use FilmTools\Commons\Densities;
use FilmTools\Commons\DensitiesInterface;
use FilmTools\Commons\DensitiesProviderInterface;

class Developing implements DevelopingInterface
{

    /**
     * @var int
     */
    public $time;

    /**
     * @var Exposures
     */
    protected $exposures;

    /**
     * @var Densities
     */
    protected $densities;

    /**
     * @var array
     */
    protected $data;


    /**
     * @param ExposuresProviderInterface|float[] $exposures
     * @param DensitiesProviderInterface|float[] $densities
     * @param int     $time
     */
    public function __construct( $exposures, $densities, int $time)
    {
        $this->setExposures( $exposures );
        $this->setDensities( $densities );

        if (count($this->getExposures()) != count( $this->getDensities() ))
            throw new DataLengthMismatchException;

        $this->resetData();

        $this->time = $time;
    }





    /**
     * @inheritDoc
     */
    public function getTime(): int
    {
        return $this->time;
    }


    /**
     * @inheritDoc
     */
    public function count()
    {
        return $this->getExposures()->count();
    }



    /**
     * @inheritDoc
     */
    public function getIterator()
    {
        $data = $this->getData();
        return new \ArrayIterator( $data );
    }


    /**
     * @inheritDoc
     * @return Exposures
     */
    public function getExposures(): ExposuresInterface {
        return $this->exposures;
    }


    /**
     * @param  ExposuresProviderInterface|float[] $exposures [description]
     * @return $this Fluent interface
     */
    protected function setExposures( $exposures )
    {
        if (is_array($exposures))
            $exposures = new Exposures($exposures);

        if (!$exposures instanceOf ExposuresProviderInterface)
            throw new FilmToolsInvalidArgumentException("Array or ExposuresProviderInterface expected");

        $this->exposures = $exposures->getExposures();
        return $this;
    }


    /**
     * @inheritDoc
     * @return Densities
     */
    public function getDensities(): DensitiesInterface {
        return $this->densities;
    }


    /**
     * @param  DensitiesProviderInterface|float[] $exposures [description]
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return $this Fluent interface
     */
    protected function setDensities( $densities )
    {
        if (is_array($densities))
            $densities = new Densities($densities);

        if (!$densities instanceOf DensitiesProviderInterface)
            throw new FilmToolsInvalidArgumentException("Array or DensitiesProviderInterface expected");

        $this->densities = $densities->getDensities();
        return $this;
    }


    /**
     * Checks if a given logH exposure exists in this developing run.
     *
     * @inheritDoc
     */
    public function has( $logH )
    {
        return ($this->getExposures()->search($logH) !== false);
    }


    /**
     * Returns the density value for a given logH exposure.
     *
     * @inheritDoc
     * @return float
     */
    public function get( $logH ): float
    {
        $index = $this->getExposures()->search( $logH );

        if ($index === false ):
            $msg = sprintf("No data for logH exposure '%s'", $logH);
            throw new ExposureNotFoundException( $msg );
        endif;

        return $this->getDensities()->offsetGet( $index );
    }


    /**
     * @inheritDoc
     */
    public function getData() : array
    {
        return $this->data;
    }


    protected function resetData()
    {
        $this->data = array_combine(
            $this->getExposures()->getArrayCopy(),
            $this->getDensities()->getArrayCopy()
        );
    }
}


1		<?php
2		namespace FilmTools\Developing;
3
4		use FilmTools\Commons\DataLengthMismatchException;
5		use FilmTools\Commons\FilmToolsInvalidArgumentException;
6		use FilmTools\Commons\Exposures;
7		use FilmTools\Commons\ExposuresInterface;
8		use FilmTools\Commons\ExposuresProviderInterface;
9		use FilmTools\Commons\Densities;
10		use FilmTools\Commons\DensitiesInterface;
11		use FilmTools\Commons\DensitiesProviderInterface;
12
13		class Developing implements DevelopingInterface
14		{
15
16		/**
17		* @var int
18		*/
19		public $time;
20
21		/**
22		* @var Exposures
23		*/
24		protected $exposures;
25
26		/**
27		* @var Densities
28		*/
29		protected $densities;
30
31		/**
32		* @var array
33		*/
34		protected $data;
35
36
37		/**
38		* @param ExposuresProviderInterface\|float[] $exposures
39		* @param DensitiesProviderInterface\|float[] $densities
40		* @param int $time
41		*/
42	30	public function __construct( $exposures, $densities, int $time)
43		{
44	30	$this->setExposures( $exposures );
45	30	$this->setDensities( $densities );
46
47	30	if (count($this->getExposures()) != count( $this->getDensities() ))
48	6	throw new DataLengthMismatchException;
49
50	24	$this->resetData();
51
52	24	$this->time = $time;
53	24	}
54
55
56
57
58
59		/**
60		* @inheritDoc
61		*/
62	12	public function getTime(): int
63		{
64	12	return $this->time;
65		}
66
67
68		/**
69		* @inheritDoc
70		*/
71	6	public function count()
72		{
73	6	return $this->getExposures()->count();
74		}
75
76
77
78		/**
79		* @inheritDoc
80		*/
81	6	public function getIterator()
82		{
83	6	$data = $this->getData();
84	6	return new \ArrayIterator( $data );
85		}
86
87
88		/**
89		* @inheritDoc
90		* @return Exposures
91		*/
92	30	public function getExposures(): ExposuresInterface {
93	30	return $this->exposures;
94		}
95
96
97		/**
98		* @param ExposuresProviderInterface\|float[] $exposures [description]
99		* @return $this Fluent interface
100		*/
101	30	protected function setExposures( $exposures )
102		{
103	30	if (is_array($exposures))
104	12	$exposures = new Exposures($exposures);
105
106	30	if (!$exposures instanceOf ExposuresProviderInterface)
107		throw new FilmToolsInvalidArgumentException("Array or ExposuresProviderInterface expected");
108
109	30	$this->exposures = $exposures->getExposures();
110	30	return $this;
111		}
112
113
114		/**
115		* @inheritDoc
116		* @return Densities
117		*/
118	30	public function getDensities(): DensitiesInterface {
119	30	return $this->densities;
120		}
121
122
123		/**
124		* @param DensitiesProviderInterface\|float[] $exposures [description]
		0 ignored issues – show Bug introduced 2018-07-31 05:36 UTC by Report Bug Copy Issue Report There is no parameter named `$exposures`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
125		* @return $this Fluent interface
126		*/
127	30	protected function setDensities( $densities )
128		{
129	30	if (is_array($densities))
130	15	$densities = new Densities($densities);
131
132	30	if (!$densities instanceOf DensitiesProviderInterface)
133		throw new FilmToolsInvalidArgumentException("Array or DensitiesProviderInterface expected");
134
135	30	$this->densities = $densities->getDensities();
136	30	return $this;
137		}
138
139
140		/**
141		* Checks if a given logH exposure exists in this developing run.
142		*
143		* @inheritDoc
144		*/
145	3	public function has( $logH )
146		{
147	3	return ($this->getExposures()->search($logH) !== false);
148		}
149
150
151		/**
152		* Returns the density value for a given logH exposure.
153		*
154		* @inheritDoc
155		* @return float
156		*/
157	3	public function get( $logH ): float
158		{
159	3	$index = $this->getExposures()->search( $logH );
160
161	3	if ($index === false ):
162	3	$msg = sprintf("No data for logH exposure '%s'", $logH);
163	3	throw new ExposureNotFoundException( $msg );
164		endif;
165
166	3	return $this->getDensities()->offsetGet( $index );
167		}
168
169
170		/**
171		* @inheritDoc
172		*/
173	12	public function getData() : array
174		{
175	12	return $this->data;
176		}
177
178
179	24	protected function resetData()
180		{
181	24	$this->data = array_combine(
182	24	$this->getExposures()->getArrayCopy(),
183	24	$this->getDensities()->getArrayCopy()
184		);
185	24	}
186		}
187

filmtools / developing

Push — master ( 02a3c4...5798f5 )

Developing::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like