STLSplit - Code Metrics - Inspection of "Added functionality for splitting and STL object i..." - fgheorghe/php3d-stl - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a7a39a...dc869e )

by Grosan

created 2016-07-27 22:36 UTC

STLSplit A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	98
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	11
lcom	1
cbo	1
dl	0
loc	98
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	getStl()	4	1
A	setStl()	5	1
A	__construct()	4	1
B	split()	34	4
A	findNeighbour()	17	4

<?php
/*
 * This file is part of the STL package.
 *
 * (c) Grosan Flaviu Gheorghe <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace php3d\stl;

/**
 * Class STLSplit. Extracts separate 3D objects as STL objects.
 * @package php3d\stl
 */
class STLSplit {
    /**
     * @var STL
     */
    private $stl;

    /**
     * @return STL
     */
    public function getStl(): STL
    {
        return $this->stl;
    }

    /**
     * @param STL $stl
     * @return STLSplit
     */
    private function setStl(STL $stl): STLSplit
    {
        $this->stl = $stl;
        return $this;
    }

    /**
     * STLSplit constructor.
     * @param STL $stl
     */
    public function __construct(STL $stl)
    {
        $this->setStl($stl);
    }

    /**
     * Splits an STL object into 3, and returns the new 3D objects in an array of STL files.
     *
     * @return array
     */
    public function split() : array
    {
        $stlArray = $this->getStl()->toArray();
        $facets = $stlArray["facets"];

        $objArray = array();
        $vertex = $facets[0];
        unset($facets[0]);

        $current = 0;
        $objArray[$current] = array($vertex);
        while (count($facets) != 0) {
            $this->findNeighbour(
                $vertex,
                $objArray[$current],
                $facets
            );
            $vertex = array_pop($facets);
            $current++;
            if ($vertex) {
                $objArray[$current] = array($vertex);
            }
        }

        $stlObjects = array();
        foreach ($objArray as $key => $object) {
            $stlObjects[] = STL::fromArray(array(
                "name" => $this->getStl()->getSolidName() . $key,
                "facets" => $object
            ));
        }

        return $stlObjects;
    }

    /**
     * Finds the neighbouring facets of a facet.
     *
     * @param array $facet
     * @param array $object
     * @param array $facets
     */
    private function findNeighbour(array $facet, array &$object, array &$facets)
    {
        foreach ($facets as $key => $_facet) {
            for ($i = 0; $i < 3; $i++) {
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
                if (in_array($_facet["vertex"][$i], $facet["vertex"])) {
                    unset($facets[$key]);
                    $object[] = $_facet;
                    $this->findNeighbour(
                        $_facet,
                        $object,
                        $facets
                    );
                }
                continue 2;
            }
        }
    }
}

1			<?php
2			/*
3			* This file is part of the STL package.
4			*
5			* (c) Grosan Flaviu Gheorghe <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace php3d\stl;
12
13			/**
14			* Class STLSplit. Extracts separate 3D objects as STL objects.
15			* @package php3d\stl
16			*/
17			class STLSplit {
18			/**
19			* @var STL
20			*/
21			private $stl;
22
23			/**
24			* @return STL
25			*/
26			public function getStl(): STL
27			{
28			return $this->stl;
29			}
30
31			/**
32			* @param STL $stl
33			* @return STLSplit
34			*/
35			private function setStl(STL $stl): STLSplit
36			{
37			$this->stl = $stl;
38			return $this;
39			}
40
41			/**
42			* STLSplit constructor.
43			* @param STL $stl
44			*/
45			public function __construct(STL $stl)
46			{
47			$this->setStl($stl);
48			}
49
50			/**
51			* Splits an STL object into 3, and returns the new 3D objects in an array of STL files.
52			*
53			* @return array
54			*/
55			public function split() : array
56			{
57			$stlArray = $this->getStl()->toArray();
58			$facets = $stlArray["facets"];
59
60			$objArray = array();
61			$vertex = $facets[0];
62			unset($facets[0]);
63
64			$current = 0;
65			$objArray[$current] = array($vertex);
66			while (count($facets) != 0) {
67			$this->findNeighbour(
68			$vertex,
69			$objArray[$current],
70			$facets
71			);
72			$vertex = array_pop($facets);
73			$current++;
74			if ($vertex) {
75			$objArray[$current] = array($vertex);
76			}
77			}
78
79			$stlObjects = array();
80			foreach ($objArray as $key => $object) {
81			$stlObjects[] = STL::fromArray(array(
82			"name" => $this->getStl()->getSolidName() . $key,
83			"facets" => $object
84			));
85			}
86
87			return $stlObjects;
88			}
89
90			/**
91			* Finds the neighbouring facets of a facet.
92			*
93			* @param array $facet
94			* @param array $object
95			* @param array $facets
96			*/
97			private function findNeighbour(array $facet, array &$object, array &$facets)
98			{
99			foreach ($facets as $key => $_facet) {
100			for ($i = 0; $i < 3; $i++) {
			0 ignored issues – show Unused Code introduced 2016-07-27 22:39 UTC by Report Bug Copy Issue Report `$i++;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
101			if (in_array($_facet["vertex"][$i], $facet["vertex"])) {
102			unset($facets[$key]);
103			$object[] = $_facet;
104			$this->findNeighbour(
105			$_facet,
106			$object,
107			$facets
108			);
109			}
110			continue 2;
111			}
112			}
113			}
114			}

fgheorghe / php3d-stl

Push — master ( a7a39a...dc869e )

STLSplit A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like