node.js ➔ define - Code Metrics - Inspection of "[TASK] Avoid unnassary loops in domain name mappin..." - ffrgb/meshviewer - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 77c94a...be0d3a )

by Xaver

created 2018-10-21 16:31 UTC

node.js ➔ define B

↳ Parent: Project

Complexity

Conditions	1
Paths	128

Size

Total Lines	143
Code Lines	91

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	1
eloc	91
c	3
b	0
f	0
nc	128
dl	0
loc	143
rs	7.2945
nop	3

13 Functions

Rating	Name	Size	Complexity
A	node.js ➔ ... ➔ showLoad	3	1
A	node.js ➔ ... ➔ showFirstSeen	3	1
A	node.js ➔ ... ➔ showStatus	8	3
A	node.js ➔ ... ➔ showIPs	17	1
A	node.js ➔ ... ➔ showFirmware	8	1
A	node.js ➔ ... ➔ showDomain	11	2
A	node.js ➔ ... ➔ showRAM	3	1
A	node.js ➔ ... ➔ showClients	36	3
A	node.js ➔ ... ➔ showGeoURI	12	2
A	node.js ➔ ... ➔ showAutoupdate	3	2
A	node.js ➔ ... ➔ showGateway	3	2
A	node.js ➔ ... ➔ showUptime	3	1
A	node.js ➔ ... ➔ showBar	12	2

How to fix Long Method

define(['snabbdom', 'helper', 'moment'], function (V, helper, moment) {
  'use strict';
  V = V.default;

  var self = {};

  function showBar(v, width, warning) {
    return V.h('span',
      { props: { className: 'bar' + (warning ? ' warning' : '') } },
      [
        V.h('span',
          {
            style: { width: (width * 100) + '%' }
          }),
        V.h('label', v)
      ]
    );
  }

  self.showStatus = function showStatus(d) {
    return V.h('td',
      { props: { className: d.is_online ? 'online' : 'offline' } },
      _.t((d.is_online ? 'node.lastOnline' : 'node.lastOffline'), {
        time: d.lastseen.fromNow(),
        date: d.lastseen.format('DD.MM.YYYY, H:mm:ss')
      }));
  };

  self.showGeoURI = function showGeoURI(d) {
    if (!helper.hasLocation(d)) {
      return undefined;
    }

    return V.h('td',
      V.h('a',
        { props: { href: 'geo:' + d.location.latitude + ',' + d.location.longitude } },
        Number(d.location.latitude.toFixed(6)) + ', ' + Number(d.location.longitude.toFixed(6))
      )
    );
  };

  self.showGateway = function showGateway(d) {
    return d.is_gateway ? _.t('yes') : undefined;
  };

  self.showFirmware = function showFirmware(d) {
    return [
      helper.dictGet(d, ['firmware', 'release']),
      helper.dictGet(d, ['firmware', 'base'])
    ].filter(function (n) {
      return n !== null;
    }).join(' / ') || undefined;
  };

  self.showUptime = function showUptime(d) {
    return moment.utc(d.uptime).local().fromNow(true);
  };

  self.showFirstSeen = function showFirstSeen(d) {
    return d.firstseen.fromNow(true);
  };

  self.showLoad = function showLoad(d) {
    return showBar(d.loadavg.toFixed(2), d.loadavg / (d.nproc || 1), d.loadavg >= d.nproc);
  };

  self.showRAM = function showRAM(d) {
    return showBar(Math.round(d.memory_usage * 100) + ' %', d.memory_usage, d.memory_usage >= 0.8);
  };

  self.showDomain = function showDomain(d) {
    var rt = d.domain;
    if (config.domainNames) {
      config.domainNames.forEach(function (t) {
        if (rt === t.domain) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
          return t.name;
        }
      });
    }
    return rt;
  };

  self.showClients = function showClients(d) {
    if (!d.is_online) {
      return undefined;
    }

    var clients = [
      V.h('span', [
        d.clients > 0 ? d.clients : _.t('none'),
        V.h('br'),
        V.h('i', { props: { className: 'ion-people', title: _.t('node.clients') } })
      ]),
      V.h('span',
        { props: { className: 'legend-24ghz' } },
        [
          d.clients_wifi24,
          V.h('br'),
          V.h('span', { props: { className: 'symbol', title: '2,4 Ghz' } })
        ]),
      V.h('span',
        { props: { className: 'legend-5ghz' } },
        [
          d.clients_wifi5,
          V.h('br'),
          V.h('span', { props: { className: 'symbol', title: '5 Ghz' } })
        ]),
      V.h('span',
        { props: { className: 'legend-others' } },
        [
          d.clients_other,
          V.h('br'),
          V.h('span', { props: { className: 'symbol', title: _.t('others') } })
        ])
    ];

    return V.h('td', { props: { className: 'clients' } }, clients);
  };

  self.showIPs = function showIPs(d) {
    var string = [];
    var ips = d.addresses;
    ips.sort();
    ips.forEach(function (ip, i) {
      if (i > 0) {
        string.push(V.h('br'));
      }

      if (ip.indexOf('fe80:') !== 0) {
        string.push(V.h('a', { props: { href: 'http://[' + ip + ']/', target: '_blank' } }, ip));
      } else {
        string.push(ip);
      }
    });
    return V.h('td', string);
  };

  self.showAutoupdate = function showAutoupdate(d) {
    return d.autoupdater.enabled ? _.t('node.activated', { branch: d.autoupdater.branch }) : _.t('node.deactivated');
  };

  return self;
});


1			define(['snabbdom', 'helper', 'moment'], function (V, helper, moment) {
2			'use strict';
3			V = V.default;
4
5			var self = {};
6
7			function showBar(v, width, warning) {
8			return V.h('span',
9			{ props: { className: 'bar' + (warning ? ' warning' : '') } },
10			[
11			V.h('span',
12			{
13			style: { width: (width * 100) + '%' }
14			}),
15			V.h('label', v)
16			]
17			);
18			}
19
20			self.showStatus = function showStatus(d) {
21			return V.h('td',
22			{ props: { className: d.is_online ? 'online' : 'offline' } },
23			_.t((d.is_online ? 'node.lastOnline' : 'node.lastOffline'), {
24			time: d.lastseen.fromNow(),
25			date: d.lastseen.format('DD.MM.YYYY, H:mm:ss')
26			}));
27			};
28
29			self.showGeoURI = function showGeoURI(d) {
30			if (!helper.hasLocation(d)) {
31			return undefined;
32			}
33
34			return V.h('td',
35			V.h('a',
36			{ props: { href: 'geo:' + d.location.latitude + ',' + d.location.longitude } },
37			Number(d.location.latitude.toFixed(6)) + ', ' + Number(d.location.longitude.toFixed(6))
38			)
39			);
40			};
41
42			self.showGateway = function showGateway(d) {
43			return d.is_gateway ? _.t('yes') : undefined;
44			};
45
46			self.showFirmware = function showFirmware(d) {
47			return [
48			helper.dictGet(d, ['firmware', 'release']),
49			helper.dictGet(d, ['firmware', 'base'])
50			].filter(function (n) {
51			return n !== null;
52			}).join(' / ') \|\| undefined;
53			};
54
55			self.showUptime = function showUptime(d) {
56			return moment.utc(d.uptime).local().fromNow(true);
57			};
58
59			self.showFirstSeen = function showFirstSeen(d) {
60			return d.firstseen.fromNow(true);
61			};
62
63			self.showLoad = function showLoad(d) {
64			return showBar(d.loadavg.toFixed(2), d.loadavg / (d.nproc \|\| 1), d.loadavg >= d.nproc);
65			};
66
67			self.showRAM = function showRAM(d) {
68			return showBar(Math.round(d.memory_usage * 100) + ' %', d.memory_usage, d.memory_usage >= 0.8);
69			};
70
71			self.showDomain = function showDomain(d) {
72			var rt = d.domain;
73			if (config.domainNames) {
74			config.domainNames.forEach(function (t) {
75			if (rt === t.domain) {
			0 ignored issues – show Complexity Best Practice introduced 2018-10-21 16:34 UTC by Report Bug Copy Issue Report There is no return statement if `rt === t.domain` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
76			return t.name;
77			}
78			});
79			}
80			return rt;
81			};
82
83			self.showClients = function showClients(d) {
84			if (!d.is_online) {
85			return undefined;
86			}
87
88			var clients = [
89			V.h('span', [
90			d.clients > 0 ? d.clients : _.t('none'),
91			V.h('br'),
92			V.h('i', { props: { className: 'ion-people', title: _.t('node.clients') } })
93			]),
94			V.h('span',
95			{ props: { className: 'legend-24ghz' } },
96			[
97			d.clients_wifi24,
98			V.h('br'),
99			V.h('span', { props: { className: 'symbol', title: '2,4 Ghz' } })
100			]),
101			V.h('span',
102			{ props: { className: 'legend-5ghz' } },
103			[
104			d.clients_wifi5,
105			V.h('br'),
106			V.h('span', { props: { className: 'symbol', title: '5 Ghz' } })
107			]),
108			V.h('span',
109			{ props: { className: 'legend-others' } },
110			[
111			d.clients_other,
112			V.h('br'),
113			V.h('span', { props: { className: 'symbol', title: _.t('others') } })
114			])
115			];
116
117			return V.h('td', { props: { className: 'clients' } }, clients);
118			};
119
120			self.showIPs = function showIPs(d) {
121			var string = [];
122			var ips = d.addresses;
123			ips.sort();
124			ips.forEach(function (ip, i) {
125			if (i > 0) {
126			string.push(V.h('br'));
127			}
128
129			if (ip.indexOf('fe80:') !== 0) {
130			string.push(V.h('a', { props: { href: 'http://[' + ip + ']/', target: '_blank' } }, ip));
131			} else {
132			string.push(ip);
133			}
134			});
135			return V.h('td', string);
136			};
137
138			self.showAutoupdate = function showAutoupdate(d) {
139			return d.autoupdater.enabled ? _.t('node.activated', { branch: d.autoupdater.branch }) : _.t('node.deactivated');
140			};
141
142			return self;
143			});
144

ffrgb / meshviewer

Push — develop ( 77c94a...be0d3a )

node.js ➔ define B

Complexity

Size

Duplication

Importance

13 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like